#
303975 |
|
11-Aug-2016 |
gjb |
Copy stable/11@r303970 to releng/11.0 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, and rename it to RC1.
Update __FreeBSD_version.
Use the quarterly branch for the default FreeBSD.conf pkg(8) repo and the dvd1.iso packages population.
Approved by: re (implicit) Sponsored by: The FreeBSD Foundation |
#
302408 |
|
08-Jul-2016 |
gjb |
Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle. Prune svn:mergeinfo from the new branch, as nothing has been merged here.
Additional commits post-branch will follow.
Approved by: re (implicit) Sponsored by: The FreeBSD Foundation
|
#
300050 |
|
17-May-2016 |
eadler |
Don't repeat the the word 'the'
(one manual change to fix grammar)
Confirmed With: db Approved by: secteam (not really, but this is a comment typo fix)
|
#
298884 |
|
01-May-2016 |
pfg |
usr.sbin/bsdconfig: minor spelling fixes on comments.
No functional change.
|
#
293617 |
|
09-Jan-2016 |
dteske |
Fix improper duration for f_dialog_pause() API
MFC after: 3 days X-MFC-to: stable/10
|
#
278493 |
|
10-Feb-2015 |
dteske |
Update copyrights.
|
#
278491 |
|
10-Feb-2015 |
dteske |
Add bsdconfig api function f_dialog_menutag2help()
|
#
278490 |
|
10-Feb-2015 |
dteske |
Add bsdconfig api functions f_dialog_pause()/f_dialog_pause_no_cancel()
|
#
270989 |
|
02-Sep-2014 |
dteske |
Fix regression introduced by SVN r270954. Correct way to reset getopts is to set OPTIND to 1, not unset it (which causes an error).
Thanks to: jilles
|
#
270954 |
|
01-Sep-2014 |
dteske |
Fix a bug where command line arguments could be misprocessed if getopts is used prior to f_dialog_init() -- e.g., in a script that sets DIALOG_SELF_INITIALIZE to NULL, preventing f_dialog_init() from being run automaticaly when `dialog.subr' is included. Caused by sub-shell processing of arguments inheriting prior value of $OPTIND, used by getopts. Solved by unsetting OPTIND prior to [re-]processing of positional arguments.
|
#
269460 |
|
03-Aug-2014 |
dteske |
Add required `exec' before Xdialog(1) invocation for the case where we expect (require) data on stdin. The effect of this is that, when backgrounded, $! returns the pid of an Xdialog(1) instance instead of an sh(1) instance -- the difference being a later kill of $! will reach the Xdialog(1) instance whereas without the exec the kill succeeds on the sh(1) instance leaving Xdialog(1) open.
|
#
269352 |
|
31-Jul-2014 |
dteske |
Fix a syntax error when running under bash(1) for portability.
|
#
263137 |
|
14-Mar-2014 |
dteske |
Fix future namespace issues for functions taking $var_to_set -- functions taking a variable to set need to make sure they protect their locals; if $var_to_set positional argument coincides with a local the expected call to `setvar' will fail to reach outside of the function's namespace. When such collisions are experienced (as I did in the rewrite of usermgmt) the solution is to append a full or abbreviated version of the function name to the local (ultimately eliminating collisions). This is rarely needed and only occurs when you have a lot of like-named functions that pass very similar $var_to_set positional arguments to each other (such as-is the case with an expansive library such as `dialog.subr').
|
#
259054 |
|
07-Dec-2013 |
dteske |
Performance and debugging enhancements: + Remove UNAME_P=$(...) from startup/misc -- already supplied by common.subr + Use f_getvar instead of $(eval echo \$$var) -- f_getvar is sub-shell free + Add `-e' and `-k var' options to f_eval_catch -- increasing use-cases + Use f_eval_catch to display errors on failure -- reducing duplicated code + Use f_eval_catch when we need output from a command -- improving debugging + Optimize f_isinter of strings.subr for performance -- now sub-shell free + Improve error checking on pidfiles -- using f_eval_catch and f_isinteger + Use $var_to_set arg of f_ifconfig_{inet,netmask} -- eliminate sub-shells + Use f_sprintf instead of $(printf ...) -- consolidate sub-shells + Use $var_to_set arg of f_route_get_default -- eliminate sub-shells + Add f_count to replace $(set -- ...;echo $#) -- eliminate sub-shells + Add f_count_ifs to replace $(IFS=x;set -- ...;echo $#) -- no sub-shells + Replace var="$var${var:+ }..." in loops with var="$var ..." with a follow- up var="${var# }" to trim leading whitespace -- optimize loops + Use $var_to_set arg of f_resolv_conf_nameservers -- eliminate sub-shells + Comments for the f_eval_catch function + Remove a duplicate `local ... desc ...' in f_device_get_all of device.subr + Use $var_to_set arg of f_device_capacity -- eliminate sub-shells + Whitespace fixes in f_dialog_init of dialog.subr + Optimize f_inet_atoi of media/tcpip.subr for performance -- sub-shell free + In several cases, send stderr to /dev/null -- clean up runtime execution + Change f_err of common.subr to go to program stderr not terminal stderr, allowing redirection of output from functions that use f_err + Disable debugging when using f_getvar to get variable argument to f_startup_rcconf_map_expand of startup/rcconf.subr + Use f_replace_all instead of $(echo ... | tr | sed) -- performance + Add a $var_to_set option to f_index_{file,menusel_{command,keyword}} of common.subr -- centralize sub-shells
|
#
257793 |
|
07-Nov-2013 |
dteske |
Fix an off-by-one error that was causing menus to look funny.
|
#
257785 |
|
07-Nov-2013 |
dteske |
Use dialog(1) to obtain maximum-size; stty fails when running in a pipe- chain. This allows dialogs to reach full size even when executed as an rvalue operand to a pipe (e.g., cat file | bsdconfig -f-).
|
#
256330 |
|
11-Oct-2013 |
dteske |
Fix a bug that would occur in application death when debugging was enabled if you ended up in f_dialog_*_constrain() (indirectly, of course) with a purposefully-set NULL height, width, or rows parameter (because you didn't care to have that attribute calculated). Fix typo in a comment while here.
Approved by: re (glebius)
|
#
256323 |
|
11-Oct-2013 |
dteske |
Add a USE_DIALOG global (analogous to USE_XDIALOG); useful for inserting text into a prompt or command syntax iff dialog(1) is in-use.
Approved by: re (glebius)
|
#
256181 |
|
09-Oct-2013 |
dteske |
Introduce centralized [X]dialog(1) exit codes to `dialog.subr' and make-use throughout the bsdconfig(8) code. While we're here, add an explicit argument to lvalue-seeking invocations of "return" that previously had no argument. Also, consolidate a single instance of double-newline and remove some comments that are no longer required (given increased readability with new exit codes).
Approved by: re (glebius)
|
#
253121 |
|
09-Jul-2013 |
dteske |
Adjust comments to fit within 80-columns.
|
#
253118 |
|
09-Jul-2013 |
dteske |
Fix conditional (der should match the comment above it).
MFC after: 1 day
|
#
253117 |
|
09-Jul-2013 |
dteske |
Do two things: First, don't obscure the backtitle. Second, read ~/.dialogrc if it exists to determine if use_shadow is true (ON) or false (OFF).
The purpose of determining the value of use_shadow is to know how many lines to subtract from the maximum height value in assuring that the backtitle is not obscured.
The detriment of obscuring the backtitle is that it provides information that is not easily obtained elsewhere. That is the command-line shortcut used to access the current menu. As you navigate from one dialog to the next, invariably transparently corssing module boundaries, the backtitle represents the command-line argument used to get there. Obscuring this information with a widget that is too-tall and/or too-wide would see that data go unnoticed (leaving few other ways to get that information in the same helpful context).
So despite the fact that this change reduces the standard maximum height for all widgets, there is a trap-door to prevent this calculation. If you want to utilize the full screen height on the terminal (remember, this adjustment is not made for Xdialog(1)) you can set $NO_BACKTITLE to 1 (or any non-NULL value for that matter) and this calculation will be skipped. You will be able to draw a widget that partially obscures the backtitle if-necessary.
MFC after: 1 day
|
#
252987 |
|
07-Jul-2013 |
dteske |
Fix typos in the BSD License.
|
#
252980 |
|
07-Jul-2013 |
dteske |
Be consistent with other usr.sbin programs w/respect to the copyright wording ("All rights reserved."); I had the casing wrong on many instances.
|
#
252178 |
|
24-Jun-2013 |
dteske |
More whitespace.
|
#
252075 |
|
21-Jun-2013 |
dteske |
Typo and grammar fixes to comments.
|
#
251977 |
|
18-Jun-2013 |
dteske |
Change the f_dialog_{yesno,noyes}() function-arguments in `dialog.subr' to accomodate an $hline value for overriding the default. This change does not effect any current modules as it turns out that not one single usage of either f_dialog_yesno() or f_dialog_noyes() relied on accepting more than a first argument (read: all occurrences quoted the first parameter; so $* was never depended upon).
This will allow some custom invocations of --yesno and --noyes to roll over to these functions (for example, in `timezone/timezone').
|
#
251912 |
|
18-Jun-2013 |
dteske |
Change the f_dialog_msgbox() arguments in `dialog.subr' to accomodate an $hline argument for setting the --hline parameter value. This change does not effect any current modules as it turns out that not one single usage of f_dialog_msgbox() relied on accepting more than a first argument (read: all occurrences quoted the first parameter; so $* was never depended upon).
This will allow some custom invocations of --msgbox to roll over to this function (for example, in `mouse/disable').
|
#
251361 |
|
04-Jun-2013 |
dteske |
Similar to r251236, r251242, and r251244. Introduce new function-pair to dialog(1) API in dialog.subr responsible for retrieving menu-choice data (for the --menu widget).
Add f_dialog_menuitem_store()/f_dialog_menuitem_fetch() for storing and retrieving the menuitem (not the tag) from a --menu widget result.
The dialog --menu widget returns the `tag' from the tag/item pair of choices for a menu list. Because the menu list is often local to the function that is displaying it, the ability to dereference this into the item is not possible unless you use a global. This changes things so the function (upon successful return of dialog) dereferences the tag into the item and stores it for later retrieval using these functions.
NOTE: Tags are dereferenced into items using f_dialog_menutag2item().
|
#
251353 |
|
04-Jun-2013 |
dteske |
Improve debugging for f_dialog_*_constrain() to print constrained rather than unconstrained values.
|
#
251267 |
|
02-Jun-2013 |
dteske |
Make proper use of locals in f_dialog_init().
|
#
251266 |
|
02-Jun-2013 |
dteske |
Improvements to whitespace and comments.
|
#
251265 |
|
02-Jun-2013 |
dteske |
Fix option processing from the library layer to address unexpected behavior(s); e.g., `-Xd' versus `-dX' did not produce the same results.
The libraries common.subr and dialog.subr automatically process the arguments passed to the program and enable/disable functionality without the need to process the arguments within your program. For example, if "$@" contains `-d', common.subr will see this and enable debugging regardless of whether you process "$@" yourself or not (this automatic processing can easily be disabled for custom scripts that don't want it; see the afore- mentioned scripts for additional details).
NOTE: common.subr stores a copy of "$@" in $ARGV for convenient (and repeated) processing by libraries such as dialog.subr which provide such transparent functionality for the consuming script(s).
However, the libraries don't know if a program wants to accept `extra' options. Flags are not really a problem, because the library can be programmed to silently ignore unknown flags. The trouble comes into play when the program wants to define an option that takes an argument.
For example:
bsdconfig -D logfile -X
In the above example, the library uses getopts to process $ARGV and if it doesn't know that `-D' takes an argument, the option processing will prematurely terminate on `logfile' (this is standard/correct behavior for getopts but is undesired in our situation where we have partially off-loaded main argument processing).
The problem is solved by allowing the program to define an extra set of options to be included in each library's handling of $ARGV. Only options that require arguments are truly necessary to be pre-specified in this new manner.
|
#
251244 |
|
02-Jun-2013 |
dteske |
Improve the dialog(1) API in dialog.subr by adding f_dialog_default_store() and f_dialog_default_fetch(). Operating similar to functions introduced by SVN r251236 and r251242, these functions operate as a pair for helping track the default-item data (for the --menu, --checklist, and --radiolist widgets).
This replaces the direct usage of a global to store the data with an abstract method for readability and to centralize the code.
|
#
251242 |
|
02-Jun-2013 |
dteske |
Similar to r251236, improve the portion of dialog(1) API in dialog.subr responsible for retrieving stored input (for the --inputbox and --password widgets).
When we (Ron McDowell and I) developed the first version of bsdconfig, it used temporary files to store responses from dialog(1). That hasn't been true for a very long time, so the need to always execute some clean-up function is long-deprecated. The function that used to perform these clean- up routines for these widgets was f_dialog_inputstr().
We really don't need f_dialog_inputstr() for its originally designed purpose as all dialog invocations no longer require temporary files.
Just as in r251236, redesign f_dialog_inputstr() in the following four ways:
1. Rename f_dialog_inputstr() to f_dialog_inputstr_fetch() 2. Introduce the new first-argument of $var_to_set to reduce forking 3. Create a corresponding f_dialog_inputstr_store() to abstract storage 4. Offload the sanitization to a new function, f_dialog_line_sanitize()
It should be noted that f_dialog_line_sanitize() -- unlike its cousin from SVN r251236, f_dialog_data_sanitize() -- trims leading/trailing whitespace from the user's input. This helps prevent errors and common mistakes caused by the fact that the new cdialog implementation allows the right-arrow cursor key to go beyond the last byte of realtime input (adding whitespace at the end of the typed value).
While we're centralizing the sanitization, let's rewrite f_dialog_input() while we're here to likewise reduce forking. The f_dialog_input() function now expects the first argument of $var_to_set instead of producing results on standard-out.
These changes greatly improve readability and also improve performance.
|
#
251236 |
|
01-Jun-2013 |
dteske |
Improve portion of the dialog(1) API in dialog.subr responsible for retrieving stored data (for the --menu, --calendar, --timebox, --checklist, and --radiolist widgets).
When we (Ron McDowell and I) developed the first version of bsdconfig, it used temporary files to store responses from dialog(1). That hasn't been true for some very long time, so the need to always store the return status of dialog(1) and then call some function to clean-up is long-deprecated. The function that used to do the clean-up was f_dialog_menutag().
We really don't need f_dialog_menutag() for its originally designed purpose, as all dialog invocations (even when in a sub-shell) do not use temporary files anymore.
However, we do need to keep f_dialog_menutag() around because it still fills the need of being able to abstract the procedure for fetching stored data provided by functions that display the aforementioned widgets.
In re-designing f_dialog_menutag(), four important changes are made:
1. Rename f_dialog_menutag() to f_dialog_menutag_fetch() 2. Introduce the new first-argument of $var_to_set to reduce number of forks 3. Create a corresponding f_dialog_menutag_store() to abstract the storage 4. Offload the sanitization to a new function, f_dialog_data_sanitize()
NOTE: That last one is important. Not all functions need to store their data for later fetching, meanwhile every invocation of dialog should be sanitized (as we learned early-on in the i18n-effort -- underlying libraries will spit warnings to stderr for bad values of $LANG and since dialog outputs its responses to stderr, we need to sanitize every response of these warnings).
These changes greatly improve readbaility and also improve performance by reducing unnecessary forking.
|
#
251190 |
|
31-May-2013 |
dteske |
Improve portion of the dialog(1) API in dialog.subr responsible for calculating widget sizes. Instead of forking a sub-shell to calculate the optimum size for a widget, use a byRef style call-out to set variables in the parent namespace. For example, instead of:
size=$( f_dialog_buttonbox_size title btitle msg ) $DIALOG --title title --backtitle btitle --msgbox msg $size
The new API replaces the above with the following:
f_dialog_buttonbox_size height width title btitle msg $DIALOG --title title --backtitle btitle --msgbox msg $height $width
This reduces the number of forks, improves performance, and makes the code more readable by revealing the argument-order for widget sizing. It also makes performing minor adjustments to the calculated values easier as you no longer have to split-out the response (which required knowledge of ordering so was counter-intuitive).
|
#
250633 |
|
14-May-2013 |
dteske |
Centralize standard getopts arguments, both for convenience and to correct a bug in which certain combinations of arguments produced unexpected results such as `-dX' (now properly produces debugging and X11), `-XS' (now properly produces X11 in secure mode), `-df-' (enables debugging when reading a script from standard-input, etc. Multi-word variations such as `-d -X', `-X -S', `-d -f-', `-d -f -', etc. also work as expected. Also tested were variations in argument order, which are now working as expected.
|
#
249758 |
|
22-Apr-2013 |
dteske |
New helper functions for common widgets.
|
#
249757 |
|
22-Apr-2013 |
dteske |
Proper fix for copy/paste error (first attempt r249756).
|
#
249756 |
|
22-Apr-2013 |
dteske |
Fix a copy/paste error.
|
#
245117 |
|
07-Jan-2013 |
dteske |
Update copyright following last commit.
|
#
245116 |
|
07-Jan-2013 |
dteske |
Add nonInteractive support to f_dialog_yesno/noyes().
|
#
244804 |
|
29-Dec-2012 |
dteske |
Comments.
|
#
244802 |
|
29-Dec-2012 |
dteske |
Add missing enforcement of height restriction after minor adjustment.
|
#
244801 |
|
29-Dec-2012 |
dteske |
Add support for running without a controlling terminal (for example, when running as an rvalue to a pipe).
|
#
244675 |
|
25-Dec-2012 |
dteske |
Add more debugging to help with diagnosis of program-flow when needed.
|
#
244558 |
|
21-Dec-2012 |
dteske |
Change axiom for initialization. Including script can disable (default) automatic initialization by setting appropriate variable to particular value.
|
#
244550 |
|
21-Dec-2012 |
dteske |
Improve the debugging abilities and clean up debug messages. In most cases, all one has to do is set the environment variable DEBUGGING to get the debug messages to appear on the console.
|
#
244548 |
|
21-Dec-2012 |
dteske |
Add much-needed dialog(1) --inputbox function for simplifying the process of requesting input from the user.
|
#
243636 |
|
27-Nov-2012 |
dteske |
Allow setting of NULL titles with f_dialog_[back]title().
Approved by: adrian (co-mentor) (implicit)
|
#
243635 |
|
27-Nov-2012 |
dteske |
Change self-initialization to occur when loaded versus the previous behavior which was to self-initialize during the first function-call. This didn't work so well because the first call was may or may-not be within a sub-shell (which prevented proper setup of the pass-thru file descriptor, resulting in dialogs that would not display).
Approved by: adrian (co-mentor) (implicit)
|
#
243476 |
|
24-Nov-2012 |
dteske |
Whitespace.
Approved by: adrian (co-mentor) (implicit)
|
#
242115 |
|
26-Oct-2012 |
dteske |
Tighten-up displays that use a NULL prompt (e.g., networking and usermgmt).
Approved by: adrian (co-mentor) (implicit)
|
#
242114 |
|
26-Oct-2012 |
dteske |
Fix copy/paste error.
Approved by: adrian (co-mentor) (implicit)
|
#
242107 |
|
26-Oct-2012 |
dteske |
Switch from using a msgbox to display help files to a textbox instead. The problem with using a msgbox was one of truncation in the case of Xdialog(1) and lack of screen real-estate (since the msgbox is not scrollable in X11 while a textbox is).
The textbox renders the text much better and is more appropriate for this type of data display.
Approved by: adrian (co-mentor) (implicit)
|
#
240783 |
|
21-Sep-2012 |
dteske |
Reverse SVN r240770 -- jilles@ made a suggestion that allowed us to redesign our embedded rescue environment to support /dev/null making r240770 obsolete.
Reviewed by: jilles, adrian (co-mentor) Approved by: jilles, adrian (co-mentor)
|
#
240770 |
|
21-Sep-2012 |
dteske |
Replace redirections to /dev/null with "close file-descriptor" syntax (>&-).
Reviewed by: adrian (co-mentor) Approved by: adrian (co-mentor)
|
#
240768 |
|
20-Sep-2012 |
dteske |
Change all invocations of dialog(1) to no-longer require temporary files. This allows bsdconfig to -- like bsdinstall -- operate from read-only media.
Reviewed by: adrian (co-mentor) Approved by: adrian (co-mentor)
|
#
240684 |
|
18-Sep-2012 |
dteske |
Move major includes into /usr/share/bsdconfig for easy external access.
Reviewed by: adrian (co-mentor) Approved by: adrian (co-mentor)
|
#
238438 |
|
14-Jul-2012 |
dteske |
Import bsdconfig(8) as a replacement for the post-install abilities of deprecated sysinstall(8). NOTE: WITH_BSDCONFIG is currently required.
Submitted by: Devin Teske (dteske), Ron McDowell <rcm@fuzzwad.org> Reviewed by: Ron McDowell <rcm@fuzzwad.org> Approved by: Ed Maste (emaste)
|