MFC r350079:

tzsetup: upgrade to zone1970.tab

zone.tab is deprecated. Install zone1970.tab alongside it, and use it
for tzsetup(8). This is also useful for other applications that need
the modern better maintained file.

PR: 243394
Submitted by: tmunro

MFC r337522:

In read_zones(), check if the file name actually fit in the buffer
and make sure it would terminate with nul with strlcpy().

Reviewed by: imp (earlier revision)
Differential Revision: https://reviews.freebsd.org/D16595

MFC: r322097, r322203

- Since r301131, /etc/localtime is also installed when selecting UTC in
interactive configurations. Thus, the code added in r220172 which treats
a NULL zone file name as UTC and removes /etc/localtime in that case can
go again.
- Consistently refer to "could not delete" (as chosen by the oldest such
code in here) when unlink(2) fails instead of a to mixture of "delete"
and "unlink" in error messages.

MFC r306375,r307802:

r306375 (by emaste):

Add a WITHOUT_DIALOG src.conf(5) knob

It also turns off dependencies (bsdinstall, bsdconfig, dpv, tzsetup).

r307802 (by bapt):

Fix build of tzsetup when WITHOUT_DIALOG is set

Hide dialog specific code behind HAVE_DIALOG. It allows to build a stripped
down version (missing the dialog UI) but perfectly function tzsetup when
world is built WITHOUT_DIALOG

Reorganise a bit the code to limit the number of blocks under HAVE_DIALOG

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Fix tzsetup not installing /etc/localtime for UTC

If tzsetup UTC is run then it successfully configured the system for UTC
including installing /etc/localtime however if the user ran just tzsetup
for interactive configuration and select UTC no /etc/localtime was installed
which resulted in failures for utilities which require said file.

Change set_zone_utc to call install_zoneinfo("UTC") to ensure that
/etc/localtime is created for interactive UTC selection.

Users who have previously run tzsetup in interactive mode and select UTC
can install the missing /etc/localtime by running tzsetup -r.

Also correct static miss-match for set_zone_utc.

MFC after: 2 weeks
Relnotes: Yes
Sponsored by: Multiplay

Avoid buffer overflow or truncation when constructing path_zoneinfo_file.

Reported by: Coverity
CID: 1011160
MFC after: 1 week

Use NULL instead of 0 for pointers.

fgetln(3) will returns NULL if cannot get a line from a stream.
strsep(3) it will returns NULL if the end of the string was reached.
jemalloc(3) malloc will returns NULL if it cannot allocate memory.
fgetln(3) it will returns NULL if it cannot get a line from a stream.

MFC after: 4 weeks

Revert r289269 for now. After looking at share/zoneinfo/Makefile this could
potentially break non-root installs and we need a better solution, probably
by doing it differently when no UI is involved.

Use chroot(2) instead of using prefixes for files.

Previously, the code prefixes the chroot path to actual file paths to
simulate the effect. This, however, will not work for tzset(3) which
expects the current system have a working set of timezone data files,
and that is not always the case.

This changeset simplifies the handling of paths and use an actual
chroot(2) call to implement the effect.

PR: bin/197313
MFC after: 2 weeks

tzsetup: remove set but unused variable
- leave a comment explaining which variable it used to be

Reported by: gcc5.1

Fix whitespace.

Thanks to: nwhitehorn

Default `bsdconfig timezone' and `tzsetup' to `-s' in a VM.

Recommended by: cperciva
Reviewed by: cperciva
Relnotes: tzsetup and bsdconfig now assume that the "hardware" clock inside a VM is set to UTC

Fix VERBOSE reporting on results when removing _PATH_LOCALTIME for UTC option.

PR: bin/164976
Submitted by: dteske

It's not an error if unlink(2) fails because the pathname doesn't exist.

Noticed by: kevlo
Pointy hat to: wollman

Clean up reinstall option and remove duplicate code

- Move the reinstall logic to be before menus are initialised
(menus are not needed when reinstalling a zonefile).

- Remove unnecessary re-initialization of path_db.

- Update variable name and error message because we now use the
zone name relative to /usr/share/zoneinfo, not the full path.

pr: bin/164041
Submitted by: Devin Teske <dteske vicor com>
MFC after: 1 week

Fix #ifdef VERBOSE for UTC case

Update verbose output to match what actually happens when selecting
the UTC option, and when the -n option is used.

Patch updated slightly for new libdialog.

PR: bin/164042
Submitted by: Devin Teske <dteske vicor com>
MFC after: 2 weeks

Don't write /var/db/zoneinfo when zone is not actually changed.

If the specified zone file does not exist or the -n flag is specified,
do not update /var/db/zoneinfo.

PR: bin/164039
Submitted by: Devin Teske <dteske vicor com>
MFC after: 1 week

Use a reasonable-sized buffer when formatting error messages about
installing zoneinfo. While we're in the vicinity, add some missing
error checking to eliminate an unhelpful error message when unlink()
fails.

/me is embarrassed by the quality of his 16-year-old code.
The whole thing is awful and could stand a complete rewrite.

PR: 164038
Submitted by: Devin Teske (but implemented differently)

Sync xdialog_menu() implementation with sade.

calloc +1 DIALOG_LISTITEM to prevent possible wild pointer access
in dlg_default_listitem().

Port to new libdialog.

If the user is moving from any other time zone to UTC we need
to delete any old /var/db/zoneinfo file that may exist so that
tzsetup -r does the right thing.

- add missing options and arguments to program's usage()
and sync it with manpage's SYNOPSIS

- generally clean up a manpage's formatting

Reviewed by: edwin

Add a menu entry for UTC in the main menu.

PR: bin/156019
Submitted by: Daniel O'Conner
Reviewed by: Garrett Cooper <gcooper@FreeBSD.org>
MFC after: 1 week

Fix support for chrooted installs.

Approved by: imp (mentor)

Use literal format strings. Found by clang.

Add comment that this value is unused.
It is obvious that it isn't used, but both clang and Coverity talk about it.

Found with: Coverity Prevent(tm)
CID: 8066

When there is a problem with writing, also bail out.

Found with the clang checker.

- Add support for chrooted installs.
- Add examples to the man-page.

MFC after: 1 week

Instead of having to know which timezone was picked last time, you
now can run "tzsetup -r" which will reinstall the last choice. This
data is recorded in /var/db/zoneinfo.

MFC after: 1 week

When tzsetup is run as non-root and the "CMOS clock question on
UTC" is answered as No, it would abort without properly ending the
dialog session.

MFC after: 1 week

Add a new options (-s) that, when specified, skips the question about
adjusting the clock to UTC.
That avoids to write on /etc/wall_cmos_clock which is useful in some
cases (example: host user in a jail).

Sponsored by: Sandvine Incorporated
Initially submitted by: Matt Koivisto <mkoivisto at sandvine dot com>
Approved by: re (kib)

- Replace rcsid with __FBSDID.
- Remove paths.h and embed it in the source.
- Remove stale alpha support.
- Clean up compiler warnings and fix style(9) bugs.

Fix a crash when Arctic Ocean is selected.

MFC after: 1 week

Update wording regarding geography to match the man page and web site.
Specifically, change the second level menu title from 'Country' to
'Country or Region', since e.g. Hong Kong is not a country.

Submitted by: Xin LI <delphij@frontfree.net>

Cosmetic fix: a message was mixed with a dialog box border line.

Approved by: re (rwatson)

Explicitly cast NCONTINENTS to int to silence an overflow warning.

Default to UTC on sparc64 also.

Default the UTC question to "yes" on the Alpha.

Convert to use the <sys/queue.h> macros rather than fiddling with the queue
structure internals.

Reviewed by: markm

Use dialog_noyes() for UTC selection; uses No as default answer now.

Don't depend on <sys/stat.h> bogusly including <sys/time.h> (and thereby
<time.h>).

Back out the previous change to the queue(3) interface.
It was not discussed and should probably not happen.

Requested by: msmith and others

Change the way that the queue(3) structures are declared; don't assume that
the type argument to *_HEAD and *_ENTRY is a struct.

Suggested by: phk
Reviewed by: phk
Approved by: mdodd

Convert err() to errx(), reason is already provided. Complete the
abort on allocation failure instead of deferencing NULL later.

$Id$ -> $FreeBSD$

- ignore the user-supplied umask, set it to 0022 by default
- install /etc/wall_cmos_clock with 0444 mode rather than 0666
- -Wall inspection

PR: 12967

Make UTC or local time message a little more clear.

Add a `default' feature to tzsetup for use in script-driven installation
(if someone writes the other half). Also rewrite the man page in a more
appropriate (formal) style.

Old stuff lying around a source tree:
Create/remove /etc/wall_cmos_clock without using system() and magic paths.

Minor brace gymnastics so that /etc/wall_cmos_clock is really
created.

PR: 5473
Submitted by: MIHIRA Yoshiro <sanpei@yy.cs.keio.ac.jp>

Teach tzsetup to understand blank lines in the iso3166 file.

Found by: evanc@synapse.net (Evan Champion)

Add usage(). Document -n flag. Do not touch/remove /etc/wall_cmos_clock
when -n (do nothing) is used.

Revert $FreeBSD$ to $Id$

Ask about local or UTC here, like we used to.

At the end it was much simpler than I thought. 26 * 26 = 676 and not 576.
South Africa and a few other countries exists again. This fix pr 2595.
This should go into 2.2.

Make some of the less necessary user feedback #ifdef VERBOSE.

We could also make this stuff only come out when getpid() != 1
and thus avoid the install case (where it really is just too verbose,
and people have complained), but this seems less messy and no one
complained when tzsetup didn't print the final "things went fine!"
messages (which sort of contravene the UNIX spirit of only yelling
when you need to anyway).

Make the long-awaited change from $Id$ to $FreeBSD$

This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.

Remove two uninitialized and unused variables that used to cause a
segfault before.

Completely re-vamped `tzsetup':

- It no longer attempts to fiddle wall-vs-UTC-in-RTC. The results
were just confusing most of the time.

- The program no longer contains a pre-compiled list of timezones
(compiled by groveling through the tzdata source files for comments
starting with `ZONE-DESCR'). Now it uses the new `zone.tab' file
supplied with current versions of the timezone data files, to determine
the list at run time. (It also requires the ISO 3166 table I
committed some months ago.)

AS A RESULT, this program will NOT work until the new timezone data files
are committed (should happen sometime soon).