Revert r330897:

This was intended to be a non-functional change. It wasn't. The commit
message was thus wrong. In addition it broke arm, and merged crypto
related code.

Revert with prejudice.

This revert skips files touched in r316370 since that commit was since
MFCed. This revert also skips files that require $FreeBSD$ property
changes.

Thank you to those who helped me get out of this mess including but not
limited to gonzo, kevans, rgrimes.

Requested by: gjb (re)

Partial merge of the SPDX changes

These changes are incomplete but are making it difficult
to determine what other changes can/should be merged.

No objections from: pfg

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Undo the bogus gethostname() change from r299709.

The "- 1" is there specifically to enable checking for NUL termination.

I should also admit the rest change was mostly cosmetic and the
overruns can't occur in practice: still I leave them to pacify
static analyzers.

Pointed out by: bde

timed(8): Use strlcpy() for bounds checking.

Prevent some theorical buffer overruns reported by Coverity.
Cleanup a use of gethostname() while here.

CID: 1006713, 1011166, 1011167, 1011168,

timed(8): Use stronger random number generator.

Using arc4random simplifies the code by not having to worry about
seeds which ironically depend on the time.

CID: 1300004

timed(8): use NULL instead of zero for pointers.

Change old-style function definition

Add missing braces

Obtained from: DragonFly

Rework all non-contributed files that use `struct timezone'.

This structure is not part of POSIX. According to POSIX, gettimeofday()
has the following prototype:

int gettimeofday(struct timeval *restrict tp, void *restrict tzp);

Also, POSIX states that gettimeofday() shall return 0 (as long as tzp is
not used). Remove dead error handling code. Also use NULL for a
nul-pointer instead of integer 0.

While there, change all pieces of code that only use tv_sec to use
time(3), as this provides less overhead.

Simplify inclusion of the tsptype array a bit.

We don't need this array in timed.c -- only readmsg.c.

Remove the advertising clause from UCB copyrighted files in usr.sbin. This
is in accordance with the information provided at
ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change

getopt returns an int, not a char. Make sure that we store the
variable in an int to avoid casting to an unsigned value which causes
the comparison with -1 to fail.

PR: 123807
Submitted by: Matthew Luckie
Reviewed by: keramida@
MFC after: 1 week

de-__P
use port/proto to represent services (not proto/port).
add FBSDID

Unifdef all the SGI code. It mainly added clutter while providing some
specialized logging, SGI-specific priority massaging, and SCI-specific
time trimming support. Also add missing $FreeBSD$'s.

Inspired by: NetBSD

$Id$ -> $FreeBSD$

Don't assume that time_t is long. Fixed printf format errors.

Make all strings representing hostnames to be NUL-terminated within
MAXHOSTNAMELEN chars, like everywhere else in the system, so that strcpy()s
and printf()s won't fail.

Back out strcpy() -> strncpy() changes. According to bruce, they are unneeded.

Use err(3).
Sync man page and usage string.
Strcpy -> strncpy from OpenBSD.
-Wall cleaning.
Obtained from: OpenBSD

Convert nets specified with -i/-n to network byte order.
PR: 3906, 3801
Submitted by: Bob Willcox <bob@luke.pmr.com>, Hiroya Tsubakimoto

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Fully initialize (bzero) the stack-allocated "struct sockaddr_in server"
structure. Random junk on the stack would cause the call to bind to fail
in some cases (since the address portion wasn't initialized).

This commit was generated by cvs2svn to compensate for changes in r1553,
which included commits to RCS files with non-trunk default branches.

BSD 4.4 Lite usr.sbin Sources