360326 |
25-Apr-2020 |
dim |
MFC r348282 (by lwhsu):
Remove an uneeded indentation introduced in r286196 to silence gcc warnging
Sponsored by: The FreeBSD Foundation |
359588 |
03-Apr-2020 |
bapt |
MFC r359232:
pw: do not removed home directories if not owned
When deleting a user, if its home directory does not belong to it, it should not be removed. This is the promise that the manpage makes, the tool should ensure that it respects that promise.
Add a regression test about it
PR: 244967 Submitted by: Eric Hanneken <eric@erichanneken.com> |
344017 |
11-Feb-2019 |
bcr |
MFC r343921:
Add an example to pw.8 about how to add an existing user to a group.
Instead of using pw to modify group membership, users often edit /etc/group by hand, which is discouraged. Provide an example of adding a user to the wheel group, which is a common use case. I'm using a different user here as in the previous example as that deleted the user (although the examples don't necessarily have to be followed in order).
Reviewed by: rgrimes,0mp Approved by: 0mp Differential Revision: https://reviews.freebsd.org/D19123 |
330694 |
09-Mar-2018 |
dab |
MFC r330245:
Allow the "@" and "!" characters in passwd file GECOS fields.
Two PRs (152084 & 210187) request allowing the "@" and/or "!" characters in the passwd file GECOS field. The man page for pw does not mention that those characters are disallowed, Linux supports those characters in this field, and the "@" character in particular would be useful for storing email addresses in that field.
PR: 152084, 210187 Submitted by: jschauma@netmeister.org, Dave Cottlehuber <dch@freebsd.org> Reported by: jschauma@netmeister.org, Dave Cottlehuber <dch@freebsd.org> Sponsored by: Dell EMC |
330449 |
05-Mar-2018 |
eadler |
MFC r326276:
various: general adoption of SPDX licensing ID tags.
Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task.
The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts.
No functional change intended. |
327090 |
22-Dec-2017 |
eugen |
MFC r326872: fix expiration arithmetic after r326738 and MFC.
Approved by: mav (mentor) |
326848 |
14-Dec-2017 |
eugen |
MFC r326738: pw(8): correct expiration period handling and command line overrides to preconfigured values for -e, -p and -w flags.
Use non-negative symbols instead of magic values in passwd_val/pw_password functions.
PR: 223431 Submitted by: Yuri Pankov (in part, patch for the manual) Approved by: mav (mentor) Relnotes: yes |
323009 |
30-Aug-2017 |
emaste |
MFC r322581: remove debug files in delete-old* when WITHOUT_DEBUG_FILES
Sponsored by: The FreeBSD Foundation |
322919 |
26-Aug-2017 |
emaste |
MFC r322677: pw usermod: Properly deal with empty secondary group lists (-G '')
PR: 221417 Relnotes: Yes |
321164 |
18-Jul-2017 |
ngie |
MFC r319026:
pw: add some basic testcases for groupshow and usershow
- groupshow: test out -a/-g/-n . - usershow: test out -a/-n/-u . |
319217 |
30-May-2017 |
asomers |
MFC r318141, r318143-r318144
r318141: strcpy => strlcpy
Reported by: Coverity CID: 1352771 Sponsored by: Spectra Logic Corp
r318143: strcpy => strlcpy
Reported by: Coverity CID: 1006715 Sponsored by: Spectra Logic Corp
r318144: Don't depend on assert(3) getting evaluated
Reported by: imp X-MFC-With: 318141, 318143 Sponsored by: Spectra Logic Corp |
316389 |
02-Apr-2017 |
asomers |
MFC r315041
Increase WARNS for pw tests
ATF tests have a default WARNS of 0, unlike other usermode programs.
Reviewed by: ngie, julian MFC after: 3 weeks Sponsored by: Spectra Logic Corporation Differential Revision: https://reviews.freebsd.org/D9933 |
316347 |
01-Apr-2017 |
bapt |
MFC: r315912 (by eugen@) and r315935
Properly initialise with content of pw.conf(5) that was mistakenly ignored. Also, respect "defaultgroup" if specified there.
Add a regression test
PR: 217934 Reported by: Victor Sudakov <vas@mpeks.tomsk.su> |
316256 |
30-Mar-2017 |
ngie |
MFC r315776:
Rename tests from <foo> to <foo>_test to match the FreeBSD test suite naming scheme
usr.bin/diff/diff_test was renamed to usr.bin/diff/netbsd_diff_test to avoid collisions with the renamed FreeBSD test. |
312931 |
28-Jan-2017 |
bapt |
MFC r312644, r312650
r312644: Readd a feature lost in pw(8) refactoring
pw usermod foo -m
It used to be able to (re)create the home directory if it didn't exists
PR: 216224 Reported by: ae MFC after: 3 days
r312650: Really restore the old behaviour for pw usermod -m
It again reinstall missing skel files without overwriting changed one Add a regression test about it
Reported by: ae MFC after: 3 days |
310176 |
16-Dec-2016 |
asomers |
MFC r308806
Speed up pw operations that edit /etc/group or /etc/passwd
r285050 fixed a bug in pw that could lead to /etc/passwd or /etc/group corruption on power loss. However, it fixed it by opening those files with O_SYNC, which is very slow, especially on ZFS. This change replaces O_SYNC with appropriately placed fsync()s instead, which is much faster. Using a ZFS tmpdir, the time to run pw's kyua tests drops from 245s to 35s. |
309880 |
12-Dec-2016 |
bapt |
MFC r309803:
Fix pw groupshow <gid>
PR: 204676 Submitted by: longwitz@incore.de |
308815 |
18-Nov-2016 |
asomers |
MFC r307752
Close some file descriptor leaks in pw |
305741 |
12-Sep-2016 |
asomers |
MFC r302778
pw should sanitize the argument of -w.
Otherwise, it will silently disable the login for the selected account if the argument is unrecognizable.
usr.sbin/pw/pw.h usr.sbin/pw/pw_conf.c usr.sbin/pw/pw_user.c Use separate rules to validate boolean parameters and passwd parameters. Error out if a password parameter cannot be parsed.
usr.sbin/pw/tests/Makefile usr.sbin/pw/tests/crypt.c usr.sbin/pw/tests/pw_useradd.sh usr.sbin/pw/tests/pw_usermod.sh Add tests for the validation. Also, enhance existing password-related tests to actually validate that the correct hash is written to master.passwd. |
303256 |
24-Jul-2016 |
bapt |
iDo not try to delete the home of the user if is is not a directory for example "/dev/null"
PR: 211195 Submitted by: rday <ryan@ryanday.net> Reported by: eniorm <eniorm@gmail.com> Approved by: re (kib) |
302408 |
08-Jul-2016 |
gjb |
Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle. Prune svn:mergeinfo from the new branch, as nothing has been merged here.
Additional commits post-branch will follow.
Approved by: re (implicit) Sponsored by: The FreeBSD Foundation |
301367 |
04-Jun-2016 |
bapt |
Fix typo preventing pw {user,group}next -C from working as expected
Reported by: Mike Selnet via forums.freebsd.org MFC after: 3 days
|
300564 |
24-May-2016 |
truckman |
Fix CID 1006692 in /usr/sbin/pw pw_log() function and other fixes
The length of the name returned from the $LOGNAME and $USER can be very long and it was being concatenated to a fixed length buffer with no bounds checking. Fix this problem by limiting the length of the name copied.
Additionally, this name is actually used to create a format string to be used in adding log file entries so embedded % characters in the name could confuse *printf(), and embedded whitespace could confuse a log file parser. Handle the former by escaping each % with an additional %, and handle the latter by simply stripping it out.
Clean up the code by moving the variable declarations to the top of the function, formatting them to conform with style, and moving intialization elsewhere.
Reduce code indentation by returning early in a couple of places.
Reported by: Coverity CID: 1006692 Reviewed by: markj (previous version) MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D6490
|
299094 |
04-May-2016 |
ngie |
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed after r298107
Summary of changes:
- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed - Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc - Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously. - Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk - Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk. - Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo - Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)
Document the proposed changes in share/examples/tests/tests/... via examples so it's clear that ${PACKAGES}FILES is the suggested way forward in terms of replacing FILES. share/mk/bsd.README didn't seem like the appropriate method of communicating that info.
MFC after: never probably X-MFC with: r298107 PR: 209114 Relnotes: yes Tested with: buildworld, installworld, checkworld; buildworld, packageworld Sponsored by: EMC / Isilon Storage Division
|
298525 |
23-Apr-2016 |
wblock |
Add a single example of adding a user that roughly corresponds with the adduser example in the Handbook.
MFC after: 1 week
|
298107 |
16-Apr-2016 |
gjb |
Merge the projects/release-pkg branch to head.
This allows packaging the base system with pkg(8), including but not limited to providing the ability to provide upstream binary update possibilities for non-tier-1 architectures.
This merge is a requirement of the 11.0-RELEASE, and as such, thank you to everyone that has tested the project branch.
Documentation in build(7) etc. is still somewhat sparse, but updates to those parts will follow.
Sponsored by: The FreeBSD Foundation
|
297330 |
28-Mar-2016 |
wblock |
Adjust misleading wording of the -G option and simplify a few surrounding sentences. From a discussion on -ports.
Reviewed by: David Wolfskill <david@catwhisker.org>
|
297290 |
26-Mar-2016 |
bapt |
Remove some unneeded headers
Found by 'include-what-you-use'
|
296587 |
09-Mar-2016 |
bdrewery |
DIRDEPS_BUILD: Connect MK_TESTS.
Sponsored by: EMC / Isilon Storage Division
|
296300 |
02-Mar-2016 |
markj |
Fix a typo that prevented pw(8) from setting a user's UID to 0.
MFC after: 1 week Sponsored by: EMC / Isilon Storage Division
|
292849 |
29-Dec-2015 |
bapt |
Simplify code for parsing extra groups
|
292847 |
29-Dec-2015 |
bapt |
Remove useless assignement of linelen
|
292846 |
29-Dec-2015 |
bapt |
Restore dryrun support for pw groupmod
|
291658 |
02-Dec-2015 |
bapt |
pw_checkname since the beginning if too strict on GECOS field, relax it a bit so gecos can be used to store multibytes data.
This was unseen before FreeBSD 10.2 as this validation function was motly unused since FreeBSD 10.2 the usage of this function has been generalized to improve validation.
Reported by: des MFC after: 1 week
|
291657 |
02-Dec-2015 |
bapt |
Fix handling of numeric-only names with pw lock Add a regression test about it
PR: 204968 MFC after: 1 week
|
290174 |
30-Oct-2015 |
delphij |
In pw_userlock, set 'name' to NULL when we encounter an all number string because it is also used as an indicator of whether a name or an UID is being used and we may have undefined results as 'name' may contain uninitialized stack contents.
MFC after: 2 weeks
|
290153 |
29-Oct-2015 |
bdrewery |
Fix unlikely memory leak.
It is unlikely since the first check in the function is that dir[0] is '/', but later code changes may make it real.
Coverity CID: 1332104
|
289600 |
19-Oct-2015 |
ngie |
Initialize `quiet` to false so `pw groupnext` again prints out the next gid by default
Reported by: Florian Degner <f.degner@gmx.de> MFC after: 1 week PR: 203876 Sponsored by: EMC / Isilon Storage Division
|
289172 |
12-Oct-2015 |
ngie |
Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) and netbsd-tests.test.mk (r289151)
- Eliminate explicit OBJTOP/SRCTOP setting - Convert all ad hoc NetBSD test integration over to netbsd-tests.test.mk - Remove unnecessary TESTSDIR setting - Use SRCTOP where possible for clarity
MFC after: 2 weeks Sponsored by: EMC / Isilon Storage Divison
|
289067 |
09-Oct-2015 |
wblock |
Fix a repeated typo: rootir -> rootdir.
Approved by: bapt MFC after: 1 week
|
287799 |
14-Sep-2015 |
bapt |
Regression: fix usershow -7
Submitted by: Dan McGregor (via IRC) MFC after: 2 days
|
287701 |
12-Sep-2015 |
bapt |
Regression: fix pw usermod -d
Mark the user has having been edited if -d option is passed to usermod and so the request change of home directory actually happen
PR: 203052 Reported by: lenzi.sergio@gmail.com MFC after: 2 days
|
286993 |
21-Aug-2015 |
bapt |
Fix err pointer not initialized to NULL resulting
Reported by: "O. Hartmann" <ohartman@zedat.fu-berlin.de>
|
286991 |
21-Aug-2015 |
bapt |
Fix typo in regression test
|
286986 |
21-Aug-2015 |
bapt |
Fix /home symlink creation
Add regression test about it
|
286982 |
21-Aug-2015 |
bapt |
Fix useradd regression:
Readd the function to create the parents home directory if it does not exists. if it is only a directory at the top level of the hierarchy symlink it into /usr as it used to be done before.
Reported by: kevlo, adrian
|
286775 |
14-Aug-2015 |
bapt |
Regression: fix pw usermod -w xxx
Reported by: gjb
|
286341 |
05-Aug-2015 |
bapt |
Add regression tests for a bug reported in stable/10
While pw(8) on head is not affected it is worth adding more regression tests ensuring this bug will not happen unnoticed in the futur
|
286259 |
03-Aug-2015 |
ed |
Avoid calling strlen() where we can use the strspn() return value.
|
286258 |
03-Aug-2015 |
dteske |
Clarify pw(8) manual w/respect to required arguments. Break long lines at punctuation while here.
Differential Revision: https://reviews.freebsd.org/D2700 Reviewed by: wblock, bapt MFC after: 3 days X-MFC-to: stable/10
|
286218 |
03-Aug-2015 |
bapt |
Fix bugs spotted by gcc
Reported by: adrian
|
286217 |
03-Aug-2015 |
adrian |
Actually set quiet to something.
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_next': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680: warning: statement with no effect
|
286211 |
02-Aug-2015 |
bapt |
Use intmax_t rather than long long
|
286210 |
02-Aug-2015 |
bapt |
Convert the year used for regression test fro 2043 to 2037
This makes the regression tests pass on systems where time_t is 32bits
|
286204 |
02-Aug-2015 |
bapt |
Fix build on 32bits
|
286203 |
02-Aug-2015 |
bapt |
Split some extra long lines
|
286202 |
02-Aug-2015 |
bapt |
Split some extra long lines
|
286201 |
02-Aug-2015 |
bapt |
Cleanup a bit includes
|
286200 |
02-Aug-2015 |
bapt |
Add regression tests about adding already existsing groups/users
|
286199 |
02-Aug-2015 |
bapt |
Fix regression: report if a group already exists when creating it
|
286198 |
02-Aug-2015 |
bapt |
Fix regression: report again if a username already exists when creating it
|
286197 |
02-Aug-2015 |
bapt |
Remove dead code
|
286196 |
02-Aug-2015 |
bapt |
Rewrite parsing subcommands arguments of pw(8)
Now each subcommands checks its arguments in a dedicated functions.
This helps improving input validation, code readability/maintainability While here: - Add a -y option to pw userdel/usermod so it can maintain NIS servers if nispasswd is not defined in pw.conf(5) - Allow pw -r <rootdir> to remove directory with userdel -r - Fix bug when renaming a user which was not renaming the user name it groups it is a member of. - Only parse pw.conf(5) when needed.
|
286173 |
02-Aug-2015 |
bapt |
Remove netbsd tests on pw(8)
First they are redundant with the tests we currently have on pw(8) Second they to modify the host database instead of being self contained withing the test directory
|
286157 |
01-Aug-2015 |
bapt |
Remove things that crept in after badly checked revert
|
286156 |
01-Aug-2015 |
bapt |
Partial revert of r286152
More work needed on the cli validation
|
286155 |
01-Aug-2015 |
bapt |
Fix build
|
286154 |
01-Aug-2015 |
bapt |
Fix formatting of new code Fix sorting or errstr Remove useless initialisation or errstr
Reported by: bde
|
286152 |
01-Aug-2015 |
bapt |
Validate expiration days and password days from commmand line and pw.conf
|
286151 |
01-Aug-2015 |
bapt |
Validate the max_uid/max_gid boundaries and entry type in pw.conf
|
286150 |
01-Aug-2015 |
bapt |
Cast uid/git to uintmax_t when using printf-like functions so the size of uid/gid size remains a implementation detail
|
286066 |
30-Jul-2015 |
bapt |
Improve strtounum
Fix many style bugs Better variable naming Use C99 'restrict' were apropriate Fix potential errno race
Submitted by: bde
|
286047 |
29-Jul-2015 |
bapt |
Cleanup includes
|
286045 |
29-Jul-2015 |
bapt |
Actually set the proper license
Reported by: trasz
|
285997 |
29-Jul-2015 |
bapt |
Actually add the new code
|
285996 |
29-Jul-2015 |
bapt |
Create a strtounum function using the same API as strtonum
This function returns uintmax_t Use this function to convert to gid_t/uid_t
|
285989 |
28-Jul-2015 |
bapt |
Reject usermod and userdel if the user concerned is not on the user database supposed to be manipulated
This prevent pw usermod creating a new local user when requesting to usermod on a username is defined in LDAP.
This issue only happens when modifying the local user database (not inpacting commands when -V or -R are used).
PR: 187653 Submitted by: tmwalaszek@gmail.com
|
285985 |
28-Jul-2015 |
bapt |
Check uid/gid used when creating a user/group are not larger than UID_MAX/GID_MAX
PR: 173977 Reported by: nvass@gmx.com
|
285984 |
28-Jul-2015 |
bapt |
Fix wrong warning printed after changing or updating NIS users
PR: 37672 Submitted by: chris+freebsd@chrullrich.de
|
285948 |
28-Jul-2015 |
bapt |
when -n is passed to any pw subcommand it is always expected to be considered as a name so do not try to convert it to an id if it is a numeric value
PR: 31933 Reported by: ted@impulse.net Sponsored by: gandi.net
|
285443 |
13-Jul-2015 |
bapt |
Really fix -o
|
285442 |
13-Jul-2015 |
bapt |
Add regression tests to ensure we keep allowing creating users with uid0
|
285441 |
13-Jul-2015 |
bapt |
Regression fix: allow to create users with uid0
Reported by: Jan Mikkelsen <janm@transactionware.com>
|
285440 |
13-Jul-2015 |
bapt |
Fix logic of check duplicates that has been inverted
|
285434 |
12-Jul-2015 |
bapt |
Ensure skeldir is abolute path (relatively to the rootdir)
|
285433 |
12-Jul-2015 |
bapt |
pw -R <rootdir> userdel can now cleanup installation
Rewrite rm_r to use *at function, allowing to remove home directories along with users. only crontabs and at(1) installation are not removed
Relnotes: yes
|
285430 |
12-Jul-2015 |
bapt |
Rework the home directory creation and copy or the skel content to use *at functions
This allows to simplify the code a bit for -R by not having to keep modifying path and also prepare the code to improve support -R in userdel
While here, add regression tests for the functionality
|
285418 |
12-Jul-2015 |
bapt |
Add minimum regression tests for pw -R
|
285415 |
12-Jul-2015 |
bapt |
Make getarg return NULL if args is NULL
|
285414 |
12-Jul-2015 |
bapt |
Fix regression: ensure when try to create the group and the user with the same id if possible and nothing in particular was specified
|
285413 |
11-Jul-2015 |
bapt |
Remove now unused variable
|
285412 |
11-Jul-2015 |
bapt |
Replace custom string array with stringlist(3)
|
285411 |
11-Jul-2015 |
bapt |
Rework groupmod modification:
Use gr_add(3) when possible to avoid code duplication. Use a simpler logic to delete members of a group
|
285409 |
11-Jul-2015 |
bapt |
Remove unused argument from pm_passwd
|
285408 |
11-Jul-2015 |
bapt |
check the gecos format early: at the moment the -c option is parsed
|
285406 |
11-Jul-2015 |
bapt |
Remove useless use of goto
|
285405 |
11-Jul-2015 |
bapt |
Isolate pw lock/unlock into a separate function
|
285403 |
11-Jul-2015 |
bapt |
homedir can only be populate during useradd
|
285401 |
11-Jul-2015 |
bapt |
Make a separate groupdel/userdel from the main function
|
285398 |
11-Jul-2015 |
bapt |
Make separate functions to show users and groups
|
285396 |
11-Jul-2015 |
bapt |
Move the quiet flag into the configuration structure
|
285395 |
11-Jul-2015 |
bapt |
Separate usernext/groupnext from the main functions
|
285318 |
09-Jul-2015 |
bapt |
Do not try to set password on group if the group is added as a consequence of of creating a user (regression from r285136)
Reported by: Fabian Keil <fk@fabiankeil.de>
|
285256 |
07-Jul-2015 |
bapt |
pw: fail if an invalid entry is found while parsing master.passwd and group
PR: 198554 Reported by: diaran <fbsd@centraltech.co.uk> MFC after: 2 days
|
285158 |
05-Jul-2015 |
bapt |
Remove dead code
|
285157 |
05-Jul-2015 |
bapt |
Also validate hours via strptime_l(3)
Simplify the code, by only using one parser, ensure the dates (hours and dates) are valid
|
285156 |
05-Jul-2015 |
bapt |
Validate expiration dates
Use strptime_l(3) to validate the dates provided in input
|
285137 |
04-Jul-2015 |
bapt |
Fix validation of crypted password Small cleanups
|
285136 |
04-Jul-2015 |
bapt |
Also validate inputs of pw groupmod -h and groupmod -H
|
285133 |
04-Jul-2015 |
bapt |
Validate input of pw usermod -h and pwusermod -H
Push the code that set the password into a separate function to improve readability
Add regression tests about pw usermod -h and pw usermod -H
|
284392 |
14-Jun-2015 |
bapt |
Change the documentation to reflect where the -V option should be used
Suggested by: kientzle
|
284345 |
13-Jun-2015 |
sjg |
Add META_MODE support.
Off by default, build behaves normally. WITH_META_MODE we get auto objdir creation, the ability to start build from anywhere in the tree.
Still need to add real targets under targets/ to build packages.
Differential Revision: D2796 Reviewed by: brooks imp
|
284149 |
08-Jun-2015 |
bapt |
backout remove of -q option for pw [user|group] next
While the return code is broken, some corner case usage depends on the functionnality, so backout until we get better regression tests covering those corner case usage.
|
284148 |
08-Jun-2015 |
bapt |
Fix typo
|
284140 |
07-Jun-2015 |
bapt |
Fix mistakes than came along with r284139
|
284139 |
07-Jun-2015 |
bapt |
Remove '-q' support for pw [user|group] next
the intent of -q in this command is to return as exit status the value of the next group/user id, which does not make sense given exit status are limited to values between 0 and 255.
|
284137 |
07-Jun-2015 |
bapt |
Fix setting uid/gid min/max via pw
|
284135 |
07-Jun-2015 |
bapt |
Fix generating configuration file
|
284133 |
07-Jun-2015 |
bapt |
Fix duplicate checking
|
284130 |
07-Jun-2015 |
bapt |
Remove uneeded code (already done by pw_make_v7)
|
284129 |
07-Jun-2015 |
bapt |
In case of rename validate the length of the new name
Check early that the new name fits MAXLOGNAME and store it in pwconf
|
284128 |
07-Jun-2015 |
bapt |
Refactor input validation
Mutualize code to validate inputs of both 'user' and 'group' command Test that the input name fits into MAXLOGNAME
|
284126 |
07-Jun-2015 |
bapt |
Finish converting -7 to pwconf
|
284124 |
07-Jun-2015 |
bapt |
Handle -7 via gloval pwconf
|
284123 |
07-Jun-2015 |
bapt |
Initialize conf using menset(3)
|
284122 |
07-Jun-2015 |
bapt |
Handle pretty print (-P) via global pwconf
|
284121 |
07-Jun-2015 |
bapt |
Handle dryrun (-N) via global pwconf
|
284120 |
07-Jun-2015 |
bapt |
Sort headers
|
284119 |
07-Jun-2015 |
bapt |
Handle -C and -Y locally and stop adding them to arglist
|
284118 |
07-Jun-2015 |
bapt |
Add a new global struct pwconf to store etcpath, rootdir and struct userconf
Do not add anymore -R and -V to arglist Add an error message if both -V and -R are set in arguments
|
284117 |
07-Jun-2015 |
bapt |
Fix pw userdel -r not deleting homedir
|
284114 |
07-Jun-2015 |
bapt |
Test explicitly the result of strcmp to be consistent with the rest of the code
|
284113 |
07-Jun-2015 |
bapt |
Improve readability by reducing indentations levels
|
284112 |
07-Jun-2015 |
bapt |
Remove one level of indentation
|
284111 |
07-Jun-2015 |
bapt |
Move user deletion code into a separate function to improve readability
|
284110 |
07-Jun-2015 |
bapt |
Instead of always casting the pw_checkname input to u_char * and casting it back to char *, change pw_checkname to directly take char * in input
|
283962 |
03-Jun-2015 |
gjb |
Document pw(8) '-R' option, added in r283961.
MFC after: 1 week X-MFC-after: r283961 Sponsored by: The FreeBSD Foundation
|
283961 |
03-Jun-2015 |
bapt |
New pw -R rootdir option
This allows to set an alternate root directory in which the users/groups will be manipulated
Requested by: gjb, ian Tested by: gjb
|
283843 |
31-May-2015 |
bapt |
Cast to gid_t for groups not uid_t
|
283842 |
31-May-2015 |
bapt |
Remove useless cast in printf and printf-like functions: use %u for uid_t and gid_t
|
283841 |
31-May-2015 |
bapt |
Cast -1 to uid_t and bump WARNING level to 3
|
283818 |
31-May-2015 |
bapt |
Move cleanup functions to the right place
|
283816 |
31-May-2015 |
bapt |
Remove useless test before free()
|
283815 |
31-May-2015 |
bapt |
Return early in case we cannot read the configuration file
This drops one level of indentation
|
283814 |
31-May-2015 |
bapt |
Make pw_user()/pw_group() more consitent about errors
Some of errors were returned to the main function, some others caused a direct exit via err(3).
The main function is only interested in EXIT_SUCCESS, so in all other cases replace warn(3) + return err by err(3)
|
283811 |
31-May-2015 |
bapt |
Remove uneeded intermediate variable
|
283810 |
31-May-2015 |
bapt |
Remove uneeded intermediate variable
|
283809 |
31-May-2015 |
bapt |
Use asprintf instead of malloc + snprintf and test the memory allocation
|
283695 |
29-May-2015 |
bapt |
Remove dead declaration
PR: 195928 MFC after: 2 days
|
282721 |
10-May-2015 |
bapt |
Remove extendline definition Remove now unused PWBUFSZ define
|
282720 |
10-May-2015 |
bapt |
Use calloc(3) instead of malloc(3) + memset(3) While here check the return of calloc(3)
|
282719 |
10-May-2015 |
bapt |
The initial logic for allocating the new string was wrong, the conversion to strndup(3) duplicated the same mistake, actually strdup(3) is good enough to allocate the new string.
|
282718 |
10-May-2015 |
bapt |
Use strndup(3) instead of malloc(3) + memcpy(3) Check the return of strndup
|
282716 |
10-May-2015 |
bapt |
Remove useless call to extendarray
|
282713 |
10-May-2015 |
bapt |
The pwdb function is only used once to check the database rename it pwdb_check and simplify it accordingly
|
282712 |
10-May-2015 |
bapt |
if the check of the pw db fails return the failed value
|
282709 |
10-May-2015 |
bapt |
Some style(9) fixes
|
282700 |
09-May-2015 |
bapt |
Replace sprintf(3) with snprintf(3)
|
282699 |
09-May-2015 |
bapt |
Use snprintf(3) instead of sprintf(3) Remove useless "else"
|
282698 |
09-May-2015 |
bapt |
Remove now unused LNBUFSZ buffer size
|
282697 |
09-May-2015 |
bapt |
Return from the function as early as possible
This reduces the depth of the if statements and improves clarity of the code
|
282687 |
09-May-2015 |
bapt |
Remove some uneeded headers
|
282686 |
09-May-2015 |
bapt |
Remove unneeded headers
|
282685 |
09-May-2015 |
bapt |
Replace malloc(3) + strcpy(3) + strcat(3) by asprintf(3)
|
282683 |
09-May-2015 |
bapt |
Use snprintf(3) instead of strcpy(3) + strncat(3)
|
282681 |
09-May-2015 |
bapt |
Use sbuf(9) instead of homebrewed buffered string
|
279256 |
24-Feb-2015 |
brd |
Fix a race condition by allowing up to 5 seconds of difference between the time stamps.
PR: 197861 Approved by: will
|
278902 |
17-Feb-2015 |
brd |
Add tests for account and password expiration.
Approved by: will
|
278819 |
15-Feb-2015 |
brd |
Really fix the pw_usernext tests.
PR: 197612 Approved by: will
|
278767 |
14-Feb-2015 |
brd |
Remove an extra curly bracket that was causing intermittent failures.
PR: 197612 Submitted by: Robert O'Niel <oneil.rs@gmail.com> Approved by: will
|
278475 |
09-Feb-2015 |
brd |
Add tests for `pw usernext'.
PR: 197120 Submitted by: Robert O'Neil <oneil.rs@gmail.com> Approved by: will
|
277764 |
26-Jan-2015 |
bapt |
Revert r277652
uid and gid are never and should never be negative. The pw(8) manpage clearly states the -u and -g arguments are for uids/gids, hence using negative values is abusing a bug in former versions of pw(8)
|
277652 |
24-Jan-2015 |
bapt |
Allow negative numbers in -u and -g options
PR: 196514 MFC after: 1 week
|
275829 |
16-Dec-2014 |
brd |
Add tests for pw -N
PR: 150449 Submitted by: Robert O'Neil <oneil.rs@gmail.com> Approved by: will
|
275658 |
09-Dec-2014 |
brd |
Restructure to make it easier to extend in the future
Reviewed by: will Suggested by: ngie
|
275657 |
09-Dec-2014 |
brd |
Add some tests for user modification. [1] Fix a missing test in the Makefile from my previous commit.
PR: 195834 [1] Submitted by: Robert O'Neil <oneil.rs@gmail.com> Approved by: will
|
275656 |
09-Dec-2014 |
brd |
Break out the tests into a file per command and clean up some long lines
Approved by: will
|
275653 |
09-Dec-2014 |
brd |
Add more tests for pw(8) useradd.
PR: 195832 Submitted by: Robert O'Neil <oneil.rs@gmail.com> Approved by: will
|
274986 |
24-Nov-2014 |
brd |
Convert to LIBADD.
Reviewed by: bapt
|
274727 |
19-Nov-2014 |
brd |
Replace the pw(1) calls with a variable, to make it easier to to change across all the tests as needed.
Reviewed by: will
|
274632 |
17-Nov-2014 |
brd |
Clean up some language
Reviewed by: will
|
274542 |
15-Nov-2014 |
brd |
Add a test for locking and unlocking user accounts
Submitted by: Robert O'Neil <oneil.rs@gmail.com> Reviewed by: will
|
274453 |
12-Nov-2014 |
bapt |
Fix wrong message when using pw -V with a non existent directory Add a regression test about it
PR: 194971 Submitted by: Freddy DISSAUX <bugzilla@dsx.bsdsx.fr>
|
274022 |
03-Nov-2014 |
ngie |
Require root when running the pw_delete and pw_modify test programs (pw(8) requires it)
|
274011 |
03-Nov-2014 |
ngie |
Integrate usr.sbin/useradd/t_useradd.sh from NetBSD into FreeBSD as pw_test
- Suffix useradd/userdel commands with pw - Remove the atf_expect_fail for bin/39546
Phabric: D921 Reviewed by: brd Sponsored by: EMC / Isilon Storage Division
|
273791 |
28-Oct-2014 |
bapt |
Fix renaming a group via the gr_copy function
Add a regression test to pw(8) because the bug was discovered via using: pw groupmod
PR: 187189 Reported by: mcdouga9@egr.msu.edu Tested by: mcdouga9@egr.msu.edu Patch by: Marc de la Gueronniere
|
273787 |
28-Oct-2014 |
bapt |
Ensure pw userdel -u <invalid> do not try to remove root
Check the uid passed is actually a number as early as possible
MFC after: 1 week
|
273786 |
28-Oct-2014 |
bapt |
Fix atf syntax
|
273782 |
28-Oct-2014 |
bapt |
Do not delete the group wheel when bad argument is passed to pw groupdel -g
Check that the -g argument is actually a number, if not report an error. This argument is converted without checking with atoi(3) later so without this check it converts any alpha entries into 0 meaning it deletes the group wheel
Add a regression test about it
PR: 90114 Reported by: bkoenig@cs.tu-berlin.de MFC after: 1 week
|
273779 |
28-Oct-2014 |
bapt |
Fix a regression in pw usermod -G list
The user was perperly adding the to different groups from "list" but was not removed from the other groups it could have belong to. While here add a regression test about this bug
PR: 185666 Reported by: sub.mesa@gmail.com MFC after: 1 week
|
273772 |
28-Oct-2014 |
bapt |
When a group is renamed then the group has been invalidated for sure. In that case get the group information using the new name.
Add a regression test about this bug
PR: 193704 Reported by: az
|
272833 |
09-Oct-2014 |
des |
Two more places where login_setcryptfmt() defaults to MD5 were missed in r252688.
MFC after: 3 days
|
272578 |
06-Oct-2014 |
brd |
- Add some tests for modifying groups
Reviewed by: will
|
272445 |
02-Oct-2014 |
brd |
- Add a test for bug 191427 where pw(8) will go into an infinite loop
Reviewed by: will MFC after: 1 month
|
267970 |
27-Jun-2014 |
mjg |
pw: fix up deletion of users from groups
Previuosly given 'foo,bar' members, removing 'foo' would result in an infinite loop.
PR: 191427 Submitted by: Voradesh Yenbut <yenbut cs.washington.edu> MFC after: 1 week
|
267670 |
20-Jun-2014 |
bapt |
Fix changing the username
PR: 189172 Submitted by: fullermd@over-yonder.net MFC after: 1 week
|
267669 |
20-Jun-2014 |
bapt |
Removed compatibility with pre FreeBSD 2.2 pw_mkdb command Fix some broken indentattion
PR: 189173 Submitted by: fullermd@over-yonder.net MFC after: 1 week
|
264781 |
22-Apr-2014 |
bapt |
Simplify reading pw.conf(5) by using getline(3)
|
263114 |
13-Mar-2014 |
dteske |
Fix pw(8) deletion of group "username" on userdel even if group "username" is not associated with user "username". E.g., user "foo" has primary group "wheel" and is unassociated with group "foo", yet userdel would delete the group "foo" when deleting user "foo" (despite the fact that user "foo" is not associated with group "foo" in any way).
Patch committed with minor style(9) changes.
PR: bin/169471 Submitted by: Alexander Pyhalov <apyhalov@gmail.com>
|
262865 |
06-Mar-2014 |
julian |
Part 2 of bug 187310.. had to commit separately due to local confusion. Don't let pw crash when give certain input.
PR: 187310 Submitted by: Kim Shrier MFC after: 1 week
|
262864 |
06-Mar-2014 |
julian |
Stop pw(8) from segfaulting when given certain input
PR:187310 Submitted by: Kim Shrier Obtained from: bug MFC after: 1 week
|
252688 |
04-Jul-2013 |
des |
Fall back to sha512 if passwd_format is not set.
MFC after: 3 days
|
252556 |
03-Jul-2013 |
des |
There is no reason to disallow setting the password or account expiry date to the current date.
MFC after: 3 days
|
252377 |
29-Jun-2013 |
kientzle |
Fix -Wunsequenced warning
Submitted by: dt71@gmx.com
|
250604 |
13-May-2013 |
joel |
mdoc sweep
|
246192 |
01-Feb-2013 |
deischen |
Prevent a null pointer dereference in pw userdel when deleting a user whose group != username.
|
245493 |
16-Jan-2013 |
eadler |
Remove unused variables
Approved by: cperciva MFC After: 3 days
|
245114 |
06-Jan-2013 |
mjg |
pw: free group returned by gr_add
|
244743 |
27-Dec-2012 |
bapt |
Simplify vnextgrent and vnextpwent reusing pw_scan and gr_scan from libutil.
|
244738 |
27-Dec-2012 |
bapt |
Fix a regression in "pw group show" introduced r242349: print a newline after printing each group line.
PR: bin/174731 Submitted by: Jan Beich <jbeich@tormail.org>
|
244737 |
27-Dec-2012 |
bapt |
Simplify the code by using the new gr_add function
|
244721 |
26-Dec-2012 |
bapt |
Simplify copying of group members by using memcpy
Submitted by: Christoph Mallon <christoph.mallon@gmx.de>
|
244720 |
26-Dec-2012 |
bapt |
Fix off-by-one error in memory allocation: j entries, one new and a null terminator is j + 2.
Submitted by: Christoph Mallon <christoph.mallon@gmx.de>
|
244711 |
26-Dec-2012 |
bapt |
In case of the deletion of a user those whole database has to be regenerated, otherwise the user planned to be deleted remain in the pwd.db while removed from the plain text password file.
|
244710 |
26-Dec-2012 |
bapt |
Fix creating a user and adding it to a group
Reported by: "Sam Fourman Jr." <sfourman@gmail.com>, dim
|
243898 |
05-Dec-2012 |
eadler |
Simplify string duplication: use strdup instead of malloc + strcpy
Submitted by: db Approved by: cperciva MFC after: 2 weeks
|
243897 |
05-Dec-2012 |
eadler |
Avoid overflowing the file buffer
Submitted by: db Approved by: cperciva MFC after: 2 weeks
|
243896 |
05-Dec-2012 |
eadler |
Use strdup instead of malloc + strcpy
Submitted by: db Approved by: cperciva MFC after: 2 weeks
|
243895 |
05-Dec-2012 |
eadler |
Avoid overflow of file buffer
Submitted by: db Approved by: cperciva MFC after: 2 weeks
|
243894 |
05-Dec-2012 |
eadler |
Remove useless check for NULL prior to free.
Approved by: cperciva MFC after: 2 weeks
|
243335 |
20-Nov-2012 |
bapt |
In NIS mode first chmod(2) the temporary file and is succeed then rename(2)
|
243330 |
20-Nov-2012 |
bapt |
Correctly set the password file mode after renaming in NIS mode
|
242349 |
30-Oct-2012 |
bapt |
Teach pw(8) about how to use pw/gr API to reduce code duplication
MFC after: 2 months
|
241108 |
01-Oct-2012 |
bapt |
Do not treat empty name as an uid 0
Reported by: Robert Bonomi <bonomi@mail.r-bonomi.com>
|
241107 |
01-Oct-2012 |
bapt |
Remove useless atoi(3), previous strspn(3) makes sure that a_name->val is a number. This also allow pw user show to work as expected.
PR: bin/172112 Submitted by: "Ilya A. Arkhipov" <rum1cro@yandex.ru> MFC after: 1 month
|
241021 |
28-Sep-2012 |
kevlo |
Make sure that each va_start has one and only one matching va_end, especially in error cases.
|
231994 |
22-Feb-2012 |
kevlo |
Handle NULL return from crypt(3). Mostly from DragonFly
|
231654 |
14-Feb-2012 |
kevlo |
readlink len-1
|
228990 |
30-Dec-2011 |
uqs |
Spelling fixes for usr.sbin/
|
228795 |
22-Dec-2011 |
eadler |
- document the -l option to usermod
PR: docs/161588 Submitted by: "Luchesar V. ILIEV" <luchesar.iliev@gmail.com> Approved by: gjb MFC after: 1 week
|
228673 |
17-Dec-2011 |
dim |
In usr.sbin/pw/pw_user.c, use the correct printf length modifier for a ptrdiff_t.
MFC after: 1 week
|
224535 |
31-Jul-2011 |
delphij |
Backout r223115 which potentially caused a POLA violation, by restoring historic behavior (create the default base directory in pw.conf) before I came up with a better fix for this.
Requested by: nwhitehorn Approved by: re (kib)
|
223115 |
15-Jun-2011 |
delphij |
Don't attempt to create the base directory when -d is specified.
MFC after: 1 month
|
219408 |
08-Mar-2011 |
jkim |
Stop hard-coding default directory mode as 0777.
|
218293 |
04-Feb-2011 |
jkim |
Do not let pw.conf(5) or -M option affect creation of basehome, e.g., /home. When the basehome does not exist, it creates all intermediate directories as required, which is logically equivalent to mkdir(1) with -m and -p options. However, it modifies all intermediate directories, not just the final home directory unlike mkdir. This problem was introduced in two revisions, i.e., r1.59 (SVN r167919) and r1.60 (SVN r168044).
MFC after: 1 month
|
213573 |
08-Oct-2010 |
uqs |
mdoc: drop redundant .Pp and .LP calls
They have no effect when coming in pairs, or before .Bl/.Bd
|
213459 |
05-Oct-2010 |
jkim |
Revert the unrelated patch crept in the previous commit.
|
213458 |
05-Oct-2010 |
jkim |
Prefer pmap_unmapbios() over pmap_unmapdev(). The binary does not change after this because pmap_unmapbios() is a macro for pmap_unmapdev() on amd64.
|
201390 |
02-Jan-2010 |
ed |
The last big commit: let usr.sbin/ use WARNS=6 by default.
|
200173 |
06-Dec-2009 |
ed |
Make pw(8) build without <utmp.h>.
The size of the username record in utmp files should not influence the maximum username length. Right now ut_user/ut_name is big enough, so in this case it's dead code anyway.
|
181785 |
16-Aug-2008 |
ache |
Use arc4random_uniform() to avoid "modulo bias"
Remove pw_getrand() unneded now: arc4random_uniform() is stronger then pw_getrand()'s MD5 tricks (inactive) and its active version, mixing arc4random() bytes in one, not make things better at all.
|
180565 |
17-Jul-2008 |
jhb |
Before updating the password database, the pw(8) utility first performs a sanity check by invoking "pwd_mkdb -C". However, if this failed it silently returned success. Fix this so it fails the update operation instead.
MFC after: 1 week
|
179365 |
27-May-2008 |
antoine |
- Increase the size of the salt in pw(8) from 8 to 32 (same as in pam_unix(8)). This makes blowfish password hashes look normal when set using pw(8)/adduser(8). [1] - Make it possible to have a '/' in the salt.
PR: 121146 [1] Submitted by: Jaakko Heinonen [1] Approved by: rwatson (mentor) MFC after: 1 month
|
176474 |
23-Feb-2008 |
scf |
Add the groupmod '-d' option to pw to allow the deletion of existing users from a group without the need to perform the same operation by replacing the existing list via the '-M' option. The '-M' option requires someone to fetch the existing members with pw, deleting the undesired members from the list and sending the altered list back to pw.
Approved by: wes (mentor) MFC after: 5 days
|
176473 |
23-Feb-2008 |
scf |
style(9) (verified no object changes)
Approved by: wes (mentor) MFC after: 5 days
|
175661 |
25-Jan-2008 |
mtm |
Clarify in what formats the grouplist for the '-G' switch may be accepted.
Submitted by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
|
168046 |
30-Mar-2007 |
le |
Do the right thing with symlinks in the skeleton directory.
PR: bin/63659
|
168045 |
30-Mar-2007 |
le |
Accept passwords which contain whitespace.
PR: bin/53434
|
168044 |
30-Mar-2007 |
le |
Add home directory creation mode to pw.conf(5) and be a bit more specific about the effect of the current umask on -M.
|
168043 |
30-Mar-2007 |
le |
Add -M argument to usage() output.
|
167919 |
26-Mar-2007 |
le |
Introduce the new option -M to allow to set the permissions of the user's newly created home directory. If omitted, it's derived from the current umask.
PR: bin/16880, bin/83253 (partially), bin/104248 MFC in: 1 month
|
163169 |
09-Oct-2006 |
trhodes |
Better mdoc(7). Bump doc date.
Kicked by: ru
|
163165 |
09-Oct-2006 |
trhodes |
Note the naming convention of files in share/skel and explain the "dot" prefix is removed.
PR: 103828
|
162400 |
18-Sep-2006 |
maxim |
o Fix groupadd getopt line and make 'pw groupadd -o' work.
PR: bin/100684 Submitted by: Devon H. O'Dell MFC after: 3 weeks
|
148584 |
31-Jul-2005 |
pjd |
Change /home symbolic link, so it will point to usr/home instead of /usr/home.
Previous symlink was confusing:
# cd /jails/virtual_system_1/home # realpath . /usr/home
...and slower.
OK'ed by: rwatson, phk
|
144841 |
09-Apr-2005 |
stefanf |
Remove unused variables.
|
141608 |
10-Feb-2005 |
stefanf |
The variable `arglist' has internal linkage in pw.c, don't declare it as extern here.
|
140442 |
18-Jan-2005 |
ru |
Sort sections.
|
140368 |
17-Jan-2005 |
ru |
Added the EXIT STATUS section where appropriate.
|
136087 |
03-Oct-2004 |
stefanf |
Don't rely on NULL being a pointer, add a cast before passing it to a variadic function.
|
131500 |
02-Jul-2004 |
ru |
Mechanically kill hard sentence breaks.
|
130633 |
17-Jun-2004 |
robert |
Use strlcpy(3) to replace the idiomatic
strncpy(d, s, l); d[l - 1] = '\0';
statements.
|
130629 |
17-Jun-2004 |
robert |
Fix a bug which occurred when the home directory given by the -d option was equal to the one already saved and which caused the pw utility to avoid updating values passed by other options processed before the -d option in the code path.
Spotted by: Richard Caley <rjc@interactive.co.uk>
|
126753 |
08-Mar-2004 |
kensmith |
Shift file locking to source file instead of temp file. This fixes data buffering issue that corrupts files if two pw(8)'s run at the same time as well as changing pw(8) so it uses the same locking mechanism as PAM, vipw(8), pwd_mkdb(8), etc.
PR: bin/23501 Submitted by: Alex Kapranoff <alex (at) kapran (dot) bitmcnit (dot) bryansk (dot) su> Approved by: rwatson (mentor) MFC after: 5 days
|
124382 |
11-Jan-2004 |
iedowse |
Add a `-H <fd>' option that is like `-h <fd>', but accepts an already encrypted password on the specified file descriptor.
PR: bin/22033 MFC after: 2 weeks
|
119893 |
08-Sep-2003 |
ru |
mdoc(7): Use the new feature of the .In macro.
|
116051 |
08-Jun-2003 |
charnier |
The .Xr utility. Spelling. Put NIS under .Tn
|
114823 |
08-May-2003 |
trhodes |
Add information about the log file.
PR: 35575 Submitted by: "Simon L. Nielsen" <simon@nitro.dk> (original version)
|
113091 |
04-Apr-2003 |
obrien |
style.Makefile(5)
|
110667 |
11-Feb-2003 |
ache |
There is no sense to use random random() and arc4random() in the same program. Switch to arc4random() completely.
|
109961 |
28-Jan-2003 |
gad |
Changes so the 'pw' command will allow '$' as the last character in a userid or group name (mainly for the benefit of samba). This pretty much rewrites he pw_checkname() routine, but should work exactly the same except for the above change, and that error messages are somewhat more informative.
PR: 28733 46890 Inspired by: example patch written by Terry Lambert Reviewed by: no objections on freebsd-arch and freebsd-current MFC plans: no plans, but will do if people want it in stable.
|
109749 |
23-Jan-2003 |
fjoe |
Do not expose password if it is empty and PWF_STANDARD format is requested
MFC after: 1 week
|
107788 |
12-Dec-2002 |
ru |
Uniformly refer to a file system as "file system".
Approved by: re
|
99968 |
14-Jul-2002 |
charnier |
The .Nm utility
|
99806 |
11-Jul-2002 |
alfred |
de-__P()
|
99108 |
30-Jun-2002 |
dd |
Lists follow a colon, not a semicolon.
|
98854 |
26-Jun-2002 |
sada |
`pw useradd' could be used with -w without -D option.
PR: docs/39770 Submitted by: sada Approved by: dd
|
98744 |
24-Jun-2002 |
dwmalone |
Print a long with %ld not %d. (We possibly should be using %j here, but that can be fixed when the many other warnings here are being fixed.)
PR: 39741 Submitted by: Dan Lukes <dan@obluda.cz> MFC after: 1 week
|
93866 |
05-Apr-2002 |
dd |
In the words of the submitter:
This patch explains -F for usershow and groupshow. Because "groupmod ... -F" doesn't do anything, the patch also drops that from groupmod's command line args.
PR: 35955 Submitted by: Mike DeGraw-Bertsch <mbertsch@radioactivedata.org>
|
93865 |
05-Apr-2002 |
dd |
Document the -7 option for usershow.
PR: 36735 Submitted by: Mike DeGraw-Bertsch <mbertsch@radioactivedata.org>
|
91841 |
08-Mar-2002 |
keramida |
Merge a duplicate description of the -L option into the first one.
PR: docs/34782 MFC after: 1 week
|
88280 |
20-Dec-2001 |
nectar |
Use correct mode for temporary file.
Reported by: ryan beasley <ryanb@goddamnbastard.org>
|
85145 |
19-Oct-2001 |
ache |
Change rmskey() to rmopie() - we don't have skey anymore
|
82868 |
03-Sep-2001 |
dd |
For new users, create the home directory before sending the welcome mail, if configured to do so. Some sites have setups where the user's mail is delivered to their home directory, so sending mail before is exists didn't work.
PR: 29892
|
82551 |
30-Aug-2001 |
dd |
Unbreak group operations by reverting previous delta which removed the assignment of `l' in `gr_update' to the return value of snprintf. It claimed to have fixed the case where snprintf returned -1--in fact, it broke the entire routine. Not setting `l' here causes fileupdate() to invariably fail with EINVAL because it does its own check to assert that the parameter isn't -1.
|
82059 |
21-Aug-2001 |
joerg |
Properly initialize the random number generator in pw_getpass(). Right now, the automatically generated passwords have been rather predictable. :-(
MFC after: 1 day
|
82047 |
21-Aug-2001 |
joerg |
Fix a typo in a variable name that made pw(8) coredump when using USE_MD5RAND.
MFC after: 2 days
|
81982 |
20-Aug-2001 |
brian |
Handle snprintf() returning < 0 (not just -1)
MFC after: 2 weeks
|
81977 |
20-Aug-2001 |
brian |
Handle snprintf() returning -1.
MFC after: 2 weeks
|
80029 |
20-Jul-2001 |
obrien |
Perform a major cleanup of the usr.sbin Makefiles. These are not perfectly in agreement with each other style-wise, but they are orders of orders of magnitude more consistent style-wise than before.
|
80022 |
20-Jul-2001 |
obrien |
Remove GCC'isms in CFLAGS.
|
79755 |
15-Jul-2001 |
dd |
Remove whitespace at EOL.
|
79454 |
09-Jul-2001 |
dd |
mdoc(7) police: remove extraneous .Pp before and/or after .Sh.
|
79452 |
09-Jul-2001 |
brian |
Fix the type of the NULL arg to execl()
Idea from: Theo de Raadt <deraadt@openbsd.org>
|
79328 |
05-Jul-2001 |
ru |
Don't override the default BINMODE.
Submitted by: bde
|
79292 |
05-Jul-2001 |
kris |
Fix a harmless format string bogon and mark a function as __printflike(). There is still one instance of non-constant format string use inside that function, but it's hard to fix.
MFC after: 1 week
|
78720 |
24-Jun-2001 |
dd |
Include missing header files which define functions for which gcc has builtints (e.g., exit, strcmp).
|
78451 |
19-Jun-2001 |
dd |
CND has been unused for two years, and RND has been unused for five years; remove them from CFLAGS.
PR: 23712 Submitted by: Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
|
74816 |
26-Mar-2001 |
ru |
- Backout botched attempt to introduce MANSECT feature. - MAN[1-9] -> MAN.
|
74569 |
21-Mar-2001 |
ache |
Use %c for expire/change dates
|
74351 |
16-Mar-2001 |
ru |
mdoc(7) police: simplify bogus ``.Ql Fl'' constructs.
|
74226 |
14-Mar-2001 |
dd |
Document the lock and unlock commands. This fixes a segmentation fault.
PR: 25187 Approved by: nik
|
74224 |
14-Mar-2001 |
dd |
Document the lock and unlock commands.
PR: 25187 Approved by: nik
|
73563 |
05-Mar-2001 |
kris |
Switch from using rand() or random() to a stronger, more appropriate PRNG (random() or arc4random())
Reviewed by: bde
|
71898 |
01-Feb-2001 |
ru |
mdoc(7) police: split punctuation characters + misc fixes.
|
71102 |
16-Jan-2001 |
ru |
Prepare for mdoc(7)NG.
|
70588 |
02-Jan-2001 |
peter |
Fix typo: s/memberhip/membership/
Submitted by: Peter Avalos <pavalos@theshell.com>
|
70486 |
29-Dec-2000 |
ben |
Convert to use the <sys/queue.h> macros rather than fiddling with the queue structure internals.
Reviewed by: markm
|
70133 |
18-Dec-2000 |
dougb |
Make the comment generated in /etc/pw.conf match reality
PR: misc/23451 Submitted by: Ben Rosengart, ben@narcissus.net
|
69793 |
09-Dec-2000 |
obrien |
Add `_PATH_DEVZERO'. Use _PATH_* where where possible.
|
68965 |
20-Nov-2000 |
ru |
mdoc(7) police: use the new features of the Nm macro.
|
64918 |
22-Aug-2000 |
green |
Add working and easy crypt(3)-switching. Yes, we need a whole new API for crypt(3) by now. In any case:
Add crypt_set_format(3) + documentation to -lcrypt. Add login_setcryptfmt(3) + documentation to -lutil. Support for switching crypt formats in passwd(8). Support for switching crypt formats in pw(8).
The simple synopsis is: edit login.conf; add a passwd_format field set to "des" or "md5"; go nuts :)
Reviewed by: peter
|
63600 |
20-Jul-2000 |
davidn |
Move test for -w flag outside of the code dealing with -D (defaults). This should cause -w's argument not to be ignored in the usermod case, so it will affect modification of the user's password instead of using the pw.conf (or internal default=no '*') password method. PR: bin/11168
|
63596 |
20-Jul-2000 |
davidn |
Allow -g with an empty argument in the -D case. This allows -g "" to set no default group (and thus fall back to user-based groups instead). PR: bin/5717
|
63572 |
20-Jul-2000 |
davidn |
Fix another missed case where usermod would not set the "modified" flag: -h - to set no password. But only mark modified if the account is not already locked (i.e. first char of crypt password field is '*'). PR: bin/19999
|
63239 |
16-Jul-2000 |
davidn |
Catch up to the fact that we now have tcsh in the tree.
|
63094 |
13-Jul-2000 |
davidn |
Support propogation of file flags when building a homedir from the skeleton directory. sprintf() -> snprintf() cleanup. PR: bin/8756 Submitted by: "Nickolay N. Dudorov" <nnd@itfs.nsk.su>
|
62461 |
03-Jul-2000 |
davidn |
Fix breakage introduced by bypassing update for additional 'mod' functionality when nothing had actually changed; -d changes would not set the 'something had changed flag'. Actually test for a change in homedir. PR: bin/19649
|
62097 |
26-Jun-2000 |
davidn |
Don't dereference NULL in the userdel case.
|
62034 |
24-Jun-2000 |
ache |
Localize ctype too. Add weekday to showuser expired fields
|
61957 |
22-Jun-2000 |
ache |
Localize time/date. Use ISO 8601 date in logs. Fix wrong argument type in ctype functions.
|
61762 |
18-Jun-2000 |
davidn |
Fix obvious braino in assignment statement. usermod -g should work again. PR: 17877 Submitted by: pius@zyan.com
|
61760 |
18-Jun-2000 |
davidn |
Be a little more strict about handling command line args. This allows user and group names like 'help' 'mod' 'user' 'group' etc. to work correctly without requiring the -n style invocation. PR: misc/17069
|
61759 |
18-Jun-2000 |
davidn |
Fix a long-standing bug in the rename case previously masked by another bug just fixed in .db file updating.
|
61758 |
18-Jun-2000 |
davidn |
Second and hopefully final fix to .db sync when renaming a user; we must run a full reindex in this case to remove the old record. #ifdef -u capability since this is available on FreeBSD only. PR: bin/16418 Problem pointed out by: Masachika ISHIZUKA <ishizuka@ish.org>
|
61326 |
06-Jun-2000 |
davidn |
Fix db syncronization when username is changed with -l under usermod. pw(8) was calling pwd_mkdb -u oldusername instead of newusername, so the update appears to have failed until the next full pwd_mkdb syncronization.
PR: bin/16418
|
60938 |
26-May-2000 |
jake |
Back out the previous change to the queue(3) interface. It was not discussed and should probably not happen.
Requested by: msmith and others
|
60833 |
23-May-2000 |
jake |
Change the way that the queue(3) structures are declared; don't assume that the type argument to *_HEAD and *_ENTRY is a struct.
Suggested by: phk Reviewed by: phk Approved by: mdodd
|
57695 |
02-Mar-2000 |
sheldonh |
Remove more single-space hard sentence breaks.
|
57673 |
01-Mar-2000 |
sheldonh |
Remove single-space hard sentence breaks. These degrade the quality of the typeset output, tend to make diffs harder to read and provide bad examples for new-comers to mdoc.
|
56000 |
15-Jan-2000 |
davidn |
Portability fixes for other bsd4.4 derivatives.
|
54782 |
18-Dec-1999 |
peter |
Revert the libcrypt/libmd stuff back to how it was. This should not have happened as it was working around problems elsewhere (ie: binutils/ld not doing the right thing according to the ELF design). libcrypt has been adjusted to not need the runtime -lmd. It's still not quite right (ld is supposed to work damnit) but at least it doesn't impact all the users of libcrypt in Marcel's cross-build model.
|
54677 |
16-Dec-1999 |
marcel |
Add libmd (or move it after libcrypt). We don't want the linker to be smart because it will definitely get it wrong. This popped up during cross-linking.
|
52527 |
26-Oct-1999 |
davidn |
Don't try updating the passwd file if no data has changed. This allows things like "pw usermod <name> -m" to work for non-local NIS users; since no attempt is made to update the password entry, the home directory will be created and populated as expected without error.
|
52512 |
26-Oct-1999 |
davidn |
Add new functionality "lock" and "unlock" to provide a simple password locking mechanism for users. This works by prepending the string "*LOCKED*" to the password field in master.passwd to prevent successful decoding.
|
52511 |
26-Oct-1999 |
davidn |
Missed statement in password update relating to the previous change to fileupdate() which prevented pwd_mkdb(1) from being run.
|
52502 |
26-Oct-1999 |
davidn |
Clean up error handling in fileupdate(), which now returns 0 on success instead of a boolean. This replicated through he front-end sub-functions relating to add, delete, modify entries in passwd & group files Errno is now preserved so output of errc()/warnc() will be less obfuscated by subsequent errors when reporting the problem.
Add more intelligent error handling when attempting to modify/delete NIS entries with no corresponding local database entry.
[MFC to stable in a couple of weeks to keep both in sync]
|
50653 |
30-Aug-1999 |
sheldonh |
Only do a full pwd_mkdb for deletions; other operations may use the -u option as an optimization.
PR: 13346 Submitted by: Neil Blakey-Milner <nbm@rucus.ru.ac.za>
|
50479 |
28-Aug-1999 |
peter |
$Id$ -> $FreeBSD$
|
49171 |
28-Jul-1999 |
davidn |
Remove some more warnings.
|
44775 |
15-Mar-1999 |
davidn |
Fix date parsing to allow '0' (none) date value.
|
44386 |
02-Mar-1999 |
davidn |
Add the ability to print user records in unix version 7 (old) format.
|
44232 |
23-Feb-1999 |
davidn |
Fix minor nit with command line parsing for pw -V DIR action.
|
44231 |
23-Feb-1999 |
davidn |
Fix tpyo (sic) and missing 'else' (bad cut n' paste).
|
44229 |
23-Feb-1999 |
davidn |
1) Do not blindly ignore file update errors which may occur due to concurrent updating 2) Add -V <etcdir>, which allows maintaining user/group database in alternate locations other than /etc.
|
43780 |
08-Feb-1999 |
des |
Don't assume a_name is a number just because the first character is a digit.
PR: bin/9484 Submitted by: Matthew D. Fuller <fullermd@futuresouth.com>
|
42394 |
08-Jan-1999 |
davidn |
Remove bogus file locking in main().
|
42287 |
04-Jan-1999 |
billf |
-Clarification of last commit- The char that the random letters and numbers are being pulled from is ended with a '\0'. Using sizeof() includes this '\0' in the 'pool' of possible characters. This patch decrements by one the size so we don't accidently end the new password prematurly.
|
42245 |
02-Jan-1999 |
billf |
Let's make sure we're at the end of the password string before we apply a \0 and terminate it. This patch ensures passwords will be the correct length of 8, which is what is implied in the source (but not reflected in the man page).
PR: bin/7817 Reviewed by: Alfred Perlstein <bright@hotjobs.com> Submitted by: Hiroshi Nishikawa <nis@pluto.dti.ne.jp>
|
42074 |
27-Dec-1998 |
joerg |
Fix the spelling of `FreeBSD'.
Submitted by: Peter Philipp <pjp@bsd-daemon.net>
|
39496 |
19-Sep-1998 |
obrien |
Remove useless `BINOWN=root' now that it is the default.
|
39454 |
18-Sep-1998 |
jkoshy |
Fix inappropriate use of .Ql macro.
PR: docs/7905 Submitted by: kuma@jp.freebsd.org
|
38671 |
31-Aug-1998 |
jkoshy |
The `group{del,mod,show}' take require a '[group|gid]' argument.
PR: docs/7788
|
38112 |
04-Aug-1998 |
nate |
- On second thought, attempt to get the read-only lock, but don't consider it a exit failure if it doesn't work. This means that root processes can safely get the lock, but normal processes can still use the 'pw' utility to get information (which may change out from under them.)
|
38110 |
04-Aug-1998 |
nate |
- Removed read-only lock from 'pw'. This removes portions of the FIX from PR/6787, but allow non-root users to use pw to get password information. However, this should be safe since the fixes for disallowing multiple instances from modifying the DB are still intact.
Bug noted by: dima@best.net (Dima Ruban)
|
37711 |
16-Jul-1998 |
nate |
Fix race condition in pw caused by multiple instances of pwd_mkdb being run at the same time.
Notes: The fileupdate function is still somewhat broken. Instead of returning a failure code if it can't modify the original file it renames the .new file and continues as though nothing is wrong. This will cause the lock on the original file to be lost and could lead to a similar race condition. I left that portion of the code alone since I feel that the maintainer of the code would have a better concept of how he wants to handle errors in that function than I do.
PR: bin/6787 Submitted by: Craig Spannring <cts@internetcds.com>
|
34808 |
23-Mar-1998 |
charnier |
.Nm pw -> .Nm.
|
33354 |
14-Feb-1998 |
steve |
Overhaul this manpage - removing typos, awkward phrasing, and addressing a few technical faults.
PR: 5692 Submitted by: dannyman@arh0300.urh.uiuc.edu
|
33259 |
11-Feb-1998 |
wosch |
pwd_mkdb option '-c' was renamed to -C some weeks ago.
PR: bin/5715 Submitted by: dannyman <dannyman@arh0300.urh.uiuc.edu>
|
31989 |
25-Dec-1997 |
hoek |
Use consistent spelling, writeable -> writable (recall prior debate over this? :-) initialise -> initialize recognise -> recognize
Merry Christmas! :)
|
30259 |
10-Oct-1997 |
charnier |
Use err(3) instead of local redefinition. Add rcsid string.
|
29002 |
01-Sep-1997 |
davidn |
Unquote default group in pw.conf. PR: 4365 Submitted by: "Andrew L. Moore" <alm@mclink.com>
|
27831 |
01-Aug-1997 |
davidn |
Fix -p switch.
|
27474 |
17-Jul-1997 |
davidn |
getuid() -> geteuid().
|
26626 |
14-Jun-1997 |
ache |
Remove srandomdev fallback code
|
26088 |
24-May-1997 |
davidn |
Fixes skeleton directory test-it-is-a-directory logic. PR: 3666 Reviewed by: Submitted by: iaint@css.tuu.utas.edu.au Obtained from:
|
24214 |
24-Mar-1997 |
ache |
Initialize RNG only once Use srandomdev() now
|
23700 |
11-Mar-1997 |
ache |
Fix srandom arg according to Lite2
|
23374 |
04-Mar-1997 |
danny |
Typo fix 'and' -> 'an'.
This is a 2.2 candidate.
|
23318 |
03-Mar-1997 |
ache |
Back out MAXLOGNAME fix, Bruce points that copyinstr require NUL
|
23299 |
02-Mar-1997 |
ache |
Fix MAXLOGNAME usage, the code has wrong assumption that it must be NUL terminated
|
22997 |
22-Feb-1997 |
peter |
Revert $FreeBSD$ to $Id$
|
22398 |
07-Feb-1997 |
davidn |
Yet another formatting consistency check.
|
22394 |
07-Feb-1997 |
davidn |
Fix useage of MAXLOGNAME to include terminating NUL, by using max(MAXLOGNAME-1,UT_NAMESIZE). Tidy up "pretty" printing format for longer usernames.
|
21880 |
20-Jan-1997 |
wosch |
Sort cross references.
|
21673 |
14-Jan-1997 |
jkh |
Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!) avoiding the Id-smashing problem which has plagued developers for so long.
Boy, I'm glad we're not using sup anymore. This update would have been insane otherwise.
|
21330 |
05-Jan-1997 |
davidn |
Adds optional NIS passwd file updating and optionally rebuilding NIS maps.
Suggested by: Peter Wemm
|
21319 |
05-Jan-1997 |
davidn |
Remove duplicated #include.
|
21317 |
05-Jan-1997 |
davidn |
Fix reference /etc/acct/pw.conf -> /etc/pw.conf.
Pointed-Out-By: Peter Wemm.
|
21242 |
03-Jan-1997 |
davidn |
Implemented /home -> /usr/home symlink kludge. If home basedir would be created in the root partition, create it under /usr instead, and symlink /basedir -> /usr/basedir.
|
21052 |
30-Dec-1996 |
davidn |
1) Base home directory is created if it does not already exist if useradd -m or useradd -D -b are used. 2) Hyphen allowed in username if not first character. Fix trivial bug in error fmt string. 3) /etc/skeykeys updating changed to do 'inplace' update, commenting out a username rather than removing it completely.
|
20842 |
23-Dec-1996 |
davidn |
Correct file modes on updated /etc/skeykeys.
|
20747 |
21-Dec-1996 |
davidn |
1) 200 users per group limitation removed and pw will handle lines of any length in /etc/group. 2) Fixed bug with usermod -d not updating user's home directory. 3) Minor formatting display changes/fixes with *show -P.
|
20712 |
20-Dec-1996 |
davidn |
Bugfix (cosmetic) for output of generated passwords.
|
20679 |
19-Dec-1996 |
davidn |
Allow 8-bit characters in the passwd gecos field, and adds a paragraph to the mangpage explaining the consequences (to be updated at a later date after login class conf support is added).
|
20590 |
17-Dec-1996 |
davidn |
Changes to password generator: fallback to MD5 generator disabled (/dev/urandom used by default under FreeBSD), and implemented a "portable" but less secure generator for other systems. Add display of expiry/password change dates in -P user display.
|
20576 |
17-Dec-1996 |
davidn |
Submitted by: proff@iq.org Minor fix for security patch.
|
20555 |
16-Dec-1996 |
davidn |
Reviewed by: davidn@blaze.net.au Submitted by: proff@iq.org Security patch for better random password generation.
|
20325 |
11-Dec-1996 |
joerg |
Update from David, reflecting Wolfram's wishes regarding limitation of the allowable character set.
Submitted by: David Nugent
|
20305 |
11-Dec-1996 |
joerg |
Merg-o-matic.
|
20303 |
10-Dec-1996 |
joerg |
This commit was generated by cvs2svn to compensate for changes in r20302, which included commits to RCS files with non-trunk default branches.
|
20269 |
10-Dec-1996 |
joerg |
Merge from the vendor-branch.
|
20268 |
09-Dec-1996 |
joerg |
This commit was generated by cvs2svn to compensate for changes in r20267, which included commits to RCS files with non-trunk default branches.
|
20265 |
09-Dec-1996 |
mpp |
Minor spelling/mdoc/style fixes.
|
20254 |
09-Dec-1996 |
joerg |
This commit was generated by cvs2svn to compensate for changes in r20253, which included commits to RCS files with non-trunk default branches.
|