MFC r360329:
Properly update AD field length in hccontrol(8).

While at it use strtol() instead of atoi() to support hexadecimal
numbers aswell as 10-base numbers.

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245899
Sponsored by: Mellanox Technologies

MFC r360288:
Put advertising data in correct place.

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245848
Sponsored by: Mellanox Technologies

MFC r360263:
Rename two commands to match the Bluetooth specification in hccontrol(8).
Fix some bad spelling while at it.

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245868
Sponsored by: Mellanox Technologies

MFC r360243:
Add support for LE advertising to hccontrol(8).

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245848
Sponsored by: Mellanox Technologies

MFC r360197:
Add support for Read_Local_Supported_Commands command to hccontrol(8).

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245811
Sponsored by: Mellanox Technologies

MFC r360172:
Update string tables in hccontrol(8).

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245796
Sponsored by: Mellanox Technologies

MFC r360116:
Substitute le_read_supported_status with le_read_supported_states.
Refer to bluetooth core v5.2 specifications Vol4. Part E. 7.8.27.

PR: 245763
Submitted by: Marc Veldman <marc@bumblingdork.com>
Sponsored by: Mellanox Technologies

MFC r360095:
Fix cut and paste off-by-one error in hccontrol(8).
Make sure strncpy() doesn't write beyond its given buffer.

PR: 245739
Sponsored by: Mellanox Technologies

MFC r360094:
Improve printing of le features in hccontrol(8).

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245739
Sponsored by: Mellanox Technologies

MFC r360092:
Bring HCI error messages up-to-date.
See Bluetooth v5.6 core specification Vol.1 Part F: Controller error codes.

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245737
Sponsored by: Mellanox Technologies

MFC r360070:
Add missing feature descriptions to hci_features2str().

The list of possible features in hccontrol/features2str() is incomplete.
Refer to "Bluetooth Core Specification 5.2 Vol. 2 Part C. 3.3 Feature Mask Definition".

Submitted by: Marc Veldman <marc@bumblingdork.com>
PR: 245354
Sponsored by: Mellanox Technologies

MFC r359449: correct 'disble' typo in hccontrol

PR: 245125
Submitted by: Marc Veldman

MFC r343905:
Improve Bluetooth device discovery support for Android and Microsoft devices.

Tested using the virtual_bt_speaker(8) tool from the virtual_oss(8)
project at github.com.

PR: 210089
Sponsored by: Mellanox Technologies

MFC r343572:
Add support for Audio Sink and Audio Source profiles to sdpd(8).

This allows user-space programs like virtual_oss(8) to act
as a Bluetooth speaker device.

Sponsored by: Mellanox Technologies

MFC r326276:

various: general adoption of SPDX licensing ID tags.

Mainly focus on files that use BSD 2-Clause license, however the tool I
was using misidentified many licenses so this was mostly a manual - error
prone - task.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

No functional change intended.

MFC: r324770
bthidd: Fix leds on multireport keyboards broken after r297217

Reviewed by: emax, gonzo
Approved by: gonzo (mentor)
Differential Revision: https://reviews.freebsd.org/D12214

MFC r322124:
rfcomm_pppd.8: fix a typo (SPD -> SDP).

MFC r314659,r314676:

r314659:

usr.sbin: normalize paths using SRCTOP-relative paths or :H when possible

This simplifies make logic/output

r314676:

Fix build after r314656

Some of the changes I introduced to use .ALLSRC were correct in spirit,
but incorrect in reality -- in particular, ../Makefile.inc hadn't been
pulled in via bsd.init.mk (via bsd.lib.mk, bsd.prog.mk), so the value
of .ALLSRC (evaluated immediately) was empty. .include bsd.init.mk
explicitly so we can be certain that the values used as dependencies in
the targets are defined when the target recipe has been evaluated.

Reminder: thou shalt separate out separate functional changes before
committing them.

(YUGE) Pointyhat to: ngie
In collaboration with: bdrewery

MFC r305023:

Avoid undefined behavior when calling va_start() in bnep_send_control(),
by making the 'type' parameter a plain unsigned.

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

[ath3k] add a replacement ath3k firmware loading tool.

This is influenced by the ath3k driver from linux (circa 2013, this is
how long I've been sitting on this.)

It handles loading in firmware using the newer model, where it assembles
the right set of firmware blobs and board configuration based on the
device list and querying the device.

The older utility could only load in a single image - which sometimes
was ath3k-1.fw and sometimes was ath3k-2.fw. However, the ath3k maintainers
didn't want to keep adding in binaries that were just derivatives with a
separate board config, so they deleted ath3k-2.fw from the Linux firmware
repository and instead, well, did this.

Now, this has been tested against AR3011 and AR3012 NICs from the AR9285+BT
combo up through to the QCA9565+BT combo. It doesn't yet work with the
QCAFN222 NIC as that is some newer chip.

The firmware can be grabbed from https://github.com/erikarn/ath3kfw/ in
the share/firmware/ath3k directory. I'll update this utility over time
to support the newer firmware drops (newer than mid-2013) which should
pull in the QCNFA222 and subsequent chips.

Tested:

* AR9285 + BT
* AR9287 + BT
* AR9485 + BT
* AR9462 + BT
* QCA9565 + BT

For pointers use NULL instead of 0.

Improve performance and functionality of the bitstring(3) api

Two new functions are provided, bit_ffs_at() and bit_ffc_at(), which allow
for efficient searching of set or cleared bits starting from any bit offset
within the bit string.

Performance is improved by operating on longs instead of bytes and using
ffsl() for searches within a long. ffsl() is a compiler builtin in both
clang and gcc for most architectures, converting what was a brute force
while loop search into a couple of instructions.

All of the bitstring(3) API continues to be contained in the header file.
Some of the functions are large enough that perhaps they should be uninlined
and moved to a library, but that is beyond the scope of this commit.

sys/sys/bitstring.h:
Convert the majority of the existing bit string implementation from
macros to inline functions.

Properly protect the implementation from inadvertant macro expansion
when included in a user's program by prefixing all private
macros/functions and local variables with '_'.

Add bit_ffs_at() and bit_ffc_at(). Implement bit_ffs() and
bit_ffc() in terms of their "at" counterparts.

Provide a kernel implementation of bit_alloc(), making the full API
usable in the kernel.

Improve code documenation.

share/man/man3/bitstring.3:
Add pre-exisiting API bit_ffc() to the synopsis.

Document new APIs.

Document the initialization state of the bit strings
allocated/declared by bit_alloc() and bit_decl().

Correct documentation for bitstr_size(). The original code comments
indicate the size is in bytes, not "elements of bitstr_t". The new
implementation follows this lead. Only hastd assumed "elements"
rather than bytes and it has been corrected.

etc/mtree/BSD.tests.dist:
tests/sys/Makefile:
tests/sys/sys/Makefile:
tests/sys/sys/bitstring.c:
Add tests for all existing and new functionality.

include/bitstring.h
Include all headers needed by sys/bitstring.h

lib/libbluetooth/bluetooth.h:
usr.sbin/bluetooth/hccontrol/le.c:
Include bitstring.h instead of sys/bitstring.h.

sbin/hastd/activemap.c:
Correct usage of bitstr_size().

sys/dev/xen/blkback/blkback.c
Use new bit_alloc.

sys/kern/subr_unit.c:
Remove hard-coded assumption that sizeof(bitstr_t) is 1. Get rid of
unrb.busy, which caches the number of bits set in unrb.map. When
INVARIANTS are disabled, nothing needs to know that information.
callapse_unr can be adapted to use bit_ffs and bit_ffc instead.
Eliminating unrb.busy saves memory, simplifies the code, and
provides a slight speedup when INVARIANTS are disabled.

sys/net/flowtable.c:
Use the new kernel implementation of bit-alloc, instead of hacking
the old libc-dependent macro.

sys/sys/param.h
Update __FreeBSD_version to indicate availability of new API

Submitted by: gibbs, asomers
Reviewed by: gibbs, ngie
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D6004

bluetooth: minor spelling fixes.

User-visible strings.

MFC after: 2 weeks

fix incorrect usage of hid_set_data() which causes crash
in bthidd(8) on amd64 WITH_SSP builds

Submitted by: rakuco
Reviewed by: rakuco
Tested by: rakuco
MFC after: 1 week

DIRDEPS_BUILD: Regenerate without local dependencies.

These are no longer needed after the recent 'beforebuild: depend' changes
and hooking DIRDEPS_BUILD into a subset of FAST_DEPEND which supports
skipping 'make depend'.

Sponsored by: EMC / Isilon Storage Division

Fix scancodes for Kana and Eisu keys.

PR: 204709
Submitted by: naito.yuichiro@gmail.com
MFC after: 3 days

check boundaries while parsing SDP responses

Reported by: hps
Reviewed by: hps
MFC after: 1 week

fix compare argument for address type.

Submitted by: issei10193 (via Twitter)

Add META_MODE support.

Off by default, build behaves normally.
WITH_META_MODE we get auto objdir creation, the ability to
start build from anywhere in the tree.

Still need to add real targets under targets/ to build packages.

Differential Revision: D2796
Reviewed by: brooks imp

Remove stray DEBUG_FLAGS=-g that snuck in with r137868

ath3kfw, bcmfw, bthidcontrol, bthidd all require usb(4); build them
conditionally if MK_USB != no

MFC after: 1 week

To ensure j formatting string valid, cast uint64_t values to uintmax_t.

Change printf formatting to unbroke i386 arch.

Submitted by:david@catwhisker.org

Fix Typo.

Fix misspelling.

Improve code style(9), no functional changes.

Differential Revision: D2320
Reviewed by: takawata

Add LE related HCI control command to hccontrol(1).

Accept LE event on hccontrol socket.

Add HCI/LMP revision information.

Check l2cap socket initialisation and define L2CAP_SOCKET_CHECKED
This will fix build.

bthidd: Remove unused macros from hid.c.

ASIZE() was never used, and min() stopped being used in r207812.

Differential Revision: https://reviews.freebsd.org/D2230
Reviewed by: emax
Approved by: emax
MFC after: 1 week

bthidd: Consider usage ranges when dealing with array inputs.

So far, we were always using HID_USAGE() to determine the Usage ID of a
certain HID report input item. This does not work as intended if a field
is an array and the allowed usages are specified with a usage range, as
HID_USAGE() will return 0. We need to use the field value as an index in
the usage range list in this case instead.

This makes the volume keys in a Microsoft Bluetooth Mobile Keyboard
5000 be properly recognized. The relevant part of the HID report looks
like this:

0xA1, 0x01, // Collection (Application)
0x85, 0x07, // Report ID (7)
0x05, 0x0C, // Usage Page (Consumer)
0x19, 0x00, // Usage Minimum (Unassigned)
0x2A, 0xFF, 0x03, // Usage Maximum (0x03FF)
0x95, 0x01, // Report Count (1)
0x75, 0x10, // Report Size (16)
0x15, 0x00, // Logical Minimum (0)
0x27, 0xFF, 0x03, 0x00, 0x00, // Logical Maximum (1023)
0x81, 0x00, // Input (Data,Array,Abs,No Wrap,Linear,Preferred
// State,No Null Position)

When a key such as "volume down" is pressed, the following data is
transferred through Interrupt In:

0x07 0xEA 0x00

Differential Revision: https://reviews.freebsd.org/D2229
Reviewed by: emax
Approved by: emax
MFC after: 1 week

Make hccontrol(8) and sdpcontrol(8) appear in "man -k bluetooth" output.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation

mdoc: sort SEE ALSO.

handle "Kana" and "Eisu" keys on Apple Wireless Keyboard (JIS)

PR: 187470
Submitted by: naito.yuichiro
MFC after: 1 week

Convert usr.sbin to LIBADD
Reduce overlinking

use .Mt to mark up email addresses consistently (part2)

PR: 191174
Submitted by: Franco Fichtner <franco@lastsummer.de>

mdoc: minor paragraph fixes.

Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this
shifts into the sign bit. Instead use (1U << 31) which gets the
expected result.

This fix is not ideal as it assumes a 32 bit int, but does fix the issue
for most cases.

A similar change was made in OpenBSD.

Discussed with: -arch, rdivacky
Reviewed by: cperciva

Work around build breakages with GCC 4.2.

Reported by: tinderbox

Fxi a bunch of typos.

PR: misc/174625
Submitted by: Jeremy Chadwick <jdc@koitsu.org>

Add the Clang specific -Wmissing-variable-declarations to WARNS=6.

This compiler flag enforces that that people either mark variables
static or use an external declarations for the variable, similar to how
-Wmissing-prototypes works for functions.

Due to the fact that Yacc/Lex generate code that cannot trivially be
changed to not warn because of this (lots of yy* variables), add a
NO_WMISSING_VARIABLE_DECLARATIONS that can be used to turn off this
specific compiler warning.

Announced on: toolchain@

Remove contractions.

Extend ath3kfw to include overridable device / vendor IDs.

This is required for ar3k series bluetooth devices who need firmware
but have a different vendor ID than normal.

Reviewed by: maksim

A number of places in the source tree still reference cuad.* after
sio(4) was deprecated by uart(4).

s/cuad/cuau/g/

PR: docs/171533
Reviewed by: imp
Approved by: cperciva (implicit)
MFC after: 3 weeks

make sure that socket's send and receive buffers are properly sized

Submitted by: Iain Hibbert plunky at rya-online dot net
MFC after: 3 weeks

mdoc: add missing width argument to Bl -tag.

Fix world after byacc import:
- old yacc(1) use to magicially append stdlib.h, while new one don't
- new yacc(1) do declare yyparse by itself, fix redundant declaration of
'yyparse'

Approved by: des (mentor)

Remove trailing whitespace per mdoc lint warning

Disussed with: gavin
No objection from: doc
Approved by: joel
MFC after: 3 days

Fix date.

Touch up some more small typos missed in the previous round.

Reported by: Ben Kaduk <minimarmot@gmail.com> et al.

Fix typos in command descriptions.

Spelling fixes for usr.sbin/

Reencode files to UTF-8. Drop CP1252 em-dash.

In usr.sbin/bluetooth/sdpd/server.c, don't use the size of a pointer as
the length argument to memset, but the size of the object pointed to.

MFC after: 1 week

Plug fd leaks

Remove redundant assignments to WARNS.

For these directories, WARNS is already implied to be 6.

Encode horizontal scroll events (AC Pan) as button presses (bit 5 and 6)

Submitted by: David Demelier demelier dot david at gmail dot com
MFC after: 1 week

Improve the man page and l2control's usage() a bit.

Submitted by: arundel
MFC after: 1 week

Do not use word 'flood' as it not entirely correct. Use better 'no delay'
description. While here, replace atoi(3) with strtol(3).

Submitted by: arundel
MFC after: 1 week

Don't generate input() since it's not used.

Add firmware downloader for Atheros AR3011 based USB Bluetooth devices.

Hardware donated by: Rusty Nejdl rnejdl at ringofsaturn dot com
Tested by: Rusty Nejdl rnejdl at ringofsaturn dot com
Tested by: Andrzej Tobola ato at iem dot pw dot edu dot pl
MFC after: 3 weeks

Make sure to only pickup hid_input items when parsing input reports.
As it turns out, libusbhid(3) also picks up hic_collection items even
though we explicitly requested hid_input items only.

Tested by: Buganini < buganini at gmail dot com >
MFC after: 1 week

Do not request SDP attributes using ranges.
Apparently some devices do not like it.

MFC after: 1 week
Tested by: Buganini < buganini at gmail dot com >

mdoc: move remaining sections into consistent order

This pertains mostly to FILES, HISTORY, EXIT STATUS and AUTHORS sections.

Found by: mdocml lint run
Reviewed by: ru

mdoc: move CAVEATS, BUGS and SECURITY CONSIDERATIONS sections to the
bottom of the manpages and order them consistently.

GNU groff doesn't care about the ordering, and doesn't even mention
CAVEATS and SECURITY CONSIDERATIONS as common sections and where to put
them.

Found by: mdocml lint run
Reviewed by: ru

Catch up with libusbhid merge (rev 205728).

hid_get_data() now expects that the hid data passed in always contains
the report ID byte. Thus we should not skip the the report ID byte in
hid_interrupt(). Also, if HUP_KEYBOARD usage is an array, do not try
to modify the 'data' pointer, instead, increase the hid_item_t field
'pos' by 'report_size' before calling hid_get_data() during each
iteration.

PR: usb/146367
Reported and tested by: Alex Deiter
Pointy hat to: kaiw
Reviewed by: emax

Remove redundant WARNS?=6 overrides and inherit the WARNS setting from
the toplevel directory.

This does not change any WARNS level and survives a make universe.

Approved by: ed (co-mentor)

Teach btpand(8) to recognized Bluetooth device node names.

Tested by: Daniel O'Connor <doconnor -at- gsoft -dot- com -dot- au>
MFC after: 3 days

Fix bug in event timeout handling

Submitted by: mav
MFC after: 3 days

Build fixups for the new USB stack.

Clenup code a bit and do not call fork(2) before dameon(3) where not needed.

MFC after: 1 month

Hook up btpand(8) to the build

MFC after: 1 month

Fix client mode. Pick up service availability changes.

Obtained from: NetBSD
MFC after: 1 month

Add btpand(8) daemon from NetBSD. This daemon provides support for
Bluetooth Network Access Point (NAP), Group Ad-hoc Network (GN) and
Personal Area Network User (PANU) profiles.

Obtained from: NetBSD
MFC after: 1 month

Straighten out those pesky SDP records for the Bluetooth
Service Discovery Application Profile.

Discussed with: Iain Hibbert of NetBSD plunky at rya dash online dot net
MFC after: 3 weeks

Add mandatory "security description" SDP parameter to the PANU profile

Pointed-out by: Iain Hibbert < plunky at rya-online dot net >
MFC after: 3 days

Add PSM and Load Factor SDP parameters to the BNEP based profiles
(NAP, GN and PANU). No reason to not to support them.

Separate SDP parameters data structures for the BNEP based profiles.

Generalize Service Availability SDP parameter creation.

Requested by: Iain Hibbert < plunky at rya-online dot net >
MFC after: 3 days

Update usage() - add new -D option. While I'm here, update copyright
information and license formatting

MFC after: 1 day

Add support for the NAP, GN and PANU profiles to the sdpd(8).
It should be mentioned that a somewhat similar patch was
submitted by Rako < rako29 at gmail dot com >

MFC after: 1 week

Add an option to register DUN (Dial-Up Networking) service on the same
RFCOMM channel if needed. There is really no good reason to not to support
this. AT-command exchange can be faked with chat script in ppp.conf.

MFC after: 1 week

Allow search for any UUID entered by user.

MFC after: 3 days

Fixed "make checkdpadd" (missing library dependencies).

Approved by: re (kensmith)

Add `accept dns' to rfcomm-server example

PR: docs/111320
Submitted by: James Flemer <jflemer@alum.rpi.edu>
No objection: emax
MFC after: 1 week

Check that the length of the received message is at least as big as a PDU
before we use pdu->len.

Submitted by: Iain Hibbert
MFC after: 3 days

Do not mark Bluetooth HID device as a "potential keyboard" if its descriptor
has items with CONSUMER page. For now only check for items with KEYBOARD page.
This should prevent bthidd(8) from allocating vkbd(4) keyboard for Microsoft
Bluetooth Explorer mouse.

Reported by: Eric Anderson
MFC after: 3 days

- Grammar fixes
- Reword some sentences
- Use .Cm for arguments
- s/CAVEAT/CAVEATS/

Based on PR: docs/78174
Submitted by: Jeremy Chadwick <freebsd@jdc.parodius.com>
Reviewed by: brueffer
Approved by: emax (mentor)
MFC after: 3 days

Properly htole16() PSM in sockaddr_l2cap

MFC after: 3 days

- Add a 'verbose' switch -v
- Only dump items that are being used for padding when being verbose. This
brings bthidcontrol in line with the behaviour of usbhidctl(1).
- Update the manpage accordingly

Approved by: emax

- Grammar and typo fixes
- Rewording of some sentences

Reviewed by: brueffer
Approved by: emax (mentor)
MFC after: 3 days

Fix a typo introduced in the last commit: WWW Refresh is 0x227, not 0227

Approved by: emax (mentor)
MFC after: 1 day

Pacify new GCC4 warnings.

Submitted by: kan
MFC after: 1 week

Get rid of extra const to pacify new GCC4 warnings.

Submitted by: kan
MFC after: 1 week

Use socklen_t instead of int32_t where appropriate to pacify new GCC4
warnings.

Submitted by: kan
MFC after: 1 week

Temporarily put ugly workaround in place to make sparc64 build happy.
panther is down at the moment, so better fix will follow later.

Update bthidd(8) code and hook it up to the build.
bthidd(8) now was integrated with vkbd(4) and supports
multiple keyboards via vkbd(4)/kbdmux(4).

The code was tested with Apple Bluetooth keyboard and
SE k700i cell phone (remote control feature).

MFC after: 1 month

- Only print a clarifying message about which HCI node has been used if there
is more than one HCI node present
- Use errx(3) instead of err(3) if there is no HCI node present as errno
is 0 in this case and the resulting error message wouldn't make much sense

Approved by: emax (mentor)

- Document the new Read_Node_List command, autodetection of HCI nodes and
that the '-n' parameter is now optional
- Grammar fixes

Reviewed by: emax
Approved by: emax
MFC after: 1 week

- Add HCI node autodetection. As a consequence of this, make the '-n'
parameter optional.
- Add Read_Node_List command which prints a list of available HCI nodes,
their Netgraph IDs and connected hooks

Reviewed by: emax
Approved by: emax
MFC after: 1 week

Fix formatting. Add missing break;

Submitted by: Iain Hibbert
MFC after: 3 days

Properly map mouse buttons

PR: bin/94577
Submitted by: Krzysztof Jedruczyk < beaker at hot dot pl >
MFC after: 3 days

Properly convert L2CAP PSM values in sockaddr_l2cap to LE16 byte order.

Noticed by: Iain Hibbert < plunky at rya-online dot net >
MFC after: 3 days

Style: NO_MAN doesn't need any value.

Teach bthidd(8) to reload its config when SIGHUP is received.

Submitted by: Iain Hibbert < plunky at rya-online dot net >
MFC after: 3 days

Fix typo

Submitted by: Iain Hibbert < plunky at rya-online dot net >
MFC after: 3 days

- Use official version strings for LMP and HCI version reporting and add
version strings up to Bluetooth 2.0
- Update manufacturer list

Approved by: emax
MFC after: 3 days

Fix scancode translation table

Approved by: emax
MFC after: 3 days

- Grammar fixes
- Reword one sentence

Approved by: brueffer
MFC after: 3 days

- Fix attribute id of HIDBatteryPower
- Fix two typos in comments

Approved by: emax

Fix typo in rfcomm_pppd(8) man page.

Noticed by: Ronald Klop
MFC after: 1 day

Teach sdpd(8) to check peer's credentials before accepting request to
register, remove or change services in the local database. For now only
accept the request if the peer has effective user ID the same as 'root'
user ID.

MFC after: 1 week

Fix typo in usage.

Submitted by: Jonatan B < onatan at gmail dot com >
MFC after: 3 days

Fix all the spelling mistakes I could find in the man pages for words
that have at least 3 characters.

MFC after: 1 week
Thanks to: Music band ``Chingon''
for keeping me company while searching for these.

- Grammar fixes
- s/spdcontrol/sdpcontrol/

Approved by: re (hrs, rwatson), brueffer
MFC after: 3 days

Do not tread 128-bit UUID as int128. Provide separate macros to get/put
128-bit UUID libsdp(3). Fix 128-bit UUID printing in sdpcontrol(8).

MFC after: 3 days

Fix problem with session termination. bthidd(8) maintains two L2CAP
connections to Bluetooth HID device. As soon as Bluetooth HID device
is powered off (or goes out of RF range) the stack will terminate both
connections. File descriptors for both connections will become active
on next select(2) call. Because bthidd(8) processes file descriptors
in order, it will detect descriptor for one of the closed connections
first and kill the session. However, there is still a second (active)
descriptor that used to point to the same session. bthidd(8) used to
assert() if it cant find session by file descriptor, which was wrong.

While I'm here fix a couple of typos in parser.y

Reported by: Eric Anderson anderson AT centtech DOT com
MFC after: 3 days

Let bsd.prog.mk set SRCS and MAN to their default values.

Sort sections.

Added the EXIT STATUS section where appropriate.

Fix typo %d -> %x

That should fix the problem with invalid PSM returned from bthidcontrol.
Pointy hat goes to me.

PR: misc/76107
Submitted by: Hiroyuki Aizu < aizu at navi dot org >
MFC after: 1 day

Scheduled mdoc(7) sweep.

Teach sdpd(8) about 32-bit and 128-bit uuid's.

MFC after: 3 days

Rename 'class' field to 'uclass' in the ng_hci_inquiry_response structure.
class is a reserved word in C++

Submitted by: Markus Brueffer < markus AT brueffer DOT de >
MFC after: 3 days

Start the dreaded NOFOO -> NO_FOO conversion.

OK'ed by: core

Check in updated bthidd(8). This is still work in progress.

Serial devices now called /dev/cuadXX not /dev/cuaaXX

For variables that are only checked with defined(), don't provide
any fake value.

Add missing #include
Bump WARNS level to 2

PR: bin/71668
Submitted by: Dan Lukes <dan@obluda.cz>
MFC after: 3 days

Update links to the bluez-firmware package
Update md5 hash

Introduce ng_hci_inquiry_response structure and use it in the hccontrol(8)

- One can use both BD_ADDR or name to specify address of the Bluetooth device.
Update man pages to document this fact.

- Update usage messages

- Change u_intXXX to uintXXX

- Update l2ping(8) man page and mention that it is possible to use names
instead of BD_ADDRs

- Convert BD_ADDRs in l2ping(8) output into the human readable names via
bt_gethostbyaddr(3)

- Introduce and document '-n' - numberic output option

Suggested by: Anil Madhavapeddy <anil at recoil dot org>

Avoid casts as lvalues.

Add workaround for brain damaged cell phones

PR: bin/67906

Fix cut-n-paste bugs in hccontrol(8). Its very strange that no one noticed
them earlier. Thanks to Mike Crosland (mcrosland at xs4all.nl) for pointing
them out.

Remove dependency on dev/usb/usbdevs.h, in preparation for its
disappearing from the tree. We already were splitting the baby (using
the symbol for the vendor BROADCOM, but not for the device). Use
#defines for both.

Assorted markup, grammar, and spelling fixes.

Markup nits.

Reapply some lost fixes, fix some more.

Start committing Bluetooth HID (Human Interface Device) support.
Note: bthidd(8) is still not complete. Need to commit kernel
support (a-la Linux /dev/input) to feed HID events into kernel.
Also need to write bthidd(8) and bthidd.conf(5) man pages.

Use uint instead of u_int

Make sure Bluetooth stuff can be compiled on amd64

Submitted by: ps

Make NULL a (void*)0 whereever possible, and fix the warnings(-Werror)
that this provokes. "Wherever possible" means "In the kernel OR NOT
C++" (implying C).

There are places where (void *) pointers are not valid, such as for
function pointers, but in the special case of (void *)0, agreement
settles on it being OK.

Most of the fixes were NULL where an integer zero was needed; many
of the fixes were NULL where ascii <nul> ('\0') was needed, and a
few were just "other".

Tested on: i386 sparc64

Add extra sanity check for SDP packets in libsdp(3)
Fix yet another endianess bug in sdpd(8)

Fix endianes bug

Teach rfcomm_pppd(8) how to register Bluetooth LAN service with local sdpd(8)
Add -u(unit) option

Reviewed by: imp (mentor), ru

l2ping(8) should not loose echo data if target does not responds to the ping

Reviewed by: imp (mentor), ru

Cleanup CFLAGS in libsdp(3) Makefile
Connect sdpd(8) to the build

Reviewed by: ru, imp (mentor)

Import sdpd(8) sources. This is Bluetooth Service Discovery Protocol daemon.
Extend libsdp(3) API to allow service registration and removal.
Fix uninitialized variable bug in sdpcontrol(8).

Reviewed by: imp (mentor)
No objection: ru

Change sdp_open_local(3) API. It now takes a path to a control socket
Teach sdpcontrol(8) how to talk to the local SDP server
Update man pages
s/u_int/uint

Reviewed by: imp (mentor), ru

Fix uncontrolled access to the buffer in rfcomm_sppd(1).
Fix typo in hcsecd(8) man page.

Submitted by: Guido Falsi <mad@madpilot.net>
Reviewed by: imp (mentor)
Approved by: imp (mentor)

Replace all uses of the old netgraph constants NG_*LEN by the new
constants NG_*SIZ that include the trailing NUL byte. This change
is mostly mechanical except for the replacement of a couple of snprintf()
and sprintf() calls with strlcpy.

Fix few typos

Reviewed by: imp, julian, ru
Approved by: imp (mentor)

Update Bluetooth code.

Reviewed by: M. Warner Losh <imp@bsdimp.com>; John Hay <jhay@freebsd.org>
Approved by: M. Warner Losh <imp@bsdimp.com> (mentor)

Account for the fact that "buildworld" builds in the 'obj' tree
Pointed out by: Andrew Gallatin <gallatin@cs.duke.edu>

Reapply mdoc(7) fixes that got accidentally lost in the last
Bluetooth update, and fix a few more issues.

Submitted by: Maksim Yevmenkin <m_evmenkin@yahoo.com>, ru
Approved by: re (blanket)

Make the README reflect reality.

Approved by: re@ (blanket for bluetooth upgrade)

Re-enable the broadcom firmware utility now that the Makefile in that subdir
has been fixed to not need the missing files.
The firmware files themselves still now need to be fetched from the internet.
The README there gives the location.

Approved by: re@ (part of bluetooth upgrade)

Fix (presently unused) Makefile to not need files not yet checked in.
Submitted by: Maksim Yevmenkin <m_evmenkin@yahoo.com>

Approved by: re@ (part of Bluetooth upgrade)

Don't compile the broadcom firmware module yet.

Broadcom firmware loading module.. The actual firmware files will follow when
the legal status has been confirmed, in the meanwhile they can be
downloaded from the location in the README file.

Part 2 of the commit if new bluetooth code.
Submitted by: Maksim Yevmenkin <m_evmenkin@yahoo.com>
Approved by: re@

Correct typos, mostly s/ a / an / where appropriate. Some whitespace cleanup,
especially in troff files.

mdoc(7) police: markup fixes.

Approved by: re

The second try a committing the bluetooth code
Has been seen to work on several cards and communicating with
several mobile phones to use them as modems etc.

We are still talking with 3com to try get them to allow us to include
the firmware for their pccard in the driver but the driver is here..
In the mean time
it can be downloaded from the 3com website and loaded using the utility
bt3cfw(8) (supplied) (instructions in the man page)

Not yet linked to the build

Submitted by: Maksim Yevmenkin <myevmenk@exodus.net>
Approved by: re