#
368931 |
|
05-Jan-2021 |
mr |
MFC r340361:
Fix printing of 64-bit counters on 32-bit ppc platforms.
Several statistic counters are uint64_t values and are printed by systat using %lu. This results in displaying wrong numbers. Use PRIu64 instead. While there, print variables of size_t using %zd.
Approved by: re (gjb@) Differential Revision: https://reviews.freebsd.org/D17838
(cherry picked from commit 45e9405ea4b05926b22a743237cbfe918206db50)
systat: use and correctly display 64bit counters.
Following struct vmtotal changes, make systat use and correctly display 64-bit counters. Switch to humanize_number(3) to overcome homegrown arithmetics limits in pretty printing large numbers. Use 1024 as a divisor for memory fields to make it consistent with other tools and users expectations.
Submitted by: Pawel Biernacki <pawel.biernacki@gmail.com> Sponsored by: Mysterious Code Ltd. PR: 2137 Differential revision: https://reviews.freebsd.org/D13105
(cherry picked from commit 90dd3e79cc4d721b17c473fdaf3ba3d6d912b138)
Order declarations alphabetically. Match signess of the format and the value.
Noted by: bde Sponsored by: The FreeBSD Foundation
(cherry picked from commit 1b7a3d1f5ffe700203f12654cd01a08a84551b4a)
MFC r340361, r345804: catch up on systat in head/
[Neither of these originally mine, but the latter commit referenced fixes an -fno-common issue and the former is a bugfix]
r340361: Fix printing of 64-bit counters on 32-bit ppc platforms.
Several statistic counters are uint64_t values and are printed by systat using %lu. This results in displaying wrong numbers. Use PRIu64 instead. While there, print variables of size_t using %zd.
r345804: systat -zarc to display disk activities like -vm
PR: 213310 (cherry picked from commit a70af2507f720c2d7f56f51a18d358123b4770a5)
MFC r360919,r360929,r361084:
Patch systat -zarc to display cumulative rate and round down large numbers by SI units
Introduce sysputpage() to display large page size with human readable format. Using UI units allows to fit larger numbers in columns. Stop calling v_page_size - this is a value that doesn't change at runtime. Renamed WINDOW *wnd to *wd to avoid conflict with global *wnd variable. Use bit-shift to convert page size to byte.
PR: 237664, 246458 Submitted by: ota@j.email.ne.jp
(cherry picked from commit 65d1fd13ac2182f7ca0c223bb723fba6d780740f)
MFC r363095: Handle device removal and removal+add cases to fix infinity rate.
PR: 219829 Submitted by: ota@j.email.ne.jp Reported by: rezo@live.cn Differential Revision: https://reviews.freebsd.org/D25226
(cherry picked from commit 7a446028cedb13a0d2004cf6f584291a976392da)
PR: 219829, 237664, 246458, 213310, 2137
Git Hash: 72b42d209ff5b37c615048fb251d7bf9eb276381 Git Author: tuexen@FreeBSD.org
|
#
331722 |
|
29-Mar-2018 |
eadler |
Revert r330897:
This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code.
Revert with prejudice.
This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes.
Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes.
Requested by: gjb (re)
|
#
158160 |
|
30-Apr-2006 |
bde |
Show the load average in the tcp display (it was already shown, perhaps not very usefully, in all other displays). This was the original point of the PR.
Move the load average up by 2 so that it starts in row 0 for all windows (2 lines above it were wasted for all other windows except vmstat). Move everything below it up by 2 or 3 (3 for icmp and icmp6 which had an extra blank line due from not compensating for the foot-shooting in note (3); only ip and ip6 compensated). Reduce the magic numbers related to this.
Notes by the submitter: %%% 1. All the subwin() calls are identical using #define MAINWIN_ROW 3 (systat.h). 2. The load average is at the top of the window. 3. Each display starts on the fourth line. I made changes to those displays that shifted the start line (i.e., icmp). This entailed a lot of changes within the comments at the top of those displays. 4. For ip6, I shifted the "Input next-header histogram" column down one row to separate it from "IPv6 Output". I raised "bad scope packets" and "address selection failed" up one row to stay with "IPv6 Input" (valid?). They were down one row to probably line up at the bottom, but I think they should stick with their fellow items in a column. 5. I condensed ifstat a bit. It had a lot of empty rows. %%%
Submitted by: Se=E1n Farley <sean-freebsd at farley dot org> PR: bin/81874
|