Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

rlogin(1): initialize term variable.

CID: 1011522
Obtained from: NetBSD (CVS 1.18, partial)

More -Wmissing-variable-declarations fixes.

In addition to adding `static' where possible:

- bin/date: Move `retval' into extern.h to make it visible to date.c.
- bin/ed: Move globally used variables into ed.h.
- sbin/camcontrol: Move `verbose' into camcontrol.h and fix shadow warnings.
- usr.bin/calendar: Remove unneeded variables.
- usr.bin/chat: Make `line' local instead of global.
- usr.bin/elfdump: Comment out unneeded function.
- usr.bin/rlogin: Use _Noreturn instead of __dead2.
- usr.bin/tset: Pull `Ospeed' into extern.h.
- usr.sbin/mfiutil: Put global variables in mfiutil.h.
- usr.sbin/pkg: Remove unused `os_corres'.
- usr.sbin/quotaon, usr.sbin/repquota: Remove unused `qfname'.

Replace index() and rindex() calls with strchr() and strrchr().

The index() and rindex() functions were marked LEGACY in the 2001
revision of POSIX and were subsequently removed from the 2008 revision.
The strchr() and strrchr() functions are part of the C standard.

This makes the source code a lot more consistent, as most of these C
files also call into other str*() routines. In fact, about a dozen
already perform strchr() calls.

Generate the network byte order version of the window size structure in a
temporary variable on the stack and then copy that into the output buffer
so that the htons() conversions use aligned accesses.

MFC after: 1 month

Catch up with r57841 which removed the possible linking against libutil
by not bothering to include its API.

Revert most part of 200420 as requested, as more review and polish is
needed.

Remove unneeded header includes from usr.bin/ except contributed code.

Tested with: make universe

len and len2 work better as size_t

Use socklen_t where appropriate.

Removed Kerberos remnants.

Use the POSIX tty interface instead of the old interface. This makes
rlogin work properly without COMPAT_43.

Obtained from: NetBSD (mycroft)

Remove remnants of Kerberos -Kkx options.

Dekerberise. The corresponding userland stuff has been dekerberised
for ages, and no-one seems to have noticed. Viva PAM!

Fix some easy/trivial warnings while I'm here.

Do not repeat option name in its definition. Use .Nm. In the sequence ``~.'',
``.'' is not a sentence termination, it must be escaped to be put inside
quotes.
Abort if execv() fails by adding err(). Do not dot terminate error messages.

Use POSIX macros for wait(2)-style status information instead of the
deprecated 4.2/4.3BSD wait union. Fix some nearby pid_t/int
confusion.

Really include <paths.h> (it seems it was brought in indirectly)

Use <paths.h> rather than "pathnames.h", and fix a couple of whitespace nits.

Sponsored by: DARPA, NAI Labs

Easy warns fixes; use const, mark unused function parameters. Remove
unused includes.

o unifdef -D__STDC__
o use ansi function definitions
o remove OLDSUN

remove __P

Use SIGUSR1 to propogate SIGURG to the child; security measures prevent
the parent from sending SIGURG itself to the child. This fixes the
problem of occasionally failing to pass the window size.

[rlogin.1] Document the `-4' and `-6' options. Correct a typo.
[rlogin.c] Make the usage message match the code.

getopt and friends are declared in <unistd.h>
getopt returns -1 not EOF.

Use libcrypto in place of libdes.

Add -4 and -6 options.

Current getaddrinfo() implemetation has a problem of too much resolving
waiting time on INET6 enabled systems.
-4 and -6 options can limit name resolving address family and is a possible
workaround for the problem.

Approved by: jkh

several tcp apps IPv6 update
-inetd
-rshd
-rlogind
-telnetd
-rsh
-rlogin

Reviewed by: freebsd-arch, cvs-committers
Obtained from: KAME project

$Id$ -> $FreeBSD$

Fixed usage message to almost match the man page. The old -d option and
the new -i option were missing.

Fixed style bugs in previous commit:
(1) initialisation of a local variable in its declaration.
(2) inconsistency of (1) with style of nearby code.
(3) disorder of declaration for (1).
(4) a line longer than 80 characters.
(5) bitrot in the printf() -> err() cleanups to help bloat the line in (4).

Add a -i localname switch (restricted to root) to specify a different
local "login" name for rcmd(3). This is particularly useful for things
like portslave and other packages with terminal server functionality
where a login can either run ppp locally or get shunted off to another
box via rlogin depending on radius authentication etc. Quite often the
local box doesn't even have accounts, so a flag such as this is needed.
Obviously this is restricted to callers with uid == 0.

Use KJH's auth.conf parser to turn on/off Kerberos in userland.

Quite a while back KTH (who are the good folks who wrote our KerberosIV)
announced a K4 weakness with their rsh/rlogins. We were not put in any
danger by this, as we were not using KTH rlogin/rsh, but the patches
in themselves, had some good points. This lot means we can run our
rlogin without it being SUID root. Win win win. There are other KTH
cleanups as well.

Changes for KTH KerberosIV.
Also quieten -Wall a bit.

Use err(3). Document -l flag.
Obtained from: OpenBSD

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Don't use __dead or __pure in user code. They were obfuscations
for gcc >= 2.5 and no-ops for gcc >= 2.6. Converted to use __dead2
or __pure2 where it wasn't already done, except in math.h where use
of __pure was mostly wrong.

Add Bruce's improvement to security patch

Do a bounds check on the strcpy of environment variables onto the stack.

#include <kerberosIV/des.h> -> #include <des.h>

Rename des_set_key -> des_set_key_krb. (libdes conflict)

Kerberos can now deal with multi-homed clients.

Kerberos obtains a network address for the local host from the routing
tables and uses it consistently for all Kerberos transactions. This ensures
that packets only leave the *authenticated* interface. Clients who open
and use their own sockets for encrypted or authenticated correspondance
to kerberos services should bind their sockets to the same address as that
used by kerberos. krb_get_local_addr() and krb_bind_local_addr() allow
clients to obtain the local address or bind a socket to the local address
used by Kerberos respectively.

Reviewed by: Mark Murray <markm>, Garrett Wollman <wollman>
Obtained from: concept by Dieter Dworkin Muller <dworkin@village.org>

Back out speed reducing to 38400 for old remote rlogind.
I do some digging out on this subject and found that remote
rlogind may reduce big speeds to 38400 by itself and (as more often
rlogind variant) speed setting ioctl fails, so speed left on 9600.
In all cases it doesn't do any real harm.

Reduce passed speed to 38400, like telnet does too.
Remote rlogind may not understand speeds > 38400.

Added "D" option to usage clause.

Added a "-D" option to set the TCP_NODELAY socket option.

Move the call to des_set_key to after the kerberos initialisation, removing
assumption about the implementation of des_read/des_write.

Reviewed by:
Add entries for the speed 57600 and 115200 to the allowed speeds.

This commit was generated by cvs2svn to compensate for changes in r1590,
which included commits to RCS files with non-trunk default branches.

BSD 4.4 Lite Usr.bin Sources