Revert r330897:

This was intended to be a non-functional change. It wasn't. The commit
message was thus wrong. In addition it broke arm, and merged crypto
related code.

Revert with prejudice.

This revert skips files touched in r316370 since that commit was since
MFCed. This revert also skips files that require $FreeBSD$ property
changes.

Thank you to those who helped me get out of this mess including but not
limited to gonzo, kevans, rgrimes.

Requested by: gjb (re)

Partial merge of the SPDX changes

These changes are incomplete but are making it difficult
to determine what other changes can/should be merged.

No objections from: pfg

MFC r316501, r316523

r316501:
Fix file descriptor and memory leaks in pr(1)

Also, hook NetBSD's pr test into the build, and add three more test cases.

Reported by: Coverity, Valgrind
CID: 271650 271651 271652 271653 271654 271655 271656 271656
CID: 271657 271658 271659 1006939 1006940 1006941 1006942 1009098
Reviewed by: ngie
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D9137

r316523:
Remove a duplicate fclose() that snuck into r316501

Reported by: Coverity
CID: 1373338
X-MFC-With: 316501
Sponsored by: Spectra Logic Corp

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Spelling fixes for usr.bin/

Add missing static keywords to pr(1)

Use time(NULL) instead of gettimeofday(), because we only need tv_sec.

Fix misspelled 'argument' and try to make the sentence into English.

Submitted by: Andre Guibert de Bruet andy at siliconlandmark dot com

No capital letter after :

Fix typos, mostly s/ an / a / where appropriate and a few s/an/and/
Add FreeBSD Id tag where missing.

ANSIify function definitions.
Add some constness to avoid some warnings.
Remove use register keyword.
Deal with missing/unneeded extern/prototypes.
Some minor type changes/casts to avoid warnings.

Reviewed by: md5

Modernise this code by rounding up the usual suspects: register keyword,
consts, ANSIfication of functions, proper use of __FBSDID() and so on.
This commit is non-functional from a code-execution perspective, but
pr(1) now compiles WARNS=6 clean.

Don't convert a single space before a tab stop into a tab when the
-i option is used.

Add P1003.1-2001 -f and -p options.

PR: standards/36243
Submitted by: Tim J. Robbins <tim@robbins.dropbear.id.au>
Reviewed by: mike
MFC after: 2 weeks

Ensure err is a useful value to prevent using fputs() with a NULL stream.
MFC after: 1 week

Use nl_langinfo instead of %Ef

Fix typo: seperate -> separate.

Seperate does not exist in the english language.

The -s option was broken (missing braces around an else clause).

Noticed by: Thomas Stromberg <tstromberg@rtci.com>
Obtained from: OpenBSD

Change meaning of newly introduced -L option - it helps lpr later

Localize it

Don't assume that time_t is long.

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Fixes:

When you ask pr to use form feeds at the end of pages and specify a page
length and tell pr to not put the fancy headers and footers on each
pages, then pr will not separate the pages with a form feed.

Closes PR: bin/1237

Submitted by: Warner Losh <imp@village.org>

Remove wrong LC_TIME env. usage

Remove trailing whitespace.

This commit was generated by cvs2svn to compensate for changes in r1590,
which included commits to RCS files with non-trunk default branches.

BSD 4.4 Lite Usr.bin Sources