339033 |
01-Oct-2018 |
mav |
MFC r338913: Fix use-after-free in RAID0 error reporting of GEOM_RAID. |
326744 |
10-Dec-2017 |
eugen |
MFC r326655,326668: correct error handling for graid SINGLE/CONCAT/RAID5 volumes.
Approved by: mav (mentor) |
302408 |
08-Jul-2016 |
gjb |
Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle. Prune svn:mergeinfo from the new branch, as nothing has been merged here.
Additional commits post-branch will follow.
Approved by: re (implicit) Sponsored by: The FreeBSD Foundation |
300288 |
20-May-2016 |
kib |
Removal of Giant droping wrappers for GEOM classes.
Sponsored by: The FreeBSD Foundation
|
298808 |
29-Apr-2016 |
pfg |
sys/geom: spelling fixes in comments.
No functional change.
|
298755 |
28-Apr-2016 |
pfg |
sys/geom: spelling fixes.
These affect debugging messages.
MFC after: 2 weeks
|
298698 |
27-Apr-2016 |
pfg |
geom: unsign some types to match their definitions and avoid overflows.
In struct:gctl_req, nargs is unsigned.
In mirror: g_mirror_syncreqs is unsigned.
In raid: in struct:g_raid_volume, v_disks_count is unsigned.
In virstor: in struct:g_virstor_softc, n_components is unsigned.
MFC after: 2 weeks
|
298649 |
26-Apr-2016 |
pfg |
sys: extend use of the howmany() macro when available.
We have a howmany() macro in the <sys/param.h> header that is convenient to re-use as it makes things easier to read.
|
297793 |
10-Apr-2016 |
pfg |
Cleanup unnecessary semicolons from the kernel.
Found with devel/coccinelle.
|
295707 |
17-Feb-2016 |
imp |
Create an API to reset a struct bio (g_reset_bio). This is mandatory for all struct bio you get back from g_{new,alloc}_bio. Temporary bios that you create on the stack or elsewhere should use this before first use of the bio, and between uses of the bio. At the moment, it is nothing more than a wrapper around bzero, but that may change in the future. The wrapper also removes one place where we encode the size of struct bio in the KBI.
|
289137 |
11-Oct-2015 |
mav |
Remove compatibility shims for legacy ATA device names.
We got new ATA stack in FreeBSD 8.x, switched to it at 9.x, completely removed old stack at 10.x, so at 11.x it is time to remove compat shims.
|
286615 |
11-Aug-2015 |
pfg |
Clean out some externally visible "more then" grammar
MFC after: 3 days
|
280757 |
27-Mar-2015 |
mav |
Remove request sorting from GEOM_MIRROR and GEOM_RAID.
When CPU is not busy, those queues are typically empty. When CPU is busy, then one more extra sorting is the last thing it needs. If specific device (HDD) really needs sorting, then it will be done later by CAM.
This supposed to fix livelock reported for mirror of two SSDs, when UFS fires zillion of BIO_DELETE requests, that totally blocks I/O subsystem by pointless sorting of requests and responses under single mutex lock.
MFC after: 2 weeks
|
279278 |
25-Feb-2015 |
mav |
Replace constant with proper sizeof().
Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com> MFC after: 2 weeks
|
275503 |
05-Dec-2014 |
mav |
Avoid unneeded malloc/memcpy/free if there is no metadata on disk.
Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com> MFC after: 2 weeks
|
275475 |
04-Dec-2014 |
mav |
Decode some binary fields of Intel metadata.
Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com> MFC after: 2 weeks
|
273174 |
16-Oct-2014 |
davide |
Follow up to r225617. In order to maximize the re-usability of kernel code in userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv(). This fixes a namespace collision with libc symbols.
Submitted by: kmacy Tested by: make universe
|
267992 |
28-Jun-2014 |
hselasky |
Pull in r267961 and r267973 again. Fix for issues reported will follow.
|
267985 |
27-Jun-2014 |
gjb |
Revert r267961, r267973:
These changes prevent sysctl(8) from returning proper output, such as:
1) no output from sysctl(8) 2) erroneously returning ENOMEM with tools like truss(1) or uname(1) truss: can not get etype: Cannot allocate memory
|
267961 |
27-Jun-2014 |
hselasky |
Extend the meaning of the CTLFLAG_TUN flag to automatically check if there is an environment variable which shall initialize the SYSCTL during early boot. This works for all SYSCTL types both statically and dynamically created ones, except for the SYSCTL NODE type and SYSCTLs which belong to VNETs. A new flag, CTLFLAG_NOFETCH, has been added to be used in the case a tunable sysctl has a custom initialisation function allowing the sysctl to still be marked as a tunable. The kernel SYSCTL API is mostly the same, with a few exceptions for some special operations like iterating childrens of a static/extern SYSCTL node. This operation should probably be made into a factored out common macro, hence some device drivers use this. The reason for changing the SYSCTL API was the need for a SYSCTL parent OID pointer and not only the SYSCTL parent OID list pointer in order to quickly generate the sysctl path. The motivation behind this patch is to avoid parameter loading cludges inside the OFED driver subsystem. Instead of adding special code to the OFED driver subsystem to post-load tunables into dynamically created sysctls, we generalize this in the kernel.
Other changes: - Corrected a possibly incorrect sysctl name from "hw.cbb.intr_mask" to "hw.pcic.intr_mask". - Removed redundant TUNABLE statements throughout the kernel. - Some minor code rewrites in connection to removing not needed TUNABLE statements. - Added a missing SYSCTL_DECL(). - Wrapped two very long lines. - Avoid malloc()/free() inside sysctl string handling, in case it is called to initialize a sysctl from a tunable, hence malloc()/free() is not ready when sysctls from the sysctl dataset are registered. - Bumped FreeBSD version to indicate SYSCTL API change.
MFC after: 2 weeks Sponsored by: Mellanox Technologies
|
265054 |
28-Apr-2014 |
mav |
Reduce number of opens by REOM RAID during provider taste.
Instead opening/closing provider by each of metadata classes, do it only once in core code. Since for SCSI disks open/close means sending some SCSI commands to the device, this change reduces taste time.
MFC after: 2 weeks Sponsored by: iXsystems, Inc.
|
264318 |
10-Apr-2014 |
mav |
Fix wrong sizes used to access PD_Type and PD_State DDF metadata fields.
This caused incorrect behavior of arrays with big-endian DDF metadata. Little-endian (like used by Adaptec controllers) should not be harmed. Add workaround should be enough to manage compatibility.
MFC after: 2 weeks
|
258780 |
30-Nov-2013 |
eadler |
Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this shifts into the sign bit. Instead use (1U << 31) which gets the expected result.
This fix is not ideal as it assumes a 32 bit int, but does fix the issue for most cases.
A similar change was made in OpenBSD.
Discussed with: -arch, rdivacky Reviewed by: cperciva
|
256880 |
22-Oct-2013 |
mav |
Merge GEOM direct dispatch changes from the projects/camlock branch.
When safety requirements are met, it allows to avoid passing I/O requests to GEOM g_up/g_down thread, executing them directly in the caller context. That allows to avoid CPU bottlenecks in g_up/g_down threads, plus avoid several context switches per I/O.
The defined now safety requirements are: - caller should not hold any locks and should be reenterable; - callee should not depend on GEOM dual-threaded concurency semantics; - on the way down, if request is unmapped while callee doesn't support it, the context should be sleepable; - kernel thread stack usage should be below 50%.
To keep compatibility with GEOM classes not meeting above requirements new provider and consumer flags added: - G_CF_DIRECT_SEND -- consumer code meets caller requirements (request); - G_CF_DIRECT_RECEIVE -- consumer code meets callee requirements (done); - G_PF_DIRECT_SEND -- provider code meets caller requirements (done); - G_PF_DIRECT_RECEIVE -- provider code meets callee requirements (request). Capable GEOM class can set them, allowing direct dispatch in cases where it is safe. If any of requirements are not met, request is queued to g_up or g_down thread same as before.
Such GEOM classes were reviewed and updated to support direct dispatch: CONCAT, DEV, DISK, GATE, MD, MIRROR, MULTIPATH, NOP, PART, RAID, STRIPE, VFS, ZERO, ZFS::VDEV, ZFS::ZVOL, all classes based on g_slice KPI (LABEL, MAP, FLASHMAP, etc).
To declare direct completion capability disk(9) KPI got new flag equivalent to G_PF_DIRECT_SEND -- DISKFLAG_DIRECT_COMPLETION. da(4) and ada(4) disk drivers got it set now thanks to earlier CAM locking work.
This change more then twice increases peak block storage performance on systems with manu CPUs, together with earlier CAM locking changes reaching more then 1 million IOPS (512 byte raw reads from 16 SATA SSDs on 4 HBAs to 256 user-level threads).
Sponsored by: iXsystems, Inc. MFC after: 2 months
|
256610 |
16-Oct-2013 |
mav |
MFprojects/camlock r256445: Add unmapped I/O support to GEOM RAID.
|
254275 |
13-Aug-2013 |
mav |
Return error when opening read-only volumes (like RAID4/5/...) for writing. Previously opens succeeded, but actual write operations returned errors.
Requested by: peter MFC after: 2 weeks
|
254271 |
13-Aug-2013 |
mav |
Oops, wrong constant at r254269.
|
254269 |
13-Aug-2013 |
mav |
Fix reasonable but safe Clang warnings.
|
253706 |
27-Jul-2013 |
mav |
Introduce 3 seconds timeout on `graid stop` command (mostly with -f flag). Since completion waiting goes in g_event thread, it may cause GEOM deadlock if consumer on top (for example, ZFS) uses g_event thread for closing.
|
250819 |
20-May-2013 |
mav |
Fix vdc->Secondary_Element_Count metadata field access from 16 to 8 bit. In some cases it could cause kernel panic during failed drive replacement.
Reported by: trasz MFC after: 1 week
|
249974 |
27-Apr-2013 |
mav |
Return "descr" field alike to "Intel RAID1 volume" for GEOM RAID to make it look better in bsdinstall.
|
248720 |
26-Mar-2013 |
mav |
Remove extra bio_data and bio_length copying to child request after calling g_clone_bio(), that already copied them.
|
248068 |
08-Mar-2013 |
sbruno |
Add legacy support to geom raid to create a /dev/arX device for support of upgrading older machines using ataraid(4) to newer releases.
This optional parameter is controlled via kern.geom.raid.legacy_aliases and will create a /dev/ar0 device that will point at /dev/raid/r0 for example.
Tested on Dell SC 1425 DDF-1 format software raid controllers installing from stable/7 and upgrading to stable/9 without having to adjust /etc/fstab
Reviewed by: mav Obtained from: Yahoo! MFC after: 2 Weeks
|
247918 |
07-Mar-2013 |
mav |
Fix panic when Secondary_Element_Count == 1 and Secondary_Element_Seq is not set (255).
Reported by: sbruno MFC after: 1 week
|
245533 |
17-Jan-2013 |
mav |
- Fix rebuild position broken at r245522. - Identify one more metadata field.
|
245522 |
17-Jan-2013 |
mav |
For Promise/AMD metadata add support for disks with capacity above 2TiB and for volumes with sector size above 512 bytes.
|
245519 |
17-Jan-2013 |
mav |
Recalculate volume size only for real CONCATs. For SINGLE trust volume size given by metadata, as it should be correct and in some cases can be smaller then subdisk size.
|
245433 |
14-Jan-2013 |
mav |
Keep value of orig_config_id metadata field. Windows driver writes there previous value of config_id when it is changed in some cases. I guess it may be used do avoid some split-brain conditions.
|
245425 |
14-Jan-2013 |
mav |
Small cosmetic tuning of the IRRT status constants.
|
245423 |
14-Jan-2013 |
mav |
Print some more metadata fields.
|
245400 |
14-Jan-2013 |
mav |
Windows driver writes relative volume IDs to metadata field. Use that value as a hint for raid/rX device number to make it persistent across reboots.
|
245398 |
13-Jan-2013 |
mav |
- Add checks for Intel metadata version and attributes. Ignore disks with unsupported metadata types like Intel Smart Response to not corrupt them. - Improve setting of these things during metadata writing to protect from incapable BIOS'es and other implementations.
|
245363 |
13-Jan-2013 |
mav |
Improve support for disabled disks. If disabled disk disconnected and then reconnected back, leave it as disconnected. If new disk inserted instead of disabled, rebuild it and leave as enabled.
|
245341 |
12-Jan-2013 |
mav |
Windows handles INIT and VERIFY as array-wide and it doesn't specify which disks should be rebuilt. Our rebuild code is same time disk-centric. To handle this situation properly check all disks for RBLD flags, and if no disk specified try rebuild/resync all of them except newly inserted.
|
245338 |
12-Jan-2013 |
mav |
Implement migration from single disk to RAID1/IRRT for Intel metadata. Windows driver uses such migration when it creates new arrays. While GEOM RAID has no mechanism to implement migration in general case, this specifc case still can be handled easily via degraded RAID1 creation followed by regular rebuild.
|
245326 |
12-Jan-2013 |
mav |
Add basic support for Intel Rapid Recover Technology (Intel RRT). It is alike to RAID1, but with dedicating master and recovery disks and providing manual control over synchronization. It allows to use recovery disk as snapshot of the master disk from the time of the last sync.
This implementation is not functionaly complete comparing to Windows, but it is better then silent conversion to RAID1 on first boot.
|
242328 |
29-Oct-2012 |
mav |
Minor addition to r242323: Alike to BIO_WRITE, report success if at least one subdisk succeeded with BIO_DELETE. But unlike BIO_WRITE don't fail disk on BIO_DELETE error.
Sponsored by: iXsystems, Inc. MFC after: 1 month
|
242323 |
29-Oct-2012 |
mav |
Add basic BIO_DELETE support to GEOM RAID class for all RAID levels.
If at least one subdisk in the volume supports it, BIO_DELETE requests will be propagated down. Unfortunatelly, for RAID levels with redundancy unmapped blocks will be mapped back during first rebuild/resync process.
Sponsored by: iXsystems, Inc. MFC after: 1 month
|
242314 |
29-Oct-2012 |
mav |
Make GEOM RAID more aggressive in marking volumes as clean on shutdown and move that action from shutdown_pre_sync to shutdown_post_sync stage to avoid extra flapping.
ZFS tends to not close devices on shutdown, that doesn't allow GEOM RAID to shutdown gracefully. To handle that, mark volume as clean just when shutdown time comes and there are no active writes.
MFC after: 2 weeks
|
241418 |
10-Oct-2012 |
mav |
NULL-ify last previously used pointer instead of last possible pointer. This should be only a cosmetic change.
Found by: Clang Static Analyzer
|
241329 |
07-Oct-2012 |
mav |
Make graid command line a bit more friendly by allowing volume name or provider name to be specified instead of geom name (first argument in all subcommands except label). In most cases there is only one array used any way, so it is not really useful to make user type ugly geom names like Intel-f0bdf223 or SiI-732c2b9448cf. Though they can be used in some cases.
Sponsored by: iXsystems, Inc. MFC after: 1 month
|
240465 |
13-Sep-2012 |
mav |
Add global and per-module sysctls/tunables to enable/disable metadata taste. That should help to handle some cases when disk has some RAID metadata that should be ignored, especially during boot.
MFC after: 3 days
|
239175 |
10-Aug-2012 |
mav |
Add missing FAILED event to g_raid_subdisk_event2str() to print it properly in debug messages.
Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com>
|
235270 |
11-May-2012 |
mav |
- Prevent error status leak if write to some of the RAID1/1E volume disks failed while write to some other succeeded. Instead mark disk as failed. - Make RAID1E less aggressive in failing disks to avoid volume breakage.
MFC after: 2 weeks
|
235096 |
06-May-2012 |
mav |
Remove some hardcoded constants from code.
|
235080 |
06-May-2012 |
mav |
Plug small memory leaks.
|
235076 |
06-May-2012 |
mav |
Add support for RAID5R. Slightly improve support for RAIDMDF.
|
234994 |
04-May-2012 |
mav |
Fix bug causing memory corruption and panics with big-endian metadata.
|
234993 |
04-May-2012 |
mav |
Implement read-only support for volumes in optimal state (without using redundancy) for the following RAID levels: RAID4/5E/5EE/6/MDF.
|
234940 |
03-May-2012 |
mav |
Add optional -o argument to the `graid label ` to specify some metadata format options. Use it for specifying byte order for the DDF metadata: big-endian defined by specification and little-endian used by Adaptec.
|
234899 |
01-May-2012 |
mav |
Improve spare disks support. Unluckily, for some reason Adaptec 1430SA RAID BIOS doesn't want to understand spare disks created by graid. But at least spares created by BIOS are working fine now.
|
234869 |
01-May-2012 |
mav |
Implement volume deletion if disk has more then one partition.
|
234868 |
01-May-2012 |
mav |
Improve DDF metadata writing.
|
234848 |
30-Apr-2012 |
mav |
Add to GEOM RAID class module, supporting the DDF metadata format, as defined by the SNIA Common RAID Disk Data Format Specification v2.0.
Supports multiple volumes per array and multiple partitions per disk. Supports standard big-endian and Adaptec's little-endian byte ordering. Supports all single-layer RAID levels. Dual-layer RAID levels except RAID10 are not supported now because of GEOM RAID design limitations.
Some work is still to be done, but the present code already manages basic interoperation with RAID BIOS of the Adaptec 1430SA SATA RAID controller.
MFC after: 1 month Sponsored by: iXsystems, Inc.
|
234816 |
29-Apr-2012 |
mav |
s/gmirror/graid/
|
234727 |
27-Apr-2012 |
mav |
Fix RAID5 level names changed at r234603.
|
234610 |
23-Apr-2012 |
mav |
Fix copy-paste typo in r234603.
Submitted by: kan
|
234603 |
23-Apr-2012 |
mav |
Add names for all primary RAID levels defined by DDF 2.0 specification.
|
234601 |
23-Apr-2012 |
mav |
Add sos@ copyrights to RAID metadata modules, respecting his efforts in decoding metadata formats in ataraid(4) code.
|
234458 |
19-Apr-2012 |
mav |
Add to GEOM RAID class module for reading non-degraded RAID5 volumes and some environment to differentiate 4 possible RAID5 on-disk layouts.
Tested with Intel and AMD RAID BIOSes.
MFC after: 2 weeks
|
229886 |
09-Jan-2012 |
jimharris |
Add support for >2TB disks in GEOM RAID for Intel metadata format.
Reviewed by: mav Approved by: scottl MFC after: 1 week
|
227309 |
07-Nov-2011 |
ed |
Mark all SYSCTL_NODEs static that have no corresponding SYSCTL_DECLs.
The SYSCTL_NODE macro defines a list that stores all child-elements of that node. If there's no SYSCTL_DECL macro anywhere else, there's no reason why it shouldn't be static.
|
226816 |
26-Oct-2011 |
mav |
Clarify disks/volumes above 2TiB support in geom_raid: - add support for volumes above 2TiB with Promise metadata format; - enforse and document other limitations: - Intel and Promise metadata formats do not support disks above 2TiB; - NVIDIA metadata format does not support volumes above 2TiB.
Sponsored by: iXsystems, Inc. MFC after: 2 weeks
|
223921 |
11-Jul-2011 |
ae |
Include sys/sbuf.h directly.
Reviewed by: pjd
|
220790 |
18-Apr-2011 |
mav |
Reduce geom_raid log verbosity.
|
220210 |
31-Mar-2011 |
mav |
Bunch of small bugfixes and cleanups.
Found with: Clang Static Analyzer
|
220209 |
31-Mar-2011 |
mav |
Bunch of small bugfixes and cleanups.
Found with: Coverity Prevent(tm) CID: 9656, 9658, 9693, 9705, 9706, 9707, 9808, 9809, 9810, 9711, 9712, 9713, 9714
|
219974 |
24-Mar-2011 |
mav |
MFgraid/head: Add new RAID GEOM class, that is going to replace ataraid(4) in supporting various BIOS-based software RAIDs. Unlike ataraid(4) this implementation does not depend on legacy ata(4) subsystem and can be used with any disk drivers, including new CAM-based ones (ahci(4), siis(4), mvs(4), ata(4) with `options ATA_CAM`). To make code more readable and extensible, this implementation follows modular design, including core part and two sets of modules, implementing support for different metadata formats and RAID levels.
Support for such popular metadata formats is now implemented: Intel, JMicron, NVIDIA, Promise (also used by AMD/ATI) and SiliconImage.
Such RAID levels are now supported: RAID0, RAID1, RAID1E, RAID10, SINGLE, CONCAT.
For any all of these RAID levels and metadata formats this class supports full cycle of volume operations: reading, writing, creation, deletion, disk removal and insertion, rebuilding, dirty shutdown detection and resynchronization, bad sector recovery, faulty disks tracking, hot-spare disks. For Intel and Promise formats there is support multiple volumes per disk set.
Look graid(8) manual page for additional details.
Co-authored by: imp Sponsored by: Cisco Systems, Inc. and iXsystems, Inc.
|