Fix misleading indentation warning:

libexec/rshd/rshd.c:442:5: error: misleading indentation; statement is not part of the previous 'else' [-Werror,-Wmisleading-indentation]
ioctl(pv[0], FIONBIO, (char *)&one);
^
libexec/rshd/rshd.c:440:4: note: previous statement is here
else
^

Direct commit to stable/11, since rshd has been removed from FreeBSD 12
and later.

MFC r320406:

A little tweak for performance

MFC r320433:

Use strlcpy() instead of strncpy() and nul-terminating.

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Add blacklist support to rshd

Reviewed by: rpaulo
Approved by: rpaulo
Relnotes: YES
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D6594

Remove LOG_ODELAY because it does nothing.

Reviewed by: jilles
CR: https://reviews.freebsd.org/D611

Remove the 3rd clause ("advertising clause") of the BSD license as
permitted by the University of Berkeley on July 22, 1999.

Reviewed by: imp
MFC after: 1 week

Fix a misplaced parenthesis.

PR: 162164
Submitted by: Henning Petersen <henning.petersen@t-online.de>
MFC after: 1 week

Spell SHUT_RDWR as SHUT_RDWR not 1+1 as the how argument to shutdown(2).

Use sysconf(_SC_ARG_MAX) instead of NCARGS.

Fix most cases where the address of an int is passed to a function expecting a
socklen_t * argument.

Sync program's usage() with manpage's SYNOPSIS.

Cast the terminating NULL to char * in the execl() call.

Submitted by: Stefan Farfeleder <stefan@fafoe.narf.at>

Gut out (by default unused) cruft, and tidy up warnings.

PAMify.

Sponsored by: DARPA, NAI Labs

YA patch I forgot to commit last night.

o const poison a few prototypes to avoid gcc3 warnings
o s/err/error/ in a couple places to avoid shadowing warnings

o __P removal
o new style definitions/declarations
o declare null_conv static and its arguments __unused

Mark a function as __printf0like(). This exposes a warning which requires
some code changes to fix but should be possible.

MFC after: 1 week

Fix the type of the NULL arg to execl()

Idea from: Theo de Raadt <deraadt@openbsd.org>

Replacement of the old error() routine with errx(3) was premature.
There are protocol issues to deal with.

Bring back this routine (renamed to avoid a library conflict in libssh)
and overhaul it for more 21st Century style coding.

Pointed out by: bde

Grrr. Fix a line that was fatfingered out during the cleanup.
Submitted by: bde
Pointy hat: markm

Clean up the error handling code a bit. There is no need to "roll our
own" error() routine when errx() is available. This resolves a conflict
when linking statically.

Add full PAM support for account management and sessions.

The PAM_FAIL_CHECK and PAM_END macros in su.c came from the util-linux
package's PAM patches to the BSD login.c

Submitted by: "David J. MacKenzie" <djm@web.us.uu.net>

Fix typo: compatability -> compatibility.

Compatability is not an existing english word.

Whitespace-only to sync with -stable.

Removed broken PAM support from rshd(8) and rlogind(8). rshd does
not allocate a pty(4) so it is not suitable at all for interactive
PAM modules. rlogind calls login(1) which is already PAM enabled.

Approved by: markm

Plug the hole where rshd would bypass a proper .rhosts check if the
password was empty.

Reviewed by: Warner Losh <imp@freebsd.org>

Remove dead debug code.
This also removes a dependency/reference on COMPAT_43.

sync iruserok() extension API with other BSDs

Some of rcmd related function is need to be updated to
support IPv6. Some of them are already updated as standard
document. But there is also several de-facto functions and
they are not listed in standard documents.
They are,

iruserok() (used by rlogind, rshd)
ruserok() (used by kerberos, etc)

KAME package updated those functions in original way.

iruserok_af()
ruserok_af()

But recently there was discussion on IETF IPng mailing
list about how to sync those API, and it is decided,

-Those function is not standard and not documented.
-But let BSDs sync their API as de-facto.

And after some discussion, it is announced that

-add update to iruserok() as iruserok_sa()
-no ruserok() API change(it is only updated internaly)

So I sync those API before 4.0 is released.
The changes are,
-prototype changes
-ruserok() internal update (use iruserok_sa() inside)
-removal of ruserok_af()
-change iruserok_af() as static functioin, and also prefix the name with __.
-add iruserok_sa() (Just call __iruserok_af() inside)
-adding flag AI_ALL to getipnodebyaddr() called from __icheckhost().
This is necessary to support IPv4 communication via AF_INET6 socket
could be correctly authenticated via iruserok_sa()
-irusreok_af() call is replaced to iruserok_sa() call
in rlogind, and rshd.

Approved by: jkh

Fix rshd coredump when AF_INET socket is used.

Confirmed by: F. Heinrichmeyer <fritz.heinrichmeyer@fernuni-hagen.de>

several tcp apps IPv6 update
-inetd
-rshd
-rlogind
-telnetd
-rsh
-rlogin

Reviewed by: freebsd-arch, cvs-committers
Obtained from: KAME project

Fix for new Kerberos4. Make a fist cut at PAM-ising while I'm here.

$Id$ -> $FreeBSD$

Ensure that things returned by gethostname() and
friends are terminated and allow for a maximum
host name length of MAXHOSTNAMELEN - 1.
Put parenthesis around sizeof args.
Make some variables static.
Fix telnetd -u (broken by my last commit)

Prompted by: bde

Use realhostname() rather than various combinations of
gethostbyaddr() & gethostbyname().

Remove brokeness in ftpd for hosts of MAXHOSTNAMELEN length.

As previously threatened, clean up the rshd -a option and make it default
on rshd and rlogind. However, note that:
1: rshd used to drop a connection with -a if the hostname != ip address.
This is unneeded, because iruserok() does it's own checking.
It was also wrong if .rhosts had an explicit IP address in it,
connections would be dropped from that host solely because the DNS was
mismatched even though it was explicitly intended to work by IP address.
2: rlogind and rshd check the hostname mappings by default now because that
is what goes into the utmp/wtmp and logs. If the hostname != ip address,
then it uses the IP address for logging/utmp/wtmp purposes. There isn't
much point logging ficticious hostnames.
3: rshd -a is now accepted (but ignored) for compatability. If you really
want to make life miserable for people with bad reverse DNS, use tcpd in
paranoid mode (which is questionable anyway, given DNS ttl tweaking).

Added a -D option to turn on TCP_NODELAY.

Replace _exit() with exit()
Pointed out by: Nathan Torkington <gnat@prometheus.frii.com> PR 5585

No \n in syslog() strings. Add man page to Xrefs. Change null byte to NUL byte.

Changes for the new KTH Kerberos4.
Also make -Wall a bit quieter

Rshd print to much information if a user does not exists.

login_getclass() -> login_getpwclass().

Added login.conf support.

Be a bit more careful about what port number we are using for the
second socket. If we're going to check for reserved ports, we should
do it properly.

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Revert $FreeBSD$ to $Id$

Some patches for source routed packets from OpenBSD.
Rev 1.13 deraadt:
do not warn about valid options; invalid options correctly quit
Rev 1.12 deraadt:
need not clear options since bad ones cause exit;
provos@ws1.physnet.uni-hamburg.de
Rev 1.11 deraadt:
IPOPT_LSRR/IPOPT_SSRR must exit() due to tcp sequencing; pointed
out by provos@wserver.physnet.uni-hamburg.de. also another 1-char
buffer overflow.

Reviewed by: Peter Wemm
Obtained from: OpenSBD

Make even more copies of hostnames obtained by inet_ntoa(). iruserok()
could still clobber the static storage, yielding an error message with
a wrong hostname.

Make the long-awaited change from $Id$ to $FreeBSD$

This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.

Fixes:

When an rsh is denied by rshd because the client is lacking appropriate
.rhosts permission, an error message is formatted for syslog which contains
the client's hostname. The hostname portion of the message relies on a pointer
to a field within gethostbyname()'s internal struct hostent which changes state
between when the pointer is initialized and when it is dereferenced to create th
e
message.

Submitted by: skynyrd@opus.cts.cwu.edu

add forgotten $Id$

Fix some compilation warnings.

#include <kerberosIV/des.h> -> #include <des.h>

Rename des_set_key -> des_set_key_krb. (libdes conflict)

Add missing & in des_set_key argument

Move the setlogin() call a little earlier.. It was being done in the child
process - which would be no longer allowed if the setlogin() changes go
through. Now the parent (the session leader, when started by inetd) does it.

Check for expired passwords before allowing access to the system.

This commit was generated by cvs2svn to compensate for changes in r1592,
which included commits to RCS files with non-trunk default branches.

BSD 4.4 Lite Libexec Sources