#
326782 |
|
11-Dec-2017 |
asomers |
MFC r304443, r326034, r326065
r304443 by imp: Improve the pattern matching so that internal *'s work, as well as [set] notation. This fixes pattern matching for recently added drives that would set the NCQ Trim being broken incorrectly.
PR: 210686 Tested-by: Tomoaki AOKI
r326034: Fix multiple bugs in cam_strmatch
* Wrongly matches strings that are shorter than the pattern * Fails to match negative character sets * Fails to match character sets that aren't at the end of the pattern * Fails to match character ranges
Reviewed by: imp Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D13173
r326065: Fix uninitialized variable from 326034
Reported by: Coverity CID: 1382887 X-MFC-With: 326034 Sponsored by: Spectra Logic Corp
|
#
315695 |
|
22-Mar-2017 |
ngie |
MFC r315320:
Start adding basic tests for cam(3)
This change contains several negative and positive tests for: - cam_open_device - cam_close_device - cam_getccb - cam_freeccb
This also contains a test for the failure case noted in bug 217649, i.e., O_RDWR must be specified because pass(4) requires it.
This test unfortunately cannot assume that cam-capable devices are present, so the user must explicitly provide a device via `test_suites.FreeBSD.cam_test_device`. In the future, a test kernel module might be shipped, or ctl(4) might be used, as a test device when testing out libcam, which will allow the tests to do away with having to specify an explicit test device. |
#
315320 |
|
15-Mar-2017 |
ngie |
Start adding basic tests for cam(3)
This change contains several negative and positive tests for: - cam_open_device - cam_close_device - cam_getccb - cam_freeccb
This also contains a test for the failure case noted in bug 217649, i.e., O_RDWR must be specified because pass(4) requires it.
This test unfortunately cannot assume that cam-capable devices are present, so the user must explicitly provide a device via `test_suites.FreeBSD.cam_test_device`. In the future, a test kernel module might be shipped, or ctl(4) might be used, as a test device when testing out libcam, which will allow the tests to do away with having to specify an explicit test device.
Reviewed by: asomers, ken (earlier diff) MFC after: 1 week Sponsored by: Dell EMC Isilon Differential Revision: D9928
|