#
359754 |
|
09-Apr-2020 |
kevans |
MFC -fno-common fixes: r359389, r359394, r359397-r359399, r359403-r359404, r359406, r359413-r359416, r359425, r359427, r359432-r359433, r359443, r359675-r359677
Note: this is not necessarily a complete fix to get these programs to build with -fno-common applied.
r359389: config(8): fixes for -fno-common
Move this handful of definitions into main.c, properly declare these as extern in config.h. This fixes the config(8) build with -fno-common.
Unexplained in my previous commit to gas, -fno-common will become the default in GCC10 and LLVM11, so it's worth addressing these in advance.
r359394: MFV r359393: tcsh: import 6974bc35a5cd
This removes an extra variable definition that causes the -fno-common build to fail, which will be a new default in GCC10/LLVM11.
r359397: zfs: fix -fno-common issues
A similar (or identical?) fix has already landed in OpenZFS.
-fno-common will become the default in GCC10/LLVM11.
r359398: sh: remove duplicate el definition
el is declared extern in myhistedit.h and defined in histedit.c. Remove the duplicate definition in input.c to appease the -fno-common build.
-fno-common will become the default in GCC10/LLVM11.
r359399: telnet: remove some duplicate definitions, mark terminaltype extern
Most of these were already properly declared and defined elsewhere, this is effectively just a minor cleanup that fixes the -fno-common build.
-fno-common will become the default in GCC10/LLVM11.
r359403: Revert 359399: telnet -fno-common bits
There was a large misfire from my local diff that I need to investigate, and this version committed did not build.
r359404: Re-apply r359399: telnet -fno-common fix
line and auth_level's redefinitions are just extraneous
telnetd will #define extern and then include ext.h to allocate storage for all of these extern'd vars; however, two of them are actually defined in libtelnet instead. Instead of doing an #ifdef extern dance around those function pointers, just add an EXTERN macro to make it easier to differentiate by sight which ones will get allocated in globals.c and which ones are defined elsewhere.
r359406: telnet: kill off remaining duplicate definition
r359413: ipfilter: remove duplicate definition of 'thishost'
thishost is already defined in lib/initparse.c; no need for this one. This fixes the ipfilter build with -fno-common.
-fno-common will become the default in GCC10/LLVM11.
r359414: iscontrol: move definition of vflag/iscsidev to iscontrol.c
Mark the declaration extern as these are used elsewhere; this fixes the build with -fno-common.
r359415: userboot: mark host_fsops as extern
This is already defined elsewhere; mark this declaration extern to the fix the -fno-common build.
r359416: systat: remove redundant definition of kd
kd is already properly declared in extern.h and defined in main.c, rendering this definition useless. This fixes the -fno-common build.
r359425: locate: fix -fno-common build
Just a single variable declaration to extern and define elsewhere here, myctype.
-fno-common will become a default in GCC10/LLVM11.
r359427: fsck_ffs/fsdb: fix -fno-common build
This one is also a small list:
- 3x duplicate definition (ufs2_zino, returntosingle, nflag) - 5x 'needs extern', 3/5 of which are referenced in fsdb
-fno-common will become the default in GCC10/LLVM11.
r359432: gdb: compile with -fcommon explicitly
As described in the comment, gdb relies on some of the linker magic that happens with -fcommon. I suspect the life expectancy of gdb-in-base is low enough that this isn't worth spending much time addressing, especially given the vintage. Hit it with the -fcommon hammer so that it continues to just work.
r359433: bmake: fix -fno-common build
debug was declared extern, but debug_file was not; correct this and define debug_file in main.c (as debug is) to fix the -fno-common build.
-fno-common will become the default with GCC10/LLVM11.
r359443: MFV r359442: bmake: import -fno-common fix build back from upstream
sjg@ committed the local patch previously committed upstream; pull it in to vendor/ to ease any potential stress of future imports.
r359675: kqueue tests: fix -fno-common build
vnode_fd and kqfd are both shared among multiple CU; define them exactly once.
In the case of vnode_fd, it was simply the declaration that needed correction.
-fno-common will become the default in GCC10/LLVM11.
r359676: ntpd: fix build with -fno-common
Only a small nit here: psl should be declared extern and defined exactly once.
-fno-common will become the default in GCC10/LLVM11.
r359677: yp*: fix -fno-common build
This is mostly two problems spread out far and wide: - ypldap_process should be declared properly - debug is defined differently in many programs
For the latter, just extern it and define it everywhere that actually needs it. This mostly works out nicely for ^/libexec/ypxfr, which can remove the assignment at the beginning of main in favor of defining it properly.
-fno-common will become the default in GCC10/LLVM11.
|
#
351433 |
|
23-Aug-2019 |
emaste |
MFC r331074 (cem): telnetd(8): Fix dereference of uninitialized value 'IF'
Reported by: Coverity
|
#
351432 |
|
23-Aug-2019 |
emaste |
MFC r351070: telnet: remove 3rd clause from Berkeley copyrights
Per the July 22, 1999 letter (in /COPYRIGHT) from William Hoskins Director, Office of Technology Licensing University of California, Berkeley
|
#
302408 |
|
07-Jul-2016 |
gjb |
Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle. Prune svn:mergeinfo from the new branch, as nothing has been merged here.
Additional commits post-branch will follow.
Approved by: re (implicit) Sponsored by: The FreeBSD Foundation |
#
262679 |
|
02-Mar-2014 |
marcel |
Improve upon previous commit: 1. Check return of mmap(2) (*) 2. Avoid FD leak when fstat fails. 3. Fix style(9).
(*) Pointed out by jmg@
|
#
262673 |
|
01-Mar-2014 |
marcel |
Revive support for /etc/issue, lost due revision 81963.
Obtained from: Juniper Networks, Inc.
|
#
202214 |
|
13-Jan-2010 |
ed |
Forgot a part that was missing in the previous commit.
There is no need to call trimdomain() anymore now that ut_host is big enough to fit decent hostnames.
|
#
202212 |
|
13-Jan-2010 |
ed |
Let telnetd build without utmp and logwtmp(3).
Just like rlogind, there is no need to change the ownership of the terminal during shutdown anymore. Also don't call logwtmp, because the login(1)/PAM is responsible for doing this. Also use SHUT_RDWR instead of 2.
|
#
180931 |
|
28-Jul-2008 |
jhb |
Don't attempt authentication at all if it has been disabled via '-a off'. This works around a bug in HP-UX's telnet client and also gives a much saner user experience when using FreeBSD's telnet client.
PR: bin/19405 Submitted by: Joel Ray Holveck joelh of gnu.org MFC after: 1 month
|
#
162671 |
|
26-Sep-2006 |
ru |
Remove bogus casts of valid integer ioctl() arguments.
|
#
146468 |
|
21-May-2005 |
ume |
NI_WITHSCOPEID cleanup
|
#
139937 |
|
09-Jan-2005 |
maxim |
o Make telnet[d] -S (IP TOS) flag really work. We do not have /etc/iptos implementation so only numeric values supported.
o telnetd.8: steal the -S flag description from telnet.1, bump the date of the document.
MFC after: 6 weeks
|
#
139713 |
|
05-Jan-2005 |
maxim |
o Add -4 and -6 flags to a man page and usage(). Bump the man page date.
|
#
118866 |
|
13-Aug-2003 |
harti |
Forced commit to record the PR for the previous commit.
Remembered by: maxim
PR: bin/45967
|
#
118865 |
|
13-Aug-2003 |
harti |
Implement what has been documented for a long time: make -debug switch on socket debugging.
Okay'ed by: markm
|
#
114911 |
|
11-May-2003 |
markm |
Fix up external variables named "debug" that have a horrible habit of conflicting with other, similarly named functions in static libraries. This is done mostly by renaming the var if it is shared amongst modules, or making it static otherwise.
OK'ed by: re(scottl)
|
#
114630 |
|
04-May-2003 |
obrien |
Use __FBSDID vs. rcsid[]. Also protect sccs[] and copyright[] from GCC 3.3.
|
#
87155 |
|
30-Nov-2001 |
markm |
Damn. The previous mega-commit was incomplete WRT ANSIfication. This fixes that.
|
#
87139 |
|
30-Nov-2001 |
markm |
Very large style makeover.
1) ANSIfy. 2) Clean up ifdefs so that a) ones that never/always apply are appropriately either fully removed, or just the #if junk is removed. b) change #if defined(FOO) for appropiate values of FOO. (currently AUTHENTICATION and ENCRYPTION) 3) WARNS=2 fixing 4) GC other unused stuff
This code can now be unifdef(1)ed to make non-crypto telnet.
|
#
82497 |
|
29-Aug-2001 |
markm |
Manually unifdef(1) CRAY, UNICOS, hpux and sun uselsess code.
|
#
81965 |
|
20-Aug-2001 |
markm |
Code merge and diff reduce with "base" telnet. This is the "later" telnet, so it was treated as the reference code, except where later commits were made to "base" telnet.
|
#
80224 |
|
23-Jul-2001 |
kris |
output_data(), output_datalen() and netflush() didn't actually guarantee to do what they are supposed to: under some circumstances output data would be truncated, or the buffer would not actually be flushed (possibly leading to overflows when the caller assumes the operation succeeded). Change the semantics so that these functions ensure they complete the operation before returning.
Comment out diagnostic code enabled by '-D reports' which causes an infinite recursion and an eventual crash.
Patch developed with assistance from ru and assar.
|
#
79981 |
|
19-Jul-2001 |
ru |
Fixed the exploitable remote buffer overflow.
Reported on: bugtraq Obtained from: Heimdal, NetBSD Reviewed by: obrien, imp
|
#
72083 |
|
06-Feb-2001 |
asmodai |
Fix typo: wierd -> weird.
There is no such thing as wierd in the english language.
|
#
69387 |
|
30-Nov-2000 |
asmodai |
String paranoia fix. Synched from normal telnet.
|
#
69223 |
|
26-Nov-2000 |
kris |
Correct definition of MAXHOSTNAMELEN in ifdef'ed code.
Submitted by: Edwin Groothuis <mavetju@chello.nl> PR: bin/22787
|
#
63249 |
|
16-Jul-2000 |
peter |
Forced commit. This is to try and help folks that used the international crypto repo and have slightly different files but with the same version. cvsup in 'checkout mode' has no trouble with this, but cvs can get really silly about it.
|
#
56668 |
|
27-Jan-2000 |
shin |
another tcp apps IPv6 updates.(should be make world safe) ftp, telnet, ftpd, faithd also telnet related sync with crypto, secure, kerberosIV
Obtained from: KAME project
|
#
50479 |
|
27-Aug-1999 |
peter |
$Id$ -> $FreeBSD$
|
#
45493 |
|
08-Apr-1999 |
brian |
MF libexec/telnetd: Determine the host name using an array size of MAXHOSTNAMELEN and call trimdomain() before implementing the -u option.
|
#
45428 |
|
07-Apr-1999 |
brian |
MF libexec/telnetd: MAXHOSTNAMELEN & -u fixes.
|
#
45395 |
|
06-Apr-1999 |
brian |
Use realhostname().
|
#
45377 |
|
06-Apr-1999 |
brian |
MF src/libexec/telnetd: Verify the reverse DNS lookup ala rlogind. Suggested by: markm
|
#
41858 |
|
16-Dec-1998 |
peter |
Old stuff laying around: Don't use getstr which can conflict with some curses/termcap/terminfo implementations and causes recursion.
|
#
31622 |
|
08-Dec-1997 |
charnier |
MFC: no \n in syslog strings. Change -P to -p in flags. EOF -> -1. Use err(3).
|
#
30212 |
|
08-Oct-1997 |
uhclem |
PR: bin/771 and bin/1037 are resolved by this change This change changes the default handling of linemode so that older and/or stupider telnet clients can still get wakeup characters like <ESC> and <CTRL>D to work correctly multiple times on the same line, as in csh "set filec" operations. It also causes CR and LF characters to be read by apps in certain terminal modes consistently, as opposed to returning CR sometimes and LF sometimes, which broke existing apps. The change was shown to fix the problem demonstrated in the FreeBSD telnet client, along with the telnet client in Solaris, SCO, Windows '95 & NT, DEC OSF, NCSA, and others.
A similar change was incorporated in the non-crypto version of telnetd.
This resolves bin/771 and bin/1037.
|
#
29181 |
|
07-Sep-1997 |
markm |
Bring the FreeBSD changes to the virgin sources.
|
#
29089 |
|
04-Sep-1997 |
markm |
This commit was generated by cvs2svn to compensate for changes in r29088, which included commits to RCS files with non-trunk default branches.
|
#
29088 |
|
04-Sep-1997 |
markm |
Initial import of BSD telnet. This will be used to build the kerberised telnet, and after userland diffs have been merged in, will be used to build the non-kerberised sources as well. (See unifdef(1) for details)
|