Fixed build after r356566 (MFC of r356317).

This is a direct change.

MFC r356317 (by arrowd):

mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters.

PR: 231656
Approved by: bapt
Differential Revision: https://reviews.freebsd.org/D22289

MFC r335641:

Fix a stack overflow in mount_smbfs when hostname is too long.

The local hostname was blindly copied into the to the nn_name array.
When the hostname exceeded 16 bytes, it would overflow. Truncate the
hostname to 15 bytes plus a 0 terminator which is the "workstation name"
suffix.

Use defensive strlcpy() when filling nn_name in all cases.

PR: 228354
Reported by: donald.buchholz@intel.com
Reviewed by: jpaetzel, ian (prior version)
Discussed with: Security Officer (gtetlow)
Security: Stack overflow with the hostname.
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D15936

MFC 319670

Fix SMBFS when saved passwords are greater than 18 character

PR: 132302
Submitted by: dhorn2000@gmail.com guru@unixarea.de
Approved by: re (gjb)

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Avoid unaligned memory accesses when encoding netbios names in libsmb.

The current code for encoding a netbios name converts each byte to a 16-bit
value and stores the result by casting a char* to u_short*, resulting in
alignment faults on strict-alignment platforms.

This change reimplements the encoding routine using only byte accesses to
memory. There is no particular reason to work with 16-bit values just
because the encoding process creates two bytes of output for every byte of
input. Working a byte at at time also avoids endian problems for big-endian
platforms.

PR: 180438
PR: 189415
Differential Revision: https://reviews.freebsd.org/D4622

Remove the const qualifier from iconv(3) to comply with POSIX:
http://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.html

Adjust all code that calls iconv.

PR: 199099
Exp-run by: antoine
MFC after: 2 weeks

Make it possible to use empty user name ("-U ''") for mount_smbfs(8).
It's just like "-U guest", except that it actually works, at least
with Samba 4, which seems to return authentication failure for "-U guest".

MFC after: 1 month
Sponsored by: The FreeBSD Foundation

Just disable recoding support in libsmb if built WITHOUT_ICONV.

Use system libiconv, instead of trying to dlopen() it.

PR: 183153
Submitted by: Dominic Fandrey <kamikaze bsdforen.de>

Completely rewrite the interface to smbdev switching from dev_clone
to cdevpriv(9). This commit changes the semantic of mount_smbfs
in userland as well, which now passes file descriptor in order to
to mount a specific filesystem istance.

Reviewed by: attilio, ed
Tested by: martymac

When encoding an smb name, truncate one byte earlier in order than we did
previously in order to ensure it fit properly in the bufer when encoded.
This prevents a debugging printf from firing if a source or destination
host name for an smb mount exceeds 15 characters.

MFC after: 3 days
Obtained from: Apple, Inc.

Allow user to override default port numbers used by communication
protocols. This is very useful for tunneled SMB connections.

MFC after: 4 weeks

Remove macros
htole{s,l,q}, letoh{s,l,q}, htobe{s,l,q}, betoh{s,l,q}
and replace it with more standard byteorder macros in our system.

- Fix checking range of strings of struct iconv_add_in in libsmb and libkiconv,
- Add checking range of strings to iconv_sysctl_add().

Submitted by: Rudolf Cejka

Tell nls_setlocale() the very locale name from command line option,
rather than using optarg variable which would be allways NULL.

Correct argument order of kiconv_add_xlat16_cspairs().

Security:

Make smbfs capable to use 16bit char set in filenames.

PR:78110

+ Get prototypes for libc functions.
+ Use the correct printf format for size_t.

Size matters. Correctly use a size_t so 64-bit hosts can mount SMB FS's
when using character set conversions.
Also include POSIX <string.h> vs. BSD <strings.h> now that we've broken
traditional BSD behavior [and compatibility with our BSD brethren].

PR: 72445
Submitted by: Vladimir Nechitailo <nechit@lpi.ru>
Patch by: Stasys Smailys <ssmailys@komvista.lt>

Do not use casts as lvalues.

Fine-tune the last change even more and use the return value as error
indicator, as it is expected.

Spotted by: Christoph Mallon <christoph.mallon@gmx.de>

Don't return NULL when the function is defined to return an integer.

OK'ed by: tjr

Merge from NetBSD rev. 1.3 (drochner): Use getifaddrs(3) instead of
SIOCGIFCONF.

Merge from NetBSD rev. 1.2 (drochner): Do the address calculations inside
the data delivered by SIOCGIFCONF correctly (this isn't a plain array!),
and sort the checks a bit to avoid duplicates in the interface list.

Fix some off-by-one errors dealing with limits of server names,
usernames, workgroup names and passwords. We can now connect to
servers with 15-character NetBIOS names. (Some versions of Windows
use semi-random 15-char names by default.)

PR: 46902

Fixes for 64 bit cleanliness. The length arg to sysctl is a pointer to
size_t not int.

Reviewed by: bp

Use #include <string.h> rather than <strings.h> so that the strdup()
prototype gets brought into scope. This is a big deal for 64 bit
systems where the default return value of 'int' is != pointer.

Reviewed by: bp

Fix a typo in the -O parsing code that caused a crash when the -O option
is used without supplying "sowner:sgroup".

Obtained from: NetBSD (jdolecek)
PR: 37171

This commit was generated by cvs2svn to compensate for changes in r100490,
which included commits to RCS files with non-trunk default branches.

This commit was generated by cvs2svn to compensate for changes in r95267,
which included commits to RCS files with non-trunk default branches.

This commit was generated by cvs2svn to compensate for changes in r88492,
which included commits to RCS files with non-trunk default branches.

This commit was generated by cvs2svn to compensate for changes in r88282,
which included commits to RCS files with non-trunk default branches.

This commit was generated by cvs2svn to compensate for changes in r87866,
which included commits to RCS files with non-trunk default branches.