#
296373 |
|
04-Mar-2016 |
marius |
- Copy stable/10@296371 to releng/10.3 in preparation for 10.3-RC1 builds. - Update newvers.sh to reflect RC1. - Update __FreeBSD_version to reflect 10.3. - Update default pkg(8) configuration to use the quarterly branch.
Approved by: re (implicit) |
#
293684 |
|
11-Jan-2016 |
bapt |
MFC: r290153 (by bdrewery)
Fix unlikely memory leak.
It is unlikely since the first check in the function is that dir[0] is '/', but later code changes may make it real.
Coverity CID: 1332104
|
#
293682 |
|
11-Jan-2016 |
bapt |
MFC: 278899
Regression: fix usershow -7
|
#
292026 |
|
09-Dec-2015 |
bapt |
MFC: r291658
pw_checkname since the beginning is too strict on GECOS field, relax it a bit so gecos can be used to store multibytes data.
This was unseen before FreeBSD 10.2 as this validation function was motly unused since FreeBSD 10.2 the usage of this function has been generalized to improve
Reported by: des
|
#
292025 |
|
09-Dec-2015 |
bapt |
MFC: r291657
Fix handling of numeric-only names with pw lock Add a regression test about it
PR: 204968
|
#
290854 |
|
15-Nov-2015 |
delphij |
MFC r290174:
In pw_userlock, set 'name' to NULL when we encounter an all number string because it is also used as an indicator of whether a name or an UID is being used and we may have undefined results as 'name' may contain uninitialized stack contents.
|
#
287769 |
|
14-Sep-2015 |
bapt |
MFC: r287701
Regression: fix pw usermod -d
Mark the user has having been edited if -d option is passed to usermod and so the request change of home directory actually happen
PR: 203052 Reported by: lenzi.sergio@gmail.com
|
#
287084 |
|
23-Aug-2015 |
bapt |
MFC: r285133,r285136,r285137,r285156,r285157,r285158,r285256,r285318,r285395, r285396,r285398,r285401,r285403,r285405,r285406,r285408,r285409,r285411, r285412,r285413,r285415,r285418,r285430,r285433,r285434,r285442,r285948, r285984,r285985,r285989,r285996,r285997,r286045,r286047,r286066,r286150, r286151,r286152,r286154,r286155,r286156,r286157,r286173,r286196,r286197, r286198,r286199,r286200,r286201,r286202,r286203,r286204,r286210,r286211, r286217,r286218,r286258,r286259,r286341,r286775,r286982,r286986,r286991, r286993
Validate most pw inputs. Rewrite the way parsing sub arguments is made to simplify code and improve maintenability Add -y (NIS) to userdel/usermod pw userdel -r <rootdir> now deletes directories in the rootdir Only parse pw.conf when needed Reject usermod and userdel if the user concerned is not on the user database supposed to be manipulated
|
#
286340 |
|
05-Aug-2015 |
bapt |
Fix segfault were modifying the uid of a user
Do a direct commit as the code on head has changed a lot and does not fail in that case
PR: 202111 Reported by: gondim@bsdinfo.com.br
|
#
285536 |
|
14-Jul-2015 |
bapt |
MFC: r285414, r285440, r285441, r285443
- allow to create users with uid 0 - fix check duplicates logic - fix gid policy to be in sync with uid if possible
Reported by: Jan Mikkelsen <janm@transactionware.com> Approved by: re (marius)
|
#
285092 |
|
03-Jul-2015 |
bapt |
MFC: r274011,r274022,r274453,r274542,r274632,r274727,r275653,r275656,r275657, r275658,r275829,r277652,r277764,r278475,r278767,r278819,r278902,r279256, r282681,r282683,r282685,r282686,r282687,r282697,r282698,r282699,r282700, r282709,r282712,r282713,r282716,r282718,r282719,r282720,r282721,r283809, r283810,r283811,r283814,r283815,r283816,r283818,r283841,r283842,r283843, r283961,r283962,r284110,r284111,r284112,r284113,r284114,r284117,r284118, r284119,r284120,r284121,r284122,r284123,r284124,r284126,r284128,r284129, r284130,r284133,r284135,r284137,r284139,r284140,r284148,r284149,r284392
Lots of cleanup in the pw(8) code Add pw -R <rootdir> Add lots of regression tests More accurate error messages
Approved by: re (kib) Sponsored by: gandi.net
|
#
274082 |
|
04-Nov-2014 |
bapt |
MFC: 272445,272578,273772,273779,273782,273786,273787,273791
Add a test for bug 191427 where pw(8) will go into an infinite loop Add some tests for modifying groups When a group is renamed then the group has been invalidated for sure. In that case get the group information using the new name.
Fix a regression in pw usermod -G list
The user was perperly adding the to different groups from "list" but was not removed from the other groups it could have belong to.
Do not delete the group wheel when bad argument is passed to pw groupdel -g
Check that the -g argument is actually a number, if not report an error. This argument is converted without checking with atoi(3) later so without this check it converts any alpha entries into 0 meaning it deletes the group wheel
Ensure pw userdel -u <invalid> do not try to remove root
Check the uid passed is actually a number as early as possible
Fix renaming a group via the gr_copy function
Add a regression test to pw(8) because the bug was discovered via using: pw groupmod
PR: 193704 [1], 185666 [2], 90114 [3], 187189 [4] Submitted by: Marc de la Gueronniere [4] Reported by: az [1], sub.mesa@gmail.com [2], bkoenig@cs.tu-berlin.de [3], mcdouga9@egr.msu.edu [4]
|
#
273043 |
|
13-Oct-2014 |
des |
MFH (r272830): change the hardcoded default back to DES MFH (r272833): remove last vestige of MD5 password hashes
|
#
272192 |
|
26-Sep-2014 |
dteske |
MFC revisions 262864-262865, 263114, 267970: r262864: Stop pw(8) from segfaulting when given certain input (julian) r262865: Part 2 of bug 187310 (julian) r263114: Fix pw(8) edge-case deletion of group "username" on userdel r267970: Fix infinite-loop during deletion of users from groups
PR: 187310, 169471, 191427 Submitted by: Voradesh Yenbut, Alexander Pyhalov, Kim Shrier Obtained from: bug Approved by: re (gjb)
|
#
256281 |
|
10-Oct-2013 |
gjb |
Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.
Approved by: re (implicit) Sponsored by: The FreeBSD Foundation
|
#
252688 |
|
04-Jul-2013 |
des |
Fall back to sha512 if passwd_format is not set.
MFC after: 3 days
|
#
252556 |
|
03-Jul-2013 |
des |
There is no reason to disallow setting the password or account expiry date to the current date.
MFC after: 3 days
|
#
252377 |
|
29-Jun-2013 |
kientzle |
Fix -Wunsequenced warning
Submitted by: dt71@gmx.com
|
#
246192 |
|
01-Feb-2013 |
deischen |
Prevent a null pointer dereference in pw userdel when deleting a user whose group != username.
|
#
245114 |
|
06-Jan-2013 |
mjg |
pw: free group returned by gr_add
|
#
244737 |
|
27-Dec-2012 |
bapt |
Simplify the code by using the new gr_add function
|
#
244721 |
|
26-Dec-2012 |
bapt |
Simplify copying of group members by using memcpy
Submitted by: Christoph Mallon <christoph.mallon@gmx.de>
|
#
244720 |
|
26-Dec-2012 |
bapt |
Fix off-by-one error in memory allocation: j entries, one new and a null terminator is j + 2.
Submitted by: Christoph Mallon <christoph.mallon@gmx.de>
|
#
244710 |
|
26-Dec-2012 |
bapt |
Fix creating a user and adding it to a group
Reported by: "Sam Fourman Jr." <sfourman@gmail.com>, dim
|
#
243895 |
|
05-Dec-2012 |
eadler |
Avoid overflow of file buffer
Submitted by: db Approved by: cperciva MFC after: 2 weeks
|
#
242349 |
|
30-Oct-2012 |
bapt |
Teach pw(8) about how to use pw/gr API to reduce code duplication
MFC after: 2 months
|
#
241108 |
|
01-Oct-2012 |
bapt |
Do not treat empty name as an uid 0
Reported by: Robert Bonomi <bonomi@mail.r-bonomi.com>
|
#
241107 |
|
01-Oct-2012 |
bapt |
Remove useless atoi(3), previous strspn(3) makes sure that a_name->val is a number. This also allow pw user show to work as expected.
PR: bin/172112 Submitted by: "Ilya A. Arkhipov" <rum1cro@yandex.ru> MFC after: 1 month
|
#
231994 |
|
22-Feb-2012 |
kevlo |
Handle NULL return from crypt(3). Mostly from DragonFly
|
#
228673 |
|
17-Dec-2011 |
dim |
In usr.sbin/pw/pw_user.c, use the correct printf length modifier for a ptrdiff_t.
MFC after: 1 week
|
#
224535 |
|
31-Jul-2011 |
delphij |
Backout r223115 which potentially caused a POLA violation, by restoring historic behavior (create the default base directory in pw.conf) before I came up with a better fix for this.
Requested by: nwhitehorn Approved by: re (kib)
|
#
223115 |
|
15-Jun-2011 |
delphij |
Don't attempt to create the base directory when -d is specified.
MFC after: 1 month
|
#
219408 |
|
08-Mar-2011 |
jkim |
Stop hard-coding default directory mode as 0777.
|
#
218293 |
|
04-Feb-2011 |
jkim |
Do not let pw.conf(5) or -M option affect creation of basehome, e.g., /home. When the basehome does not exist, it creates all intermediate directories as required, which is logically equivalent to mkdir(1) with -m and -p options. However, it modifies all intermediate directories, not just the final home directory unlike mkdir. This problem was introduced in two revisions, i.e., r1.59 (SVN r167919) and r1.60 (SVN r168044).
MFC after: 1 month
|
#
213459 |
|
05-Oct-2010 |
jkim |
Revert the unrelated patch crept in the previous commit.
|
#
213458 |
|
05-Oct-2010 |
jkim |
Prefer pmap_unmapbios() over pmap_unmapdev(). The binary does not change after this because pmap_unmapbios() is a macro for pmap_unmapdev() on amd64.
|
#
200173 |
|
06-Dec-2009 |
ed |
Make pw(8) build without <utmp.h>.
The size of the username record in utmp files should not influence the maximum username length. Right now ut_user/ut_name is big enough, so in this case it's dead code anyway.
|
#
181785 |
|
16-Aug-2008 |
ache |
Use arc4random_uniform() to avoid "modulo bias"
Remove pw_getrand() unneded now: arc4random_uniform() is stronger then pw_getrand()'s MD5 tricks (inactive) and its active version, mixing arc4random() bytes in one, not make things better at all.
|
#
179365 |
|
27-May-2008 |
antoine |
- Increase the size of the salt in pw(8) from 8 to 32 (same as in pam_unix(8)). This makes blowfish password hashes look normal when set using pw(8)/adduser(8). [1] - Make it possible to have a '/' in the salt.
PR: 121146 [1] Submitted by: Jaakko Heinonen [1] Approved by: rwatson (mentor) MFC after: 1 month
|
#
168045 |
|
30-Mar-2007 |
le |
Accept passwords which contain whitespace.
PR: bin/53434
|
#
168044 |
|
30-Mar-2007 |
le |
Add home directory creation mode to pw.conf(5) and be a bit more specific about the effect of the current umask on -M.
|
#
167919 |
|
26-Mar-2007 |
le |
Introduce the new option -M to allow to set the permissions of the user's newly created home directory. If omitted, it's derived from the current umask.
PR: bin/16880, bin/83253 (partially), bin/104248 MFC in: 1 month
|
#
148584 |
|
31-Jul-2005 |
pjd |
Change /home symbolic link, so it will point to usr/home instead of /usr/home.
Previous symlink was confusing:
# cd /jails/virtual_system_1/home # realpath . /usr/home
...and slower.
OK'ed by: rwatson, phk
|
#
130633 |
|
17-Jun-2004 |
robert |
Use strlcpy(3) to replace the idiomatic
strncpy(d, s, l); d[l - 1] = '\0';
statements.
|
#
130629 |
|
17-Jun-2004 |
robert |
Fix a bug which occurred when the home directory given by the -d option was equal to the one already saved and which caused the pw utility to avoid updating values passed by other options processed before the -d option in the code path.
Spotted by: Richard Caley <rjc@interactive.co.uk>
|
#
124382 |
|
11-Jan-2004 |
iedowse |
Add a `-H <fd>' option that is like `-h <fd>', but accepts an already encrypted password on the specified file descriptor.
PR: bin/22033 MFC after: 2 weeks
|
#
110667 |
|
11-Feb-2003 |
ache |
There is no sense to use random random() and arc4random() in the same program. Switch to arc4random() completely.
|
#
109961 |
|
28-Jan-2003 |
gad |
Changes so the 'pw' command will allow '$' as the last character in a userid or group name (mainly for the benefit of samba). This pretty much rewrites he pw_checkname() routine, but should work exactly the same except for the above change, and that error messages are somewhat more informative.
PR: 28733 46890 Inspired by: example patch written by Terry Lambert Reviewed by: no objections on freebsd-arch and freebsd-current MFC plans: no plans, but will do if people want it in stable.
|
#
98744 |
|
24-Jun-2002 |
dwmalone |
Print a long with %ld not %d. (We possibly should be using %j here, but that can be fixed when the many other warnings here are being fixed.)
PR: 39741 Submitted by: Dan Lukes <dan@obluda.cz> MFC after: 1 week
|
#
85145 |
|
19-Oct-2001 |
ache |
Change rmskey() to rmopie() - we don't have skey anymore
|
#
82868 |
|
03-Sep-2001 |
dd |
For new users, create the home directory before sending the welcome mail, if configured to do so. Some sites have setups where the user's mail is delivered to their home directory, so sending mail before is exists didn't work.
PR: 29892
|
#
82059 |
|
21-Aug-2001 |
joerg |
Properly initialize the random number generator in pw_getpass(). Right now, the automatically generated passwords have been rather predictable. :-(
MFC after: 1 day
|
#
82047 |
|
21-Aug-2001 |
joerg |
Fix a typo in a variable name that made pw(8) coredump when using USE_MD5RAND.
MFC after: 2 days
|
#
74569 |
|
21-Mar-2001 |
ache |
Use %c for expire/change dates
|
#
73563 |
|
05-Mar-2001 |
kris |
Switch from using rand() or random() to a stronger, more appropriate PRNG (random() or arc4random())
Reviewed by: bde
|
#
70486 |
|
29-Dec-2000 |
ben |
Convert to use the <sys/queue.h> macros rather than fiddling with the queue structure internals.
Reviewed by: markm
|
#
64918 |
|
22-Aug-2000 |
green |
Add working and easy crypt(3)-switching. Yes, we need a whole new API for crypt(3) by now. In any case:
Add crypt_set_format(3) + documentation to -lcrypt. Add login_setcryptfmt(3) + documentation to -lutil. Support for switching crypt formats in passwd(8). Support for switching crypt formats in pw(8).
The simple synopsis is: edit login.conf; add a passwd_format field set to "des" or "md5"; go nuts :)
Reviewed by: peter
|
#
63600 |
|
20-Jul-2000 |
davidn |
Move test for -w flag outside of the code dealing with -D (defaults). This should cause -w's argument not to be ignored in the usermod case, so it will affect modification of the user's password instead of using the pw.conf (or internal default=no '*') password method. PR: bin/11168
|
#
63596 |
|
20-Jul-2000 |
davidn |
Allow -g with an empty argument in the -D case. This allows -g "" to set no default group (and thus fall back to user-based groups instead). PR: bin/5717
|
#
63572 |
|
20-Jul-2000 |
davidn |
Fix another missed case where usermod would not set the "modified" flag: -h - to set no password. But only mark modified if the account is not already locked (i.e. first char of crypt password field is '*'). PR: bin/19999
|
#
62461 |
|
03-Jul-2000 |
davidn |
Fix breakage introduced by bypassing update for additional 'mod' functionality when nothing had actually changed; -d changes would not set the 'something had changed flag'. Actually test for a change in homedir. PR: bin/19649
|
#
62034 |
|
24-Jun-2000 |
ache |
Localize ctype too. Add weekday to showuser expired fields
|
#
61957 |
|
22-Jun-2000 |
ache |
Localize time/date. Use ISO 8601 date in logs. Fix wrong argument type in ctype functions.
|
#
61762 |
|
18-Jun-2000 |
davidn |
Fix obvious braino in assignment statement. usermod -g should work again. PR: 17877 Submitted by: pius@zyan.com
|
#
61759 |
|
18-Jun-2000 |
davidn |
Fix a long-standing bug in the rename case previously masked by another bug just fixed in .db file updating.
|
#
56000 |
|
15-Jan-2000 |
davidn |
Portability fixes for other bsd4.4 derivatives.
|
#
52527 |
|
26-Oct-1999 |
davidn |
Don't try updating the passwd file if no data has changed. This allows things like "pw usermod <name> -m" to work for non-local NIS users; since no attempt is made to update the password entry, the home directory will be created and populated as expected without error.
|
#
52512 |
|
26-Oct-1999 |
davidn |
Add new functionality "lock" and "unlock" to provide a simple password locking mechanism for users. This works by prepending the string "*LOCKED*" to the password field in master.passwd to prevent successful decoding.
|
#
52502 |
|
26-Oct-1999 |
davidn |
Clean up error handling in fileupdate(), which now returns 0 on success instead of a boolean. This replicated through he front-end sub-functions relating to add, delete, modify entries in passwd & group files Errno is now preserved so output of errc()/warnc() will be less obfuscated by subsequent errors when reporting the problem.
Add more intelligent error handling when attempting to modify/delete NIS entries with no corresponding local database entry.
[MFC to stable in a couple of weeks to keep both in sync]
|
#
50479 |
|
28-Aug-1999 |
peter |
$Id$ -> $FreeBSD$
|
#
49171 |
|
28-Jul-1999 |
davidn |
Remove some more warnings.
|
#
44386 |
|
02-Mar-1999 |
davidn |
Add the ability to print user records in unix version 7 (old) format.
|
#
44229 |
|
23-Feb-1999 |
davidn |
1) Do not blindly ignore file update errors which may occur due to concurrent updating 2) Add -V <etcdir>, which allows maintaining user/group database in alternate locations other than /etc.
|
#
43780 |
|
08-Feb-1999 |
des |
Don't assume a_name is a number just because the first character is a digit.
PR: bin/9484 Submitted by: Matthew D. Fuller <fullermd@futuresouth.com>
|
#
42287 |
|
04-Jan-1999 |
billf |
-Clarification of last commit- The char that the random letters and numbers are being pulled from is ended with a '\0'. Using sizeof() includes this '\0' in the 'pool' of possible characters. This patch decrements by one the size so we don't accidently end the new password prematurly.
|
#
42245 |
|
02-Jan-1999 |
billf |
Let's make sure we're at the end of the password string before we apply a \0 and terminate it. This patch ensures passwords will be the correct length of 8, which is what is implied in the source (but not reflected in the man page).
PR: bin/7817 Reviewed by: Alfred Perlstein <bright@hotjobs.com> Submitted by: Hiroshi Nishikawa <nis@pluto.dti.ne.jp>
|
#
30259 |
|
10-Oct-1997 |
charnier |
Use err(3) instead of local redefinition. Add rcsid string.
|
#
27831 |
|
01-Aug-1997 |
davidn |
Fix -p switch.
|
#
26626 |
|
14-Jun-1997 |
ache |
Remove srandomdev fallback code
|
#
26088 |
|
24-May-1997 |
davidn |
Fixes skeleton directory test-it-is-a-directory logic. PR: 3666 Reviewed by: Submitted by: iaint@css.tuu.utas.edu.au Obtained from:
|
#
24214 |
|
24-Mar-1997 |
ache |
Initialize RNG only once Use srandomdev() now
|
#
23700 |
|
11-Mar-1997 |
ache |
Fix srandom arg according to Lite2
|
#
23318 |
|
03-Mar-1997 |
ache |
Back out MAXLOGNAME fix, Bruce points that copyinstr require NUL
|
#
23299 |
|
02-Mar-1997 |
ache |
Fix MAXLOGNAME usage, the code has wrong assumption that it must be NUL terminated
|
#
22997 |
|
22-Feb-1997 |
peter |
Revert $FreeBSD$ to $Id$
|
#
22394 |
|
07-Feb-1997 |
davidn |
Fix useage of MAXLOGNAME to include terminating NUL, by using max(MAXLOGNAME-1,UT_NAMESIZE). Tidy up "pretty" printing format for longer usernames.
|
#
21673 |
|
14-Jan-1997 |
jkh |
Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!) avoiding the Id-smashing problem which has plagued developers for so long.
Boy, I'm glad we're not using sup anymore. This update would have been insane otherwise.
|
#
21330 |
|
05-Jan-1997 |
davidn |
Adds optional NIS passwd file updating and optionally rebuilding NIS maps.
Suggested by: Peter Wemm
|
#
21242 |
|
03-Jan-1997 |
davidn |
Implemented /home -> /usr/home symlink kludge. If home basedir would be created in the root partition, create it under /usr instead, and symlink /basedir -> /usr/basedir.
|
#
21052 |
|
30-Dec-1996 |
davidn |
1) Base home directory is created if it does not already exist if useradd -m or useradd -D -b are used. 2) Hyphen allowed in username if not first character. Fix trivial bug in error fmt string. 3) /etc/skeykeys updating changed to do 'inplace' update, commenting out a username rather than removing it completely.
|
#
20842 |
|
23-Dec-1996 |
davidn |
Correct file modes on updated /etc/skeykeys.
|
#
20747 |
|
21-Dec-1996 |
davidn |
1) 200 users per group limitation removed and pw will handle lines of any length in /etc/group. 2) Fixed bug with usermod -d not updating user's home directory. 3) Minor formatting display changes/fixes with *show -P.
|
#
20712 |
|
20-Dec-1996 |
davidn |
Bugfix (cosmetic) for output of generated passwords.
|
#
20679 |
|
19-Dec-1996 |
davidn |
Allow 8-bit characters in the passwd gecos field, and adds a paragraph to the mangpage explaining the consequences (to be updated at a later date after login class conf support is added).
|
#
20590 |
|
17-Dec-1996 |
davidn |
Changes to password generator: fallback to MD5 generator disabled (/dev/urandom used by default under FreeBSD), and implemented a "portable" but less secure generator for other systems. Add display of expiry/password change dates in -P user display.
|
#
20576 |
|
17-Dec-1996 |
davidn |
Submitted by: proff@iq.org Minor fix for security patch.
|
#
20555 |
|
16-Dec-1996 |
davidn |
Reviewed by: davidn@blaze.net.au Submitted by: proff@iq.org Security patch for better random password generation.
|
#
20325 |
|
11-Dec-1996 |
joerg |
Update from David, reflecting Wolfram's wishes regarding limitation of the allowable character set.
Submitted by: David Nugent
|
#
20303 |
|
10-Dec-1996 |
joerg |
This commit was generated by cvs2svn to compensate for changes in r20302, which included commits to RCS files with non-trunk default branches.
|
#
20302 |
|
10-Dec-1996 |
joerg |
Copyright update by the author, to be more in line with our sample copyright.
Submitted by: David Nugent
|
#
20267 |
|
09-Dec-1996 |
joerg |
Upgrade from the author, reflecting all my wishes resulting out of the sysinstall use of this tool (plus some bug fixes).
2.2 candidate...
Submitted by: David Nugent <davidn@nserver.usn.blaze.net.au>
|
#
20253 |
|
09-Dec-1996 |
joerg |
pw(8) -- a backend utility to manage the user and group databases.
sysinstall's new User&group menu will use it, hence it's a 2.2 candidate despite of providing new functionality.
Submitted by: David L. Nugent, <davidn@blaze.net.au>
|