History log of /freebsd-10.3-release/usr.sbin/ctld/ctld.c
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
# 296373 04-Mar-2016 marius

- Copy stable/10@296371 to releng/10.3 in preparation for 10.3-RC1
builds.
- Update newvers.sh to reflect RC1.
- Update __FreeBSD_version to reflect 10.3.
- Update default pkg(8) configuration to use the quarterly branch.

Approved by: re (implicit)

# 293290 07-Jan-2016 bdrewery

MFC r289677:

Fix a ton of speelling errors


# 291387 27-Nov-2015 mav

MFC r290615: Introduce portal group options in ctl.conf.

While CTL has concept of port options, used at least for iSCSI ports now,
before this change it was impossible to set them manually. There still
no user-configurable port options now, but I am planning to change that.


# 288823 05-Oct-2015 mav

MFC r288486, r288488: Set default block size for CD to expected 2048 bytes.


# 288810 05-Oct-2015 mav

MFC r288310: Add to CTL initial support for CDROMs and removable devices.

Relnotes: yes


# 288760 05-Oct-2015 mav

MFC r287823: Add ctl-lun config option for consistency in HA setups.


# 288748 05-Oct-2015 mav

MFC r287757: When updating port, apply only change of LUN map, not whole.


# 288729 05-Oct-2015 mav

MFC r287534: Add two new portal group options "tag" and "foreign".

They are going to be useful in clustered setups.


# 288728 05-Oct-2015 mav

MFC r287500: Allow LUN options modification via CTL_LUNREQ_MODIFY.

Not all changes take effect, but that is a different question.


# 288209 25-Sep-2015 jpaetzel

MFC 288208

Fix typo.

Sponsored by: iXsystems


# 281488 13-Apr-2015 mav

MFC r281163: Make ctld to not exit on ECONNABORTED on accept().

That is not really an error for the main process.


# 281187 07-Apr-2015 jpaetzel

MFC 281084

Fix thinko/copypaste error.

When checking the length of the mutual secret password the variable for
the secret password was used by mistake. This resulted in ctld never
warning about the length of the mutual secret being wrong even if it was.

Sponsored by: iXsystems


# 279481 01-Mar-2015 mav

MFC r279277: Fix memory leak on incorrect initiator portal.

Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com>


# 279056 20-Feb-2015 mav

MFC r278594: Add missing asprintf() status checks.


# 279055 20-Feb-2015 mav

MFC r278354: Teach ctld(8) to control non-iSCSI CTL ports.

This change introduces new target option "port", that assigns current target
to specified CTL port. On config application ctld(8) will apply LUN mapping
according to target configuration to specified port and bring the port up.
On shutdown cltd(8) will remove the mapping and put the port down.

This change allows to configure both iSCSI and FibreChannel targets in the
same configuration file in alike way.

Kernel side support was added earlier at r278037.

Relnotes: yes
Sponsored by: iXsystems, Inc.


# 279006 19-Feb-2015 mav

MFC r278322: Add support for multiple portal groups per target.

This change allows multiple "portal-group" options to be specified per
target. Each of them may include new optional auth-group name parameter
to override per-target auth parameters for specific portal group.

Kernel side support was added earlier at r278161.

Sponsored by: iXsystems, Inc.


# 279003 19-Feb-2015 mav

MFC r278161: Bring some more order into iSCSI portal group tags support.

While ctld(8) still does not allow multiple portal groups per target
to be configured, kernel should now be able to handle it.

Sponsored by: iXsystems, Inc.


# 279002 19-Feb-2015 mav

MFC r278037: CTL LUN mapping rewrite.

Replace iSCSI-specific LUN mapping mechanism with new one, working for any
ports. By default all ports are created without LUN mapping, exposing all
CTL LUNs as before. But, if needed, LUN mapping can be manually set on
per-port basis via ctladm. For its iSCSI ports ctld does it via ioctl(2).
The next step will be to teach ctld to work with FibreChannel ports also.

Respecting additional flexibility of the new mechanism, ctl.conf now allows
alternative syntax for LUN definition. LUNs can now be defined in global
context, and then referenced from targets by unique name, as needed. It
allows same LUN to be exposed several times via multiple targets.

While there, increase limit for LUNs per target in ctld from 256 to 1024.
Some initiators do not support LUNs above 255, but that is not our problem.

Relnotes: yes
Sponsored by: iXsystems, Inc.


# 279001 19-Feb-2015 mav

MFC r274853:
For both iSCSI initiator and target increase socket buffer sizes before
establishing connection.

This is a workaround for Chelsio TOE driver, that does not update socket
buffer size in hardware after connection established, and unless that is
done beforehand, kernel code will stuck, attempting to send/receive full
PDU at once.


# 279000 19-Feb-2015 mav

MFC r274804:
In conf_apply() remove iSCSI ports from kernel before removing LUNs.

Previous order confused initiators with messages about "removed" LUNs
during simple ctld restart without any real config change. After this
commit initiators only reestablish lost connection, receive "Power on
occurred" UNIT ATTENTION status and continue normal operation.


# 277749 26-Jan-2015 trasz

MFC r274791:

Add missing error checking for kernel_port_{add,remove}(). Both can fail
for reasons yet unknown; don't make it increment cumulated_error as a kind
of temporary workaround.

MFC r275399:

Fix null pointer dereference.

Sponsored by: The FreeBSD Foundation


# 275674 10-Dec-2014 mav

MFC r275452: Do not corrupt the listen string when parsing it.

This fixes problem with ctld reload when it is configured to listen on two
portals with same IP, but different ports.


# 275642 09-Dec-2014 trasz

MFC r274308:

Add support for sending redirections to iSCSI target.

MFC r274309:

Fix several nits in redirection handling - don't use wrong CSG,
and avoid use-after-free.

Sponsored by: The FreeBSD Foundation


# 275496 05-Dec-2014 mav

MFC r274248: Remove unused assignments, noticed by Clang analyzer.


# 275245 29-Nov-2014 trasz

MFC r273816:

Simplify code; no functional changes.

Sponsored by: The FreeBSD Foundation


# 275244 29-Nov-2014 trasz

MFC r273813:

Add discovery-filter. This makes it possible to restrict which targets
are returned during discovery based on initiator portal, name, and CHAP
credentials.


# 274949 24-Nov-2014 trasz

MFC r273584:

Make the initiator-name and initiator-portal checks a little nicer.

Sponsored by: The FreeBSD Foundation


# 274939 24-Nov-2014 mav

MFC r273635, r273793, r274797: Add basic iSNS client to the iSCSI target.

This makes ctld(8) register its iSCSI targets and portals on configured
iSNS servers to allow initiators find them without active discovery.

Fetching of allowed initiators from iSNS is not implemented now, so target
ACLs still should be configured manually.

Relnotes: Yes
Sponsored by: iXsystems, Inc.


# 274871 22-Nov-2014 trasz

MFC r273465:

Fix ctld(8) to not show the "auth-group <name> not assigned to any target"
warning for auth-groups assigned to a portal-group.

Sponsored by: The FreeBSD Foundation


# 274870 22-Nov-2014 trasz

MFC r273464:

Whitespace fixes.

Sponsored by: The FreeBSD Foundation


# 271929 21-Sep-2014 mav

MFC r271797: Make kernel to update LUN size from the backing storage
on configuration reload also if that size was not specified in the new
configuration.

Previously it happened only if size was explicitly changed in config.

Approved by: re (delphij)


# 271632 15-Sep-2014 trasz

MFC r271187:

Avoid ctld(8) crash on getaddrinfo(3) failure.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation


# 271627 15-Sep-2014 trasz

MFC r271169:

Turn two errors, which are possible to trigger only by bugs,
into assertions.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation


# 270888 31-Aug-2014 trasz

MFC r270279:

Make the iSCSI stack use __FBSDID() properly.

Sponsored by: The FreeBSD Foundation


# 270137 18-Aug-2014 mav

MFC r269183, r269191:
Add netmasks support to initiator-portal option.


# 268682 15-Jul-2014 mav

MFC r268291:
Create separate CTL port for every iSCSI target (and maybe portal group).

Having single port for all iSCSI connections makes problematic implementing
some more advanced SCSI functionality in CTL, that require proper ports
enumeration and identification.

This change extends CTL iSCSI API, making ctld daemon to control list of
iSCSI ports in CTL. When new target is defined in config fine, ctld will
create respective port in CTL. When target is removed -- port will be
also removed after all active commands through that port properly aborted.
This change require ctld to be rebuilt to match the kernel.

As a minor side effect, this allows to have iSCSI targets without LUNs.
While that may look odd and not very useful, that is not incorrect.


# 265519 07-May-2014 trasz

MFC r264535:

English.

Sponsored by: The FreeBSD Foundation


# 265518 07-May-2014 trasz

MFC r264534:

If we fail to create LUN, try again on next configuration reload.

Sponsored by: The FreeBSD Foundation


# 265516 07-May-2014 trasz

MFC r264533:

Use consistent punctuation.

Sponsored by: The FreeBSD Foundation


# 265514 07-May-2014 trasz

MFC r264531:

Constify.

Sponsored by: The FreeBSD Foundation


# 265513 07-May-2014 trasz

MFC r264530:

Properly pass the initiator address when running in proxy mode.

Sponsored by: The FreeBSD Foundation


# 265512 07-May-2014 trasz

MFC r264529:

Use socket address from accept(2) instead of retrieving it via
getpeername(2).

Sponsored by: The FreeBSD Foundation


# 265511 07-May-2014 trasz

MFC r264528:

Rework the way we enable CTL iSCSI port. Previously conf_apply()
needed it to be already enabled, because listening in proxy mode
requires it; however, it's conf_apply() that opens pidfiles,
so it resulted in port being enabled before pidfile was opened.
This was not so bad, but it was also disabled when pidfile couldn't
be opened due to ctld already running; this means that starting
second ctld instance screwed up the first.

Sponsored by: The FreeBSD Foundation


# 265509 07-May-2014 trasz

MFC r264526:

Properly identify target portal when running in proxy mode. While here,
remove CTL_ISCSI_CLOSE, it wasn't used or implemented anyway.

Sponsored by: The FreeBSD Foundation


# 265507 07-May-2014 trasz

MFC r264524:

Make it possible for the iSCSI target side to operate in both normal
and ICL_KERNEL_PROXY mode, and fix some bit rot so the latter actually
works again.

Sponsored by: The FreeBSD Foundation


# 265506 07-May-2014 trasz

MFC r264500:

Stop treating LUN 0 as mandatory. There is no reason to do that.

Sponsored by: The FreeBSD Foundation


# 263730 25-Mar-2014 trasz

MFC r261764:

So, it turns out SIGCHLD is discarded by default, so we have to set up
a dummy handler to make it interrupt an ioctl(2) or select(2).

This makes those short-lived ctld(8) zombies disappear.

Sponsored by: The FreeBSD Foundation


# 263729 25-Mar-2014 trasz

MFC r261763:

Use new auth-type "deny" instead of using "chap" with no chap entries;
it's cleaner this way, and gives better feedback to the user.

Sponsored by: The FreeBSD Foundation


# 263728 25-Mar-2014 trasz

MFC r261762:

Use "default" as default discovery-auth-group, instead of "no-access".
It doesn't change visible behaviour, as previously auth-group "default"
wasn't redefinable, so by default access was always denied.

Sponsored by: The FreeBSD Foundation


# 263726 25-Mar-2014 trasz

MFC r261760:

Add a new auth-group "default", defaulting to deny, and make it possible
to redefine it. From now on, assigning auth-group to a target is no longer
mandatory.

Sponsored by: The FreeBSD Foundation


# 263724 25-Mar-2014 trasz

MFC r261758:

Add auth-type.

Sponsored by: The FreeBSD Foundation


# 263723 25-Mar-2014 trasz

MFC r261757:

Rename a variable, no functional changes.

Sponsored by: The FreeBSD Foundation


# 263721 25-Mar-2014 trasz

MFC r261755:

Make function ordering slightly more logical; no functional changes.

Sponsored by: The FreeBSD Foundation


# 263720 25-Mar-2014 trasz

MFC r261754:

Implement initiator-name and initiator-portal restrictions.

Sponsored by: The FreeBSD Foundation


# 263719 25-Mar-2014 trasz

MFC r261753:

Daemonize after applying configuration, not before, so that
any problems - including "daemon already running" - are visible
on the terminal and not just in logs.

Sponsored by: The FreeBSD Foundation


# 263718 25-Mar-2014 trasz

MFC r261750:

Improve check for duplicated paths. It shows the warning twice for every
path (once for each duplicate found), but it should do for now.

Sponsored by: The FreeBSD Foundation


# 263717 25-Mar-2014 trasz

MFC r261749:

Refactor.

Sponsored by: The FreeBSD Foundation


# 263716 25-Mar-2014 trasz

MFC r261768:

Make the debug messages during ctld(8) shutdown less confusing.

Sponsored by: The FreeBSD Foundation


# 256281 10-Oct-2013 gjb

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation


# 255678 18-Sep-2013 trasz

Fix several problems in the new iSCSI stack; this includes interoperability
fix for LIO (Linux target), removing possibility for the target to avoid mutual
CHAP by choosing to skip authentication altogether, and fixing truncated error
messages in iscsictl(8) output. This also fixes several of the problems found
with Coverity.

Note that this change requires world rebuild.

Coverity CID: 1088038, 1087998, 1087990, 1088004, 1088044, 1088041, 1088040
Approved by: re (blanket)
Sponsored by: FreeBSD Foundation


# 255570 14-Sep-2013 trasz

Bring in the new iSCSI target and initiator.

Reviewed by: ken (parts)
Approved by: re (delphij)
Sponsored by: FreeBSD Foundation