Do not add 'default:' cases inside a switch() on an enum like the SNMP option argument. That way the compiler will give a warning in case of a missing or an extra but unknown 'case:'. Do the same for SNMP LEAF objects to be prepared once gensnmptree will auto-generate enums for those too. Add an abort() after the switch() instead of the 'default:' to catch any errors. The nice side effect is that the compiler will correctly track supposed to be 'uninitialized' variables with that.
When trying to set a value sanity check it before calling the OS dependent API of snmp_bridge to tell whether it is an attempt to set a bad value or a general error.
Suggested by: harti (first part) Approved by: bz (mentor)
|