Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

The mode of files created by ctm_rmail was always 0600, even if the
umask was less restrictive. This was caused by the use of mkstemp()
which internally passes a mode of 0600 to open(). Fix this by
explicitly chmod'ing the files to (0666 & ~umask).

PR: bin/16119
Submitted by: Sascha Blank <blank@uni-trier.de>

* fix ctm(8) to use mkstemp() instead of tempnam() for tempfile
creation.

* Tag the internal err() function with __printflike to allow checking
for non-constant format string arguments (none exist)

* Use fmtcheck() to sanitize the tar command obtained via -t to make
sure it doesn't contain extraneous format operators.

Reviewed by: mikeh
MFC after: 1 week

Close buffer overflows. This is partially based on an old version of
the fix from OpenBSD.

Reviewed by: markm

Paranoia: use mkstemp instead of mktemp.
PR: bin/3211
Reported by: Mark Pritchard <mpp@FreeBSD.ORG>

Support for "-u" which sets the timestamp from the delta on the file.
Intended for sup mirrors etc. Not well tested yet.

Reviewed by: phk
Submitted by: Giles Lean <giles@nemeton.com.au>
Submitted by: John Hay <jhay@mikom.csir.co.za>

typo in my last commit.

A trivial enhancement to ctm_rmail to support the -v option and pass it
through to cvs when unpacking the delta.. (I read the output.. :-)

Remove all trailing white space on the lines.
Suggested by: Phil Taylor <phil@zipmail.co.uk>

Remove trailing whitespace.

Make the +%d-%d part +%03d-%03d so ls(1) sorts the files more sensibly.

(Not tested yet. I may insist that ctm be invoked with absolute path. /phk)

This patch fixes the concurrency problem, and adds a possibly useful -f switch
(which you can read about in the man page :-) ). It also removes the absolute
path from the invocation of ctm. I'll write a note about how to use a script
with sendmail and procmail or some such, and people can fix their PATH there.

BTW, this patch changes ctm_rmail.1, ctm_rmail.c and error.c in the ctm_rmail
directory.

Stephen.

Reviewed by: phk
Submitted by: Stephen McKay <syssgm@devetir.qld.gov.au>

I (phk) blundered with the last change. Make it right & better now.

Reviewed by: phk
Submitted by: John Hay <jhay@mikom.csir.co.za>

Make us a little safer, by writing to a tempfile, and rename when done.
Still needs more locking I belive.

Use absolute path for the "ctm" program.

Various nitpicking from Stephen.

Reviewed by: phk
Submitted by: Stephen McKay <syssgm@devetir.qld.gov.au>

Clean up some details, to make it clear to gcc that we do not try to do
something stupid.

CTM email tools.

Reviewed by: phk
Submitted by: Stephen McKay <syssgm@devetir.qld.gov.au>