History log of /freebsd-10-stable/sys/dev/ciss/ciss.c
Revision Date Author Comments
# 315813 23-Mar-2017 mav

MFC r311305 (by asomers):
Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".

This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.

PR: 215474
Reported by: Coverity
CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID: 1010035 1010036 1010042 1010041 1010040 1010039


# 303176 22-Jul-2016 sbruno

MFC r300551
Update some of the TBD entries in ciss(4) to match what's in the pci
IDS data.


# 300060 17-May-2016 pfg

MFC r298931, r298981, r299375:

Minor spelling fixes in:
sys/dev, sys/sys

Many of these have user-visible strings.


# 299634 13-May-2016 ngie

MFC r298670:
r298670 (by cem):

ciss(4): Fix overrun of array

The softc member 'ciss_logical' is an array of 'ciss_max_logical_bus' members.
Most of the time it is iterated correctly. This patch fixes the two instances
where the driver iterated off the end of the array.

CID: 1305492


# 287566 08-Sep-2015 sbruno

MFC r287437

r249170 was just plain wrong. The effect of the change is to always
delete a logic volume on status change which is NOT what we want here.

The original code is correct in that when the volume changes status
the driver will only delete the volume if the status is one of the
fatal errors. A drive failure in a mirrored volume is NOT a situtation
where the volume should dissapear.

Reported on freebsd-scsi@:
https://lists.freebsd.org/pipermail/freebsd-scsi/2015-September/006800.html


# 281826 21-Apr-2015 mav

MFC r280347: Remove MAXBSIZE use from drivers where it has nothing to do.

In some cases limits are just not needed, in others -- DFLTPHYS is the
right constant to use instead.


# 275982 21-Dec-2014 smh

MFC r274819:
Prevent overflow issues in timeout processing

MFC r274852:
Fix build with asr driver

Sponsored by: Multiplay


# 268955 21-Jul-2014 sbruno

MFC r268017 and r268018

268017:
Check return of cam_periph_find() before using it in a printf.

268018:
Add detection for ciss(4) controllers that are set to non-raid JBOD mode.


# 264734 21-Apr-2014 sbruno

MFC r264127

Add PCI-IDs for TBD Gen9 RAID controller HBAs from HP to ciss(4)

Submitted by: Benesh, Scott <scott.benesh@hp.com>
Sponsored by: Yahoo! Inc.


# 264510 15-Apr-2014 sbruno

MFC r264354

Fix insta-panic on assert of unlocked periph mtx in ciss(4) when
logical volume state changes.

Sponsored by: Yahoo! Inc.


# 287566 08-Sep-2015 sbruno

MFC r287437

r249170 was just plain wrong. The effect of the change is to always
delete a logic volume on status change which is NOT what we want here.

The original code is correct in that when the volume changes status
the driver will only delete the volume if the status is one of the
fatal errors. A drive failure in a mirrored volume is NOT a situtation
where the volume should dissapear.

Reported on freebsd-scsi@:
https://lists.freebsd.org/pipermail/freebsd-scsi/2015-September/006800.html


# 281826 21-Apr-2015 mav

MFC r280347: Remove MAXBSIZE use from drivers where it has nothing to do.

In some cases limits are just not needed, in others -- DFLTPHYS is the
right constant to use instead.


# 275982 21-Dec-2014 smh

MFC r274819:
Prevent overflow issues in timeout processing

MFC r274852:
Fix build with asr driver

Sponsored by: Multiplay


# 268955 21-Jul-2014 sbruno

MFC r268017 and r268018

268017:
Check return of cam_periph_find() before using it in a printf.

268018:
Add detection for ciss(4) controllers that are set to non-raid JBOD mode.


# 264734 21-Apr-2014 sbruno

MFC r264127

Add PCI-IDs for TBD Gen9 RAID controller HBAs from HP to ciss(4)

Submitted by: Benesh, Scott <scott.benesh@hp.com>
Sponsored by: Yahoo! Inc.


# 264510 15-Apr-2014 sbruno

MFC r264354

Fix insta-panic on assert of unlocked periph mtx in ciss(4) when
logical volume state changes.

Sponsored by: Yahoo! Inc.