History log of /freebsd-10-stable/sys/amd64/pci/pci_cfgreg.c
Revision Date Author Comments
# 318208 12-May-2017 sephe

MFC 317786

pcicfg: Fix direct calls of pci_cfg{read,write} on systems w/o PCI host bridge.

Reported by: dexuan@
Reviewed by: jhb@
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D10564


# 261455 04-Feb-2014 eadler

MFC r258779,r258780,r258787,r258822:

Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this
shifts into the sign bit. Instead use (1U << 31) which gets the
expected result.

Similar to the (1 << 31) case it is not defined to do (2 << 30).

This fix is not ideal as it assumes a 32 bit int, but does fix the issue
for most cases.

A similar change was made in OpenBSD.


# 261455 04-Feb-2014 eadler

MFC r258779,r258780,r258787,r258822:

Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this
shifts into the sign bit. Instead use (1U << 31) which gets the
expected result.

Similar to the (1 << 31) case it is not defined to do (2 << 30).

This fix is not ideal as it assumes a 32 bit int, but does fix the issue
for most cases.

A similar change was made in OpenBSD.