SemaDeclObjC.cpp revision 195341
1//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===// 2// 3// The LLVM Compiler Infrastructure 4// 5// This file is distributed under the University of Illinois Open Source 6// License. See LICENSE.TXT for details. 7// 8//===----------------------------------------------------------------------===// 9// 10// This file implements semantic analysis for Objective C declarations. 11// 12//===----------------------------------------------------------------------===// 13 14#include "Sema.h" 15#include "clang/Sema/ExternalSemaSource.h" 16#include "clang/AST/Expr.h" 17#include "clang/AST/ASTContext.h" 18#include "clang/AST/DeclObjC.h" 19#include "clang/Parse/DeclSpec.h" 20using namespace clang; 21 22bool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 23 ObjCMethodDecl *GetterMethod, 24 SourceLocation Loc) { 25 if (GetterMethod && 26 GetterMethod->getResultType() != property->getType()) { 27 AssignConvertType result = Incompatible; 28 if (Context.isObjCObjectPointerType(property->getType())) 29 result = CheckAssignmentConstraints(GetterMethod->getResultType(), property->getType()); 30 if (result != Compatible) { 31 Diag(Loc, diag::warn_accessor_property_type_mismatch) 32 << property->getDeclName() 33 << GetterMethod->getSelector(); 34 Diag(GetterMethod->getLocation(), diag::note_declared_at); 35 return true; 36 } 37 } 38 return false; 39} 40 41/// ActOnStartOfObjCMethodDef - This routine sets up parameters; invisible 42/// and user declared, in the method definition's AST. 43void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, DeclPtrTy D) { 44 assert(getCurMethodDecl() == 0 && "Method parsing confused"); 45 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D.getAs<Decl>()); 46 47 // If we don't have a valid method decl, simply return. 48 if (!MDecl) 49 return; 50 51 CurFunctionNeedsScopeChecking = false; 52 53 // Allow the rest of sema to find private method decl implementations. 54 if (MDecl->isInstanceMethod()) 55 AddInstanceMethodToGlobalPool(MDecl); 56 else 57 AddFactoryMethodToGlobalPool(MDecl); 58 59 // Allow all of Sema to see that we are entering a method definition. 60 PushDeclContext(FnBodyScope, MDecl); 61 62 // Create Decl objects for each parameter, entrring them in the scope for 63 // binding to their use. 64 65 // Insert the invisible arguments, self and _cmd! 66 MDecl->createImplicitParams(Context, MDecl->getClassInterface()); 67 68 PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope); 69 PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope); 70 71 // Introduce all of the other parameters into this scope. 72 for (ObjCMethodDecl::param_iterator PI = MDecl->param_begin(), 73 E = MDecl->param_end(); PI != E; ++PI) 74 if ((*PI)->getIdentifier()) 75 PushOnScopeChains(*PI, FnBodyScope); 76} 77 78Sema::DeclPtrTy Sema:: 79ActOnStartClassInterface(SourceLocation AtInterfaceLoc, 80 IdentifierInfo *ClassName, SourceLocation ClassLoc, 81 IdentifierInfo *SuperName, SourceLocation SuperLoc, 82 const DeclPtrTy *ProtoRefs, unsigned NumProtoRefs, 83 SourceLocation EndProtoLoc, AttributeList *AttrList) { 84 assert(ClassName && "Missing class identifier"); 85 86 // Check for another declaration kind with the same name. 87 NamedDecl *PrevDecl = LookupName(TUScope, ClassName, LookupOrdinaryName); 88 if (PrevDecl && PrevDecl->isTemplateParameter()) { 89 // Maybe we will complain about the shadowed template parameter. 90 DiagnoseTemplateParameterShadow(ClassLoc, PrevDecl); 91 // Just pretend that we didn't see the previous declaration. 92 PrevDecl = 0; 93 } 94 95 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 96 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 97 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 98 } 99 100 ObjCInterfaceDecl* IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 101 if (IDecl) { 102 // Class already seen. Is it a forward declaration? 103 if (!IDecl->isForwardDecl()) { 104 IDecl->setInvalidDecl(); 105 Diag(AtInterfaceLoc, diag::err_duplicate_class_def)<<IDecl->getDeclName(); 106 Diag(IDecl->getLocation(), diag::note_previous_definition); 107 108 // Return the previous class interface. 109 // FIXME: don't leak the objects passed in! 110 return DeclPtrTy::make(IDecl); 111 } else { 112 IDecl->setLocation(AtInterfaceLoc); 113 IDecl->setForwardDecl(false); 114 } 115 } else { 116 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtInterfaceLoc, 117 ClassName, ClassLoc); 118 if (AttrList) 119 ProcessDeclAttributeList(TUScope, IDecl, AttrList); 120 121 PushOnScopeChains(IDecl, TUScope); 122 } 123 124 if (SuperName) { 125 // Check if a different kind of symbol declared in this scope. 126 PrevDecl = LookupName(TUScope, SuperName, LookupOrdinaryName); 127 128 ObjCInterfaceDecl *SuperClassDecl = 129 dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 130 131 // Diagnose classes that inherit from deprecated classes. 132 if (SuperClassDecl) 133 (void)DiagnoseUseOfDecl(SuperClassDecl, SuperLoc); 134 135 if (PrevDecl && SuperClassDecl == 0) { 136 // The previous declaration was not a class decl. Check if we have a 137 // typedef. If we do, get the underlying class type. 138 if (const TypedefDecl *TDecl = dyn_cast_or_null<TypedefDecl>(PrevDecl)) { 139 QualType T = TDecl->getUnderlyingType(); 140 if (T->isObjCInterfaceType()) { 141 if (NamedDecl *IDecl = T->getAsObjCInterfaceType()->getDecl()) 142 SuperClassDecl = dyn_cast<ObjCInterfaceDecl>(IDecl); 143 } 144 } 145 146 // This handles the following case: 147 // 148 // typedef int SuperClass; 149 // @interface MyClass : SuperClass {} @end 150 // 151 if (!SuperClassDecl) { 152 Diag(SuperLoc, diag::err_redefinition_different_kind) << SuperName; 153 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 154 } 155 } 156 157 if (!dyn_cast_or_null<TypedefDecl>(PrevDecl)) { 158 if (!SuperClassDecl) 159 Diag(SuperLoc, diag::err_undef_superclass) 160 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc); 161 else if (SuperClassDecl->isForwardDecl()) 162 Diag(SuperLoc, diag::err_undef_superclass) 163 << SuperClassDecl->getDeclName() << ClassName 164 << SourceRange(AtInterfaceLoc, ClassLoc); 165 } 166 IDecl->setSuperClass(SuperClassDecl); 167 IDecl->setSuperClassLoc(SuperLoc); 168 IDecl->setLocEnd(SuperLoc); 169 } else { // we have a root class. 170 IDecl->setLocEnd(ClassLoc); 171 } 172 173 /// Check then save referenced protocols. 174 if (NumProtoRefs) { 175 IDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 176 Context); 177 IDecl->setLocEnd(EndProtoLoc); 178 } 179 180 CheckObjCDeclScope(IDecl); 181 return DeclPtrTy::make(IDecl); 182} 183 184/// ActOnCompatiblityAlias - this action is called after complete parsing of 185/// @compatibility_alias declaration. It sets up the alias relationships. 186Sema::DeclPtrTy Sema::ActOnCompatiblityAlias(SourceLocation AtLoc, 187 IdentifierInfo *AliasName, 188 SourceLocation AliasLocation, 189 IdentifierInfo *ClassName, 190 SourceLocation ClassLocation) { 191 // Look for previous declaration of alias name 192 NamedDecl *ADecl = LookupName(TUScope, AliasName, LookupOrdinaryName); 193 if (ADecl) { 194 if (isa<ObjCCompatibleAliasDecl>(ADecl)) 195 Diag(AliasLocation, diag::warn_previous_alias_decl); 196 else 197 Diag(AliasLocation, diag::err_conflicting_aliasing_type) << AliasName; 198 Diag(ADecl->getLocation(), diag::note_previous_declaration); 199 return DeclPtrTy(); 200 } 201 // Check for class declaration 202 NamedDecl *CDeclU = LookupName(TUScope, ClassName, LookupOrdinaryName); 203 if (const TypedefDecl *TDecl = dyn_cast_or_null<TypedefDecl>(CDeclU)) { 204 QualType T = TDecl->getUnderlyingType(); 205 if (T->isObjCInterfaceType()) { 206 if (NamedDecl *IDecl = T->getAsObjCInterfaceType()->getDecl()) { 207 ClassName = IDecl->getIdentifier(); 208 CDeclU = LookupName(TUScope, ClassName, LookupOrdinaryName); 209 } 210 } 211 } 212 ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU); 213 if (CDecl == 0) { 214 Diag(ClassLocation, diag::warn_undef_interface) << ClassName; 215 if (CDeclU) 216 Diag(CDeclU->getLocation(), diag::note_previous_declaration); 217 return DeclPtrTy(); 218 } 219 220 // Everything checked out, instantiate a new alias declaration AST. 221 ObjCCompatibleAliasDecl *AliasDecl = 222 ObjCCompatibleAliasDecl::Create(Context, CurContext, AtLoc, AliasName, CDecl); 223 224 if (!CheckObjCDeclScope(AliasDecl)) 225 PushOnScopeChains(AliasDecl, TUScope); 226 227 return DeclPtrTy::make(AliasDecl); 228} 229 230void Sema::CheckForwardProtocolDeclarationForCircularDependency( 231 IdentifierInfo *PName, 232 SourceLocation &Ploc, SourceLocation PrevLoc, 233 const ObjCList<ObjCProtocolDecl> &PList) 234{ 235 for (ObjCList<ObjCProtocolDecl>::iterator I = PList.begin(), 236 E = PList.end(); I != E; ++I) { 237 238 if (ObjCProtocolDecl *PDecl = LookupProtocol((*I)->getIdentifier())) { 239 if (PDecl->getIdentifier() == PName) { 240 Diag(Ploc, diag::err_protocol_has_circular_dependency); 241 Diag(PrevLoc, diag::note_previous_definition); 242 } 243 CheckForwardProtocolDeclarationForCircularDependency(PName, Ploc, 244 PDecl->getLocation(), PDecl->getReferencedProtocols()); 245 } 246 } 247} 248 249Sema::DeclPtrTy 250Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc, 251 IdentifierInfo *ProtocolName, 252 SourceLocation ProtocolLoc, 253 const DeclPtrTy *ProtoRefs, 254 unsigned NumProtoRefs, 255 SourceLocation EndProtoLoc, 256 AttributeList *AttrList) { 257 // FIXME: Deal with AttrList. 258 assert(ProtocolName && "Missing protocol identifier"); 259 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolName); 260 if (PDecl) { 261 // Protocol already seen. Better be a forward protocol declaration 262 if (!PDecl->isForwardDecl()) { 263 Diag(ProtocolLoc, diag::warn_duplicate_protocol_def) << ProtocolName; 264 Diag(PDecl->getLocation(), diag::note_previous_definition); 265 // Just return the protocol we already had. 266 // FIXME: don't leak the objects passed in! 267 return DeclPtrTy::make(PDecl); 268 } 269 ObjCList<ObjCProtocolDecl> PList; 270 PList.set((ObjCProtocolDecl *const*)ProtoRefs, NumProtoRefs, Context); 271 CheckForwardProtocolDeclarationForCircularDependency( 272 ProtocolName, ProtocolLoc, PDecl->getLocation(), PList); 273 PList.Destroy(Context); 274 275 // Make sure the cached decl gets a valid start location. 276 PDecl->setLocation(AtProtoInterfaceLoc); 277 PDecl->setForwardDecl(false); 278 } else { 279 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 280 AtProtoInterfaceLoc,ProtocolName); 281 PushOnScopeChains(PDecl, TUScope); 282 PDecl->setForwardDecl(false); 283 } 284 if (AttrList) 285 ProcessDeclAttributeList(TUScope, PDecl, AttrList); 286 if (NumProtoRefs) { 287 /// Check then save referenced protocols. 288 PDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs,Context); 289 PDecl->setLocEnd(EndProtoLoc); 290 } 291 292 CheckObjCDeclScope(PDecl); 293 return DeclPtrTy::make(PDecl); 294} 295 296/// FindProtocolDeclaration - This routine looks up protocols and 297/// issues an error if they are not declared. It returns list of 298/// protocol declarations in its 'Protocols' argument. 299void 300Sema::FindProtocolDeclaration(bool WarnOnDeclarations, 301 const IdentifierLocPair *ProtocolId, 302 unsigned NumProtocols, 303 llvm::SmallVectorImpl<DeclPtrTy> &Protocols) { 304 for (unsigned i = 0; i != NumProtocols; ++i) { 305 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolId[i].first); 306 if (!PDecl) { 307 Diag(ProtocolId[i].second, diag::err_undeclared_protocol) 308 << ProtocolId[i].first; 309 continue; 310 } 311 312 (void)DiagnoseUseOfDecl(PDecl, ProtocolId[i].second); 313 314 // If this is a forward declaration and we are supposed to warn in this 315 // case, do it. 316 if (WarnOnDeclarations && PDecl->isForwardDecl()) 317 Diag(ProtocolId[i].second, diag::warn_undef_protocolref) 318 << ProtocolId[i].first; 319 Protocols.push_back(DeclPtrTy::make(PDecl)); 320 } 321} 322 323/// DiagnosePropertyMismatch - Compares two properties for their 324/// attributes and types and warns on a variety of inconsistencies. 325/// 326void 327Sema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 328 ObjCPropertyDecl *SuperProperty, 329 const IdentifierInfo *inheritedName) { 330 ObjCPropertyDecl::PropertyAttributeKind CAttr = 331 Property->getPropertyAttributes(); 332 ObjCPropertyDecl::PropertyAttributeKind SAttr = 333 SuperProperty->getPropertyAttributes(); 334 if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 335 && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 336 Diag(Property->getLocation(), diag::warn_readonly_property) 337 << Property->getDeclName() << inheritedName; 338 if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 339 != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 340 Diag(Property->getLocation(), diag::warn_property_attribute) 341 << Property->getDeclName() << "copy" << inheritedName; 342 else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain) 343 != (SAttr & ObjCPropertyDecl::OBJC_PR_retain)) 344 Diag(Property->getLocation(), diag::warn_property_attribute) 345 << Property->getDeclName() << "retain" << inheritedName; 346 347 if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 348 != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 349 Diag(Property->getLocation(), diag::warn_property_attribute) 350 << Property->getDeclName() << "atomic" << inheritedName; 351 if (Property->getSetterName() != SuperProperty->getSetterName()) 352 Diag(Property->getLocation(), diag::warn_property_attribute) 353 << Property->getDeclName() << "setter" << inheritedName; 354 if (Property->getGetterName() != SuperProperty->getGetterName()) 355 Diag(Property->getLocation(), diag::warn_property_attribute) 356 << Property->getDeclName() << "getter" << inheritedName; 357 358 QualType LHSType = 359 Context.getCanonicalType(SuperProperty->getType()); 360 QualType RHSType = 361 Context.getCanonicalType(Property->getType()); 362 363 if (!Context.typesAreCompatible(LHSType, RHSType)) { 364 // FIXME: Incorporate this test with typesAreCompatible. 365 if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 366 if (ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 367 return; 368 Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 369 << Property->getType() << SuperProperty->getType() << inheritedName; 370 } 371} 372 373/// ComparePropertiesInBaseAndSuper - This routine compares property 374/// declarations in base and its super class, if any, and issues 375/// diagnostics in a variety of inconsistant situations. 376/// 377void Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 378 ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 379 if (!SDecl) 380 return; 381 // FIXME: O(N^2) 382 for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 383 E = SDecl->prop_end(); S != E; ++S) { 384 ObjCPropertyDecl *SuperPDecl = (*S); 385 // Does property in super class has declaration in current class? 386 for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 387 E = IDecl->prop_end(); I != E; ++I) { 388 ObjCPropertyDecl *PDecl = (*I); 389 if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 390 DiagnosePropertyMismatch(PDecl, SuperPDecl, 391 SDecl->getIdentifier()); 392 } 393 } 394} 395 396/// MergeOneProtocolPropertiesIntoClass - This routine goes thru the list 397/// of properties declared in a protocol and adds them to the list 398/// of properties for current class/category if it is not there already. 399void 400Sema::MergeOneProtocolPropertiesIntoClass(Decl *CDecl, 401 ObjCProtocolDecl *PDecl) { 402 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 403 if (!IDecl) { 404 // Category 405 ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 406 assert (CatDecl && "MergeOneProtocolPropertiesIntoClass"); 407 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 408 E = PDecl->prop_end(); P != E; ++P) { 409 ObjCPropertyDecl *Pr = (*P); 410 ObjCCategoryDecl::prop_iterator CP, CE; 411 // Is this property already in category's list of properties? 412 for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP != CE; ++CP) 413 if ((*CP)->getIdentifier() == Pr->getIdentifier()) 414 break; 415 if (CP != CE) 416 // Property protocol already exist in class. Diagnose any mismatch. 417 DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 418 } 419 return; 420 } 421 for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 422 E = PDecl->prop_end(); P != E; ++P) { 423 ObjCPropertyDecl *Pr = (*P); 424 ObjCInterfaceDecl::prop_iterator CP, CE; 425 // Is this property already in class's list of properties? 426 for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 427 if ((*CP)->getIdentifier() == Pr->getIdentifier()) 428 break; 429 if (CP != CE) 430 // Property protocol already exist in class. Diagnose any mismatch. 431 DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 432 } 433} 434 435/// MergeProtocolPropertiesIntoClass - This routine merges properties 436/// declared in 'MergeItsProtocols' objects (which can be a class or an 437/// inherited protocol into the list of properties for class/category 'CDecl' 438/// 439void Sema::MergeProtocolPropertiesIntoClass(Decl *CDecl, 440 DeclPtrTy MergeItsProtocols) { 441 Decl *ClassDecl = MergeItsProtocols.getAs<Decl>(); 442 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 443 444 if (!IDecl) { 445 // Category 446 ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 447 assert (CatDecl && "MergeProtocolPropertiesIntoClass"); 448 if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 449 for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 450 E = MDecl->protocol_end(); P != E; ++P) 451 // Merge properties of category (*P) into IDECL's 452 MergeOneProtocolPropertiesIntoClass(CatDecl, *P); 453 454 // Go thru the list of protocols for this category and recursively merge 455 // their properties into this class as well. 456 for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 457 E = CatDecl->protocol_end(); P != E; ++P) 458 MergeProtocolPropertiesIntoClass(CatDecl, DeclPtrTy::make(*P)); 459 } else { 460 ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 461 for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 462 E = MD->protocol_end(); P != E; ++P) 463 MergeOneProtocolPropertiesIntoClass(CatDecl, *P); 464 } 465 return; 466 } 467 468 if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 469 for (ObjCInterfaceDecl::protocol_iterator P = MDecl->protocol_begin(), 470 E = MDecl->protocol_end(); P != E; ++P) 471 // Merge properties of class (*P) into IDECL's 472 MergeOneProtocolPropertiesIntoClass(IDecl, *P); 473 474 // Go thru the list of protocols for this class and recursively merge 475 // their properties into this class as well. 476 for (ObjCInterfaceDecl::protocol_iterator P = IDecl->protocol_begin(), 477 E = IDecl->protocol_end(); P != E; ++P) 478 MergeProtocolPropertiesIntoClass(IDecl, DeclPtrTy::make(*P)); 479 } else { 480 ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 481 for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 482 E = MD->protocol_end(); P != E; ++P) 483 MergeOneProtocolPropertiesIntoClass(IDecl, *P); 484 } 485} 486 487/// DiagnoseClassExtensionDupMethods - Check for duplicate declaration of 488/// a class method in its extension. 489/// 490void Sema::DiagnoseClassExtensionDupMethods(ObjCCategoryDecl *CAT, 491 ObjCInterfaceDecl *ID) { 492 if (!ID) 493 return; // Possibly due to previous error 494 495 llvm::DenseMap<Selector, const ObjCMethodDecl*> MethodMap; 496 for (ObjCInterfaceDecl::method_iterator i = ID->meth_begin(), 497 e = ID->meth_end(); i != e; ++i) { 498 ObjCMethodDecl *MD = *i; 499 MethodMap[MD->getSelector()] = MD; 500 } 501 502 if (MethodMap.empty()) 503 return; 504 for (ObjCCategoryDecl::method_iterator i = CAT->meth_begin(), 505 e = CAT->meth_end(); i != e; ++i) { 506 ObjCMethodDecl *Method = *i; 507 const ObjCMethodDecl *&PrevMethod = MethodMap[Method->getSelector()]; 508 if (PrevMethod && !MatchTwoMethodDeclarations(Method, PrevMethod)) { 509 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 510 << Method->getDeclName(); 511 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 512 } 513 } 514} 515 516/// ActOnForwardProtocolDeclaration - Handle @protocol foo; 517Action::DeclPtrTy 518Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc, 519 const IdentifierLocPair *IdentList, 520 unsigned NumElts, 521 AttributeList *attrList) { 522 llvm::SmallVector<ObjCProtocolDecl*, 32> Protocols; 523 524 for (unsigned i = 0; i != NumElts; ++i) { 525 IdentifierInfo *Ident = IdentList[i].first; 526 ObjCProtocolDecl *PDecl = LookupProtocol(Ident); 527 if (PDecl == 0) { // Not already seen? 528 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 529 IdentList[i].second, Ident); 530 PushOnScopeChains(PDecl, TUScope); 531 } 532 if (attrList) 533 ProcessDeclAttributeList(TUScope, PDecl, attrList); 534 Protocols.push_back(PDecl); 535 } 536 537 ObjCForwardProtocolDecl *PDecl = 538 ObjCForwardProtocolDecl::Create(Context, CurContext, AtProtocolLoc, 539 &Protocols[0], Protocols.size()); 540 CurContext->addDecl(PDecl); 541 CheckObjCDeclScope(PDecl); 542 return DeclPtrTy::make(PDecl); 543} 544 545Sema::DeclPtrTy Sema:: 546ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc, 547 IdentifierInfo *ClassName, SourceLocation ClassLoc, 548 IdentifierInfo *CategoryName, 549 SourceLocation CategoryLoc, 550 const DeclPtrTy *ProtoRefs, 551 unsigned NumProtoRefs, 552 SourceLocation EndProtoLoc) { 553 ObjCCategoryDecl *CDecl = 554 ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc, CategoryName); 555 // FIXME: PushOnScopeChains? 556 CurContext->addDecl(CDecl); 557 558 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName); 559 /// Check that class of this category is already completely declared. 560 if (!IDecl || IDecl->isForwardDecl()) { 561 CDecl->setInvalidDecl(); 562 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 563 return DeclPtrTy::make(CDecl); 564 } 565 566 CDecl->setClassInterface(IDecl); 567 568 // If the interface is deprecated, warn about it. 569 (void)DiagnoseUseOfDecl(IDecl, ClassLoc); 570 571 /// Check for duplicate interface declaration for this category 572 ObjCCategoryDecl *CDeclChain; 573 for (CDeclChain = IDecl->getCategoryList(); CDeclChain; 574 CDeclChain = CDeclChain->getNextClassCategory()) { 575 if (CategoryName && CDeclChain->getIdentifier() == CategoryName) { 576 Diag(CategoryLoc, diag::warn_dup_category_def) 577 << ClassName << CategoryName; 578 Diag(CDeclChain->getLocation(), diag::note_previous_definition); 579 break; 580 } 581 } 582 if (!CDeclChain) 583 CDecl->insertNextClassCategory(); 584 585 if (NumProtoRefs) { 586 CDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs,Context); 587 CDecl->setLocEnd(EndProtoLoc); 588 } 589 590 CheckObjCDeclScope(CDecl); 591 return DeclPtrTy::make(CDecl); 592} 593 594/// ActOnStartCategoryImplementation - Perform semantic checks on the 595/// category implementation declaration and build an ObjCCategoryImplDecl 596/// object. 597Sema::DeclPtrTy Sema::ActOnStartCategoryImplementation( 598 SourceLocation AtCatImplLoc, 599 IdentifierInfo *ClassName, SourceLocation ClassLoc, 600 IdentifierInfo *CatName, SourceLocation CatLoc) { 601 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName); 602 ObjCCategoryImplDecl *CDecl = 603 ObjCCategoryImplDecl::Create(Context, CurContext, AtCatImplLoc, CatName, 604 IDecl); 605 /// Check that class of this category is already completely declared. 606 if (!IDecl || IDecl->isForwardDecl()) 607 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 608 609 // FIXME: PushOnScopeChains? 610 CurContext->addDecl(CDecl); 611 612 /// TODO: Check that CatName, category name, is not used in another 613 // implementation. 614 ObjCCategoryImpls.push_back(CDecl); 615 616 CheckObjCDeclScope(CDecl); 617 return DeclPtrTy::make(CDecl); 618} 619 620Sema::DeclPtrTy Sema::ActOnStartClassImplementation( 621 SourceLocation AtClassImplLoc, 622 IdentifierInfo *ClassName, SourceLocation ClassLoc, 623 IdentifierInfo *SuperClassname, 624 SourceLocation SuperClassLoc) { 625 ObjCInterfaceDecl* IDecl = 0; 626 // Check for another declaration kind with the same name. 627 NamedDecl *PrevDecl = LookupName(TUScope, ClassName, LookupOrdinaryName); 628 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 629 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 630 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 631 } else { 632 // Is there an interface declaration of this class; if not, warn! 633 IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 634 if (!IDecl || IDecl->isForwardDecl()) { 635 Diag(ClassLoc, diag::warn_undef_interface) << ClassName; 636 IDecl = 0; 637 } 638 } 639 640 // Check that super class name is valid class name 641 ObjCInterfaceDecl* SDecl = 0; 642 if (SuperClassname) { 643 // Check if a different kind of symbol declared in this scope. 644 PrevDecl = LookupName(TUScope, SuperClassname, LookupOrdinaryName); 645 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 646 Diag(SuperClassLoc, diag::err_redefinition_different_kind) 647 << SuperClassname; 648 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 649 } else { 650 SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 651 if (!SDecl) 652 Diag(SuperClassLoc, diag::err_undef_superclass) 653 << SuperClassname << ClassName; 654 else if (IDecl && IDecl->getSuperClass() != SDecl) { 655 // This implementation and its interface do not have the same 656 // super class. 657 Diag(SuperClassLoc, diag::err_conflicting_super_class) 658 << SDecl->getDeclName(); 659 Diag(SDecl->getLocation(), diag::note_previous_definition); 660 } 661 } 662 } 663 664 if (!IDecl) { 665 // Legacy case of @implementation with no corresponding @interface. 666 // Build, chain & install the interface decl into the identifier. 667 668 // FIXME: Do we support attributes on the @implementation? If so we should 669 // copy them over. 670 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassImplLoc, 671 ClassName, ClassLoc, false, true); 672 IDecl->setSuperClass(SDecl); 673 IDecl->setLocEnd(ClassLoc); 674 675 PushOnScopeChains(IDecl, TUScope); 676 } else { 677 // Mark the interface as being completed, even if it was just as 678 // @class ....; 679 // declaration; the user cannot reopen it. 680 IDecl->setForwardDecl(false); 681 } 682 683 ObjCImplementationDecl* IMPDecl = 684 ObjCImplementationDecl::Create(Context, CurContext, AtClassImplLoc, 685 IDecl, SDecl); 686 687 if (CheckObjCDeclScope(IMPDecl)) 688 return DeclPtrTy::make(IMPDecl); 689 690 // Check that there is no duplicate implementation of this class. 691 if (LookupObjCImplementation(ClassName)) 692 // FIXME: Don't leak everything! 693 Diag(ClassLoc, diag::err_dup_implementation_class) << ClassName; 694 else // add it to the list. 695 PushOnScopeChains(IMPDecl, TUScope); 696 return DeclPtrTy::make(IMPDecl); 697} 698 699void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl, 700 ObjCIvarDecl **ivars, unsigned numIvars, 701 SourceLocation RBrace) { 702 assert(ImpDecl && "missing implementation decl"); 703 ObjCInterfaceDecl* IDecl = ImpDecl->getClassInterface(); 704 if (!IDecl) 705 return; 706 /// Check case of non-existing @interface decl. 707 /// (legacy objective-c @implementation decl without an @interface decl). 708 /// Add implementations's ivar to the synthesize class's ivar list. 709 if (IDecl->isImplicitInterfaceDecl()) { 710 IDecl->setIVarList(ivars, numIvars, Context); 711 IDecl->setLocEnd(RBrace); 712 return; 713 } 714 // If implementation has empty ivar list, just return. 715 if (numIvars == 0) 716 return; 717 718 assert(ivars && "missing @implementation ivars"); 719 720 // Check interface's Ivar list against those in the implementation. 721 // names and types must match. 722 // 723 unsigned j = 0; 724 ObjCInterfaceDecl::ivar_iterator 725 IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end(); 726 for (; numIvars > 0 && IVI != IVE; ++IVI) { 727 ObjCIvarDecl* ImplIvar = ivars[j++]; 728 ObjCIvarDecl* ClsIvar = *IVI; 729 assert (ImplIvar && "missing implementation ivar"); 730 assert (ClsIvar && "missing class ivar"); 731 732 // First, make sure the types match. 733 if (Context.getCanonicalType(ImplIvar->getType()) != 734 Context.getCanonicalType(ClsIvar->getType())) { 735 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type) 736 << ImplIvar->getIdentifier() 737 << ImplIvar->getType() << ClsIvar->getType(); 738 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 739 } else if (ImplIvar->isBitField() && ClsIvar->isBitField()) { 740 Expr *ImplBitWidth = ImplIvar->getBitWidth(); 741 Expr *ClsBitWidth = ClsIvar->getBitWidth(); 742 if (ImplBitWidth->EvaluateAsInt(Context).getZExtValue() != 743 ClsBitWidth->EvaluateAsInt(Context).getZExtValue()) { 744 Diag(ImplBitWidth->getLocStart(), diag::err_conflicting_ivar_bitwidth) 745 << ImplIvar->getIdentifier(); 746 Diag(ClsBitWidth->getLocStart(), diag::note_previous_definition); 747 } 748 } 749 // Make sure the names are identical. 750 if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) { 751 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name) 752 << ImplIvar->getIdentifier() << ClsIvar->getIdentifier(); 753 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 754 } 755 --numIvars; 756 } 757 758 if (numIvars > 0) 759 Diag(ivars[j]->getLocation(), diag::err_inconsistant_ivar_count); 760 else if (IVI != IVE) 761 Diag((*IVI)->getLocation(), diag::err_inconsistant_ivar_count); 762} 763 764void Sema::WarnUndefinedMethod(SourceLocation ImpLoc, ObjCMethodDecl *method, 765 bool &IncompleteImpl) { 766 if (!IncompleteImpl) { 767 Diag(ImpLoc, diag::warn_incomplete_impl); 768 IncompleteImpl = true; 769 } 770 Diag(ImpLoc, diag::warn_undef_method_impl) << method->getDeclName(); 771} 772 773void Sema::WarnConflictingTypedMethods(ObjCMethodDecl *ImpMethodDecl, 774 ObjCMethodDecl *IntfMethodDecl) { 775 if (!Context.typesAreCompatible(IntfMethodDecl->getResultType(), 776 ImpMethodDecl->getResultType()) && 777 !QualifiedIdConformsQualifiedId(IntfMethodDecl->getResultType(), 778 ImpMethodDecl->getResultType())) { 779 Diag(ImpMethodDecl->getLocation(), diag::warn_conflicting_ret_types) 780 << ImpMethodDecl->getDeclName() << IntfMethodDecl->getResultType() 781 << ImpMethodDecl->getResultType(); 782 Diag(IntfMethodDecl->getLocation(), diag::note_previous_definition); 783 } 784 785 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(), 786 IF = IntfMethodDecl->param_begin(), EM = ImpMethodDecl->param_end(); 787 IM != EM; ++IM, ++IF) { 788 if (Context.typesAreCompatible((*IF)->getType(), (*IM)->getType()) || 789 QualifiedIdConformsQualifiedId((*IF)->getType(), (*IM)->getType())) 790 continue; 791 792 Diag((*IM)->getLocation(), diag::warn_conflicting_param_types) 793 << ImpMethodDecl->getDeclName() << (*IF)->getType() 794 << (*IM)->getType(); 795 Diag((*IF)->getLocation(), diag::note_previous_definition); 796 } 797} 798 799/// isPropertyReadonly - Return true if property is readonly, by searching 800/// for the property in the class and in its categories and implementations 801/// 802bool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 803 ObjCInterfaceDecl *IDecl) { 804 // by far the most common case. 805 if (!PDecl->isReadOnly()) 806 return false; 807 // Even if property is ready only, if interface has a user defined setter, 808 // it is not considered read only. 809 if (IDecl->getInstanceMethod(PDecl->getSetterName())) 810 return false; 811 812 // Main class has the property as 'readonly'. Must search 813 // through the category list to see if the property's 814 // attribute has been over-ridden to 'readwrite'. 815 for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 816 Category; Category = Category->getNextClassCategory()) { 817 // Even if property is ready only, if a category has a user defined setter, 818 // it is not considered read only. 819 if (Category->getInstanceMethod(PDecl->getSetterName())) 820 return false; 821 ObjCPropertyDecl *P = 822 Category->FindPropertyDeclaration(PDecl->getIdentifier()); 823 if (P && !P->isReadOnly()) 824 return false; 825 } 826 827 // Also, check for definition of a setter method in the implementation if 828 // all else failed. 829 if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 830 if (ObjCImplementationDecl *IMD = 831 dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 832 if (IMD->getInstanceMethod(PDecl->getSetterName())) 833 return false; 834 } 835 else if (ObjCCategoryImplDecl *CIMD = 836 dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 837 if (CIMD->getInstanceMethod(PDecl->getSetterName())) 838 return false; 839 } 840 } 841 // Lastly, look through the implementation (if one is in scope). 842 if (ObjCImplementationDecl *ImpDecl 843 = LookupObjCImplementation(IDecl->getIdentifier())) 844 if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 845 return false; 846 // If all fails, look at the super class. 847 if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 848 return isPropertyReadonly(PDecl, SIDecl); 849 return true; 850} 851 852/// FIXME: Type hierarchies in Objective-C can be deep. We could most likely 853/// improve the efficiency of selector lookups and type checking by associating 854/// with each protocol / interface / category the flattened instance tables. If 855/// we used an immutable set to keep the table then it wouldn't add significant 856/// memory cost and it would be handy for lookups. 857 858/// CheckProtocolMethodDefs - This routine checks unimplemented methods 859/// Declared in protocol, and those referenced by it. 860void Sema::CheckProtocolMethodDefs(SourceLocation ImpLoc, 861 ObjCProtocolDecl *PDecl, 862 bool& IncompleteImpl, 863 const llvm::DenseSet<Selector> &InsMap, 864 const llvm::DenseSet<Selector> &ClsMap, 865 ObjCInterfaceDecl *IDecl) { 866 ObjCInterfaceDecl *Super = IDecl->getSuperClass(); 867 ObjCInterfaceDecl *NSIDecl = 0; 868 if (getLangOptions().NeXTRuntime) { 869 // check to see if class implements forwardInvocation method and objects 870 // of this class are derived from 'NSProxy' so that to forward requests 871 // from one object to another. 872 // Under such conditions, which means that every method possible is 873 // implemented in the class, we should not issue "Method definition not 874 // found" warnings. 875 // FIXME: Use a general GetUnarySelector method for this. 876 IdentifierInfo* II = &Context.Idents.get("forwardInvocation"); 877 Selector fISelector = Context.Selectors.getSelector(1, &II); 878 if (InsMap.count(fISelector)) 879 // Is IDecl derived from 'NSProxy'? If so, no instance methods 880 // need be implemented in the implementation. 881 NSIDecl = IDecl->lookupInheritedClass(&Context.Idents.get("NSProxy")); 882 } 883 884 // If a method lookup fails locally we still need to look and see if 885 // the method was implemented by a base class or an inherited 886 // protocol. This lookup is slow, but occurs rarely in correct code 887 // and otherwise would terminate in a warning. 888 889 // check unimplemented instance methods. 890 if (!NSIDecl) 891 for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(), 892 E = PDecl->instmeth_end(); I != E; ++I) { 893 ObjCMethodDecl *method = *I; 894 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 895 !method->isSynthesized() && !InsMap.count(method->getSelector()) && 896 (!Super || 897 !Super->lookupInstanceMethod(method->getSelector()))) { 898 // Ugly, but necessary. Method declared in protcol might have 899 // have been synthesized due to a property declared in the class which 900 // uses the protocol. 901 ObjCMethodDecl *MethodInClass = 902 IDecl->lookupInstanceMethod(method->getSelector()); 903 if (!MethodInClass || !MethodInClass->isSynthesized()) 904 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl); 905 } 906 } 907 // check unimplemented class methods 908 for (ObjCProtocolDecl::classmeth_iterator 909 I = PDecl->classmeth_begin(), E = PDecl->classmeth_end(); 910 I != E; ++I) { 911 ObjCMethodDecl *method = *I; 912 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 913 !ClsMap.count(method->getSelector()) && 914 (!Super || !Super->lookupClassMethod(method->getSelector()))) 915 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl); 916 } 917 // Check on this protocols's referenced protocols, recursively. 918 for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 919 E = PDecl->protocol_end(); PI != E; ++PI) 920 CheckProtocolMethodDefs(ImpLoc, *PI, IncompleteImpl, InsMap, ClsMap, IDecl); 921} 922 923/// MatchAllMethodDeclarations - Check methods declaraed in interface or 924/// or protocol against those declared in their implementations. 925/// 926void Sema::MatchAllMethodDeclarations(const llvm::DenseSet<Selector> &InsMap, 927 const llvm::DenseSet<Selector> &ClsMap, 928 llvm::DenseSet<Selector> &InsMapSeen, 929 llvm::DenseSet<Selector> &ClsMapSeen, 930 ObjCImplDecl* IMPDecl, 931 ObjCContainerDecl* CDecl, 932 bool &IncompleteImpl, 933 bool ImmediateClass) 934{ 935 // Check and see if instance methods in class interface have been 936 // implemented in the implementation class. If so, their types match. 937 for (ObjCInterfaceDecl::instmeth_iterator I = CDecl->instmeth_begin(), 938 E = CDecl->instmeth_end(); I != E; ++I) { 939 if (InsMapSeen.count((*I)->getSelector())) 940 continue; 941 InsMapSeen.insert((*I)->getSelector()); 942 if (!(*I)->isSynthesized() && 943 !InsMap.count((*I)->getSelector())) { 944 if (ImmediateClass) 945 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl); 946 continue; 947 } 948 else { 949 ObjCMethodDecl *ImpMethodDecl = 950 IMPDecl->getInstanceMethod((*I)->getSelector()); 951 ObjCMethodDecl *IntfMethodDecl = 952 CDecl->getInstanceMethod((*I)->getSelector()); 953 assert(IntfMethodDecl && 954 "IntfMethodDecl is null in ImplMethodsVsClassMethods"); 955 // ImpMethodDecl may be null as in a @dynamic property. 956 if (ImpMethodDecl) 957 WarnConflictingTypedMethods(ImpMethodDecl, IntfMethodDecl); 958 } 959 } 960 961 // Check and see if class methods in class interface have been 962 // implemented in the implementation class. If so, their types match. 963 for (ObjCInterfaceDecl::classmeth_iterator 964 I = CDecl->classmeth_begin(), E = CDecl->classmeth_end(); I != E; ++I) { 965 if (ClsMapSeen.count((*I)->getSelector())) 966 continue; 967 ClsMapSeen.insert((*I)->getSelector()); 968 if (!ClsMap.count((*I)->getSelector())) { 969 if (ImmediateClass) 970 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl); 971 } 972 else { 973 ObjCMethodDecl *ImpMethodDecl = 974 IMPDecl->getClassMethod((*I)->getSelector()); 975 ObjCMethodDecl *IntfMethodDecl = 976 CDecl->getClassMethod((*I)->getSelector()); 977 WarnConflictingTypedMethods(ImpMethodDecl, IntfMethodDecl); 978 } 979 } 980 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 981 // Check for any implementation of a methods declared in protocol. 982 for (ObjCInterfaceDecl::protocol_iterator PI = I->protocol_begin(), 983 E = I->protocol_end(); PI != E; ++PI) 984 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 985 IMPDecl, 986 (*PI), IncompleteImpl, false); 987 if (I->getSuperClass()) 988 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 989 IMPDecl, 990 I->getSuperClass(), IncompleteImpl, false); 991 } 992} 993 994void Sema::ImplMethodsVsClassMethods(ObjCImplDecl* IMPDecl, 995 ObjCContainerDecl* CDecl, 996 bool IncompleteImpl) { 997 llvm::DenseSet<Selector> InsMap; 998 // Check and see if instance methods in class interface have been 999 // implemented in the implementation class. 1000 for (ObjCImplementationDecl::instmeth_iterator 1001 I = IMPDecl->instmeth_begin(), E = IMPDecl->instmeth_end(); I!=E; ++I) 1002 InsMap.insert((*I)->getSelector()); 1003 1004 // Check and see if properties declared in the interface have either 1) 1005 // an implementation or 2) there is a @synthesize/@dynamic implementation 1006 // of the property in the @implementation. 1007 if (isa<ObjCInterfaceDecl>(CDecl)) 1008 for (ObjCContainerDecl::prop_iterator P = CDecl->prop_begin(), 1009 E = CDecl->prop_end(); P != E; ++P) { 1010 ObjCPropertyDecl *Prop = (*P); 1011 if (Prop->isInvalidDecl()) 1012 continue; 1013 ObjCPropertyImplDecl *PI = 0; 1014 // Is there a matching propery synthesize/dynamic? 1015 for (ObjCImplDecl::propimpl_iterator 1016 I = IMPDecl->propimpl_begin(), 1017 EI = IMPDecl->propimpl_end(); I != EI; ++I) 1018 if ((*I)->getPropertyDecl() == Prop) { 1019 PI = (*I); 1020 break; 1021 } 1022 if (PI) 1023 continue; 1024 if (!InsMap.count(Prop->getGetterName())) { 1025 Diag(Prop->getLocation(), 1026 diag::warn_setter_getter_impl_required) 1027 << Prop->getDeclName() << Prop->getGetterName(); 1028 Diag(IMPDecl->getLocation(), 1029 diag::note_property_impl_required); 1030 } 1031 1032 if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1033 Diag(Prop->getLocation(), 1034 diag::warn_setter_getter_impl_required) 1035 << Prop->getDeclName() << Prop->getSetterName(); 1036 Diag(IMPDecl->getLocation(), 1037 diag::note_property_impl_required); 1038 } 1039 } 1040 1041 llvm::DenseSet<Selector> ClsMap; 1042 for (ObjCImplementationDecl::classmeth_iterator 1043 I = IMPDecl->classmeth_begin(), 1044 E = IMPDecl->classmeth_end(); I != E; ++I) 1045 ClsMap.insert((*I)->getSelector()); 1046 1047 // Check for type conflict of methods declared in a class/protocol and 1048 // its implementation; if any. 1049 llvm::DenseSet<Selector> InsMapSeen, ClsMapSeen; 1050 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1051 IMPDecl, CDecl, 1052 IncompleteImpl, true); 1053 1054 // Check the protocol list for unimplemented methods in the @implementation 1055 // class. 1056 // Check and see if class methods in class interface have been 1057 // implemented in the implementation class. 1058 1059 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 1060 for (ObjCInterfaceDecl::protocol_iterator PI = I->protocol_begin(), 1061 E = I->protocol_end(); PI != E; ++PI) 1062 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1063 InsMap, ClsMap, I); 1064 // Check class extensions (unnamed categories) 1065 for (ObjCCategoryDecl *Categories = I->getCategoryList(); 1066 Categories; Categories = Categories->getNextClassCategory()) { 1067 if (!Categories->getIdentifier()) { 1068 ImplMethodsVsClassMethods(IMPDecl, Categories, IncompleteImpl); 1069 break; 1070 } 1071 } 1072 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1073 for (ObjCCategoryDecl::protocol_iterator PI = C->protocol_begin(), 1074 E = C->protocol_end(); PI != E; ++PI) 1075 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1076 InsMap, ClsMap, C->getClassInterface()); 1077 } else 1078 assert(false && "invalid ObjCContainerDecl type."); 1079} 1080 1081/// ActOnForwardClassDeclaration - 1082Action::DeclPtrTy 1083Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc, 1084 IdentifierInfo **IdentList, 1085 unsigned NumElts) { 1086 llvm::SmallVector<ObjCInterfaceDecl*, 32> Interfaces; 1087 1088 for (unsigned i = 0; i != NumElts; ++i) { 1089 // Check for another declaration kind with the same name. 1090 NamedDecl *PrevDecl = LookupName(TUScope, IdentList[i], LookupOrdinaryName); 1091 if (PrevDecl && PrevDecl->isTemplateParameter()) { 1092 // Maybe we will complain about the shadowed template parameter. 1093 DiagnoseTemplateParameterShadow(AtClassLoc, PrevDecl); 1094 // Just pretend that we didn't see the previous declaration. 1095 PrevDecl = 0; 1096 } 1097 1098 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 1099 // GCC apparently allows the following idiom: 1100 // 1101 // typedef NSObject < XCElementTogglerP > XCElementToggler; 1102 // @class XCElementToggler; 1103 // 1104 // FIXME: Make an extension? 1105 TypedefDecl *TDD = dyn_cast<TypedefDecl>(PrevDecl); 1106 if (!TDD || !isa<ObjCInterfaceType>(TDD->getUnderlyingType())) { 1107 Diag(AtClassLoc, diag::err_redefinition_different_kind) << IdentList[i]; 1108 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 1109 } 1110 else if (TDD) { 1111 // a forward class declaration matching a typedef name of a class 1112 // refers to the underlying class. 1113 if (ObjCInterfaceType * OI = 1114 dyn_cast<ObjCInterfaceType>(TDD->getUnderlyingType())) 1115 PrevDecl = OI->getDecl(); 1116 } 1117 } 1118 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 1119 if (!IDecl) { // Not already seen? Make a forward decl. 1120 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassLoc, 1121 IdentList[i], SourceLocation(), true); 1122 PushOnScopeChains(IDecl, TUScope); 1123 } 1124 1125 Interfaces.push_back(IDecl); 1126 } 1127 1128 ObjCClassDecl *CDecl = ObjCClassDecl::Create(Context, CurContext, AtClassLoc, 1129 &Interfaces[0], 1130 Interfaces.size()); 1131 CurContext->addDecl(CDecl); 1132 CheckObjCDeclScope(CDecl); 1133 return DeclPtrTy::make(CDecl); 1134} 1135 1136 1137/// MatchTwoMethodDeclarations - Checks that two methods have matching type and 1138/// returns true, or false, accordingly. 1139/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons 1140bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *Method, 1141 const ObjCMethodDecl *PrevMethod, 1142 bool matchBasedOnSizeAndAlignment) { 1143 QualType T1 = Context.getCanonicalType(Method->getResultType()); 1144 QualType T2 = Context.getCanonicalType(PrevMethod->getResultType()); 1145 1146 if (T1 != T2) { 1147 // The result types are different. 1148 if (!matchBasedOnSizeAndAlignment) 1149 return false; 1150 // Incomplete types don't have a size and alignment. 1151 if (T1->isIncompleteType() || T2->isIncompleteType()) 1152 return false; 1153 // Check is based on size and alignment. 1154 if (Context.getTypeInfo(T1) != Context.getTypeInfo(T2)) 1155 return false; 1156 } 1157 1158 ObjCMethodDecl::param_iterator ParamI = Method->param_begin(), 1159 E = Method->param_end(); 1160 ObjCMethodDecl::param_iterator PrevI = PrevMethod->param_begin(); 1161 1162 for (; ParamI != E; ++ParamI, ++PrevI) { 1163 assert(PrevI != PrevMethod->param_end() && "Param mismatch"); 1164 T1 = Context.getCanonicalType((*ParamI)->getType()); 1165 T2 = Context.getCanonicalType((*PrevI)->getType()); 1166 if (T1 != T2) { 1167 // The result types are different. 1168 if (!matchBasedOnSizeAndAlignment) 1169 return false; 1170 // Incomplete types don't have a size and alignment. 1171 if (T1->isIncompleteType() || T2->isIncompleteType()) 1172 return false; 1173 // Check is based on size and alignment. 1174 if (Context.getTypeInfo(T1) != Context.getTypeInfo(T2)) 1175 return false; 1176 } 1177 } 1178 return true; 1179} 1180 1181/// \brief Read the contents of the instance and factory method pools 1182/// for a given selector from external storage. 1183/// 1184/// This routine should only be called once, when neither the instance 1185/// nor the factory method pool has an entry for this selector. 1186Sema::MethodPool::iterator Sema::ReadMethodPool(Selector Sel, 1187 bool isInstance) { 1188 assert(ExternalSource && "We need an external AST source"); 1189 assert(InstanceMethodPool.find(Sel) == InstanceMethodPool.end() && 1190 "Selector data already loaded into the instance method pool"); 1191 assert(FactoryMethodPool.find(Sel) == FactoryMethodPool.end() && 1192 "Selector data already loaded into the factory method pool"); 1193 1194 // Read the method list from the external source. 1195 std::pair<ObjCMethodList, ObjCMethodList> Methods 1196 = ExternalSource->ReadMethodPool(Sel); 1197 1198 if (isInstance) { 1199 if (Methods.second.Method) 1200 FactoryMethodPool[Sel] = Methods.second; 1201 return InstanceMethodPool.insert(std::make_pair(Sel, Methods.first)).first; 1202 } 1203 1204 if (Methods.first.Method) 1205 InstanceMethodPool[Sel] = Methods.first; 1206 1207 return FactoryMethodPool.insert(std::make_pair(Sel, Methods.second)).first; 1208} 1209 1210void Sema::AddInstanceMethodToGlobalPool(ObjCMethodDecl *Method) { 1211 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1212 = InstanceMethodPool.find(Method->getSelector()); 1213 if (Pos == InstanceMethodPool.end()) { 1214 if (ExternalSource && !FactoryMethodPool.count(Method->getSelector())) 1215 Pos = ReadMethodPool(Method->getSelector(), /*isInstance=*/true); 1216 else 1217 Pos = InstanceMethodPool.insert(std::make_pair(Method->getSelector(), 1218 ObjCMethodList())).first; 1219 } 1220 1221 ObjCMethodList &Entry = Pos->second; 1222 if (Entry.Method == 0) { 1223 // Haven't seen a method with this selector name yet - add it. 1224 Entry.Method = Method; 1225 Entry.Next = 0; 1226 return; 1227 } 1228 1229 // We've seen a method with this name, see if we have already seen this type 1230 // signature. 1231 for (ObjCMethodList *List = &Entry; List; List = List->Next) 1232 if (MatchTwoMethodDeclarations(Method, List->Method)) 1233 return; 1234 1235 // We have a new signature for an existing method - add it. 1236 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded". 1237 Entry.Next = new ObjCMethodList(Method, Entry.Next); 1238} 1239 1240// FIXME: Finish implementing -Wno-strict-selector-match. 1241ObjCMethodDecl *Sema::LookupInstanceMethodInGlobalPool(Selector Sel, 1242 SourceRange R) { 1243 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1244 = InstanceMethodPool.find(Sel); 1245 if (Pos == InstanceMethodPool.end()) { 1246 if (ExternalSource && !FactoryMethodPool.count(Sel)) 1247 Pos = ReadMethodPool(Sel, /*isInstance=*/true); 1248 else 1249 return 0; 1250 } 1251 1252 ObjCMethodList &MethList = Pos->second; 1253 bool issueWarning = false; 1254 1255 if (MethList.Method && MethList.Next) { 1256 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1257 // This checks if the methods differ by size & alignment. 1258 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, true)) 1259 issueWarning = true; 1260 } 1261 if (issueWarning && (MethList.Method && MethList.Next)) { 1262 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R; 1263 Diag(MethList.Method->getLocStart(), diag::note_using_decl) 1264 << MethList.Method->getSourceRange(); 1265 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1266 Diag(Next->Method->getLocStart(), diag::note_also_found_decl) 1267 << Next->Method->getSourceRange(); 1268 } 1269 return MethList.Method; 1270} 1271 1272void Sema::AddFactoryMethodToGlobalPool(ObjCMethodDecl *Method) { 1273 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1274 = FactoryMethodPool.find(Method->getSelector()); 1275 if (Pos == FactoryMethodPool.end()) { 1276 if (ExternalSource && !InstanceMethodPool.count(Method->getSelector())) 1277 Pos = ReadMethodPool(Method->getSelector(), /*isInstance=*/false); 1278 else 1279 Pos = FactoryMethodPool.insert(std::make_pair(Method->getSelector(), 1280 ObjCMethodList())).first; 1281 } 1282 1283 ObjCMethodList &FirstMethod = Pos->second; 1284 if (!FirstMethod.Method) { 1285 // Haven't seen a method with this selector name yet - add it. 1286 FirstMethod.Method = Method; 1287 FirstMethod.Next = 0; 1288 } else { 1289 // We've seen a method with this name, now check the type signature(s). 1290 bool match = MatchTwoMethodDeclarations(Method, FirstMethod.Method); 1291 1292 for (ObjCMethodList *Next = FirstMethod.Next; !match && Next; 1293 Next = Next->Next) 1294 match = MatchTwoMethodDeclarations(Method, Next->Method); 1295 1296 if (!match) { 1297 // We have a new signature for an existing method - add it. 1298 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded". 1299 struct ObjCMethodList *OMI = new ObjCMethodList(Method, FirstMethod.Next); 1300 FirstMethod.Next = OMI; 1301 } 1302 } 1303} 1304 1305ObjCMethodDecl *Sema::LookupFactoryMethodInGlobalPool(Selector Sel, 1306 SourceRange R) { 1307 llvm::DenseMap<Selector, ObjCMethodList>::iterator Pos 1308 = FactoryMethodPool.find(Sel); 1309 if (Pos == FactoryMethodPool.end()) { 1310 if (ExternalSource && !InstanceMethodPool.count(Sel)) 1311 Pos = ReadMethodPool(Sel, /*isInstance=*/false); 1312 else 1313 return 0; 1314 } 1315 1316 ObjCMethodList &MethList = Pos->second; 1317 bool issueWarning = false; 1318 1319 if (MethList.Method && MethList.Next) { 1320 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1321 // This checks if the methods differ by size & alignment. 1322 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, true)) 1323 issueWarning = true; 1324 } 1325 if (issueWarning && (MethList.Method && MethList.Next)) { 1326 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R; 1327 Diag(MethList.Method->getLocStart(), diag::note_using_decl) 1328 << MethList.Method->getSourceRange(); 1329 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1330 Diag(Next->Method->getLocStart(), diag::note_also_found_decl) 1331 << Next->Method->getSourceRange(); 1332 } 1333 return MethList.Method; 1334} 1335 1336/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 1337/// have the property type and issue diagnostics if they don't. 1338/// Also synthesize a getter/setter method if none exist (and update the 1339/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 1340/// methods is the "right" thing to do. 1341void Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 1342 ObjCContainerDecl *CD) { 1343 ObjCMethodDecl *GetterMethod, *SetterMethod; 1344 1345 GetterMethod = CD->getInstanceMethod(property->getGetterName()); 1346 SetterMethod = CD->getInstanceMethod(property->getSetterName()); 1347 DiagnosePropertyAccessorMismatch(property, GetterMethod, 1348 property->getLocation()); 1349 1350 if (SetterMethod) { 1351 if (Context.getCanonicalType(SetterMethod->getResultType()) 1352 != Context.VoidTy) 1353 Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 1354 if (SetterMethod->param_size() != 1 || 1355 ((*SetterMethod->param_begin())->getType() != property->getType())) { 1356 Diag(property->getLocation(), 1357 diag::warn_accessor_property_type_mismatch) 1358 << property->getDeclName() 1359 << SetterMethod->getSelector(); 1360 Diag(SetterMethod->getLocation(), diag::note_declared_at); 1361 } 1362 } 1363 1364 // Synthesize getter/setter methods if none exist. 1365 // Find the default getter and if one not found, add one. 1366 // FIXME: The synthesized property we set here is misleading. We almost always 1367 // synthesize these methods unless the user explicitly provided prototypes 1368 // (which is odd, but allowed). Sema should be typechecking that the 1369 // declarations jive in that situation (which it is not currently). 1370 if (!GetterMethod) { 1371 // No instance method of same name as property getter name was found. 1372 // Declare a getter method and add it to the list of methods 1373 // for this class. 1374 GetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 1375 property->getLocation(), property->getGetterName(), 1376 property->getType(), CD, true, false, true, 1377 (property->getPropertyImplementation() == 1378 ObjCPropertyDecl::Optional) ? 1379 ObjCMethodDecl::Optional : 1380 ObjCMethodDecl::Required); 1381 CD->addDecl(GetterMethod); 1382 } else 1383 // A user declared getter will be synthesize when @synthesize of 1384 // the property with the same name is seen in the @implementation 1385 GetterMethod->setSynthesized(true); 1386 property->setGetterMethodDecl(GetterMethod); 1387 1388 // Skip setter if property is read-only. 1389 if (!property->isReadOnly()) { 1390 // Find the default setter and if one not found, add one. 1391 if (!SetterMethod) { 1392 // No instance method of same name as property setter name was found. 1393 // Declare a setter method and add it to the list of methods 1394 // for this class. 1395 SetterMethod = ObjCMethodDecl::Create(Context, property->getLocation(), 1396 property->getLocation(), 1397 property->getSetterName(), 1398 Context.VoidTy, CD, true, false, true, 1399 (property->getPropertyImplementation() == 1400 ObjCPropertyDecl::Optional) ? 1401 ObjCMethodDecl::Optional : 1402 ObjCMethodDecl::Required); 1403 // Invent the arguments for the setter. We don't bother making a 1404 // nice name for the argument. 1405 ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1406 property->getLocation(), 1407 property->getIdentifier(), 1408 property->getType(), 1409 VarDecl::None, 1410 0); 1411 SetterMethod->setMethodParams(Context, &Argument, 1); 1412 CD->addDecl(SetterMethod); 1413 } else 1414 // A user declared setter will be synthesize when @synthesize of 1415 // the property with the same name is seen in the @implementation 1416 SetterMethod->setSynthesized(true); 1417 property->setSetterMethodDecl(SetterMethod); 1418 } 1419 // Add any synthesized methods to the global pool. This allows us to 1420 // handle the following, which is supported by GCC (and part of the design). 1421 // 1422 // @interface Foo 1423 // @property double bar; 1424 // @end 1425 // 1426 // void thisIsUnfortunate() { 1427 // id foo; 1428 // double bar = [foo bar]; 1429 // } 1430 // 1431 if (GetterMethod) 1432 AddInstanceMethodToGlobalPool(GetterMethod); 1433 if (SetterMethod) 1434 AddInstanceMethodToGlobalPool(SetterMethod); 1435} 1436 1437// Note: For class/category implemenations, allMethods/allProperties is 1438// always null. 1439void Sema::ActOnAtEnd(SourceLocation AtEndLoc, DeclPtrTy classDecl, 1440 DeclPtrTy *allMethods, unsigned allNum, 1441 DeclPtrTy *allProperties, unsigned pNum, 1442 DeclGroupPtrTy *allTUVars, unsigned tuvNum) { 1443 Decl *ClassDecl = classDecl.getAs<Decl>(); 1444 1445 // FIXME: If we don't have a ClassDecl, we have an error. We should consider 1446 // always passing in a decl. If the decl has an error, isInvalidDecl() 1447 // should be true. 1448 if (!ClassDecl) 1449 return; 1450 1451 bool isInterfaceDeclKind = 1452 isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl) 1453 || isa<ObjCProtocolDecl>(ClassDecl); 1454 bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl); 1455 1456 DeclContext *DC = dyn_cast<DeclContext>(ClassDecl); 1457 1458 // FIXME: Remove these and use the ObjCContainerDecl/DeclContext. 1459 llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap; 1460 llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap; 1461 1462 for (unsigned i = 0; i < allNum; i++ ) { 1463 ObjCMethodDecl *Method = 1464 cast_or_null<ObjCMethodDecl>(allMethods[i].getAs<Decl>()); 1465 1466 if (!Method) continue; // Already issued a diagnostic. 1467 if (Method->isInstanceMethod()) { 1468 /// Check for instance method of the same name with incompatible types 1469 const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()]; 1470 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 1471 : false; 1472 if ((isInterfaceDeclKind && PrevMethod && !match) 1473 || (checkIdenticalMethods && match)) { 1474 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 1475 << Method->getDeclName(); 1476 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1477 } else { 1478 DC->addDecl(Method); 1479 InsMap[Method->getSelector()] = Method; 1480 /// The following allows us to typecheck messages to "id". 1481 AddInstanceMethodToGlobalPool(Method); 1482 } 1483 } 1484 else { 1485 /// Check for class method of the same name with incompatible types 1486 const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()]; 1487 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 1488 : false; 1489 if ((isInterfaceDeclKind && PrevMethod && !match) 1490 || (checkIdenticalMethods && match)) { 1491 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 1492 << Method->getDeclName(); 1493 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1494 } else { 1495 DC->addDecl(Method); 1496 ClsMap[Method->getSelector()] = Method; 1497 /// The following allows us to typecheck messages to "Class". 1498 AddFactoryMethodToGlobalPool(Method); 1499 } 1500 } 1501 } 1502 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 1503 // Compares properties declared in this class to those of its 1504 // super class. 1505 ComparePropertiesInBaseAndSuper(I); 1506 MergeProtocolPropertiesIntoClass(I, DeclPtrTy::make(I)); 1507 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 1508 // Categories are used to extend the class by declaring new methods. 1509 // By the same token, they are also used to add new properties. No 1510 // need to compare the added property to those in the class. 1511 1512 // Merge protocol properties into category 1513 MergeProtocolPropertiesIntoClass(C, DeclPtrTy::make(C)); 1514 if (C->getIdentifier() == 0) 1515 DiagnoseClassExtensionDupMethods(C, C->getClassInterface()); 1516 } 1517 if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(ClassDecl)) { 1518 // ProcessPropertyDecl is responsible for diagnosing conflicts with any 1519 // user-defined setter/getter. It also synthesizes setter/getter methods 1520 // and adds them to the DeclContext and global method pools. 1521 for (ObjCContainerDecl::prop_iterator I = CDecl->prop_begin(), 1522 E = CDecl->prop_end(); 1523 I != E; ++I) 1524 ProcessPropertyDecl(*I, CDecl); 1525 CDecl->setAtEndLoc(AtEndLoc); 1526 } 1527 if (ObjCImplementationDecl *IC=dyn_cast<ObjCImplementationDecl>(ClassDecl)) { 1528 IC->setLocEnd(AtEndLoc); 1529 if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 1530 ImplMethodsVsClassMethods(IC, IDecl); 1531 } else if (ObjCCategoryImplDecl* CatImplClass = 1532 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) { 1533 CatImplClass->setLocEnd(AtEndLoc); 1534 1535 // Find category interface decl and then check that all methods declared 1536 // in this interface are implemented in the category @implementation. 1537 if (ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface()) { 1538 for (ObjCCategoryDecl *Categories = IDecl->getCategoryList(); 1539 Categories; Categories = Categories->getNextClassCategory()) { 1540 if (Categories->getIdentifier() == CatImplClass->getIdentifier()) { 1541 ImplMethodsVsClassMethods(CatImplClass, Categories); 1542 break; 1543 } 1544 } 1545 } 1546 } 1547 if (isInterfaceDeclKind) { 1548 // Reject invalid vardecls. 1549 for (unsigned i = 0; i != tuvNum; i++) { 1550 DeclGroupRef DG = allTUVars[i].getAsVal<DeclGroupRef>(); 1551 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I) 1552 if (VarDecl *VDecl = dyn_cast<VarDecl>(*I)) { 1553 if (!VDecl->hasExternalStorage()) 1554 Diag(VDecl->getLocation(), diag::err_objc_var_decl_inclass); 1555 } 1556 } 1557 } 1558} 1559 1560 1561/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for 1562/// objective-c's type qualifier from the parser version of the same info. 1563static Decl::ObjCDeclQualifier 1564CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) { 1565 Decl::ObjCDeclQualifier ret = Decl::OBJC_TQ_None; 1566 if (PQTVal & ObjCDeclSpec::DQ_In) 1567 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_In); 1568 if (PQTVal & ObjCDeclSpec::DQ_Inout) 1569 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Inout); 1570 if (PQTVal & ObjCDeclSpec::DQ_Out) 1571 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Out); 1572 if (PQTVal & ObjCDeclSpec::DQ_Bycopy) 1573 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Bycopy); 1574 if (PQTVal & ObjCDeclSpec::DQ_Byref) 1575 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Byref); 1576 if (PQTVal & ObjCDeclSpec::DQ_Oneway) 1577 ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Oneway); 1578 1579 return ret; 1580} 1581 1582Sema::DeclPtrTy Sema::ActOnMethodDeclaration( 1583 SourceLocation MethodLoc, SourceLocation EndLoc, 1584 tok::TokenKind MethodType, DeclPtrTy classDecl, 1585 ObjCDeclSpec &ReturnQT, TypeTy *ReturnType, 1586 Selector Sel, 1587 // optional arguments. The number of types/arguments is obtained 1588 // from the Sel.getNumArgs(). 1589 ObjCArgInfo *ArgInfo, 1590 llvm::SmallVectorImpl<Declarator> &Cdecls, 1591 AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind, 1592 bool isVariadic) { 1593 Decl *ClassDecl = classDecl.getAs<Decl>(); 1594 1595 // Make sure we can establish a context for the method. 1596 if (!ClassDecl) { 1597 Diag(MethodLoc, diag::error_missing_method_context); 1598 return DeclPtrTy(); 1599 } 1600 QualType resultDeclType; 1601 1602 if (ReturnType) { 1603 resultDeclType = QualType::getFromOpaquePtr(ReturnType); 1604 1605 // Methods cannot return interface types. All ObjC objects are 1606 // passed by reference. 1607 if (resultDeclType->isObjCInterfaceType()) { 1608 Diag(MethodLoc, diag::err_object_cannot_be_passed_returned_by_value) 1609 << 0 << resultDeclType; 1610 return DeclPtrTy(); 1611 } 1612 } else // get the type for "id". 1613 resultDeclType = Context.getObjCIdType(); 1614 1615 ObjCMethodDecl* ObjCMethod = 1616 ObjCMethodDecl::Create(Context, MethodLoc, EndLoc, Sel, resultDeclType, 1617 cast<DeclContext>(ClassDecl), 1618 MethodType == tok::minus, isVariadic, 1619 false, 1620 MethodDeclKind == tok::objc_optional ? 1621 ObjCMethodDecl::Optional : 1622 ObjCMethodDecl::Required); 1623 1624 llvm::SmallVector<ParmVarDecl*, 16> Params; 1625 1626 for (unsigned i = 0, e = Sel.getNumArgs(); i != e; ++i) { 1627 QualType ArgType, UnpromotedArgType; 1628 1629 if (ArgInfo[i].Type == 0) { 1630 UnpromotedArgType = ArgType = Context.getObjCIdType(); 1631 } else { 1632 UnpromotedArgType = ArgType = QualType::getFromOpaquePtr(ArgInfo[i].Type); 1633 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]). 1634 ArgType = adjustParameterType(ArgType); 1635 } 1636 1637 ParmVarDecl* Param; 1638 if (ArgType == UnpromotedArgType) 1639 Param = ParmVarDecl::Create(Context, ObjCMethod, ArgInfo[i].NameLoc, 1640 ArgInfo[i].Name, ArgType, 1641 VarDecl::None, 0); 1642 else 1643 Param = OriginalParmVarDecl::Create(Context, ObjCMethod, 1644 ArgInfo[i].NameLoc, 1645 ArgInfo[i].Name, ArgType, 1646 UnpromotedArgType, 1647 VarDecl::None, 0); 1648 1649 if (ArgType->isObjCInterfaceType()) { 1650 Diag(ArgInfo[i].NameLoc, 1651 diag::err_object_cannot_be_passed_returned_by_value) 1652 << 1 << ArgType; 1653 Param->setInvalidDecl(); 1654 } 1655 1656 Param->setObjCDeclQualifier( 1657 CvtQTToAstBitMask(ArgInfo[i].DeclSpec.getObjCDeclQualifier())); 1658 1659 // Apply the attributes to the parameter. 1660 ProcessDeclAttributeList(TUScope, Param, ArgInfo[i].ArgAttrs); 1661 1662 Params.push_back(Param); 1663 } 1664 1665 ObjCMethod->setMethodParams(Context, Params.data(), Sel.getNumArgs()); 1666 ObjCMethod->setObjCDeclQualifier( 1667 CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier())); 1668 const ObjCMethodDecl *PrevMethod = 0; 1669 1670 if (AttrList) 1671 ProcessDeclAttributeList(TUScope, ObjCMethod, AttrList); 1672 1673 // For implementations (which can be very "coarse grain"), we add the 1674 // method now. This allows the AST to implement lookup methods that work 1675 // incrementally (without waiting until we parse the @end). It also allows 1676 // us to flag multiple declaration errors as they occur. 1677 if (ObjCImplementationDecl *ImpDecl = 1678 dyn_cast<ObjCImplementationDecl>(ClassDecl)) { 1679 if (MethodType == tok::minus) { 1680 PrevMethod = ImpDecl->getInstanceMethod(Sel); 1681 ImpDecl->addInstanceMethod(ObjCMethod); 1682 } else { 1683 PrevMethod = ImpDecl->getClassMethod(Sel); 1684 ImpDecl->addClassMethod(ObjCMethod); 1685 } 1686 if (AttrList) 1687 Diag(EndLoc, diag::warn_attribute_method_def); 1688 } 1689 else if (ObjCCategoryImplDecl *CatImpDecl = 1690 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) { 1691 if (MethodType == tok::minus) { 1692 PrevMethod = CatImpDecl->getInstanceMethod(Sel); 1693 CatImpDecl->addInstanceMethod(ObjCMethod); 1694 } else { 1695 PrevMethod = CatImpDecl->getClassMethod(Sel); 1696 CatImpDecl->addClassMethod(ObjCMethod); 1697 } 1698 if (AttrList) 1699 Diag(EndLoc, diag::warn_attribute_method_def); 1700 } 1701 if (PrevMethod) { 1702 // You can never have two method definitions with the same name. 1703 Diag(ObjCMethod->getLocation(), diag::err_duplicate_method_decl) 1704 << ObjCMethod->getDeclName(); 1705 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 1706 } 1707 return DeclPtrTy::make(ObjCMethod); 1708} 1709 1710void Sema::CheckObjCPropertyAttributes(QualType PropertyTy, 1711 SourceLocation Loc, 1712 unsigned &Attributes) { 1713 // FIXME: Improve the reported location. 1714 1715 // readonly and readwrite/assign/retain/copy conflict. 1716 if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1717 (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 1718 ObjCDeclSpec::DQ_PR_assign | 1719 ObjCDeclSpec::DQ_PR_copy | 1720 ObjCDeclSpec::DQ_PR_retain))) { 1721 const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 1722 "readwrite" : 1723 (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 1724 "assign" : 1725 (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 1726 "copy" : "retain"; 1727 1728 Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 1729 diag::err_objc_property_attr_mutually_exclusive : 1730 diag::warn_objc_property_attr_mutually_exclusive) 1731 << "readonly" << which; 1732 } 1733 1734 // Check for copy or retain on non-object types. 1735 if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) && 1736 !Context.isObjCObjectPointerType(PropertyTy)) { 1737 Diag(Loc, diag::err_objc_property_requires_object) 1738 << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain"); 1739 Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain); 1740 } 1741 1742 // Check for more than one of { assign, copy, retain }. 1743 if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 1744 if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1745 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1746 << "assign" << "copy"; 1747 Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1748 } 1749 if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1750 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1751 << "assign" << "retain"; 1752 Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1753 } 1754 } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1755 if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1756 Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1757 << "copy" << "retain"; 1758 Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1759 } 1760 } 1761 1762 // Warn if user supplied no assignment attribute, property is 1763 // readwrite, and this is an object type. 1764 if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1765 ObjCDeclSpec::DQ_PR_retain)) && 1766 !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1767 Context.isObjCObjectPointerType(PropertyTy)) { 1768 // Skip this warning in gc-only mode. 1769 if (getLangOptions().getGCMode() != LangOptions::GCOnly) 1770 Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 1771 1772 // If non-gc code warn that this is likely inappropriate. 1773 if (getLangOptions().getGCMode() == LangOptions::NonGC) 1774 Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1775 1776 // FIXME: Implement warning dependent on NSCopying being 1777 // implemented. See also: 1778 // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 1779 // (please trim this list while you are at it). 1780 } 1781 1782 if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 1783 && getLangOptions().getGCMode() == LangOptions::GCOnly 1784 && PropertyTy->isBlockPointerType()) 1785 Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 1786} 1787 1788Sema::DeclPtrTy Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 1789 FieldDeclarator &FD, 1790 ObjCDeclSpec &ODS, 1791 Selector GetterSel, 1792 Selector SetterSel, 1793 DeclPtrTy ClassCategory, 1794 bool *isOverridingProperty, 1795 tok::ObjCKeywordKind MethodImplKind) { 1796 unsigned Attributes = ODS.getPropertyAttributes(); 1797 bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 1798 // default is readwrite! 1799 !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 1800 // property is defaulted to 'assign' if it is readwrite and is 1801 // not retain or copy 1802 bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 1803 (isReadWrite && 1804 !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 1805 !(Attributes & ObjCDeclSpec::DQ_PR_copy))); 1806 QualType T = GetTypeForDeclarator(FD.D, S); 1807 Decl *ClassDecl = ClassCategory.getAs<Decl>(); 1808 ObjCInterfaceDecl *CCPrimary = 0; // continuation class's primary class 1809 // May modify Attributes. 1810 CheckObjCPropertyAttributes(T, AtLoc, Attributes); 1811 if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 1812 if (!CDecl->getIdentifier()) { 1813 // This is a continuation class. property requires special 1814 // handling. 1815 if ((CCPrimary = CDecl->getClassInterface())) { 1816 // Find the property in continuation class's primary class only. 1817 ObjCPropertyDecl *PIDecl = 0; 1818 IdentifierInfo *PropertyId = FD.D.getIdentifier(); 1819 for (ObjCInterfaceDecl::prop_iterator 1820 I = CCPrimary->prop_begin(), E = CCPrimary->prop_end(); 1821 I != E; ++I) 1822 if ((*I)->getIdentifier() == PropertyId) { 1823 PIDecl = *I; 1824 break; 1825 } 1826 1827 if (PIDecl) { 1828 // property 'PIDecl's readonly attribute will be over-ridden 1829 // with continuation class's readwrite property attribute! 1830 unsigned PIkind = PIDecl->getPropertyAttributes(); 1831 if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 1832 if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) != 1833 (PIkind & ObjCPropertyDecl::OBJC_PR_nonatomic)) 1834 Diag(AtLoc, diag::warn_property_attr_mismatch); 1835 PIDecl->makeitReadWriteAttribute(); 1836 if (Attributes & ObjCDeclSpec::DQ_PR_retain) 1837 PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 1838 if (Attributes & ObjCDeclSpec::DQ_PR_copy) 1839 PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 1840 PIDecl->setSetterName(SetterSel); 1841 } 1842 else 1843 Diag(AtLoc, diag::err_use_continuation_class) 1844 << CCPrimary->getDeclName(); 1845 *isOverridingProperty = true; 1846 // Make sure setter decl is synthesized, and added to primary 1847 // class's list. 1848 ProcessPropertyDecl(PIDecl, CCPrimary); 1849 return DeclPtrTy(); 1850 } 1851 // No matching property found in the primary class. Just fall thru 1852 // and add property to continuation class's primary class. 1853 ClassDecl = CCPrimary; 1854 } else { 1855 Diag(CDecl->getLocation(), diag::err_continuation_class); 1856 *isOverridingProperty = true; 1857 return DeclPtrTy(); 1858 } 1859 } 1860 1861 DeclContext *DC = dyn_cast<DeclContext>(ClassDecl); 1862 assert(DC && "ClassDecl is not a DeclContext"); 1863 ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 1864 FD.D.getIdentifierLoc(), 1865 FD.D.getIdentifier(), T); 1866 DC->addDecl(PDecl); 1867 1868 if (T->isArrayType() || T->isFunctionType()) { 1869 Diag(AtLoc, diag::err_property_type) << T; 1870 PDecl->setInvalidDecl(); 1871 } 1872 1873 ProcessDeclAttributes(S, PDecl, FD.D); 1874 1875 // Regardless of setter/getter attribute, we save the default getter/setter 1876 // selector names in anticipation of declaration of setter/getter methods. 1877 PDecl->setGetterName(GetterSel); 1878 PDecl->setSetterName(SetterSel); 1879 1880 if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 1881 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 1882 1883 if (Attributes & ObjCDeclSpec::DQ_PR_getter) 1884 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 1885 1886 if (Attributes & ObjCDeclSpec::DQ_PR_setter) 1887 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 1888 1889 if (isReadWrite) 1890 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 1891 1892 if (Attributes & ObjCDeclSpec::DQ_PR_retain) 1893 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 1894 1895 if (Attributes & ObjCDeclSpec::DQ_PR_copy) 1896 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 1897 1898 if (isAssign) 1899 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 1900 1901 if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 1902 PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 1903 1904 if (MethodImplKind == tok::objc_required) 1905 PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 1906 else if (MethodImplKind == tok::objc_optional) 1907 PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 1908 // A case of continuation class adding a new property in the class. This 1909 // is not what it was meant for. However, gcc supports it and so should we. 1910 // Make sure setter/getters are declared here. 1911 if (CCPrimary) 1912 ProcessPropertyDecl(PDecl, CCPrimary); 1913 1914 return DeclPtrTy::make(PDecl); 1915} 1916 1917/// ActOnPropertyImplDecl - This routine performs semantic checks and 1918/// builds the AST node for a property implementation declaration; declared 1919/// as @synthesize or @dynamic. 1920/// 1921Sema::DeclPtrTy Sema::ActOnPropertyImplDecl(SourceLocation AtLoc, 1922 SourceLocation PropertyLoc, 1923 bool Synthesize, 1924 DeclPtrTy ClassCatImpDecl, 1925 IdentifierInfo *PropertyId, 1926 IdentifierInfo *PropertyIvar) { 1927 Decl *ClassImpDecl = ClassCatImpDecl.getAs<Decl>(); 1928 // Make sure we have a context for the property implementation declaration. 1929 if (!ClassImpDecl) { 1930 Diag(AtLoc, diag::error_missing_property_context); 1931 return DeclPtrTy(); 1932 } 1933 ObjCPropertyDecl *property = 0; 1934 ObjCInterfaceDecl* IDecl = 0; 1935 // Find the class or category class where this property must have 1936 // a declaration. 1937 ObjCImplementationDecl *IC = 0; 1938 ObjCCategoryImplDecl* CatImplClass = 0; 1939 if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 1940 IDecl = IC->getClassInterface(); 1941 // We always synthesize an interface for an implementation 1942 // without an interface decl. So, IDecl is always non-zero. 1943 assert(IDecl && 1944 "ActOnPropertyImplDecl - @implementation without @interface"); 1945 1946 // Look for this property declaration in the @implementation's @interface 1947 property = IDecl->FindPropertyDeclaration(PropertyId); 1948 if (!property) { 1949 Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 1950 return DeclPtrTy(); 1951 } 1952 } 1953 else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 1954 if (Synthesize) { 1955 Diag(AtLoc, diag::error_synthesize_category_decl); 1956 return DeclPtrTy(); 1957 } 1958 IDecl = CatImplClass->getClassInterface(); 1959 if (!IDecl) { 1960 Diag(AtLoc, diag::error_missing_property_interface); 1961 return DeclPtrTy(); 1962 } 1963 ObjCCategoryDecl *Category = 1964 IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 1965 1966 // If category for this implementation not found, it is an error which 1967 // has already been reported eralier. 1968 if (!Category) 1969 return DeclPtrTy(); 1970 // Look for this property declaration in @implementation's category 1971 property = Category->FindPropertyDeclaration(PropertyId); 1972 if (!property) { 1973 Diag(PropertyLoc, diag::error_bad_category_property_decl) 1974 << Category->getDeclName(); 1975 return DeclPtrTy(); 1976 } 1977 } else { 1978 Diag(AtLoc, diag::error_bad_property_context); 1979 return DeclPtrTy(); 1980 } 1981 ObjCIvarDecl *Ivar = 0; 1982 // Check that we have a valid, previously declared ivar for @synthesize 1983 if (Synthesize) { 1984 // @synthesize 1985 if (!PropertyIvar) 1986 PropertyIvar = PropertyId; 1987 QualType PropType = Context.getCanonicalType(property->getType()); 1988 // Check that this is a previously declared 'ivar' in 'IDecl' interface 1989 ObjCInterfaceDecl *ClassDeclared; 1990 Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 1991 if (!Ivar) { 1992 DeclContext *EnclosingContext = cast_or_null<DeclContext>(IDecl); 1993 assert(EnclosingContext && 1994 "null DeclContext for synthesized ivar - ActOnPropertyImplDecl"); 1995 Ivar = ObjCIvarDecl::Create(Context, EnclosingContext, PropertyLoc, 1996 PropertyIvar, PropType, 1997 ObjCIvarDecl::Public, 1998 (Expr *)0); 1999 Ivar->setLexicalDeclContext(IDecl); 2000 IDecl->addDecl(Ivar); 2001 property->setPropertyIvarDecl(Ivar); 2002 if (!getLangOptions().ObjCNonFragileABI) 2003 Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 2004 // Note! I deliberately want it to fall thru so, we have a 2005 // a property implementation and to avoid future warnings. 2006 } 2007 else if (getLangOptions().ObjCNonFragileABI && 2008 ClassDeclared != IDecl) { 2009 Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 2010 << property->getDeclName() << Ivar->getDeclName() 2011 << ClassDeclared->getDeclName(); 2012 Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 2013 << Ivar << Ivar->getNameAsCString(); 2014 // Note! I deliberately want it to fall thru so more errors are caught. 2015 } 2016 QualType IvarType = Context.getCanonicalType(Ivar->getType()); 2017 2018 // Check that type of property and its ivar are type compatible. 2019 if (PropType != IvarType) { 2020 if (CheckAssignmentConstraints(PropType, IvarType) != Compatible) { 2021 Diag(PropertyLoc, diag::error_property_ivar_type) 2022 << property->getDeclName() << Ivar->getDeclName(); 2023 // Note! I deliberately want it to fall thru so, we have a 2024 // a property implementation and to avoid future warnings. 2025 } 2026 2027 // FIXME! Rules for properties are somewhat different that those 2028 // for assignments. Use a new routine to consolidate all cases; 2029 // specifically for property redeclarations as well as for ivars. 2030 QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType(); 2031 QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 2032 if (lhsType != rhsType && 2033 lhsType->isArithmeticType()) { 2034 Diag(PropertyLoc, diag::error_property_ivar_type) 2035 << property->getDeclName() << Ivar->getDeclName(); 2036 // Fall thru - see previous comment 2037 } 2038 // __weak is explicit. So it works on Canonical type. 2039 if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 2040 getLangOptions().getGCMode() != LangOptions::NonGC) { 2041 Diag(PropertyLoc, diag::error_weak_property) 2042 << property->getDeclName() << Ivar->getDeclName(); 2043 // Fall thru - see previous comment 2044 } 2045 if ((Context.isObjCObjectPointerType(property->getType()) || 2046 PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 2047 getLangOptions().getGCMode() != LangOptions::NonGC) { 2048 Diag(PropertyLoc, diag::error_strong_property) 2049 << property->getDeclName() << Ivar->getDeclName(); 2050 // Fall thru - see previous comment 2051 } 2052 } 2053 } else if (PropertyIvar) 2054 // @dynamic 2055 Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 2056 assert (property && "ActOnPropertyImplDecl - property declaration missing"); 2057 ObjCPropertyImplDecl *PIDecl = 2058 ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 2059 property, 2060 (Synthesize ? 2061 ObjCPropertyImplDecl::Synthesize 2062 : ObjCPropertyImplDecl::Dynamic), 2063 Ivar); 2064 if (IC) { 2065 if (Synthesize) 2066 if (ObjCPropertyImplDecl *PPIDecl = 2067 IC->FindPropertyImplIvarDecl(PropertyIvar)) { 2068 Diag(PropertyLoc, diag::error_duplicate_ivar_use) 2069 << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 2070 << PropertyIvar; 2071 Diag(PPIDecl->getLocation(), diag::note_previous_use); 2072 } 2073 2074 if (ObjCPropertyImplDecl *PPIDecl 2075 = IC->FindPropertyImplDecl(PropertyId)) { 2076 Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 2077 Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 2078 return DeclPtrTy(); 2079 } 2080 IC->addPropertyImplementation(PIDecl); 2081 } 2082 else { 2083 if (Synthesize) 2084 if (ObjCPropertyImplDecl *PPIDecl = 2085 CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 2086 Diag(PropertyLoc, diag::error_duplicate_ivar_use) 2087 << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 2088 << PropertyIvar; 2089 Diag(PPIDecl->getLocation(), diag::note_previous_use); 2090 } 2091 2092 if (ObjCPropertyImplDecl *PPIDecl = 2093 CatImplClass->FindPropertyImplDecl(PropertyId)) { 2094 Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 2095 Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 2096 return DeclPtrTy(); 2097 } 2098 CatImplClass->addPropertyImplementation(PIDecl); 2099 } 2100 2101 return DeclPtrTy::make(PIDecl); 2102} 2103 2104bool Sema::CheckObjCDeclScope(Decl *D) { 2105 if (isa<TranslationUnitDecl>(CurContext->getLookupContext())) 2106 return false; 2107 2108 Diag(D->getLocation(), diag::err_objc_decls_may_only_appear_in_global_scope); 2109 D->setInvalidDecl(); 2110 2111 return true; 2112} 2113 2114/// Called whenever @defs(ClassName) is encountered in the source. Inserts the 2115/// instance variables of ClassName into Decls. 2116void Sema::ActOnDefs(Scope *S, DeclPtrTy TagD, SourceLocation DeclStart, 2117 IdentifierInfo *ClassName, 2118 llvm::SmallVectorImpl<DeclPtrTy> &Decls) { 2119 // Check that ClassName is a valid class 2120 ObjCInterfaceDecl *Class = getObjCInterfaceDecl(ClassName); 2121 if (!Class) { 2122 Diag(DeclStart, diag::err_undef_interface) << ClassName; 2123 return; 2124 } 2125 if (LangOpts.ObjCNonFragileABI) { 2126 Diag(DeclStart, diag::err_atdef_nonfragile_interface); 2127 return; 2128 } 2129 2130 // Collect the instance variables 2131 llvm::SmallVector<FieldDecl*, 32> RecFields; 2132 Context.CollectObjCIvars(Class, RecFields); 2133 // For each ivar, create a fresh ObjCAtDefsFieldDecl. 2134 for (unsigned i = 0; i < RecFields.size(); i++) { 2135 FieldDecl* ID = RecFields[i]; 2136 RecordDecl *Record = dyn_cast<RecordDecl>(TagD.getAs<Decl>()); 2137 Decl *FD = ObjCAtDefsFieldDecl::Create(Context, Record, ID->getLocation(), 2138 ID->getIdentifier(), ID->getType(), 2139 ID->getBitWidth()); 2140 Decls.push_back(Sema::DeclPtrTy::make(FD)); 2141 } 2142 2143 // Introduce all of these fields into the appropriate scope. 2144 for (llvm::SmallVectorImpl<DeclPtrTy>::iterator D = Decls.begin(); 2145 D != Decls.end(); ++D) { 2146 FieldDecl *FD = cast<FieldDecl>(D->getAs<Decl>()); 2147 if (getLangOptions().CPlusPlus) 2148 PushOnScopeChains(cast<FieldDecl>(FD), S); 2149 else if (RecordDecl *Record = dyn_cast<RecordDecl>(TagD.getAs<Decl>())) 2150 Record->addDecl(FD); 2151 } 2152} 2153 2154