Searched hist:69257 (Results 1 - 4 of 4) sorted by relevance

/freebsd-10.2-release/share/doc/papers/relengr/
H A D0.tdiff 69257 Mon Nov 27 07:55:08 MST 2000 ru Eliminate groff(1) warnings: unbreak refer(1)ences.
H A DMakefilediff 69257 Mon Nov 27 07:55:08 MST 2000 ru Eliminate groff(1) warnings: unbreak refer(1)ences.
/freebsd-10.2-release/sys/i386/include/
H A Din_cksum.hdiff 172835 Sat Oct 20 22:18:42 MDT 2007 bz Fold multiple asm statements into one so that the compiler at a certain
optimization level (-march=pentium-mmx for example) does not insert
intermediate ops which would trash the carry.

Change both sys/i386/i386/in_cksum.c[1] and sys/i386/include/in_cksum.h.

To my best understanding the same problem was addressed in rev. 1.16
of src/sys/i386/include/in_cksum.h for just a single function 3y ago.

Reviewed by: jhb
Submitted by: Zhouyi ZHOU <zhouzhouyi FreeBSD.org> (intial version of [1])
MFC after: 5 days
PR: 115678, 69257
diff 134300 Wed Aug 25 18:28:15 MDT 2004 obrien Fix a bug in in_cksum_hdr w/o -O.

The C code assumes that the carry bit is always kept from the previous
operation. However, the pointer indexing requires another add operation.
Thus, the carry bit from the first operation is tromped over by the
"addl" operation that ends up following it, so the "adcl" that follows
that has no effect because the carry bit is cleared before it.
The result is checksum failure on received packets.

The larger issue is that there isn't any other way of preventing the compiler
inserting arbitrary instructions between different __asm statements (and
that the commit message in revision 1.13 of in_cksum.h is wrong on
this point). From
http://developer.apple.com/documentation/DeveloperTools/gcc-3.3/gcc/Extended-Asm.html
---8<---8<---8<---
You can't expect a sequence of volatile asm instructions to remain
perfectly consecutive. If you want consecutive output, use a single
asm. Also, GCC will perform some optimizations across a volatile
asm instruction; GCC does not "forget everything" when it encounters
a volatile asm instruction the way some other compilers do.
---8<---8<---8<---

Also, this change also makes the ASM code much easier to read.

PR: 69257
Submitted by: Mike Bristow <mike@urgle.com>, Qing Li <qing.li@bluecoat.com>
/freebsd-10.2-release/sys/i386/i386/
H A Din_cksum.cdiff 172835 Sat Oct 20 22:18:42 MDT 2007 bz Fold multiple asm statements into one so that the compiler at a certain
optimization level (-march=pentium-mmx for example) does not insert
intermediate ops which would trash the carry.

Change both sys/i386/i386/in_cksum.c[1] and sys/i386/include/in_cksum.h.

To my best understanding the same problem was addressed in rev. 1.16
of src/sys/i386/include/in_cksum.h for just a single function 3y ago.

Reviewed by: jhb
Submitted by: Zhouyi ZHOU <zhouzhouyi FreeBSD.org> (intial version of [1])
MFC after: 5 days
PR: 115678, 69257

Completed in 114 milliseconds