Searched hist:203734 (Results 1 - 1 of 1) sorted by relevance

/freebsd-11-stable/lib/libc/stdlib/
H A Dstrfmon.cdiff 203734 Tue Feb 09 22:05:09 MST 2010 cracauer Fix PR
http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/143350
Empty string test gone wrong.

Testing this requires that you have a locale that has the sign string
unset but has int_n_sign_posn set (the default locale falls through to
use "()" around negative numbers which is probably another bug).

I created that setup by hand and indeed without this fix negative
numbers are put out as positive numbers (doesn't fall through to use
"-" as default indicator).

Unfixed example in nl_NL.ISO8859-1 with lc->negative_sign set to empty
string:
strfmon(buf, sizeof(buf), "%-8i", -42.0);
==>
example2: 'EUR 42,00' 'Eu 42,00'

Fixed:
example2: 'EUR 42,00-' 'Eu 42,00-'

This file and suggested fix are identical in at least freebsd-8.
Backport might be appropriate but some expert on locales should
probably have a look at us defaulting to negative numbers in
parenthesis when LC_* is default. That doesn't look right and is not
what other OSes are doing.

PR: 143350
Submitted by: Corinna Vinschen
Reviewed by: bug reporter submitted, tested by me

Completed in 60 milliseconds