Searched +hist:3426 +hist:ce14 (Results 1 - 1 of 1) sorted by relevance
/haiku/src/system/kernel/cache/ | ||
H A D | block_cache.cpp | diff 3426ce14 Wed Aug 04 07:19:20 MDT 2010 Axel Dörfler <axeld@pinc-software.de> * Thanks to Janito I had a closer look to cache_detach_sub_transaction(), and it turned out it's pretty much broken. Not only did it potentially leak memory, it would also potentially replace the original data with a NULL pointer, making the current transaction non revertable. The code should now be much clearer. This fixes bug #6378. * Changed a few "if (... != NULL)" into ASSERTs, since the code should bail out earlier in these cases already. * Added a TODO comment to cache_start_sub_transaction() about its broken discard handling. This can cause FS corruptions in case the parent transaction is ever going to be aborted (which shouldn't happen in real life, though). * Added a bit more and better comments. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37899 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 3426ce14 Wed Aug 04 07:19:20 MDT 2010 Axel Dörfler <axeld@pinc-software.de> * Thanks to Janito I had a closer look to cache_detach_sub_transaction(), and it turned out it's pretty much broken. Not only did it potentially leak memory, it would also potentially replace the original data with a NULL pointer, making the current transaction non revertable. The code should now be much clearer. This fixes bug #6378. * Changed a few "if (... != NULL)" into ASSERTs, since the code should bail out earlier in these cases already. * Added a TODO comment to cache_start_sub_transaction() about its broken discard handling. This can cause FS corruptions in case the parent transaction is ever going to be aborted (which shouldn't happen in real life, though). * Added a bit more and better comments. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37899 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 3426ce140439483c07d632d956065c4eba08f8fd Wed Aug 04 07:19:20 MDT 2010 Axel Dörfler <axeld@pinc-software.de> * Thanks to Janito I had a closer look to cache_detach_sub_transaction(), and it turned out it's pretty much broken. Not only did it potentially leak memory, it would also potentially replace the original data with a NULL pointer, making the current transaction non revertable. The code should now be much clearer. This fixes bug #6378. * Changed a few "if (... != NULL)" into ASSERTs, since the code should bail out earlier in these cases already. * Added a TODO comment to cache_start_sub_transaction() about its broken discard handling. This can cause FS corruptions in case the parent transaction is ever going to be aborted (which shouldn't happen in real life, though). * Added a bit more and better comments. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37899 a95241bf-73f2-0310-859d-f6bbb57e9c96 |
Completed in 59 milliseconds