Searched +hist:2 +hist:c11ec31 (Results 1 - 4 of 4) sorted by relevance
/haiku/headers/private/interface/ | ||
H A D | MenuPrivate.h | diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31c876f2b77e3d03c9776dbf99119bbce7 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 |
/haiku/src/kits/interface/ | ||
H A D | MenuWindow.cpp | diff 2f86ba45 Sun Feb 15 11:23:19 MST 2009 Stephan Aßmus <superstippi@gmx.de> Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 5b752875 Mon Jan 03 17:59:49 MST 2005 Stefano Ceccherini <stefano.ceccherini@gmail.com> The frame around the BMenu is now drawn by a special class (as happens in beos), and not by BMenu::DrawBackground(). Refactored BMenuWindow to support scrolling (not implemented yet). The AddItem() functions now call the private _AddItem(). Implemented AddList(), but it's not tested. BMenus are now offsetted by 2, 2, as in BeOS. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10582 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 5b752875 Mon Jan 03 17:59:49 MST 2005 Stefano Ceccherini <stefano.ceccherini@gmail.com> The frame around the BMenu is now drawn by a special class (as happens in beos), and not by BMenu::DrawBackground(). Refactored BMenuWindow to support scrolling (not implemented yet). The AddItem() functions now call the private _AddItem(). Implemented AddList(), but it's not tested. BMenus are now offsetted by 2, 2, as in BeOS. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10582 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2f86ba45579bdc9648b232175f87edc62ab71b54 Sun Feb 15 11:23:19 MST 2009 Stephan Aßmus <superstippi@gmx.de> Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31c876f2b77e3d03c9776dbf99119bbce7 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 5b7528754df83835624e2536e13c848deb58ac93 Mon Jan 03 17:59:49 MST 2005 Stefano Ceccherini <stefano.ceccherini@gmail.com> The frame around the BMenu is now drawn by a special class (as happens in beos), and not by BMenu::DrawBackground(). Refactored BMenuWindow to support scrolling (not implemented yet). The AddItem() functions now call the private _AddItem(). Implemented AddList(), but it's not tested. BMenus are now offsetted by 2, 2, as in BeOS. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10582 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 5b7528754df83835624e2536e13c848deb58ac93 Mon Jan 03 17:59:49 MST 2005 Stefano Ceccherini <stefano.ceccherini@gmail.com> The frame around the BMenu is now drawn by a special class (as happens in beos), and not by BMenu::DrawBackground(). Refactored BMenuWindow to support scrolling (not implemented yet). The AddItem() functions now call the private _AddItem(). Implemented AddList(), but it's not tested. BMenus are now offsetted by 2, 2, as in BeOS. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10582 a95241bf-73f2-0310-859d-f6bbb57e9c96 |
H A D | MenuItem.cpp | diff 5f603da0 Tue Jul 17 13:03:11 MDT 2018 Adrien Destugues <pulkomandy@pulkomandy.tk> Better shape for submenu arrow Just use BControLook where appropriate. It already provides a nice arrow drawing function (also used in DeskBar expander and in scrollbar buttons). Fix second part of #8900 Changes by John Scipione: Update menu mark and submenu arrow color with menu text color Use text color for checkmark and submenu arrow colors, tint less black. This means that colored bg/white text menu item will also draw a white checkmark and submenu arrow. Break out BMenuItem::Draw functionality into private methods _IsActive, _LowColor() and _HighColor() methods and use them to set the mark colors. Scale submenu arrow and checkmark with item height (which scales with font size.) does not align shortcuts with submenu arrows... but if you were to do that you'd add item->Bounds().Height() / 2. Signed-off-by: John Scipione <jscipione@gmail.com> Change-Id: I8299094ef88bf227510b116eb1b84c261dc94723 Reviewed-on: https://review.haiku-os.org/c/341 Reviewed-by: Stefano Ceccherini <stefano.ceccherini@gmail.com> Reviewed-by: Axel Dörfler <axeld@pinc-software.de> Reviewed-by: waddlesplash <waddlesplash@gmail.com> diff 2bcccf5a Wed Mar 03 10:43:31 MST 2010 Stephan Aßmus <superstippi@gmx.de> Patch in part by "yourpalal": * Set the MENU_STATE_CLOSED state upon BMenu initialization. * When drawing the label, use the parent bounds, including item margins to truncate the label, when the parent menu is closed. Thanks a lot for the patch! Changes by myself: * Cache the MenuPrivate instance in BMenuItem::DrawContent(). * Use Window()->UpdateIfNeeded() to animate the flashing invoked menu item, which makes a lot more sense, the comment about it working in BeOS is probably due to item->Select() probably drawing outside of an update cycle. * The trigger invokation in keyboard handling didn't break out of the loop after invoking an item. Probably didn't matter since triggers are hopefully not assigned to more than one menu item. :-) * Use the same trick as BMenuBar to avoid interfering with keyboard navigation in the BMenu::_Track() hook. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35739 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2f86ba45 Sun Feb 15 11:23:19 MST 2009 Stephan Aßmus <superstippi@gmx.de> Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2cdfcae4 Tue Jan 18 08:10:46 MST 2005 Stefano Ceccherini <stefano.ceccherini@gmail.com> The LowColor() had to be resetted after having drawn the shortcut symbol. Corrected a weird typo. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10829 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2bcccf5a74b943b5cbff81d6481ee26bff244eec Wed Mar 03 10:43:31 MST 2010 Stephan Aßmus <superstippi@gmx.de> Patch in part by "yourpalal": * Set the MENU_STATE_CLOSED state upon BMenu initialization. * When drawing the label, use the parent bounds, including item margins to truncate the label, when the parent menu is closed. Thanks a lot for the patch! Changes by myself: * Cache the MenuPrivate instance in BMenuItem::DrawContent(). * Use Window()->UpdateIfNeeded() to animate the flashing invoked menu item, which makes a lot more sense, the comment about it working in BeOS is probably due to item->Select() probably drawing outside of an update cycle. * The trigger invokation in keyboard handling didn't break out of the loop after invoking an item. Probably didn't matter since triggers are hopefully not assigned to more than one menu item. :-) * Use the same trick as BMenuBar to avoid interfering with keyboard navigation in the BMenu::_Track() hook. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35739 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2f86ba45579bdc9648b232175f87edc62ab71b54 Sun Feb 15 11:23:19 MST 2009 Stephan Aßmus <superstippi@gmx.de> Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31c876f2b77e3d03c9776dbf99119bbce7 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2cdfcae44bbd86a30cd8278c1b9672b5924d495f Tue Jan 18 08:10:46 MST 2005 Stefano Ceccherini <stefano.ceccherini@gmail.com> The LowColor() had to be resetted after having drawn the shortcut symbol. Corrected a weird typo. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10829 a95241bf-73f2-0310-859d-f6bbb57e9c96 |
H A D | Menu.cpp | diff 2db8ba2c Fri Dec 04 08:01:57 MST 2020 Murai Takashi <tmurai01@gmail.com> Menu: Fix dead store Fix value stored to 'flags' is never read. Pointed out by Clang Static Analyzer. Change-Id: Ia154fbdd4dd5fb10716cf9079625ca65e2f58122 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3472 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com> diff 2e08685b Tue Mar 03 03:49:06 MST 2020 John Scipione <jscipione@gmail.com> BMenu: Rename FrameMoved and FrameResized variable names No functional change. lowercase_with_underscore file names are not in-line with Haiku's style guidelines. Change-Id: I254c975ee60168963ca4039a61dc428c05e0e6ba Reviewed-on: https://review.haiku-os.org/c/haiku/+/2306 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com> diff 5f603da0 Tue Jul 17 13:03:11 MDT 2018 Adrien Destugues <pulkomandy@pulkomandy.tk> Better shape for submenu arrow Just use BControLook where appropriate. It already provides a nice arrow drawing function (also used in DeskBar expander and in scrollbar buttons). Fix second part of #8900 Changes by John Scipione: Update menu mark and submenu arrow color with menu text color Use text color for checkmark and submenu arrow colors, tint less black. This means that colored bg/white text menu item will also draw a white checkmark and submenu arrow. Break out BMenuItem::Draw functionality into private methods _IsActive, _LowColor() and _HighColor() methods and use them to set the mark colors. Scale submenu arrow and checkmark with item height (which scales with font size.) does not align shortcuts with submenu arrows... but if you were to do that you'd add item->Bounds().Height() / 2. Signed-off-by: John Scipione <jscipione@gmail.com> Change-Id: I8299094ef88bf227510b116eb1b84c261dc94723 Reviewed-on: https://review.haiku-os.org/c/341 Reviewed-by: Stefano Ceccherini <stefano.ceccherini@gmail.com> Reviewed-by: Axel Dörfler <axeld@pinc-software.de> Reviewed-by: waddlesplash <waddlesplash@gmail.com> diff 2bcccf5a Wed Mar 03 10:43:31 MST 2010 Stephan Aßmus <superstippi@gmx.de> Patch in part by "yourpalal": * Set the MENU_STATE_CLOSED state upon BMenu initialization. * When drawing the label, use the parent bounds, including item margins to truncate the label, when the parent menu is closed. Thanks a lot for the patch! Changes by myself: * Cache the MenuPrivate instance in BMenuItem::DrawContent(). * Use Window()->UpdateIfNeeded() to animate the flashing invoked menu item, which makes a lot more sense, the comment about it working in BeOS is probably due to item->Select() probably drawing outside of an update cycle. * The trigger invokation in keyboard handling didn't break out of the loop after invoking an item. Probably didn't matter since triggers are hopefully not assigned to more than one menu item. :-) * Use the same trick as BMenuBar to avoid interfering with keyboard navigation in the BMenu::_Track() hook. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35739 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2f86ba45 Sun Feb 15 11:23:19 MST 2009 Stephan Aßmus <superstippi@gmx.de> Implemented a new look for the Haiku interface controls. It was overheard that they looked too ninety-ish. TODO: The code behind this is work in progress. The basic idea is to extract all drawing code into a new class BControlLook, of which there is a global instance be_control_look, instantiated in InterfaceDefs.cpp. At the moment, all the old drawing code is still there, and the usage of be_control_look is inside if-bodies checking the instance against NULL. In another words, by not instanitating be_control_look, you can revert back to the old look. BControlLook's job is to provide reusable methods for drawing certain types of frames, backgrounds and labels, so that application developers can make controls that re-use the same drawing code as built-in controls and adopt to changes made there. I have added the notion of "borders". Each of the frame drawing methods can be made to draw certain borders only, which is supposed to help when controls shall visually attach. This feature is not fully explored at all ATM. TODO: Update BColumnListView header view and BStringItem text spacing. Update other apps where it makes sense to use BControlLook. For the moment, only Tracker and LaunchBox are updated. More... NOTE: The new look is not very radically different, so that existing apps do not immediately look too ugly or out of place. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2e2bff94 Fri Sep 12 02:09:13 MDT 2008 Stefano Ceccherini <stefano.ceccherini@gmail.com> buttons could be used initialized if locking the looper failed (CID 1134) git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27440 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2a3de9bc Fri May 19 03:39:54 MDT 2006 Stephan Aßmus <superstippi@gmx.de> * use new (nothrow) when checking the returned pointer * better handling of errors in various versions of AddItem() git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17506 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2c11ec31 Fri Mar 03 12:31:09 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> BMenuItem also draws ctrl bitmap if needed, BTextView::AutoResize implemented more correctly git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16577 a95241bf-73f2-0310-859d-f6bbb57e9c96 diff 2a5bad15 Thu Feb 09 13:58:15 MST 2006 Stefano Ceccherini <stefano.ceccherini@gmail.com> Avoid menus in menufields going out of the screen in the upper part git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16316 a95241bf-73f2-0310-859d-f6bbb57e9c96 |
Completed in 331 milliseconds