8173425: Javadoc needs a new tag to specify the summary.
Reviewed-by: jjg

8057647: javac parser needs updates to have better error recovery for error cases of new array creation with dimensions
Reviewed-by: jlahoda

8182450: javac aborts when generating ct.sym intermittently
Summary: Initialize the module system model even in presence of missing/broken module-infos; BadClassFiles should not immediatelly abort compilation anymore, but should be handled as if the classfile did not exist.
Reviewed-by: jjg

8074364: Update error message for incorrect annotation type declaration
Summary: Issue a more direct, specific error when an annotation type is declared where it is disallowed
Reviewed-by: sadayapalam

8182776: Fix typos in module declarations
Reviewed-by: jjg, alanb

8183126: port improvements to analyzers from lvti repo to jdk10
Reviewed-by: mcimadamore, jlahoda

8068836: Error message should be updated when Override is used with static methods
Summary: Issue a more direct, specific error when @Override annotation is used with a static method
Reviewed-by: sadayapalam
Contributed-by: priya.lakshmi.muthuswamy@oracle.com

8182047: javac compile error on type-parameter-exceptions in lambda expressions
Reviewed-by: mcimadamore

8182649: Unable to integrate due to compilation error
Reviewed-by: mcimadamore

8182747: javac crashes on bad annotation value
Reviewed-by: mcimadamore

8183148: cleanup ModuleSymbol.getSimpleName
Reviewed-by: jjg

8058408: Compiler should emit a clearer message for invalid parenthesized expression
Reviewed-by: sadayapalam
Contributed-by: priya.lakshmi.muthuswamy@oracle.com

Merge

8163989: Clarify ModuleElement spec
Reviewed-by: abuckley, jjg

8182162: Remove -XD-Xmodule
Summary: Removing the undocumented -XD-Xmodule: option.
Reviewed-by: jjg

8182416: Clean up module-info.java like move requires transitive adjacent to exports
Reviewed-by: alanb

8181087: Module system implementation refresh (6/2017)
Reviewed-by: jjg
Contributed-by: alan.bateman@oracle.com, jan.lahoda@oracle.com

8181825: Add tool and services information to module summary
Reviewed-by: mchung, rfield

8181911: Lambda Analyzer causes compile-time error
Summary: When copying Env<AttrContext> for Analyzer, detach returnResult from the outer context.
Reviewed-by: mcimadamore

8144185: javac produces incorrect RuntimeInvisibleTypeAnnotations length attribute
Reviewed-by: sadayapalam

8180296: Move Javadoc: doclet, taglet specs to specs directory
Reviewed-by: ksrini

8170326: Inconsistencies between code, compiler.properties and comments
Summary: Converting uses of Log and JCDiagnostic.Factory methods to use CompilerProperties instead of plain Strings, fixing inconsistencies, adding crules analyzer to ensure CompilerProperties are used whenever possible.
Reviewed-by: mcimadamore

8181464: Invalid lambda in annotation causes NPE in Lint.augment
Reviewed-by: mcimadamore

8175794: Type inference regression after JDK-8078093
Reviewed-by: mcimadamore
Contributed-by: maurizio.cimadamore@oracle.com, vicente.romero@oracle.com

8180167: JDK9 message drop 40 l10n resource file updates
Reviewed-by: alanb, mchung, dfuchs, rfield, shinyafox, weijun, joehw
Contributed-by: li.jiang@oracle.com

7170058: Confusing error message from javac when overriding a method from a raw supertype
Reviewed-by: mcimadamore

8172880: Incorrect line number for NPE generated by instance-bound method reference
Summary: Synthetic null checks should have a LineNumberTable entry.
Reviewed-by: mcimadamore

8180660: missing LNT entry for finally block
Reviewed-by: mcimadamore, vromero
Contributed-by: maurizio.cimadamore@oracle.com, vicente.romero@oracle.com

8180720: method InferenceGraph.initNodes() can potentially add a trivial dependency of a node to itself
Reviewed-by: mcimadamore

8180745: Add --release 10 as an alias for --release 9
Reviewed-by: mcimadamore

Merge

8178152: Handling of incubating modules, the jdk.unsupported module and --add-exports with --release <current>
Summary: --release 9 should only allow documented modules; --add-exports/--add-reads/--patch-module should not be allowed on system modules when --release 9 is used.
Reviewed-by: jjg, erikj, ihse

8180141: Missing entry in LineNumberTable for break statement that jumps out of try-finally
Reviewed-by: mcimadamore

Merge

8179299: Fix HTML 5 errors in java.compiler module
8179300: Fix HTML 5 errors in jdk.compiler module
8179301: Fix HTML 5 errors in jdk.javadoc module
8179303: Fix HTML 5 errors in jdk.jshell module
Reviewed-by: darcy

8176327: javac produces wrong module-info
8178518: Add method JavaFileManager.contains
Reviewed-by: jlahoda

8178017: JDK 9 change to symlink handling causes misleading class.public.should.be.in.file diagnostic
Reviewed-by: jlahoda, cushon

8178012: Finish removal of -Xmodule:
Summary: Changing -Xmodule: option to -XD-Xmodule:, setting jtreg to use --patch-module instead of -Xmodule:.
Reviewed-by: jjg

8157763: update links to technotes in javadoc API
Reviewed-by: ksrini

8178509: MODULE_SOURCE_PATH: Implement missing methods
8178493: StandardJavaFileManager: Clarify/document the use of IllegalStateException
Reviewed-by: jlahoda

Merge

8178011: Automatic module warnings
Summary: Adding lints for automatic modules in requires and requires transitive directives.
Reviewed-by: jjg

8177530: Module system implementation refresh (4/2017)
Reviewed-by: jjg
Contributed-by: alan.bateman@oracle.com, jan.lahoda@oracle.com

8177933: Stackoverflow during compilation, starting jdk-9+163
Summary: Avoid extra method call in Attr.attribTree
Reviewed-by: vromero

8176572: Javac does not enforce module name restrictions
Reviewed-by: jlahoda

8177332: The presence of a file with a Japanese ShiftJIS name can cause javac to fail
Reviewed-by: jjg, jlahoda

Merge

8175116: jtreg agentvms uses more virtual address space in langtool/test :tier1 runs
Summary: Avoiding creation of an unnecessary read edge from jdk.compiler to a newly created unnamed module.
Reviewed-by: jlahoda

8173303: Add module-subgraph images to main platform documentation
Reviewed-by: alanb, chegar, erikj, ihse, lancea
Contributed-by: jonathan.gibbons@oracle.com, mandy.chung@oracle.com

8177311: Denied access when named module accesses unreferences package from the unnamed module
Summary: Ensure access to the unnamed module is allowed if the given module reads the unnamed module.
Reviewed-by: jjg

8175277: javadoc AssertionError when specified with release 8
Reviewed-by: jjg, jlahoda

8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
Reviewed-by: mcimadamore

8177097: Generic method reference returning wildcard parameterized type does not compile
Summary: Captured cache should not be used during 'fake' attr checks
Reviewed-by: vromero, jjg

Merge

8176743: tools/javac/modules/MOptionTest.java test fails on Mac
Summary: Correctly preferring classfiles over source files when timestamps match.
Reviewed-by: jjg

8176534: Missing check against target-type during applicability inference
Summary: PartiallyInferredMethodType should check against target if unchecked conversion occurred
Reviewed-by: vromero

8175119: Need to specify module of types created by Filer.createSourceFile/Filer.createClassFile?
Summary: Clarifications and improvements to jx.a.processing.Filer for creating and reading files in and from modules.
Reviewed-by: darcy, jjg

8176045: No compile error when a package is not declared
Summary: Fixing handling of otherwise empty files with package clauses and empty files without package clauses.
Reviewed-by: jjg

8175057: module-info on patch path should not produce an error
Summary: Allowing module-infos on patch paths during compilation.
Reviewed-by: jjg, ksrini

Merge

8175198: Javac incorrectly allows receiver parameters in annotation methods
Reviewed-by: mcimadamore

8176482: Use of DirectiveVisitor needs @DefinedBy annotation for RunCodingRules.java
Reviewed-by: jlahoda

8176470: javac Pretty printer should include doc comment for modules
Reviewed-by: vromero

8176477: Use DirectiveVisitor to print module information
Reviewed-by: jjg

8175235: type inference regression after JDK-8046685
Reviewed-by: mcimadamore
Contributed-by: vicente.romero@oracle.com, maurizio.cimadamore@oracle.com

8176265: Method overload resolution on a covariant base type doesn't work in 9
Summary: Some type mappings should not be recursive
Reviewed-by: vromero, jlahoda

8072114: javac performance should be improved
Summary: Avoiding unnecessary use of Stream.empty().
Reviewed-by: mcimadamore

8175317: javac does not issue unchecked warnings when checking method reference return types
Summary: Missing Warner object on method reference return type check
Reviewed-by: vromero

8175184: Annotation processor observes interface private methods as default methods
Reviewed-by: mcimadamore

Merge

8175560: Drop String pkgName from javax.tools.JavaFileManager.getLocationForModule(Location location, JavaFileObject fo, String pkgName)
Reviewed-by: jjg

8175118: Revisit modeling of module directives
Reviewed-by: darcy, jlahoda

8175790: field JCVariableDecl.vartype can't be null after post attribution analysis
Reviewed-by: mcimadamore

8175990: Javac fails to find module-info.java if module source path contains symlinks
Reviewed-by: jjg

8173914: StandardJavaFileManager.setLocationForModule
Reviewed-by: jlahoda

8175335: Improve handling of module types in javax.lang.model.util.Types
Reviewed-by: jjg, abuckley

8172956: JDK9 message drop 30 l10n resource file updates - open
Reviewed-by: joehw, mchung, smarks, sherman, henryjen
Contributed-by: li.jiang@oracle.com

8175191: dead code removal at package com.sun.tools.javac.comp
Reviewed-by: mcimadamore

8167638: javac can improve the error message issued when IllegalAccessError is produced
Reviewed-by: jjg

8174805: JavacTrees should use Types.skipTypeVars() to get the upper bound of type variables
Reviewed-by: jjg, ksrini

8173308: JAVAC_OPTIONS should be updated to align with JAVA_OPTIONS
Reviewed-by: jjg

8173596: JavaCompiler.CompilationTask should support addModules
Reviewed-by: ksrini, jlahoda

8175038: Wrong note about multiple type/package elements being found.
Summary: Avoiding quoting by a single '.
Reviewed-by: jjg

8175007: Incorrect error messages for inaccessible classes in visible packages
Summary: Recovery lookup may be triggered for inaccessible classes in visible packages - providing better errors.
Reviewed-by: mcimadamore

8174243: incorrect error message for nested service provider
Reviewed-by: jjg, jlahoda

8174695: Fix @since in module-info.java in dev/langtools repo
Reviewed-by: mcimadamore

8173945: Add methods for Elements.getAll{Type, Package, Module}Elements
Reviewed-by: jlahoda, jjg

8174245: Javadoc is not working for some methods
Summary: Parsing source file as if they were part of their corresponding modules.
Reviewed-by: rfield

8173777: Merge javac -Xmodule into javac--patch-module
Summary: Merging -Xmodule: functionality into --patch-module.
Reviewed-by: jjg, mchung, rfield

8174104: Compiler does not allow non-existent module path entry
Reviewed-by: jlahoda

8173393: Module system implementation refresh (2/2017)
Reviewed-by: mcimadamore, mchung, alanb
Contributed-by: alan.bateman@oracle.com, mandy.chung@oracle.com

8169200: Gen has a reference to Flow that is not used, should be removed
Reviewed-by: jjg

8174249: Regression in generic method unchecked calls
Summary: Erasure for unchecked call occurs too early after JDK-8078093
Reviewed-by: vromero

8174073: NPE caused by @link reference to class
Reviewed-by: jjg, ksrini

8174027: error message should adapt to the corresponding top level element
Reviewed-by: mcimadamore

Merge

6388543: improve accuracy of source positions for AnnotationValue param of Messager.printMessage
Reviewed-by: jjg

8174051: fix terminology in javadoc comment
Reviewed-by: darcy

8172901: javac: 'opens' statement cannot specify non observable package
Reviewed-by: jlahoda

8173636: Results from Processor.getSupportedAnnotationTypes should be intepreted strictly
Reviewed-by: darcy, jjg
Contributed-by: joe.darcy@oracle.com, jan.lahoda@oracle.com

8166420: Confusing error message when reading bad module declaration
Reviewed-by: jlahoda

8173456: com.sun.tools.javac.util.Assert.error during code compilation
Reviewed-by: mcimadamore

8172240: javac should not need the transitive closure to compile a module
Reviewed-by: jjg
Contributed-by: jan.lahoda@oracle.com

8172807: Javac doesn't report errors on duplicate provides with different service implementations
Reviewed-by: jlahoda

8166675: Latent bug in jar file handling during module path processing.
Reviewed-by: jlahoda

8171294: Slow compilation with long classpaths under JDK 9
Summary: Precompute packages contained in jars, to quickly determine at the lookup time whether a jar contains the given package
Reviewed-by: jjg
Contributed-by: maurizio.cimadamore@oracle.com

8172810: ModuleElement should declare and provide appropriate modifiers
Reviewed-by: darcy

8173609: Elements.printElements needs to support modules
Reviewed-by: forax, jjg

8081820: javadoc does not report warnings in case of multiple "@param" tags for the same parameter and multiple "@return" tags for the same method.
Reviewed-by: jjg
Contributed-by: istomin.den@gmail.com

8173312: Hide support for --inherit-runtime-environment
Reviewed-by: mchung

8173068: ElementUtils getPackageElement does not allow for an unnamed package
Summary: Removing special handling of unnamed packages in Elements.getPackageElement.
Reviewed-by: darcy, jjg, ksrini

8067747: javac throws exception during compilation when annotation processing is enabled
Summary: Enforcing Filer rules regarding initial inputs, to avoid downstream problems.
Reviewed-by: darcy, jjg

8171322: AssertionError in TypeSymbol.getAnnotationTypeMetadata.
Reviewed-by: vromero

8170692: inconsistent check of module-related options against target version
Reviewed-by: jjg

8173117: Compilation significantly slower after JDK-8169197
Summary: Only using recovery search when an error is inevitable.
Reviewed-by: jjg, mcimadamore

8172809: Error compiling javafx modules after fix for JDK-8169197
Summary: Properly stripping broken requires from ModuleSymbols.
Reviewed-by: jjg, mcimadamore

8171177: Compiler should issue a warning for incubating modules that are resolved
Summary: javac needs to follow ModuleResolution.DO_NOT_RESOLVE_BY_DEFAULT and ModuleResolution.WARN_INCUBATING
Reviewed-by: jjg

8171098: NPE when --add-modules java.corba is used
Summary: Block annotations queue until enter is done, to avoid flushing annotations during module resolution.
Reviewed-by: jjg

8147414: java.nio.file.ClosedFileSystemException in javadoc
Reviewed-by: vromero

8165102: incorrect message from javac
Reviewed-by: vromero

8169608: Compiler Tree API's Doctrees.getDocTreePath needs to accept a PackageElement
8157611: field visiblePackages is null for the unnamed module producing NPE when accessed
Reviewed-by: jjg, jlahoda

8138725: Add options for Javadoc generation
Reviewed-by: ksrini, bpatel, ahgross

8028544: Add SourceVersion.RELEASE_10
8028546: Add -source 10 and -target 10 to javac
Reviewed-by: jjg, smarks

8172262: packages missing from docs build
Summary: Do not return packages without members from Elements.getPackageElement(String), to avoid ambiguities among such packages in multiple modules.
Reviewed-by: jjg

8171993: AssertionError when compiling method reference with generic code and varargs.
Reviewed-by: mcimadamore

8172474: javac should enable doclint checking for HTML 5
Reviewed-by: jlahoda

Merge

8171528: Crash in Annotate with duplicate package-info declarations
Reviewed-by: jjg

8172213: Remove unused and partially implemented JavacElements#getSourcePosition methods
Reviewed-by: jjg

8172668: NPE in jdk.compiler/com.sun.tools.javac.comp.TypeEnter$ImportsPhase.importNamed(
Summary: Guarding against noType returned from ErrorType.getOriginalType.
Reviewed-by: mcimadamore

8171325: NPE in Check.clearLocalClassNameIndexes
Reviewed-by: mcimadamore

8169197: Improve error reporting for compiling against unexported package
Summary: When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.
Reviewed-by: mcimadamore, jjg

8171332: NPE in MembersPhase.finishClass
Reviewed-by: mcimadamore

8172411: -XDnoModules must be removed
Reviewed-by: jjg

8172158: Annotation processor not run with -source <= 8
Summary: Avoiding use of module prefix to map annotations to processors when running without modules.
Reviewed-by: darcy, jjg

8065800: javac, fix diagnostic position for statement-bodied lambdas
Reviewed-by: mcimadamore

8172214: typo in "intersection types in cast are not supported" message
Reviewed-by: mcimadamore

8144066: StackOverflowException when computing glb
Reviewed-by: mcimadamore

8169091: Method reference T::methodName for generic type T does not compile any more
Summary: MethodReferenceLookupHelper should use original site to perform unbound subtype check
Reviewed-by: vromero

8171132: Improve class reading of invalid or out-of-range ConstantValue attributes
Reviewed-by: mcimadamore

8171412: tools/javac/modules/AddLimitMods.java failed with "error: module not found"
Reviewed-by: mcimadamore

8171255: Javac generates Deprecated class file attribute for @deprecated javadoc tag on module declaration.
Reviewed-by: mcimadamore, anazarov

8169005: tools/javac/T8132562/ClassPathWithDoubleQuotesTest.java fails after fix to JDK-8132562
Reviewed-by: jjg

8160196: Module summary page should display information based on "api" or "detail" mode.
Reviewed-by: jjg, ksrini

8171371: Remove redundant type-arguments from generic method calls
Reviewed-by: jjg, rfield, mchung

8181370: Convert anonymous inner classes into lambdas/method references
Reviewed-by: jjg, rfield, mchung

8171355: Implement Elements.getOrigin
Summary: Adding implementation for javax.lang.model.util.Elements.getOrigin
Reviewed-by: darcy, jjg

8133896: Update javax.lang.model APIs
Reviewed-by: darcy, jjg

Merge

8170987: Module system implementation refresh (12/2016)
Reviewed-by: mcimadamore
Contributed-by: jonathan.gibbons@oracle.com, jan.lahoda@oracle.com, srikanth.adayapalam@oracle.com, alan.bateman@oracle.com, mandy.chung@oracle.com

8170553: javac info options should match launcher options
Reviewed-by: jlahoda

8075793: Source incompatibility for inference using -source 7
Summary: In pre-8 sources, avoid capture variables as inference bounds, consistent with old javac behavior
Reviewed-by: vromero, mcimadamore

8072988: Update javax.annotation.processing for modules
Summary: Support for generating files in multi-module mode.
Reviewed-by: darcy, jjg
Contributed-by: joe.darcy@oracle.com, jan.lahoda@oracle.com

8171005: Fix JavaFileManager.getLocationForModule(Location location, JavaFileObject fo, String pkgName) to work with location == CLASS_OUTPUT
Summary: JavaFileManager operations that allow module-oriented locations should also allow output locations.
Reviewed-by: jjg

8153229: JavacFiler.checkFileReopening drowns in exceptions after Modular Runtime Images change
Summary: Using Path.equals instead of Files.isSameFile to speed up Filer checks
Reviewed-by: jjg

8147527: Wrong code generated for postfix unary operators
Summary: Avoiding use of duplicated tree nodes when these may be changed in place.
Reviewed-by: mcimadamore, jlahoda
Contributed-by: bsrbnd@gmail.com

8170251: Add javax.tools.Tool.name()
Reviewed-by: darcy, mchung

8170667: ClassReader assigns method parameters from MethodParameters incorrectly when long/double parameters are present
Summary: MethodParameters attribute does not skip a slot for long/double.
Reviewed-by: vromero, jlahoda

8169618: JDK9 message drop interim resource updates - OpenJDK
Reviewed-by: rfield, peytoia, joehw, weijun
Contributed-by: li.jiang@oracle.com

8170410: inference: javac doesn't implement 18.2.5 correctly
Summary: javac does not generate constraints of the kind 'throws alpha' as described in the spec
Reviewed-by: vromero, dlsmith

8162712: StandardJavaFileManager.getModuleLocation() can't find a module
Reviewed-by: jlahoda

8166628: Compiling with annotation processing, access error in specific situation
Summary: Ensure member classes inside anonymous classes have a correct owner.
Reviewed-by: mcimadamore

Merge

8169069: Module system implementation refresh (11/2016)
Reviewed-by: mcimadamore, jjg, mchung, anazarov
Contributed-by: jonathan.gibbons@oracle.com, jan.lahoda@oracle.com, alan.bateman@oracle.com, mandy.chung@oracle.com, bhavesh.x.patel@oracle.com, andrey.x.nazarov@oracle.com

8169816: Move src.zip and jrt-fs.jar under the lib directory
Reviewed-by: alanb, erikj, jjg

8170301: remove debug print statement
Reviewed-by: ksrini

8164590: javac --inherit-runtime-environment fails with "cannot find modules: ALL-DEFAULT"
Reviewed-by: mchung

8163190: Clarify JavaFileManager use of \"module location\"
Reviewed-by: jlahoda

8169676: boolean result of Option.process is often ignored
Reviewed-by: ksrini, jlahoda

8169561: jshell tool: double shift-tab on variable crashes tool
Summary: Avoid crashe for unknown HTML tags; avoid crash for non-existing documentation; fix signature for JShell variables
Reviewed-by: rfield

8168312: javac throws NPE if annotation processor is specified and module is declared in a file named arbitrarily
Reviewed-by: jlahoda

8169447: javac should detect/reject repeated use of --patch-module on command line
Reviewed-by: jlahoda

8166700: NPE during invoking getEnclosedElements() on javax.lang.model.element.Element instance representing a package
Summary: Should not strip first parameter of a local class constructor for local classes in initializers.
Reviewed-by: jjg

8169093: Generics, javac not matching actual and formal arguments.
Summary: Make diagnostic for type-args arity mismatch consistent with the class case
Reviewed-by: vromero

8168854: javac erroneously reject a a service interface inner class in a provides clause
Summary: Java SE 9 proposed spec changes do not explicitly forbid a service interface to be an inner class - javac should follow
Reviewed-by: jjg

8167975: align javac --add-* modules options with launcher
Reviewed-by: jlahoda

8166635: getEnclosedElements() on package causes BadClassFile error
Summary: Properly reading typevars from enclosing scopes for local classes.
Reviewed-by: mcimadamore

8169074: Build is failing after JDK-8166538
Summary: Reverting d3dde3f775b8
Reviewed-by: darcy

8166538: Improve error reporting for compiling against unexported package
Summary: When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.
Reviewed-by: mcimadamore, jjg