Fix 2 shortcut bugs, one in Web+, one in S&T

It's really 2 instances of the same bug, we only want to consider a
fixed set of modifier keys ignoring the lock keys and left/right keys.

S&T: Activate S&T when only option down

and not any other modifier such as command or control or shift.

Fixes #10511

We need to be more strict here because Tracker defines Cmd+Opt+Up and
Cmd+Opt+Down shortcuts, S&T shouldn't override them.

S&T: Add the arrow key tab nav back

This undoes the partial fix to #9431, both sets of shortcuts are supported
for the time being. This mirrors the functionality of ctrl+arrows and
ctrl+tab/ctrl+shift+tab to cycle through apps and windows via Twitcher.

We really need system keybinding settings to fix #9431 properly.

Update S&T copyright headers

App Server: Update S&T window group navigation

Partially fixes #9431

Cycle through tabs in current S&T group with option+tab and backwards
with option+shift+tab
Cycle through S&T groups with option+PgDn and backwards with option+PgUp

This change allows apps to once again use option+arrows when inside of a S&T group
The problem isn’t truely fixed though, just moved to different shortcuts that hopefully will
conflict in fewer applications.

I also made some improvements to how S&T cycling works.

A single window is now considered to be part of a S&T group for the purposes
of cycling through S&T groups.

We loop around when you get the last tab/group.

When you cycle through S&T groups it remembers the active tab in the group
instead of always activating the first tab.

App Server, a few more style fixes

App Server: Move empty destructor to header.

App Server: Style fixes only

* 80 char limit fixes
* remove leading tabs/spaces
* Add some helpful pragmas
* Add some newlines to separate stuff
* Compare pointers to NULL explicitly

App Server: Fix typo

WindowActitvated => WindowActivated

StackAndTile: deferencing occuring before null check (CID 743845)

Move stacked windows to a different workspace correctly.

When moving a window of a stacked window group to a different workspace all windows in the stack have to be moved. This fixes #8855.

Integrate patch from jessicah #8937. Thanks!

- navigate in a single S&T group using (win + left and right arrows)
- minor fixed to the patch
- enable switching between S&T groups on the same desktop again (win + up and down arrows)

Hope window key + arrow keys does not collide with to many apps?

Fix hrev42632.

This really implements WindowSentBehind.

- The SATGroup has been deleted to early, that probably causes #8103. Holding a reference on the WindowArea (which hold a ref to the group) extends the lifetime till we are done.
- Fix some stayBelowMouse flags.

Activating all windows in a stack caused flickering. The reason to activate all windows was to get all windows form a stack into the upper window layers, otherwise it was possible that the top layer stack window is activated but another window in the stack is at the bottommost layer position. Sending this window to the back does not triggered sending the complete stack to the back. The send behind call is now redirected to the top most stack window to ensure the stack is send behind.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42632 a95241bf-73f2-0310-859d-f6bbb57e9c96

Only remove a window from the S&T group when the hide event is not triggered by a minimize call.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42611 a95241bf-73f2-0310-859d-f6bbb57e9c96

Don't remove the window if there is only one window in the group. Fixes #7884.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42567 a95241bf-73f2-0310-859d-f6bbb57e9c96

If a window is hidden remove it from the S&T group. This happens when MediaPlayer goes fullscreen. Maybe not optimal but at least consistent with terminal which also left the S&T group in fullscreen mode. This is because the terminal has no decorator in fullscreen mode and thus can't be stacked any more (maybe this should be solved in the future...). Fixes #7895, #7896.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42548 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix coding style pointed out by Axel. Thanks for the array trick haven't known this one :-)



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42539 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix 2 shortcut bugs, one in Web+, one in S&T

It's really 2 instances of the same bug, we only want to consider a
fixed set of modifier keys ignoring the lock keys and left/right keys.

S&T: Activate S&T when only option down

and not any other modifier such as command or control or shift.

Fixes #10511

We need to be more strict here because Tracker defines Cmd+Opt+Up and
Cmd+Opt+Down shortcuts, S&T shouldn't override them.

S&T: Add the arrow key tab nav back

This undoes the partial fix to #9431, both sets of shortcuts are supported
for the time being. This mirrors the functionality of ctrl+arrows and
ctrl+tab/ctrl+shift+tab to cycle through apps and windows via Twitcher.

We really need system keybinding settings to fix #9431 properly.

Update S&T copyright headers

App Server: Update S&T window group navigation

Partially fixes #9431

Cycle through tabs in current S&T group with option+tab and backwards
with option+shift+tab
Cycle through S&T groups with option+PgDn and backwards with option+PgUp

This change allows apps to once again use option+arrows when inside of a S&T group
The problem isn’t truely fixed though, just moved to different shortcuts that hopefully will
conflict in fewer applications.

I also made some improvements to how S&T cycling works.

A single window is now considered to be part of a S&T group for the purposes
of cycling through S&T groups.

We loop around when you get the last tab/group.

When you cycle through S&T groups it remembers the active tab in the group
instead of always activating the first tab.

App Server, a few more style fixes

App Server: Move empty destructor to header.

App Server: Style fixes only

* 80 char limit fixes
* remove leading tabs/spaces
* Add some helpful pragmas
* Add some newlines to separate stuff
* Compare pointers to NULL explicitly

App Server: Fix typo

WindowActitvated => WindowActivated

StackAndTile: deferencing occuring before null check (CID 743845)

Move stacked windows to a different workspace correctly.

When moving a window of a stacked window group to a different workspace all windows in the stack have to be moved. This fixes #8855.

Integrate patch from jessicah #8937. Thanks!

- navigate in a single S&T group using (win + left and right arrows)
- minor fixed to the patch
- enable switching between S&T groups on the same desktop again (win + up and down arrows)

Hope window key + arrow keys does not collide with to many apps?

Fix hrev42632.

This really implements WindowSentBehind.

- The SATGroup has been deleted to early, that probably causes #8103. Holding a reference on the WindowArea (which hold a ref to the group) extends the lifetime till we are done.
- Fix some stayBelowMouse flags.

Activating all windows in a stack caused flickering. The reason to activate all windows was to get all windows form a stack into the upper window layers, otherwise it was possible that the top layer stack window is activated but another window in the stack is at the bottommost layer position. Sending this window to the back does not triggered sending the complete stack to the back. The send behind call is now redirected to the top most stack window to ensure the stack is send behind.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42632 a95241bf-73f2-0310-859d-f6bbb57e9c96

Only remove a window from the S&T group when the hide event is not triggered by a minimize call.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42611 a95241bf-73f2-0310-859d-f6bbb57e9c96

Don't remove the window if there is only one window in the group. Fixes #7884.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42567 a95241bf-73f2-0310-859d-f6bbb57e9c96

If a window is hidden remove it from the S&T group. This happens when MediaPlayer goes fullscreen. Maybe not optimal but at least consistent with terminal which also left the S&T group in fullscreen mode. This is because the terminal has no decorator in fullscreen mode and thus can't be stacked any more (maybe this should be solved in the future...). Fixes #7895, #7896.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42548 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix coding style pointed out by Axel. Thanks for the array trick haven't known this one :-)



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42539 a95241bf-73f2-0310-859d-f6bbb57e9c96