#
8446d3b9 |
|
13-Dec-2023 |
John Scipione <jscipione@gmail.com> |
Tracker: Miscellaneous cleanup Move DraggableContainerIcon out of ContainerWindow.cpp into new. Move CompareLabels to Utilities.cpp Rename fContainerWindowFlags to fOpenFlags. These are the flags set by OpenContainerWindow to save and restore state and should not be confused with the windowFlags that are passed to BWindow. There are two sets of flags, which I'm calling openFlags and windowFlags. Rename fUseLayouts to fUsesLayout and useLayouts to useLayout. Put all the constructor created flags at the top. "window" variable name is ok, we don't need to say "containerWindow". Rename Addons to AddOns everywhere with a capital O. Rename BuildAddOnMenu() to BuildAddOnsMenu() with an s. Rename AttributeMenu...() methods to AttributesMenu...() with an s. Rename SetUp...() methods to Setup...() with a lowercase u. Replace a few instances of fPoseView with PoseView() inline in BContainerWindow and BDeskWindow. A few more minor fixes in BDeskWindow. Replace BPoint(0, 0) with B_ORIGIN in Pose.h Change-Id: If30803753b63b19e35f14c0f0c4e08111d0d0980 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7240 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
|
#
2b6ccde0 |
|
25-Apr-2023 |
John Scipione <jscipione@gmail.com> |
Tracker: Disable edit menu items on ro volumes ... such as virtual directories or read-only media. Also applies to open/save panels. Menu items disabled on read-only volumes: * New > * Duplicate * Move to Trash * Move To > * Cut * Paste Other reasons a menu item is disabled: * Duplicate, Move To Trash, Cut, Copy, Move to >, Copy to >, Create link > and Identify require a selection. * Paste requires something in your clipboard. * Edit name requires a single item is selected. Edit name is permitted on a read-only volume so that you may copy the name. However the name is not editable, you may only select and copy. Pop system folder warning dialog on Edit name commit instead, this way you won't see the dialog if you just want to copy the name. Move "Create link here" option last in the right- click drag menu. Disable "Move here" if source or dest is read-only, rest if dest is read-only. Ignore Paste to virtual directory, (even more) but permit Edit name. Allow drag-and-drop to virtual directory but alert and disable all right-click drag menu items like other read-only directories. Tint window backgrounds on all read-only windows darker, not just on virtual and query folders. Automatically switch the background color as you navigate in and out of read-only folders. Fix highlight color on column resize when background color is not white. Fix "reverse video" effect so that the highlight color is the inverse of the background color. On Desktop however, highlight color is always black or white. Do not alter focus in save dialogs after initial focus on the file name because focus on the pose view is required for cut/copy/paste to work. Make Edit Name work in file open/save dialogs and make Cut/Copy/Paste work while editing file name. Make Select all work in Edit name. Duplicate code cleanup: NameAttributeText::CommitEditedTextFlavor() and HeaderView::FinishEditingTitle() call common EditModelName() function in FSUtils. RealNameAttributeText inherits from NameAttributeText and calls its inherited CommitEditedTextFlavor() method. The alert text is defined in just one place in FSUtils ShouldEditRefName() instead of three. Consequently file name changed in the info window can now be undone. Change-Id: I3a78960057b8fb42d1f71af2ec3c808754c9b314 Reviewed-on: https://review.haiku-os.org/c/haiku/+/6357 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
b7dd18b2 |
|
02-May-2023 |
John Scipione <jscipione@gmail.com> |
Tracker: Style fixes only ... including whitespace, brackets, rename loc to where or location, add a pragma. Replace min_c with std::min. Replace BPoint(0, 0) with B_ORIGIN Use make_color() function to make static rgb_color objects. Change-Id: I47a4e5e5f0e7038643baca7539d211350bbb8f20 Reviewed-on: https://review.haiku-os.org/c/haiku/+/6404 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
|
#
75e66d61 |
|
13-Jul-2022 |
John Scipione <jscipione@gmail.com> |
Tracker: Improve repeated apps in Open with... menu If you have multiple Haiku installations mounted, it is common to have the same app on multiple volumes. This makes the Open with... menu show the full paths truncating them which makes it tough to see the app name you're looking for. Show volume and app names for repeated apps in Open with... menu instead of showing the full path. Keep track of whether each app in the list is a repeat and only display the volume for those. If there is only 1 app name, print it. If >1 app name and volume names are different, print [volume name] app name If >1 app name but volume names are the same, print full path Because many apps are in packages the volume is listed as [system] Make kMaxMenuWidth a bit wider. Compare app names and volume names using locale collator. Sort by name, determine labels, then sort by relation because repeats are not always consecutive once sorted by relation. Change-Id: I2c6c1db99065641cf4f940a69a47693480f151aa Reviewed-on: https://review.haiku-os.org/c/haiku/+/5448 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
|
#
2bd0b27f |
|
08-Apr-2015 |
Michael Lotz <mmlr@mlotz.ch> |
Tracker: Fix use-after-free by ref filter of OpenWithPoseView. Commit ea8b1e14 changed OpenWithPoseView from using ShouldShowPose for filtering poses to a BRefFilter. The introduced ref filter used the iterator handed to the BPoseView::AddPosesTask which took ownership of that iterator and deleted it as soon as it was done. Since actually adding the poses as well as further filtering is asynchronous and happens after the AddPosesTask completes, the iterator was used after it was already deleted. Introduce BPoseView::ReturnDirentIterator() that is called after the AddPosesTask is complete. The default version deletes the iterator, the OpenWithPoseView overrides it and does nothing, it deletes the iterator in the destructor instead. Also fix leaking the ref filter. The BPoseView does not take ownership of the filter as it usually comes from a BFilePanel which is documented to not take ownership.
|
#
0a74a005 |
|
08-Apr-2015 |
Michael Lotz <mmlr@mlotz.ch> |
Tracker: Remove two outdated comments, whitespace cleanup.
|
#
e7803cf1 |
|
26-Jan-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
Tracker: use the Layout API wherever possible. Sorry this commit is so big, but I couldn't figure out how to do this incrementally without breaking things. I wasn't able to just merge Aldeck's branch, as it was a partial refactor of Tracker and didn't just rewrite the UI creation code to use layouts, and the changes for PM (e.g. addon loading, virtual directories) made it very hard to merge (it doesn't even compile after an automerge) so rather than spending time on that, I decided it'd be better to recreate his work. Miscellaneous notes: - This partially cleans up BPoseView & subclasses and BContainerWindow & subclasses -- none of the subclasses and child views abuse the parent's state, child views, or layout now. - BFilePanel and BDeskWindow are not on layouts, because: * BFilePanel docs in the Be Book instructed developers that wanted to modify BFilePanel's layout to just use FindView() and then move the views around. Obviously making it use layouts will break all BeOS apps that do this, and there are a lot of them (Pe, WonderBrush are just two examples.) I've added a note to the TODO list for R2 to create a layout-compatible API for this. * Some replicants (Workspaces, for example) rely on manipulating BDeskWindow's drawing state. This is incompatible with layouts, as at least in the case of Workspaces, it breaks a layouted version of BDeskWindow entirely. - I noticed a lot of #ifdef BEOS_VERSION ... gunk in the code. Tracker probably didn't build on BeOS just before this commit, and now it won't for sure, so I intend to go through and clean that out in the near future. This commit also fixes: - enhancement #4996 (make Tracker's navigator use vector icons) - bug #3039 (resizing OpenWithWindow flashes the blue border) - bug #3889 (OpenWithWindow redraw errors) - a regression that was a side effect of "dynamic_cast<BDeskWindow*>(this)" always returning NULL when run in the constructor. I just added a "bool isDeskWindow" to BContainerWindow's constructor that is only set to true by BDeskWindow. - a copy&paste error in VirtualDirectoryPoseView that was passing "uint32 resizeMode" as "uint32 viewMode". Thanks to Alexandre for his original branch (it was a very useful reference), Axel (for some miscellaneous advice & encouragement), Adrien & Humdinger (for user interface review), and Diver (for user interface review & testing).
|
#
c5138395 |
|
20-Jun-2014 |
John Scipione <jscipione@gmail.com> |
Tracker: Style fixes to OpenWithWindow
|
#
ea8b1e14 |
|
07-Aug-2012 |
Philippe Saint-Pierre <stpere@gmail.com> |
OpenWithWindow: Fix crash at closing, and fix filtering Following hrev44493, the way ShouldShowPose was used changed a bit, to harmonize with type ahead filtering. This updates OpenWithWindow to use a BRefFilter to do its filtering rather than overloading ShouldShowPose.
|
#
a51764c5 |
|
27-Jul-2012 |
John Scipione <jscipione@gmail.com> |
WIP: Yet more style fixes, mostly 80 char violations.
|
#
b05aa8b5 |
|
27-Jul-2012 |
John Scipione <jscipione@gmail.com> |
Style changes in Tracker, no functional change. Manual whitespace cleanup Change instances of const char * to const char* Convert /* */ C style comments to // C++ style comments
|
#
1f34e928 |
|
14-Jul-2010 |
Alexandre Deckner <alex@zappotek.com> |
* Removed last remains of the OPEN_TRACKER define. * Cleanup of unused include. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37516 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
f28ab87b |
|
04-Oct-2008 |
Axel Dörfler <axeld@pinc-software.de> |
* Added "sortInodes" parameter to CachedEntryIteratorList constructor. * Moved static CompareInode() to CachedEntryIterator::_CompareInodes(). * Cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27869 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
269d3bd5 |
|
11-Jun-2006 |
Axel Dörfler <axeld@pinc-software.de> |
Imported PoseView.cpp 1.61, OpenWithWindow.cpp 1.8, and OpenWithWindow.h 1.3 from OpenTracker CVS. This fixes bug #354. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17796 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
66d3076d |
|
31-May-2006 |
Axel Dörfler <axeld@pinc-software.de> |
Cleanup, no functional change. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17667 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
02be5353 |
|
22-May-2005 |
Axel Dörfler <axeld@pinc-software.de> |
Added libtracker.so to the repository and the build. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12772 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
2bd0b27f5d9720741ba72afa21de0470b7521d13 |
|
08-Apr-2015 |
Michael Lotz <mmlr@mlotz.ch> |
Tracker: Fix use-after-free by ref filter of OpenWithPoseView. Commit ea8b1e14 changed OpenWithPoseView from using ShouldShowPose for filtering poses to a BRefFilter. The introduced ref filter used the iterator handed to the BPoseView::AddPosesTask which took ownership of that iterator and deleted it as soon as it was done. Since actually adding the poses as well as further filtering is asynchronous and happens after the AddPosesTask completes, the iterator was used after it was already deleted. Introduce BPoseView::ReturnDirentIterator() that is called after the AddPosesTask is complete. The default version deletes the iterator, the OpenWithPoseView overrides it and does nothing, it deletes the iterator in the destructor instead. Also fix leaking the ref filter. The BPoseView does not take ownership of the filter as it usually comes from a BFilePanel which is documented to not take ownership.
|
#
0a74a00526901d507086cac0592c9940efc24e60 |
|
08-Apr-2015 |
Michael Lotz <mmlr@mlotz.ch> |
Tracker: Remove two outdated comments, whitespace cleanup.
|
#
e7803cf1f69a81b1c77880518ba16b6708c1efdb |
|
26-Jan-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
Tracker: use the Layout API wherever possible. Sorry this commit is so big, but I couldn't figure out how to do this incrementally without breaking things. I wasn't able to just merge Aldeck's branch, as it was a partial refactor of Tracker and didn't just rewrite the UI creation code to use layouts, and the changes for PM (e.g. addon loading, virtual directories) made it very hard to merge (it doesn't even compile after an automerge) so rather than spending time on that, I decided it'd be better to recreate his work. Miscellaneous notes: - This partially cleans up BPoseView & subclasses and BContainerWindow & subclasses -- none of the subclasses and child views abuse the parent's state, child views, or layout now. - BFilePanel and BDeskWindow are not on layouts, because: * BFilePanel docs in the Be Book instructed developers that wanted to modify BFilePanel's layout to just use FindView() and then move the views around. Obviously making it use layouts will break all BeOS apps that do this, and there are a lot of them (Pe, WonderBrush are just two examples.) I've added a note to the TODO list for R2 to create a layout-compatible API for this. * Some replicants (Workspaces, for example) rely on manipulating BDeskWindow's drawing state. This is incompatible with layouts, as at least in the case of Workspaces, it breaks a layouted version of BDeskWindow entirely. - I noticed a lot of #ifdef BEOS_VERSION ... gunk in the code. Tracker probably didn't build on BeOS just before this commit, and now it won't for sure, so I intend to go through and clean that out in the near future. This commit also fixes: - enhancement #4996 (make Tracker's navigator use vector icons) - bug #3039 (resizing OpenWithWindow flashes the blue border) - bug #3889 (OpenWithWindow redraw errors) - a regression that was a side effect of "dynamic_cast<BDeskWindow*>(this)" always returning NULL when run in the constructor. I just added a "bool isDeskWindow" to BContainerWindow's constructor that is only set to true by BDeskWindow. - a copy&paste error in VirtualDirectoryPoseView that was passing "uint32 resizeMode" as "uint32 viewMode". Thanks to Alexandre for his original branch (it was a very useful reference), Axel (for some miscellaneous advice & encouragement), Adrien & Humdinger (for user interface review), and Diver (for user interface review & testing).
|
#
c513839558e708fe7c8171a8fd4f9dd99387cd4d |
|
20-Jun-2014 |
John Scipione <jscipione@gmail.com> |
Tracker: Style fixes to OpenWithWindow
|
#
ea8b1e14f9519b9aaca6e6ddea8b01babc311beb |
|
07-Aug-2012 |
Philippe Saint-Pierre <stpere@gmail.com> |
OpenWithWindow: Fix crash at closing, and fix filtering Following hrev44493, the way ShouldShowPose was used changed a bit, to harmonize with type ahead filtering. This updates OpenWithWindow to use a BRefFilter to do its filtering rather than overloading ShouldShowPose.
|
#
a51764c53eecd8ca5f6312b92d8baccda89d5b1d |
|
27-Jul-2012 |
John Scipione <jscipione@gmail.com> |
WIP: Yet more style fixes, mostly 80 char violations.
|
#
b05aa8b5b16e5b4f420a35c37805c6387df98737 |
|
27-Jul-2012 |
John Scipione <jscipione@gmail.com> |
Style changes in Tracker, no functional change. Manual whitespace cleanup Change instances of const char * to const char* Convert /* */ C style comments to // C++ style comments
|
#
1f34e928acb60a28c2343312ba738e4e9a434d8a |
|
14-Jul-2010 |
Alexandre Deckner <alex@zappotek.com> |
* Removed last remains of the OPEN_TRACKER define. * Cleanup of unused include. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37516 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
f28ab87b680bded1bbdd48104eb369d131868a56 |
|
04-Oct-2008 |
Axel Dörfler <axeld@pinc-software.de> |
* Added "sortInodes" parameter to CachedEntryIteratorList constructor. * Moved static CompareInode() to CachedEntryIterator::_CompareInodes(). * Cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27869 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
269d3bd5bce1fa4d84ee2cf577a29af93dab3b7a |
|
11-Jun-2006 |
Axel Dörfler <axeld@pinc-software.de> |
Imported PoseView.cpp 1.61, OpenWithWindow.cpp 1.8, and OpenWithWindow.h 1.3 from OpenTracker CVS. This fixes bug #354. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17796 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
66d3076d171019cb336c52886cc571c9af3953ff |
|
31-May-2006 |
Axel Dörfler <axeld@pinc-software.de> |
Cleanup, no functional change. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17667 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
02be5353fd41ea40007a382e13f007eaf6b5a3a0 |
|
22-May-2005 |
Axel Dörfler <axeld@pinc-software.de> |
Added libtracker.so to the repository and the build. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12772 a95241bf-73f2-0310-859d-f6bbb57e9c96
|