#
8cc8ec9e |
|
25-Feb-2024 |
PulkoMandy <pulkomandy@pulkomandy.tk> |
BSpinner: do not redefine fValue BSpinner had its own fValue defined instead of using the one from BControl. This results in the be:value in the message sent when the control is invoked to always be 0. Change-Id: I1cff5f30adbf5b1dede57a14377cd4e1db7a30d3 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7428 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
de1e2d92 |
|
18-Oct-2023 |
Humdinger <humdinger@mailbox.org> |
BSpinner: Simplify SetMin|MaxValue() After the last change, korli suggested this simplification that lets SetValue() do all the in/decrement-widget en/disabling. Change-Id: If87579d9104bbc9ae279aa5f2f99c9921bb238ea Reviewed-on: https://review.haiku-os.org/c/haiku/+/7053 Reviewed-by: waddlesplash <waddlesplash@gmail.com> Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
|
#
ad7c4e2d |
|
17-Oct-2023 |
Humdinger <humdinger@mailbox.org> |
BSpinner: Fix in/decrease widget behavior Say you have a BSpinner with a fValue of 10 and a fMaxValue of 10. The +-widget is correctly disabled. If you now set the fMaxValue to 20, the +-widget stays disabled. With this change the state of the +/- widgets are set correctly when the Max/MinValues are changed. Change-Id: I4dce7f0ecd6aee8e9b562618ec1367dbeb212dc4 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7050 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
5973288e |
|
12-Jan-2017 |
John Scipione <jscipione@gmail.com> |
BSpinner: Fix copy-pasta bug, min=>min, max=>max fMinValue was getting set to INT32_MAX then set to INT32_MIN fMaxValue was not getting set now set fMinValue to INT32_MIN, fMaxValue to INT32_MAX also in _InitObject()
|
#
3705d40c |
|
12-Jan-2017 |
John Scipione <jscipione@gmail.com> |
BSpinner: Set min value then max value ... reverse this to avoid confusion, you'll see why in next commit. No functional change intended in this commit, functional change is in the next commit.
|
#
a0ba79fb |
|
11-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Split BSpinner into BAbstractSpinner and... 2 concrete classes which are currently implemented: * BSpinner (works on int32s) * BDecimalSpinner (works on doubles) In addition BAbstractSpinner now inherits from BControl instead of BView/BInvoker. This allowed for code simplification at the cost of needing to cast for the decimal version because SetValue(int32 value) comes from BControl. Also, add a spinner_button_style enum with 3 options: * SPINNER_BUTTON_HORIZONTAL_ARROWS * SPINNER_BUTTON_VERTICAL_ARROWS * SPINNER_BUTTON_PLUS_MINUS which sets the spinner arrows to either use horizontal arrows (left/right) vertical arrows, (up/down), or +/- symbols (the default). If the spinner button is using horizontal arrows you can decrement and increment the spinner value by pushing control+left/right, otherwise you can increment and decrement by pushing up or down. The reason for needing control is so that you can move the cursor in the textbox otherwise. Switch the 3 apps that are currently using BSpinners to use the integer variety in Deskbar preferences, WebPostive preferences, and Screen preferences.
|
#
d1229383 |
|
10-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Generalize actions into methods Add an Increment(), Decrement(), and SetValueFromText() method. These can be overridden by derived classes.
|
#
a9385e8e |
|
10-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Move ValueChanged up ... along with the other hook methods
|
#
e4df9afe |
|
09-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Use plus/minus instead of arrows Eliminate the border between the buttons
|
#
963d585e |
|
09-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Improve look and feel This arranges the buttons to the right of the text box horizontally and also updates the background color and arrow cool to give feed back when moused over the button, disabled, and pressed. Used be_control_look arrows to match arrows used elsewhere (such as scrollbars). The background darkens on mouse over if enabled, the arrow is drawn darker when the mouse is down, and lighter if disabled.
|
#
adba4ce9 |
|
10-Mar-2014 |
John Scipione <jscipione@gmail.com> |
Add BSpinner class based on GCI2013 work
|
#
a0ba79fbff0d2a8ce0f008362d5e8832c1d994c2 |
|
11-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Split BSpinner into BAbstractSpinner and... 2 concrete classes which are currently implemented: * BSpinner (works on int32s) * BDecimalSpinner (works on doubles) In addition BAbstractSpinner now inherits from BControl instead of BView/BInvoker. This allowed for code simplification at the cost of needing to cast for the decimal version because SetValue(int32 value) comes from BControl. Also, add a spinner_button_style enum with 3 options: * SPINNER_BUTTON_HORIZONTAL_ARROWS * SPINNER_BUTTON_VERTICAL_ARROWS * SPINNER_BUTTON_PLUS_MINUS which sets the spinner arrows to either use horizontal arrows (left/right) vertical arrows, (up/down), or +/- symbols (the default). If the spinner button is using horizontal arrows you can decrement and increment the spinner value by pushing control+left/right, otherwise you can increment and decrement by pushing up or down. The reason for needing control is so that you can move the cursor in the textbox otherwise. Switch the 3 apps that are currently using BSpinners to use the integer variety in Deskbar preferences, WebPostive preferences, and Screen preferences.
|
#
d1229383468f5d62f70d336cbb5eca8468b2b249 |
|
10-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Generalize actions into methods Add an Increment(), Decrement(), and SetValueFromText() method. These can be overridden by derived classes.
|
#
a9385e8e2eb59a89b7c7d50ea9bcf1aaa645ae1b |
|
10-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Move ValueChanged up ... along with the other hook methods
|
#
e4df9afe58254b9965663ae8abef8f67259786ff |
|
09-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Use plus/minus instead of arrows Eliminate the border between the buttons
|
#
963d585e35c846ce769c88957d5420199384af3c |
|
09-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Improve look and feel This arranges the buttons to the right of the text box horizontally and also updates the background color and arrow cool to give feed back when moused over the button, disabled, and pressed. Used be_control_look arrows to match arrows used elsewhere (such as scrollbars). The background darkens on mouse over if enabled, the arrow is drawn darker when the mouse is down, and lighter if disabled.
|
#
adba4ce988febe32e061aac861f9c489af2798c4 |
|
10-Mar-2014 |
John Scipione <jscipione@gmail.com> |
Add BSpinner class based on GCI2013 work
|