Do not locate DeskBar window by its name

The name changes when translations are enabled. Use the index instead.

Fixes #8982.

Thanks to X512 for catching the problem!

Change-Id: I3c4e943f8476e46e7378a50e83a7758f694a8dc0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2606
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Deskbar: Resizable tray

* Adds max width and height arguments to
instantiate_deskbar_(item|entry).
* Old applications just stay with a 16x16 scaled icon, though.
* All used apps within the repository are converted to the new call
besides the input_server input method icon (that will need further
API changes in the input_server).

Change-Id: I29cc439396917be2c24135888459d31364997dff
Reviewed-on: https://review.haiku-os.org/656
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

BDeskbar: Moved constants to shared header

* Instead of duplicating them in different files.

BDeskbar: Set auto hide default value to false

Didn't notice this before so had to do a quick fix. Catch it before
Coverity can.

BDeskbar & Deskbar: export window bool settings to BDeskbar

Add methods to get and set "Always on top", "Auto raise", and "auto hide"
which are all booleans which control aspects of the Deskbar window to
BDeskbar.

Set the bool to the default value initially. Check if sending the
message succeeds, if so check the reply which also fills out the bool.
Don't check to see if reply succeeded because the bool will only be
overwritten if it did.

Follow the BDeskbar convention Is...() for getter, Set...() for setter
e.g IsAlwaysOnTop() is the getter, SetAlwaysOnTop() is the setter.

Define new message constants to call the newly created methods.
Follow BDeskbar convention: 'gtla' is used for getter, 'stla' for setter.
g/s for getter/setter, tla is an all-lowercase code unique to each
getter/setter pair.

Copy/paste these message constants into BarApp.h unchanged. Replace four
letter codes with imported message constants in BarApp.cpp and
BarWindow.cpp. Much nicer than using bare codes.

The new BDeskbar methods are all handled by TBarApp. The getters send
back a reply message containing the bool while the setters fall through
to existing setter cases.

BDeskbar: Style fixes

Update Copyright in cpp, add myself, alphabetize, standardize
Pointer style in cpp
Update some comments
Some 80 char stuff
pragma section headers
whitespace

Should have been part of yesterday's Deskbar changes.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@43019 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added new Haiku method IsRunning().
* Rewrote header.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19144 a95241bf-73f2-0310-859d-f6bbb57e9c96

Almost rewrote BDeskbar. Fixed some bugs. Added some ToDo comments - the
functions will currently deadlock when called from within the Deskbar.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12962 a95241bf-73f2-0310-859d-f6bbb57e9c96

Clean up


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9649 a95241bf-73f2-0310-859d-f6bbb57e9c96

better error report from BDeskbar::RemoveItem(), though OpenDeskbar should be fixed too


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5219 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed status_t BDeskbar::AddItem(entry_ref *addon, int32 *id)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3838 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed newline at end of file.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1242 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding implementation and tests for global function get_deskbar_frame().


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1187 a95241bf-73f2-0310-859d-f6bbb57e9c96

Finishing BDeskbar implementation and fixing minor test issue.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1169 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding first attempt at source code for BDeskbar.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1154 a95241bf-73f2-0310-859d-f6bbb57e9c96

Should have been part of yesterday's Deskbar changes.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@43019 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added new Haiku method IsRunning().
* Rewrote header.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19144 a95241bf-73f2-0310-859d-f6bbb57e9c96

Almost rewrote BDeskbar. Fixed some bugs. Added some ToDo comments - the
functions will currently deadlock when called from within the Deskbar.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12962 a95241bf-73f2-0310-859d-f6bbb57e9c96

Clean up


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9649 a95241bf-73f2-0310-859d-f6bbb57e9c96

better error report from BDeskbar::RemoveItem(), though OpenDeskbar should be fixed too


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5219 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed status_t BDeskbar::AddItem(entry_ref *addon, int32 *id)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3838 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed newline at end of file.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1242 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding implementation and tests for global function get_deskbar_frame().


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1187 a95241bf-73f2-0310-859d-f6bbb57e9c96

Finishing BDeskbar implementation and fixing minor test issue.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1169 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding first attempt at source code for BDeskbar.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1154 a95241bf-73f2-0310-859d-f6bbb57e9c96