#
de1e2d92 |
|
18-Oct-2023 |
Humdinger <humdinger@mailbox.org> |
BSpinner: Simplify SetMin|MaxValue() After the last change, korli suggested this simplification that lets SetValue() do all the in/decrement-widget en/disabling. Change-Id: If87579d9104bbc9ae279aa5f2f99c9921bb238ea Reviewed-on: https://review.haiku-os.org/c/haiku/+/7053 Reviewed-by: waddlesplash <waddlesplash@gmail.com> Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
|
#
ad7c4e2d |
|
17-Oct-2023 |
Humdinger <humdinger@mailbox.org> |
BSpinner: Fix in/decrease widget behavior Say you have a BSpinner with a fValue of 10 and a fMaxValue of 10. The +-widget is correctly disabled. If you now set the fMaxValue to 20, the +-widget stays disabled. With this change the state of the +/- widgets are set correctly when the Max/MinValues are changed. Change-Id: I4dce7f0ecd6aee8e9b562618ec1367dbeb212dc4 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7050 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
3705d40c |
|
12-Jan-2017 |
John Scipione <jscipione@gmail.com> |
BSpinner: Set min value then max value ... reverse this to avoid confusion, you'll see why in next commit. No functional change intended in this commit, functional change is in the next commit.
|
#
a0ba79fb |
|
11-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Split BSpinner into BAbstractSpinner and... 2 concrete classes which are currently implemented: * BSpinner (works on int32s) * BDecimalSpinner (works on doubles) In addition BAbstractSpinner now inherits from BControl instead of BView/BInvoker. This allowed for code simplification at the cost of needing to cast for the decimal version because SetValue(int32 value) comes from BControl. Also, add a spinner_button_style enum with 3 options: * SPINNER_BUTTON_HORIZONTAL_ARROWS * SPINNER_BUTTON_VERTICAL_ARROWS * SPINNER_BUTTON_PLUS_MINUS which sets the spinner arrows to either use horizontal arrows (left/right) vertical arrows, (up/down), or +/- symbols (the default). If the spinner button is using horizontal arrows you can decrement and increment the spinner value by pushing control+left/right, otherwise you can increment and decrement by pushing up or down. The reason for needing control is so that you can move the cursor in the textbox otherwise. Switch the 3 apps that are currently using BSpinners to use the integer variety in Deskbar preferences, WebPostive preferences, and Screen preferences.
|
#
a0ba79fbff0d2a8ce0f008362d5e8832c1d994c2 |
|
11-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Split BSpinner into BAbstractSpinner and... 2 concrete classes which are currently implemented: * BSpinner (works on int32s) * BDecimalSpinner (works on doubles) In addition BAbstractSpinner now inherits from BControl instead of BView/BInvoker. This allowed for code simplification at the cost of needing to cast for the decimal version because SetValue(int32 value) comes from BControl. Also, add a spinner_button_style enum with 3 options: * SPINNER_BUTTON_HORIZONTAL_ARROWS * SPINNER_BUTTON_VERTICAL_ARROWS * SPINNER_BUTTON_PLUS_MINUS which sets the spinner arrows to either use horizontal arrows (left/right) vertical arrows, (up/down), or +/- symbols (the default). If the spinner button is using horizontal arrows you can decrement and increment the spinner value by pushing control+left/right, otherwise you can increment and decrement by pushing up or down. The reason for needing control is so that you can move the cursor in the textbox otherwise. Switch the 3 apps that are currently using BSpinners to use the integer variety in Deskbar preferences, WebPostive preferences, and Screen preferences.
|