Add BIconUtils::GetSystemIcon

Allow to easily access the alert icons and anything that's added to app_server
resources.

Fixes #10887.

Convert BAlert, Debugger AlertWithCheckbox and Keymap ModifierKeysWindow
to make use of it, removing the duplicate code to locate app_server
resources.

The resources are initialized only once (per application), so there is no need
to reload them for every access to the icons.

In the ticket there is discussion about putting this in BControlLook,
but I think this should in fact be moved fully into app_server with
special drawing commands for well-known icons. That would avoid loading
and rendering the icon on the application side to then send it to
app_server (especially in remote_app_server case)?

In any case, this simple API can serve as a base for applications to
use, and we can change how it is implemented later on.

Change-Id: Id370526ae5cf165cfb8bc277bc8a7f46c26f542d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6463
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

BAlert: invalidate icon view on icon change

Invalidating the layout may not be enough for an update.

Fixes: #18069
Change-Id: I93f6b0feb043c7f317a9ff1e7af11b2047fc7cd5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5821
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

BAlert: Reserve room for stripe and large icon

... even if no icon is present. Draw stripe w/o icon.

"After ... hrev56382 alerts ... with no icons appears without a
gray stripe, causing it to jump left and right."

Fixes #18033 for R1B4 Release Milestone.

Change-Id: I35acc07411cadd4b394d6dfa1957049280b6f4b3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5810
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

BAlert: Invalidate layout if the icon is unset.

BAlert: Support changing icons while the alert is running.

After all, you can change buttons, text, and the other settings,
so why not support this, too?

BAlert: Fix preferred-size computation.

The icon is rendered starting at label-spacing * 3, not * 2.
This meant the icon got cut off in some rare scenarios, mostly
ones where text wrapped.

BAlert: Make use of the new BControlLook::ComposeIconSize().

While we're at it, also use DefaultLabelSpacing instead of
the icon size scaling factor.

BAlert: Add cast to appease GCC2.

BAlert: Use factional scaling for icons.

The behavior of not making the icons smaller than their default
pixel size is (for now) kept, but when making them larger,
fractional scaling is now used.

This makes alerts look much better on my system, which has a font
size of 18 (i.e. 150% normal, so 32px -> 48px.)

kits/interface: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0003-0017 from looncraz, unmodified.

BAlert: fixed missing initialization of fAlertSem.

* Fixes bug #12372.

BAlert: don't center ourselves if we've already been positioned.

BAlert: make SetShortcut() work again.

In hrev49481, the call to AddCommonFilter was accidentally
removed, preventing SetShortcut() from working. The filter
has also been updated to enumerate all buttons, rather than
a maximum of the first three.

BAlert: move setting default button into AddButton().

This properly fixes the crash in #12271, introduced by
hrev49481.

Removed empty line

BAlert: Use half-item spacing for layouts. Restores the old "compact" look.

Fixes #12273.

BAlert: use layout API, allow any number of buttons.

* Added default constructor; you can now alter the complete behavior
via setters, and also add buttons afterwards.

Style fixes to IK, focus on docs

Style fix in BAlert, some sort of strange spaces got in there

Create a BWindow::AlertPosition() method and use it

...to position alert's and open/save dialogs nicely inside of the parent window,
or if that is unavailable, the screen frame.

AlertPosition() is private (for now) but BAlert and BFilePanel are BWindow's friends so
BWindow allows those classes to touch it's privates.

Adjust BAlert to position the alert using the revamped BWindow::CenterIn() method.

BAlert::AlertPosition() has been superceded by the new BWindow method and should
be considered deprecated. Note that the alert position is not in the direct center of the
screen, it is offset vertically like before.

Style changes in Alert and StyledEdit Find Window

Compilation and 64-bit fixes to libbe.so sources.

Fixed the usual issues - printf format strings, uint32 instead of
addr_t, etc. One thing that isn't so nice is several places where
BList is used to store (u)int32, these require a double cast to addr_t
then void* to silence a warning on x86_64.

Fix spelling in debugger invokation.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35568 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Replaced some "new" with new(std::nothrow) where appropriate in our base
classes (BView, BWindow, BAlert, BButton - BTextView should be part of this,
too, to make BAlerts work).
* However, it's not that simple, because there is often no way to return an
error. Most of that code obviously assumes to be able to throw exceptions
(it's just not communicated to the caller). Maybe we should just start
documenting exceptions for R1 (and properly use exceptions later on).
* Automatic white space cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28646 a95241bf-73f2-0310-859d-f6bbb57e9c96

bonefish + zooey:
* Fixed a general problem with respect to overriding of the reserved
virtual function slots: instead of statically invoking the method
that corresponds to the reserved slot on the class that contains the
slot, we now invoke the virtual Perform() method. Perform() then dispatches
the method invocation to the "proper" class, i.e. the highest class in the
hierarchy that actually implements the requested method.
This fixes a crash in apps that use liblayout's MSlider class and
should fix one or other spurious bug with old apps or libraries, too.
* added new header folder 'binary_compatibility' that contains files that
define the method codes and data structures required by Perform()
* looked for and implemented all used reserved virtual slot functions to
invoke Perform() where necessary or to pass on the method call statically
(for slots that were already maintained by Be)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28124 a95241bf-73f2-0310-859d-f6bbb57e9c96

The registrar's shutdown window and BAlert both use
a BTextView in order to be able to display multiline
panel text (since BStringView can't handle this). However,
while they correctly set the background panel color, they
neglected to set the font style/color to that used by panel.
Fixed. This makes shutdown/restart dialogs properly color sensitive.




git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24226 a95241bf-73f2-0310-859d-f6bbb57e9c96

* implemented icon size and layout to depend on the system plain font size
(currently, a font size above 16pt will make the icon 64x64, TODO: some
of the other insets could depend on that value too)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21369 a95241bf-73f2-0310-859d-f6bbb57e9c96

* implemented loading and displaying of vector icons for
the alert bitmaps
* a little clean up



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21236 a95241bf-73f2-0310-859d-f6bbb57e9c96

match BView::Archive() signature, avoids a warning with gcc4


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18933 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rewrote BAlert button layout routine. Made it much simpler, and it's now
also font sensitive (really, it wasn't before).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17861 a95241bf-73f2-0310-859d-f6bbb57e9c96

style cleanup (local variables aren't capitalized)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17727 a95241bf-73f2-0310-859d-f6bbb57e9c96

The alert window position code now also takes an eventual screen offset into account.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17537 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed some Archive() following stippi's path


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17190 a95241bf-73f2-0310-859d-f6bbb57e9c96

was there any particular reason why BAlerts were old style synchronous controls BWindows?

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15387 a95241bf-73f2-0310-859d-f6bbb57e9c96

asynchronous version of Alert should have been broken, this looks more correct (not tested)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14637 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed a couple TODOs


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14623 a95241bf-73f2-0310-859d-f6bbb57e9c96

usability improvements to scrollbar, sorry had no time to include all of Stefanos drawing code yet, other visual improvements

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13535 a95241bf-73f2-0310-859d-f6bbb57e9c96

Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13194 a95241bf-73f2-0310-859d-f6bbb57e9c96

since the bitmap will be filled with content, we can use 0 as flags for the BBitmap constructor, which prevents it from unnecessarily filling with white

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12981 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed horizontal button spacing issues and window size issues when in the B_OFFSET_SPACING mode.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11146 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed button size and placement issues with the B_WIDTH_FROM_WIDEST mode, refactored code using OpenTracker style.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11137 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed beep when Go() is called because Be's version doesn't beep, fixed button sizes in B_WIDTH_FROM_LABEL mode.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11136 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed buttons and TextView back to being children of the MasterView so that the Archive() BMessage matches Be's version. Changed when MasterView is added as child of the Alert window to fix the "out-of-alignment" issue.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11134 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed drawing and placement of buttons on Alert box.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11126 a95241bf-73f2-0310-859d-f6bbb57e9c96

Pahtz's changes from PortLink/BSession/PortMessage/PortQueue to BPortLink


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8519 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed commented-out int8 hack
Tested undocumented functions and removed Erik's TODO items


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7589 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added sound
Crash to debugger if given an invalid screen in AlertPosition


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7588 a95241bf-73f2-0310-859d-f6bbb57e9c96

It is accomplished ...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10 a95241bf-73f2-0310-859d-f6bbb57e9c96

BAlert: fixed missing initialization of fAlertSem.

* Fixes bug #12372.

BAlert: don't center ourselves if we've already been positioned.

BAlert: make SetShortcut() work again.

In hrev49481, the call to AddCommonFilter was accidentally
removed, preventing SetShortcut() from working. The filter
has also been updated to enumerate all buttons, rather than
a maximum of the first three.

BAlert: move setting default button into AddButton().

This properly fixes the crash in #12271, introduced by
hrev49481.

Removed empty line

BAlert: Use half-item spacing for layouts. Restores the old "compact" look.

Fixes #12273.

BAlert: use layout API, allow any number of buttons.

* Added default constructor; you can now alter the complete behavior
via setters, and also add buttons afterwards.

Style fixes to IK, focus on docs

Style fix in BAlert, some sort of strange spaces got in there

Create a BWindow::AlertPosition() method and use it

...to position alert's and open/save dialogs nicely inside of the parent window,
or if that is unavailable, the screen frame.

AlertPosition() is private (for now) but BAlert and BFilePanel are BWindow's friends so
BWindow allows those classes to touch it's privates.

Adjust BAlert to position the alert using the revamped BWindow::CenterIn() method.

BAlert::AlertPosition() has been superceded by the new BWindow method and should
be considered deprecated. Note that the alert position is not in the direct center of the
screen, it is offset vertically like before.

Style changes in Alert and StyledEdit Find Window

Compilation and 64-bit fixes to libbe.so sources.

Fixed the usual issues - printf format strings, uint32 instead of
addr_t, etc. One thing that isn't so nice is several places where
BList is used to store (u)int32, these require a double cast to addr_t
then void* to silence a warning on x86_64.

Fix spelling in debugger invokation.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35568 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Replaced some "new" with new(std::nothrow) where appropriate in our base
classes (BView, BWindow, BAlert, BButton - BTextView should be part of this,
too, to make BAlerts work).
* However, it's not that simple, because there is often no way to return an
error. Most of that code obviously assumes to be able to throw exceptions
(it's just not communicated to the caller). Maybe we should just start
documenting exceptions for R1 (and properly use exceptions later on).
* Automatic white space cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28646 a95241bf-73f2-0310-859d-f6bbb57e9c96

bonefish + zooey:
* Fixed a general problem with respect to overriding of the reserved
virtual function slots: instead of statically invoking the method
that corresponds to the reserved slot on the class that contains the
slot, we now invoke the virtual Perform() method. Perform() then dispatches
the method invocation to the "proper" class, i.e. the highest class in the
hierarchy that actually implements the requested method.
This fixes a crash in apps that use liblayout's MSlider class and
should fix one or other spurious bug with old apps or libraries, too.
* added new header folder 'binary_compatibility' that contains files that
define the method codes and data structures required by Perform()
* looked for and implemented all used reserved virtual slot functions to
invoke Perform() where necessary or to pass on the method call statically
(for slots that were already maintained by Be)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28124 a95241bf-73f2-0310-859d-f6bbb57e9c96

The registrar's shutdown window and BAlert both use
a BTextView in order to be able to display multiline
panel text (since BStringView can't handle this). However,
while they correctly set the background panel color, they
neglected to set the font style/color to that used by panel.
Fixed. This makes shutdown/restart dialogs properly color sensitive.




git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24226 a95241bf-73f2-0310-859d-f6bbb57e9c96

* implemented icon size and layout to depend on the system plain font size
(currently, a font size above 16pt will make the icon 64x64, TODO: some
of the other insets could depend on that value too)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21369 a95241bf-73f2-0310-859d-f6bbb57e9c96

* implemented loading and displaying of vector icons for
the alert bitmaps
* a little clean up



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21236 a95241bf-73f2-0310-859d-f6bbb57e9c96

match BView::Archive() signature, avoids a warning with gcc4


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18933 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rewrote BAlert button layout routine. Made it much simpler, and it's now
also font sensitive (really, it wasn't before).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17861 a95241bf-73f2-0310-859d-f6bbb57e9c96

style cleanup (local variables aren't capitalized)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17727 a95241bf-73f2-0310-859d-f6bbb57e9c96

The alert window position code now also takes an eventual screen offset into account.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17537 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed some Archive() following stippi's path


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17190 a95241bf-73f2-0310-859d-f6bbb57e9c96

was there any particular reason why BAlerts were old style synchronous controls BWindows?

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15387 a95241bf-73f2-0310-859d-f6bbb57e9c96

asynchronous version of Alert should have been broken, this looks more correct (not tested)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14637 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed a couple TODOs


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14623 a95241bf-73f2-0310-859d-f6bbb57e9c96

usability improvements to scrollbar, sorry had no time to include all of Stefanos drawing code yet, other visual improvements

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13535 a95241bf-73f2-0310-859d-f6bbb57e9c96

Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13194 a95241bf-73f2-0310-859d-f6bbb57e9c96

since the bitmap will be filled with content, we can use 0 as flags for the BBitmap constructor, which prevents it from unnecessarily filling with white

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12981 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed horizontal button spacing issues and window size issues when in the B_OFFSET_SPACING mode.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11146 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed button size and placement issues with the B_WIDTH_FROM_WIDEST mode, refactored code using OpenTracker style.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11137 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed beep when Go() is called because Be's version doesn't beep, fixed button sizes in B_WIDTH_FROM_LABEL mode.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11136 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed buttons and TextView back to being children of the MasterView so that the Archive() BMessage matches Be's version. Changed when MasterView is added as child of the Alert window to fix the "out-of-alignment" issue.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11134 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed drawing and placement of buttons on Alert box.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11126 a95241bf-73f2-0310-859d-f6bbb57e9c96

Pahtz's changes from PortLink/BSession/PortMessage/PortQueue to BPortLink


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8519 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed commented-out int8 hack
Tested undocumented functions and removed Erik's TODO items


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7589 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added sound
Crash to debugger if given an invalid screen in AlertPosition


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7588 a95241bf-73f2-0310-859d-f6bbb57e9c96

It is accomplished ...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10 a95241bf-73f2-0310-859d-f6bbb57e9c96