#
3c346299 |
|
24-Oct-2023 |
JackBurton79 <stefano.ceccherini@gmail.com> |
AbstractSpinner: fix calling base class virtual methods (untested) AbstractSpinner inherits from BControl, so it should call BControl's virtual methods, not BView's. Found by Andrea Anzani Change-Id: If4c921d91a5095769d5f2da1832ad5bf4533becc Reviewed-on: https://review.haiku-os.org/c/haiku/+/7066 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
20f2ebae |
|
07-May-2020 |
Adrien Destugues <adrien.destugues@opensource.viveris.fr> |
Remove MouseDownThread and its usages This code comes from an old Be Newsletter and since then the API received the addition of SetMouseEventMask. In several places the MouseDownThread was misused: it would spawn a new thread on every mouse click and not clear the previous one. This could for example lead to BSpinner skipping values if you clicked it at the right speed. There are functional changes in BSpinner, before it updated for the first time 100ms after mouse down, and then as you moved the mouse around the button, now it activates immediately on first click and then every 200ms (which may be a bit short). In other places, no functional changes intended. Change-Id: Ie600dc68cbb87d1e237633953e5189918bf36575 Reviewed-on: https://review.haiku-os.org/c/haiku/+/2599 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
ebb4be2a |
|
02-Oct-2018 |
Kacper Kasper <kacperkasper@gmail.com> |
Make spinner buttons look consistent with other controls Change-Id: Icb29772c91687f4c7e4795a726636cf588b83f16 Reviewed-on: https://review.haiku-os.org/610 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
aa19dd02 |
|
16-Nov-2017 |
John Scipione <jscipione@gmail.com> |
BSpinner: Draw spinner buttons activated if mouse down Fixes #13469
|
#
6a634757 |
|
16-Nov-2017 |
John Scipione <jscipione@gmail.com> |
BSpinner: Draw spinner plus sign better The plus was a bit too tall making it look odd.
|
#
abb297f5 |
|
12-Jun-2017 |
Wiktor <vikkindhart@gmail.com> |
InterfaceKit: fixed BSpinner's label rendering. A '&' (reference) was missing on a specific line, causing font information to never be updated. Also removed extra padding dependent on a constant variable - if it is used, the label will be render too far down. Fixes #12981. Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
|
#
26d41644 |
|
12-Jan-2017 |
John Scipione <jscipione@gmail.com> |
AbstractSpinner: Make TextView resizable Fixes #13168
|
#
8b902d94 |
|
22-Mar-2016 |
John Scipione <jscipione@gmail.com> |
IK: Use panel text color for select control labels NOTE: This should have no effect on the colors of these labels unless you have changed the panel text color and control text colors to be different. Both are black by default. In the case of the menu field, spinner, check box, radio button, slider, and text control labels we want to draw these labels using the panel text color instead of the control text color because they are drawn on top of the panel color. (the menu field label color was changed in a previous commit in this push). In all cases except the menu field the label color is specified by temporarily unsetting the B_IS_CONTROL flag while drawing the label. All use control look to draw the label. The control text color is meant to be used for text INSIDE the control, not the label text that accompanies the control -- at least that's the way I understand it.
|
#
f9f16ddb |
|
09-Jan-2016 |
looncraz <looncraz@looncraz.net> |
BAbstractSpinner Colors Adopted parent colors for the text view - should not have done so. Disabled colors were incorrect, so I also corrected those in this patch. Fixes #12574. Signed-off-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>
|
#
7a96554c |
|
09-Dec-2015 |
looncraz <looncraz@looncraz.net> |
kits/interface: Convert to using Set*UIColor. Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com> Patches 0003-0017 from looncraz, unmodified.
|
#
25af167e |
|
20-Jun-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Tweak the spinner button colors * Tint the button text 1.777f which yields #303030 for the text color which produces a nice dark grey but-not-quite-black color. In testing black text is too dark and B_DARKEN_4_TINT (1.555f) yields #606060 which is too light. #303030 is a compromise between the two. * The button text gets darkened to black on mouse down and the button background gets darkened to B_DARKEN_1_TINT on hover as before, but the frame color is no longer affected --- the button frame tinted by B_DARKEN_1_TINT always (yielding standard Haiku button frame color).
|
#
a0ba79fb |
|
11-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Split BSpinner into BAbstractSpinner and... 2 concrete classes which are currently implemented: * BSpinner (works on int32s) * BDecimalSpinner (works on doubles) In addition BAbstractSpinner now inherits from BControl instead of BView/BInvoker. This allowed for code simplification at the cost of needing to cast for the decimal version because SetValue(int32 value) comes from BControl. Also, add a spinner_button_style enum with 3 options: * SPINNER_BUTTON_HORIZONTAL_ARROWS * SPINNER_BUTTON_VERTICAL_ARROWS * SPINNER_BUTTON_PLUS_MINUS which sets the spinner arrows to either use horizontal arrows (left/right) vertical arrows, (up/down), or +/- symbols (the default). If the spinner button is using horizontal arrows you can decrement and increment the spinner value by pushing control+left/right, otherwise you can increment and decrement by pushing up or down. The reason for needing control is so that you can move the cursor in the textbox otherwise. Switch the 3 apps that are currently using BSpinners to use the integer variety in Deskbar preferences, WebPostive preferences, and Screen preferences.
|
#
25af167e8f1d33b0931741434a814a59765505eb |
|
20-Jun-2015 |
John Scipione <jscipione@gmail.com> |
Spinner: Tweak the spinner button colors * Tint the button text 1.777f which yields #303030 for the text color which produces a nice dark grey but-not-quite-black color. In testing black text is too dark and B_DARKEN_4_TINT (1.555f) yields #606060 which is too light. #303030 is a compromise between the two. * The button text gets darkened to black on mouse down and the button background gets darkened to B_DARKEN_1_TINT on hover as before, but the frame color is no longer affected --- the button frame tinted by B_DARKEN_1_TINT always (yielding standard Haiku button frame color).
|
#
a0ba79fbff0d2a8ce0f008362d5e8832c1d994c2 |
|
11-Mar-2015 |
John Scipione <jscipione@gmail.com> |
Split BSpinner into BAbstractSpinner and... 2 concrete classes which are currently implemented: * BSpinner (works on int32s) * BDecimalSpinner (works on doubles) In addition BAbstractSpinner now inherits from BControl instead of BView/BInvoker. This allowed for code simplification at the cost of needing to cast for the decimal version because SetValue(int32 value) comes from BControl. Also, add a spinner_button_style enum with 3 options: * SPINNER_BUTTON_HORIZONTAL_ARROWS * SPINNER_BUTTON_VERTICAL_ARROWS * SPINNER_BUTTON_PLUS_MINUS which sets the spinner arrows to either use horizontal arrows (left/right) vertical arrows, (up/down), or +/- symbols (the default). If the spinner button is using horizontal arrows you can decrement and increment the spinner value by pushing control+left/right, otherwise you can increment and decrement by pushing up or down. The reason for needing control is so that you can move the cursor in the textbox otherwise. Switch the 3 apps that are currently using BSpinners to use the integer variety in Deskbar preferences, WebPostive preferences, and Screen preferences.
|