History log of /haiku/src/apps/webpositive/DownloadProgressView.cpp
Revision Date Author Comments
# c9764701 12-Jul-2020 Adrien Destugues <pulkomandy@pulkomandy.tk>

Fix localization in Web+ download window.

Fixes #16391


# 28eb6b3f 28-Aug-2017 Akshay Agarwal <agarwal.akshay.akshay8@gmail.com>

Use formatters from locale kit to format time remaining/finish time.

Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>


# fa19dd44 10-Dec-2015 looncraz <looncraz@looncraz.net>

apps: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0045-0075, 0077-0087 from looncraz, unmodified.


# a8821379 19-Dec-2014 Adrien Destugues <pulkomandy@gmail.com>

Web+: set a group name for download notifications

It is not clear that these come from Web+ otherwise (since they use the
downloaded file icon rather than the app one).


# 967a06e0 18-Dec-2014 Adrien Destugues <pulkomandy@gmail.com>

Web+: force download buttons to have the same width

If the text in the button is longer than what the minimal size of
BButton allows, the button exapnd. But we want the two buttons to have
the same width and stay aligned.

Fixes part of #11471.

Note: I don't understand why I need to set the explicit max size of the
button to make it bigger (I would have expected setting the minimal size
to do that), but it works.


# 03ad73fc 24-Nov-2014 Adrien Destugues <pulkomandy@gmail.com>

More uses of BMessageFormat

ZipOMatic, DiskUsage, MediaConverter, MediaPlayer, ShowImage,
WebPositive, Screen preferences, Tracker, string_for_size.

Thanks to KapiX for reporting those!


# 22491e14 27-Aug-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

WebPositive: Fix build

I'm not so happy with this solution, but I'm out of ideas for a better
one.


# 8f367d30 16-Jul-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

Rewrite "open containing folder" in a safer way.

* Tracker has support for this in its RefsReceived handler, which
results in simpler code than going through BRoster to open the folder.
* Avoids a race condition, possible confusion of Tracker windows with
the same title, and makes the code more readable (and working).
* Fixes #11008.

Thanks to Axeld for pointing the support in RefsReceived, which wasn't
used anywhere outside of Tracker, yet.


# 6b87960f 23-Jun-2014 Jessica Hamilton <jessica.l.hamilton@gmail.com>

WebPositive: rename DownloadCanceled to match semantics.


# c0c10f1c 23-Jun-2014 Jessica Hamilton <jessica.l.hamilton@gmail.com>

WebPositive: refactor cancelling a download. Fixes #10960.


# da802e25 16-Jun-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

Style fix.


# 9b738c32 16-Jun-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

don't notify when a finished download is removed.

* Actually stop the download when the target file is deleted
* Check the download state before sending a notification or changing the
progress bar color.

Fixes #10907.


# 567a96ac 22-Apr-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

Pop a BNotification on download success/failure.

Clicking the notification opens the downloaded file for succesful
downloads.
Fixes #10689.


# b4c8efac 16-Jun-2013 Stephan Aßmus <superstippi@gmx.de>

WebPositive: Removed wrong license text from all files ...

... which were technically never distributed by Apple nor
are derived from code distributed by Apple. Only BrowserApp
and BrowserWindow were originally derived from code that used
to be part of WebKit and was distributed by Apple.


# 523a87a5 22-Dec-2012 Rene Gollent <anevilyak@gmail.com>

64-bit fixes for WebPositive.


# aed35104 05-Aug-2012 Humdinger <humdingerb@gmail.com>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.


# 2218c029 11-Jul-2012 Alexandre Deckner <alexandre.deckner@uzzl.com>

Add localization support to WebPositive, patch by Humdinger

* Includes style fixes
* Functional fixes by myself, patch wouldn't build


# 56b050f3 10-Mar-2011 phoudoin <phoudoin@94f232f2-1747-11df-bad5-a5bfde151594>

* Don't trust anymore provided MIME type (if any): use instead
the registrar's type guessing feature, which we can (and should) trust
way more.
* Notify back the download objet when it's file location has changed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@577 94f232f2-1747-11df-bad5-a5bfde151594


# a071b4d0 18-Aug-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Adapt to recent layout API changes. (Untested)

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@543 94f232f2-1747-11df-bad5-a5bfde151594


# 4a098314 23-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

When the expected size of a download is unknown, at least set the progress
bar to 100% when it finished.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@519 94f232f2-1747-11df-bad5-a5bfde151594


# a933ccf2 22-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

When a download starts, do not start node monitoring the path while it is still
pointing to the containing folder. Fixes ticket #62.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@518 94f232f2-1747-11df-bad5-a5bfde151594


# e07fc6b7 05-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Changed the implementation of context menus in DownloadProgressViews. The views
were intercepting mouse messages even if the window was not showing. Now
secondary clicks are intercepted in DownloadWindow and the target view is found,
which makes this much cheaper.
* Offset context menus by 2 pixels, so the mouse does not start directly over
an item.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@488 94f232f2-1747-11df-bad5-a5bfde151594


# b9d4b634 03-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Use BStatusBar properly. The text in a BStatusBar is composed of four parts.
Label and trailing label are only specified in the constructor or in Reset().
By using SetText(), we were modifying another part of the text, while we meant
to set the label. This fixes updates on node monitor messages.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@472 94f232f2-1747-11df-bad5-a5bfde151594


# 06ea4857 01-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Add a context menu to the download progress view. It allows to open the
containing folder (and selects the file in it), and to copy the download URL
to the clipboard.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@470 94f232f2-1747-11df-bad5-a5bfde151594


# cb0b4979 03-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Don't display the unit of the current size if it's the same as the unit of the
expected size in the download progress view.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@382 94f232f2-1747-11df-bad5-a5bfde151594


# 2232d801 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Canceling a download needs to unset the info text.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@355 94f232f2-1747-11df-bad5-a5bfde151594


# 3b7f919f 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Removed commented out code which wasn't needed after all.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@353 94f232f2-1747-11df-bad5-a5bfde151594


# 90ac9c30 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Implemented displaying the download speed and estimated finish time. Looks and
behaves the same as in Tracker's status window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@352 94f232f2-1747-11df-bad5-a5bfde151594


# 7ac6b59c 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Moved DownloadProgressView and related private classes out into their own source
file.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@350 94f232f2-1747-11df-bad5-a5bfde151594


# a8821379260242f6960729584f70c057b58b992a 19-Dec-2014 Adrien Destugues <pulkomandy@gmail.com>

Web+: set a group name for download notifications

It is not clear that these come from Web+ otherwise (since they use the
downloaded file icon rather than the app one).


# 967a06e0559e26da85a4c70b32bfe40aa7c5faa7 18-Dec-2014 Adrien Destugues <pulkomandy@gmail.com>

Web+: force download buttons to have the same width

If the text in the button is longer than what the minimal size of
BButton allows, the button exapnd. But we want the two buttons to have
the same width and stay aligned.

Fixes part of #11471.

Note: I don't understand why I need to set the explicit max size of the
button to make it bigger (I would have expected setting the minimal size
to do that), but it works.


# 03ad73fc872d7a350989e7bb7dd10b9e2b1e5882 24-Nov-2014 Adrien Destugues <pulkomandy@gmail.com>

More uses of BMessageFormat

ZipOMatic, DiskUsage, MediaConverter, MediaPlayer, ShowImage,
WebPositive, Screen preferences, Tracker, string_for_size.

Thanks to KapiX for reporting those!


# 22491e14911a00867a7ac87d9959918c9a16f25a 27-Aug-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

WebPositive: Fix build

I'm not so happy with this solution, but I'm out of ideas for a better
one.


# 8f367d30c81b4107020b090c89ebe3c89a289490 16-Jul-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

Rewrite "open containing folder" in a safer way.

* Tracker has support for this in its RefsReceived handler, which
results in simpler code than going through BRoster to open the folder.
* Avoids a race condition, possible confusion of Tracker windows with
the same title, and makes the code more readable (and working).
* Fixes #11008.

Thanks to Axeld for pointing the support in RefsReceived, which wasn't
used anywhere outside of Tracker, yet.


# 6b87960fe67ee620512da531951e59174bfbd51a 23-Jun-2014 Jessica Hamilton <jessica.l.hamilton@gmail.com>

WebPositive: rename DownloadCanceled to match semantics.


# c0c10f1c83f19cf460aa44c78b676182f5f9364f 23-Jun-2014 Jessica Hamilton <jessica.l.hamilton@gmail.com>

WebPositive: refactor cancelling a download. Fixes #10960.


# da802e25b747b4c1c280d3be5acfeb2d2fc18fef 16-Jun-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

Style fix.


# 9b738c321b7ee0b5964e03f1d802c0412df9d46f 16-Jun-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

don't notify when a finished download is removed.

* Actually stop the download when the target file is deleted
* Check the download state before sending a notification or changing the
progress bar color.

Fixes #10907.


# 567a96acc9bd203a0cddff34387a73d50fcbc509 22-Apr-2014 Adrien Destugues <pulkomandy@pulkomandy.tk>

Pop a BNotification on download success/failure.

Clicking the notification opens the downloaded file for succesful
downloads.
Fixes #10689.


# b4c8efacea6265d17537b6b5fe007c21ea9d9dd1 16-Jun-2013 Stephan Aßmus <superstippi@gmx.de>

WebPositive: Removed wrong license text from all files ...

... which were technically never distributed by Apple nor
are derived from code distributed by Apple. Only BrowserApp
and BrowserWindow were originally derived from code that used
to be part of WebKit and was distributed by Apple.


# 523a87a5d28e0f60352380cc8dc48946a0361a74 22-Dec-2012 Rene Gollent <anevilyak@gmail.com>

64-bit fixes for WebPositive.


# aed35104852941f0f6f3d1dcc5338b5f337d0a3c 05-Aug-2012 Humdinger <humdingerb@gmail.com>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.


# 2218c029a5ab7260d03036b43c68475e0b35b449 11-Jul-2012 Alexandre Deckner <alexandre.deckner@uzzl.com>

Add localization support to WebPositive, patch by Humdinger

* Includes style fixes
* Functional fixes by myself, patch wouldn't build


# 56b050f337f5cebf1fdd1a87047a0146c9c5a1a2 10-Mar-2011 phoudoin <phoudoin@94f232f2-1747-11df-bad5-a5bfde151594>

* Don't trust anymore provided MIME type (if any): use instead
the registrar's type guessing feature, which we can (and should) trust
way more.
* Notify back the download objet when it's file location has changed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@577 94f232f2-1747-11df-bad5-a5bfde151594


# a071b4d0417fbb6971696d8bd5c54b1c5738c9ab 18-Aug-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Adapt to recent layout API changes. (Untested)

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@543 94f232f2-1747-11df-bad5-a5bfde151594


# 4a09831444efe276c2186c9158951577e58472cb 23-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

When the expected size of a download is unknown, at least set the progress
bar to 100% when it finished.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@519 94f232f2-1747-11df-bad5-a5bfde151594


# a933ccf28dc6f4be8996b43b90b1a6ae4d64bfa3 22-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

When a download starts, do not start node monitoring the path while it is still
pointing to the containing folder. Fixes ticket #62.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@518 94f232f2-1747-11df-bad5-a5bfde151594


# e07fc6b71df68266b262583b4d9ca43138ea6c9f 05-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Changed the implementation of context menus in DownloadProgressViews. The views
were intercepting mouse messages even if the window was not showing. Now
secondary clicks are intercepted in DownloadWindow and the target view is found,
which makes this much cheaper.
* Offset context menus by 2 pixels, so the mouse does not start directly over
an item.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@488 94f232f2-1747-11df-bad5-a5bfde151594


# b9d4b634f6406790a909a0a1c4a3770e3d8620fb 03-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Use BStatusBar properly. The text in a BStatusBar is composed of four parts.
Label and trailing label are only specified in the constructor or in Reset().
By using SetText(), we were modifying another part of the text, while we meant
to set the label. This fixes updates on node monitor messages.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@472 94f232f2-1747-11df-bad5-a5bfde151594


# 06ea485752153d9dd4bd8d02e617b28758dd7229 01-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Add a context menu to the download progress view. It allows to open the
containing folder (and selects the file in it), and to copy the download URL
to the clipboard.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@470 94f232f2-1747-11df-bad5-a5bfde151594


# cb0b497952438ca8ddd066ae673d8692e66864e7 03-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Don't display the unit of the current size if it's the same as the unit of the
expected size in the download progress view.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@382 94f232f2-1747-11df-bad5-a5bfde151594


# 2232d801e0b2fc09f38a573e562295c64a842239 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Canceling a download needs to unset the info text.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@355 94f232f2-1747-11df-bad5-a5bfde151594


# 3b7f919fb80f5f90a2be6f11a7602f49cad7242e 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Removed commented out code which wasn't needed after all.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@353 94f232f2-1747-11df-bad5-a5bfde151594


# 90ac9c309c2294577ab6eb50f1591ccc0ad29780 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Implemented displaying the download speed and estimated finish time. Looks and
behaves the same as in Tracker's status window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@352 94f232f2-1747-11df-bad5-a5bfde151594


# 7ac6b59c333c879894c189812643e5e2a8768eb2 24-Mar-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Moved DownloadProgressView and related private classes out into their own source
file.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@350 94f232f2-1747-11df-bad5-a5bfde151594