StyledEdit: Add comment explaining MakeFocus() loc

... to explain hrev562209 by Jim906 which fixes #17733
StyledEdit: give initial focus to the TextView

No functional change

Change-Id: Id428290d8d3530e5ef9213489625c1968984d323
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5422
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: nephele <nep@packageloss.eu>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

StyledEdit: give initial focus to the TextView

* Move the existing MakeFocus call to after the window layout is built.
* Also, add calls to Activate so that StyledEdit becomes the active
window after its find or replace window is closed/hidden, even if
another application is set to 'always on top.'
* Fixes #17733.

Change-Id: I8380e8ce2760ffa3f3467a618a0d843826e4ac99
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5416
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: humdinger <humdingerb@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

StyledEdit: add menu to underline text

Eases testing of B_UNDERSCORE_FACE

Change-Id: If3e1f247a984b81e9262136ca30139851cfa19a2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4244
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

StyledEdit: SetInsets() instead of insetting initial text rect

Initial rect size doesn't persist to changing text rect sizes and
alignment changes but insets do. Maintains a 3px border around text
on all sides.

Change-Id: I70e855c3b6b17bc576fd5e38cd43fedb6c830aef
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3901
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

StyledEdit: fix replace menu item

Regression after hrev54812.

Change-Id: I5f8e06c5b161eb859afc7f03b08e1c0cb07a99d0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3604
Reviewed-by: humdinger <humdingerb@gmail.com>

StyledEdit: fix layout

Fixes #16721.

Change-Id: I1ab1489b5cfe6ae0fce4ba1de9d14c69685e5a65
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3603
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

StyledEdit: Fix New menu item after hrev54812

Change-Id: I583bc43dc64d46e92e20e46da9a894c489617d43
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3563
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

StyledEdit: convert main view to layout api

Change-Id: I913c8f559faf09654b0e249f512858ed24fe1ffe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3537
Reviewed-by: John Scipione <jscipione@gmail.com>

IK: align BTextView text rect/fix alignment

Recalculate line breaks in FrameResized() if word-wrap is on, otherwise
only move the text rect into position. StyledEdit was recalculating line
breaks before on resize (we have to in this mode) and the frame offset
updates for non-wrapping text views are inexpensive. This makes resizing
text view's work like StyledEdit everywhere.

Scroll to cursor when word-wrap setting changes if text view is editable.
If you are viewing a long document changing word-wrap can move the cursor
quite far, so scroll back to it.

Fix _ActualTabWidth() pen location for right and center-aligned text views
so that tabs widths are calculated correctly.

Reset fTextRect horizontal limits to bounds minus insets in
_RecalculateLineBreaks(), then grow fTextRect based on alignment when
wrap is off.

Fixing insets also fixes right and center-aligned BTextViews.
Left-aligned text view's grow right, right-aligned ones grow left,
and center-aligned ones grow out.

Make extra scrolling space for all aligned text views go the other way
from how it did in hrev24130 (and on left-aligned text view's too) so
that half the text is visible when you edit past the end or before the
beginnning of a text view instead of none of it.

Fixes #1651 #12608 #13796 #15189

Do not _RecalculateLineBreaks() if text view bounds are invalid.
In SetText() detect invalid text view bounds and resize the view to the
width and height of the first line. Then recalculate line breaks.
This fixes BAlert text view size issues.

Fixes #16481 (regression from hrev54496.)

Remove useless and heavy computation. There is no point in computing line
breaks for a 10px wide text view and it takes a long time because it needs
a lot of linebreaks. The view eventually gets laid out properly.

Fixes #5582 (which was not locale-related, after all.)

Only apply default insets if text rect is set to bounds. This ensures
that apps that manipulate the text rect can continue to do so without
the default insets interfering while apps that don't can benefit
from the defaults. If you want to set the text rect to bounds and
not use the default insets you must override the default by calling
SetInsets(). This prevent the default insets from being applied once
apps have changed the text rect fixing a bug in Icon-O-Matic where the
text rect insets were being applied incorrectly.

Fixes #16488 (regression from hrev54496.)

Reduce left and right insets inside text views from full label spacing
to half label spacing. Unify padding between BTextControl and BTextView.

Move fLayoutData->UpdateInsets() to private BTextView::_UpdateInsets()
because we need access to BTextView member variables when deciding
whether or not to add the default padding or not.

_UpdateInsets() changes:
* Don't update insets if BTextView::SetInsets() was called.
* Don't add default insets unless fTextRect is set to view Bounds().
* Do not set the right and bottom insets to left and top if negative,
set them to 0 like we do to left and top -- DeskCalc bug otherwise.

Fixes #15688

Other BTextView fixes:
* Replace max_c and min_c with std::max and std::min respectively.
* Remove scrolling from one instance of BTextView::SetText() as it
produced undesired results while editing a scrolled text view.
* Add default insets in _UpdateInsets()
* Fix scrolling when entering and deleting text so that some part of
the text is always visible. Make visible scroll width depend on font
size.
* Allow scrolling to a negative offset in x but not y. This allows you
to scroll the entire contents of right and centered-aligned text views
whose content does not fit in the box.
* Change _Refresh() to take an offset instead of a bool so that you can
scroll to any offset.
* Replace TextLength() with fText->Length() in a couple of places.

TextControl changes:
* Set text rect in BTextControl::DoLayout().
* Remove AlignTextRect() from TextInput.

Fix the following problems in apps:

ScreenSaver: Set text rect in PreviewView::AddPreview().
Tracker: Set "Edit name" text view insets to 2. Tweek text rect position
to be on top of label in icon, mini-icon, and list mode. Add a TODO that
the text rect is a pixel off from the name on some files.
Mail: Remove _AlignTextRect() and FrameResized() from AddressTextControl.
Use default insets on the text view, defaults are fine here.
DeskCalc: Set insets based on font size in ExpressionTextView
SetTextRect() instead of manipulating the text rect.
Remove _CheckTextRect() and related methods from InputTextView.
Icon-O-Matic: Remove _CheckTextRect() and related methods from InputTextView.
WebPositive: Remove _AlignTextRect() and FrameResized() from URLTextView
and call SetInsets().
StyledEdit: Word-wrap and FrameResized() changes ported to BTextView.

Fixes #16476 #16480 #16488 (regressions from hrev54496.)

Change-Id: Ifeca6077f8815ccd86d5a3880f99556298aaf0fe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3152
Reviewed-by: John Scipione <jscipione@gmail.com>

StyledEdit: Fix build after previous changes.

StyledEdit: Add cmd +, cmd - shortcuts for font size

Change-Id: I540ed130322fa1ce7eba62c4a1d1de36b12ccf9a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2303
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

StyledEdit: Fix PVS 1167

Use new(std::nothrow) so that NULL check for allocated memory makes sense.

Change-Id: I6c0e66c63adda430686727a4085132c4e40c7530
Reviewed-on: https://review.haiku-os.org/692
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

StyledEdit: avoid crash on replace window

* Fixes #13842

StyledEdit: Rework of the font color system

1) The default font color is now B_DOCUMENT_TEXT_COLOR
2) The font color menu now shows a palette
3) The font color menu now includes a "default" item, set
to B_DOCUMENT_TEXT_COLOR
4) Added a Todo mentionning it would be ideal to not save the default color
itself, but instead saving the fact the default color was used. Maybe allow the
StyleBuffer to use a Null color or something similar.

StyledEdit: add navigation menu to status bar.

* Fix #12099.

StyledEdit: ensure caret position gets set correctly

* When opening documents without be:caret_position,
StyledEdit would place the cursor at the end of
the file. _LoadAttrs() intended to set it to the
beginning; however, a check for an existing BRect
for positioning the window would return early,
preventing the caret position to be set.

Fixes #11463

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.

StyledEdit: Fix #10349.

Override QuitRequested in FindWindow to notify the parent edit window of the
find window's demise so it can reset its corresponding pointer. Otherwise the
latter will potentially access the invalid pointer in question on subsequent
find requests, leading to potential crashes.

StyleEdit: non-modal Find/Replace windows implementation

* Switch to non-modal floating windows for Find/Replace dialogs,
preserve parameters of the previous search in this editor session;
* Fixes #10053.

- GCI 2013

StyledEdit: Use RecentItems helper instead of private impl.

* Switch recent documents list to use RecentItems.h helper instead of
homebrewn implementation;
* Fixes #9999.

- GCI 2013

StyledEdit:update status view after document was saved

StyledEdit:supress unlock if the file is on RO volume

Show the "Read-only" status for documents that are living on read-only
volumes and do not show unlock menu for such files.

* The enhancement pointed out by Sergei Reznikov (Diver). Thanks!

StyledEdit: fixed statistics words count.

* Bug #9822 and actual fix suggested by DanielW.

Remove this bit of code from StyledEdit

....as we're gonna do the work in BFilePanel instead.

Remove the alert dialog adjustements, they are now done in BAlert directly

The save panel adjustment has been kept and modified a bit to position the
window nicely. It too uses the BWindow::CenterIn() method that adjusts based
on the screen edges.

Move the save panel to the middle of the window as well

Move the alert to the middle of the window

Fix GCC2 build. Thanks to John for the warning.

Improve File Encoding StatusView cell. (Fixes #9653)

* Encoding cell of the StyledEdit StatusView is visible now only in case
the currently opened file encoding is not equal to default UTF-8 one;
* The Encodings menu that was opened by click on this cell is removed;
* Cmd-Opt-PgDn/PgUp shortcuts are added for quick iteration through the
list of encodings.

Fix CID992335,CID992334: Check FindRef/String returns

Satisfy Coverity by checking return values of FindRef and FindString
calls for fSavedMessage.

Resolves CID992335 and CID992334.

Update StyledEdit to use document background color. Style fixes.

See ticket #5293 Colors_picture2.png

StyledEdit:EncodingMenu: autodetect on root menu entry

StyledEdit::StatusView Encoding context menu implemented

Implement "be:caret_position" document file attribute.

* Use "be:caret_position"document file attribute instead of
"be:line" and "be:selection_{length|offset}" file attributes;
* Fixed code style violations. Thanks to Axel for pointing it out!

Unifying the quit/save alerts.

Wherever I found an alert prompting to save changes, I used the
button labeling 'Cancel', 'Don't save', 'Save' with the first button
left aligned, 2nd and 3rd right aligned.

I added the shortcuts 'd' for 'Don't save, and 's' for 'Save' where
not already set.

The topic was discussed at
http://permalink.gmane.org/gmane.os.haiku.devel/23244
The discussion died down, I hope I made changes everyone can live with.

Use "Revert" instead of "OK" as button label.

Handle be:line and °K in RefsReceived, store it in file attributes

This work was done during GCI2012

Fixes #4794

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

StyledEdit:Implemented StatusLine and R5-like ReadOnly mode

This work was done during GCI2012.

Fixes #3655

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Node monitoring and on-the-fly textencoding change

This work is based on the draft node monitoring implementation
created by Vlad Slepukhin during GCI 2012 and includes following:

* Refactoring of the document "Reload" feature - it replaces
"Revert to saved" one because do the same things and a bit more.
Looks like we have to keep "Reload" menu entry alive until
StyledEdit will get more functional Undo/Redo features. Reload
functionality is also heavily used in node monitoring and
on-the-fly text encoding changing. Fixes #6887;

* Support for text encoding on-the-fly switching. This make
life easier for those who lives in countires with multiple
popular 8-bit encodings. Russia is the sample of such
de facto standards' clash (KOI-8R vs CP1251 etc.);

* Node Monitoring support with alerting user in case the file
size or modification time were changed. Another alert is shown
in case edited file was removed or moved outside of the current
volume. Moving file inside of current volume silently changes
references. Choosing "Ignore" will supress new change alerts
until next Reload or Save user request;

* Do not nag user on quiting window with zero-length untitled
document. Not a Big Deal but annoys in some cases using this
editor session as temporary storage.

Revert of hrev44979 and real fix for #6453

Thanks Stefano Ceccherini for opening my eyes. ;-)

Preserve font size on changing font family of selection.

This task was completed during GCI 2012
Fixes #6453

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

64-bit fixes for StyledEdit.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Pulling declarations back into loop, plus small style change.

Pointed out by Jérô and John. Thanks,

Stylefixes, no functional change.

Patch by x-ist, thanks! Fixes non-terminating ReplaceAll, #8141.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Follow up commit on r41184, which removed the Edit->Clear menu item.
I suppose it was discussed on the i18n list as mentioned in that
commit. However two things, Humdinger: 1) You did not test your commit,
and 2) You did incomplete cleanup. If you had removed the member variable
from the StyledEditWindow header, you would have gotten at least a
compile error. Those things being said, I did not test my changes
either... :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41187 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed a few strings as discussed on the i18n mailing list. Added localization of license descriptions in AboutSystem.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41184 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bunch of localization fixes pointed out by Diver. Thanks!

Notes:
- FileTypes: The "Same as" button label separated to two entities in dependency of
context: "Same Type as ..." and "Same Application as ...";
- Tracker: The sentences like "If you do %action [...]. To do %action [...]"
now use separately translated verbs for so called
"ifYouDoAction" and "toDoAction";
- NetworkStatus: NetworkStatusView _ShowConfiguration is fixed back after previous
attempt to localize it in r37337: useless code bloating purged out,
broken quasi-header "ifaceName information:" pulled back from Hell;
- StyledEdit: Menu item "Can't undo" had different casing in some situation. Looks
like HTA cannot detect such situation, so right lines "Can't undo"
were masked by wrong one "Can't Undo" and this line stay untranslated
for most time.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40688 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use strlcpy not strncopy.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40036 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 5899: Move a variable so it does not go out of scope when a pointer to it
is used. In my testing this did not seem to be a problem but it doesn't hurt to
fix it.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40012 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 6931 and 8076: use strncpy for the extremely unlikely case that
B_TRANSLATE("???") returns something larger than the size of name.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40011 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 10412: remove assignments for unused variables.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40010 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by negusnyul that closes ticket #4689 by adding bold/italic
shortcuts to StyledEdit - thanks a lot!
* Minor style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39680 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by negusnyul that adds a few more keyboard shortcuts as part
of ticket #4689.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39583 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed incorrect indentation (spaces vs. tabs), thanks korli!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39550 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed private methhods to have an underscore prefix.
* Ordered methods as they are declared in the header.
* Style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39549 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Tamás Krutki that adds some statistic info to StyledEdit.
Thanks for the patch!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39546 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed CID 461 as well - same thing, only for adding a menu to the save panel.
* The menus are now only created when the menu bar is found.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38466 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed potential NULL menuBar. This fixes CID 462.
* Got rid of the global styled_edit_app variable.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38463 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed ReplaceAll behavior with mixed styles. Also suppress undo for replacements as it doesn't seem supported by BTextView.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37008 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Adapted to Ingo's suggestions: used a more descriptive attribute name,
got rid of the superfluous fSaveMessage check in LoadAttrs().
* Also made the attribute name a proper const variable, and renamed it to
kInfoAttributeName.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36705 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36679 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the se-info attribute endian-aware.
* Check in LoadAttrs() if the new frame looks valid, and fits on screen, and
ignore it if not.
* Moved static helper function out of the class definition.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36659 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by x-ist that adds StyledEdit storing its window position and
size per document in a se-info attribute.
* Minor style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36656 a95241bf-73f2-0310-859d-f6bbb57e9c96

* StyledEdit now checks the file permissions before writing it (bug #5521). An alert asks the user in case if not writable.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36114 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by mt : localize stylededit. Thanks !


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35656 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

Make StyledEdit check its open windows before launching a new one for an entry_ref. Simplify the application class somewhat by removing DispatchMessage() and replacing the custom made ArgvReceivedEx() with a standard ArgvReceived(). Rely on BPath to take care of paths relative to the current working directory - don't do it manually.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30701 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit didn't clear the marks on the Font Styles in the font menu.
It resulted in several bogus checkmarks. (ticket #2984)

Also, The last font was always checked by default. The error was that
instead than Marking the "left align" item, it was checking that font because
of the wrong variable used.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30590 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the line view again. Sorry, but this is pretty useless, had a small
fixed size, didn't follow our coding style, etc.
* I did not remove the back-end code in the StyledEditView, though (nor did I
had a look at it for coding style violations :-)).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30006 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Bryce Groff: add line number display to StyledEdit. Fixes ticket #2623. It does however expose an interesting curiosity in BTextView - CurrentLine() does not count a line until it's actually had some text put into it (i.e. simply hitting enter at the last line of the doc does not increment the number that CurrentLine() returns. Is this an oversight or does R5 behave this way also?



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29782 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Actually show the error that happened - are we Windows or what?
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28880 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit now alerts with "unsupported format" instead of "Bad argument type passed to function" (bug #3071)
OpenFile() now returns early when the format is unsupported (don't add the document to recent documents, don't allow to save the document) (bug #3072)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28565 a95241bf-73f2-0310-859d-f6bbb57e9c96

BFilePanel doesn't take ownership of the passed entry_ref. That code wouldn't have worked anyway, since FindRef() returns B_OK on success. CID 933

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27730 a95241bf-73f2-0310-859d-f6bbb57e9c96

* remove messenger leak in save panel
* tell something if saving a file fails before it gets to TranslationUtils, fixes #2612



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27225 a95241bf-73f2-0310-859d-f6bbb57e9c96

* show the config job panel, even if no page setup was already performed
this avoids to multiple window popup for page settings and job settings

* Note: this shows the painting regression introduced with r26665, see task #2534



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27211 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix of by one error, makes printing of ranges work properly



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26824 a95241bf-73f2-0310-859d-f6bbb57e9c96

* whitespace cleanup



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26823 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit didn't print anything if there's only one line (bug #1288).
Note, though, that printing in StyledEdit is still very much broken.
Often it prints only the current page, for example.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22511 a95241bf-73f2-0310-859d-f6bbb57e9c96

Additional style fixes from Julun: adding back the virtual keyword, moving the
commas on class member initializers, fixing a typo. Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22174 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch from "HOST", with a few small style fixes myself.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22163 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Jonas Sundstrom: fixed the usage of B_UTF8_ELLIPSIS hopefully
everywhere in the tree.
* Added the ellipsis to "About Haiku" in Deskbar as well.
* Minor cleanup of Deskbar's StatusView.cpp


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21156 a95241bf-73f2-0310-859d-f6bbb57e9c96

* StyledEditWindow::_LoadFile() now traverses symlinks when opening a file.
This fixes bug #593.
* No longer opens an empty document for every non existing path - it now only
opens a new document if there is none yet.
* No longer open an empty document for non existing files - instead, it just
passes the ref to StyledEditApp::OpenDocument(). StyledEditWindow::_LoadFile()
now treats those files gently as well, so that you can create new documents
via StyledEdit as on BeOS without getting annoyed too much.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17699 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed some minor bugs and oddities, improved error messages.
* Big-time cleanup, added license.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16696 a95241bf-73f2-0310-859d-f6bbb57e9c96

use BFilePanel::SetSaveText which selects the filename


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7140 a95241bf-73f2-0310-859d-f6bbb57e9c96

DarkWyrm feature request: keyboard short for Save As... command-shift-s


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6309 a95241bf-73f2-0310-859d-f6bbb57e9c96

With shatty's permission, added a patch to allow for opening a file by dropping it on the main window


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5488 a95241bf-73f2-0310-859d-f6bbb57e9c96

remove unused variables


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4447 a95241bf-73f2-0310-859d-f6bbb57e9c96

null settings reveal improper ownership bugs which are now fixed, no more luck needed, fixed a missing delete in destructor


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4267 a95241bf-73f2-0310-859d-f6bbb57e9c96

SetSettings turns over ownership to the BMessage so we null out our field to ensure we do not accidently use it later


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4265 a95241bf-73f2-0310-859d-f6bbb57e9c96

strange sanity check required


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4248 a95241bf-73f2-0310-859d-f6bbb57e9c96

disabled find next and replace same when no text has been found or replaced yet, enabled them when that occurs. also fixed replace all so it does not dirty the window if it fails to replace anything.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4247 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed the save as case as well


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4242 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed close click save does not save bug


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4241 a95241bf-73f2-0310-859d-f6bbb57e9c96

improve feedback and add shortcuts for alerts


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4177 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix typo in checkin


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4169 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed the "find does not work" bug on newly opened files by setting the cursor to the start of the file on opening


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4168 a95241bf-73f2-0310-859d-f6bbb57e9c96

at least tell the user that saving failed, if writing the file did, all the other returns should notify as well but I am tired and it is time to sleep :-P


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4167 a95241bf-73f2-0310-859d-f6bbb57e9c96

more and more error checks and helpful dialogs explaining what is happening when things go bad


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4166 a95241bf-73f2-0310-859d-f6bbb57e9c96

added 11 font size at Konrads request


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4113 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed annoying print before page setup aborts print bug


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4105 a95241bf-73f2-0310-859d-f6bbb57e9c96

print selected pages working better now


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4104 a95241bf-73f2-0310-859d-f6bbb57e9c96

pixel perfect printing?


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4103 a95241bf-73f2-0310-859d-f6bbb57e9c96

perfect print #1


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4100 a95241bf-73f2-0310-859d-f6bbb57e9c96

changed to use new BCharacterSet and BCharacterSetRoster from support kit. because libtextencoding.so is not finished yet it uses those sources directly instead of the library.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4092 a95241bf-73f2-0310-859d-f6bbb57e9c96

set changes monitoring on return by error


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3984 a95241bf-73f2-0310-859d-f6bbb57e9c96

moved encoding handling into StyledEditView and began reading the be:encoding attribute


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3866 a95241bf-73f2-0310-859d-f6bbb57e9c96

working save as encoding


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3863 a95241bf-73f2-0310-859d-f6bbb57e9c96

second encodings menu up for save as with field


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3853 a95241bf-73f2-0310-859d-f6bbb57e9c96

first start encodings menu up for save as


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3852 a95241bf-73f2-0310-859d-f6bbb57e9c96

update the alignment menu based on the current alignment of the text view


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2175 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed erroneous deleting of print settings BMessage and changed fMenuBar to fFontMenu to fix crashing in font settings


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2172 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed changing color reset font bug and made the menus update for font and family and font size


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2064 a95241bf-73f2-0310-859d-f6bbb57e9c96

update font menu for color based on selection or cursor location


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2063 a95241bf-73f2-0310-859d-f6bbb57e9c96

lots of font related changes to reduce memory consumption and speed up initialization. also fixes for word wrapping screen width.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2062 a95241bf-73f2-0310-859d-f6bbb57e9c96

improved soft wrapping, now saves alignment and wrapping states


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2061 a95241bf-73f2-0310-859d-f6bbb57e9c96

set the default save as directory appropriately


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2044 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix command line execution - thanks BGA


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2043 a95241bf-73f2-0310-859d-f6bbb57e9c96

disable undo after font actions


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1869 a95241bf-73f2-0310-859d-f6bbb57e9c96

I think replace all is fixed now?


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1868 a95241bf-73f2-0310-859d-f6bbb57e9c96

replace all still has problems but I am sleepy...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1867 a95241bf-73f2-0310-859d-f6bbb57e9c96

font operations now make the document unclean. they can't be undone, but R5 doesn't let you undo them either.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1865 a95241bf-73f2-0310-859d-f6bbb57e9c96

added encodings menu for save and open file panel (not functional yet)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1864 a95241bf-73f2-0310-859d-f6bbb57e9c96

recent menu works. save as puts current name into text field. revert bug fixed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1860 a95241bf-73f2-0310-859d-f6bbb57e9c96

revert to saved confirmation dialog added


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1859 a95241bf-73f2-0310-859d-f6bbb57e9c96

pixel tweaks


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1857 a95241bf-73f2-0310-859d-f6bbb57e9c96

style cleanup ; undo, revert, redo, save, quit functions fixed up ; no more extra windows ; quit when all windows are closed ; fix grey lines when scrolling


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1848 a95241bf-73f2-0310-859d-f6bbb57e9c96

made open into a submenu, changed case of Save As


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1837 a95241bf-73f2-0310-859d-f6bbb57e9c96

patches from Mattias Sundblad


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1836 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed newline at end of files.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1204 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initial Check in. Coded by Mattias Sundblad.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1135 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit: avoid crash on replace window

* Fixes #13842

StyledEdit: Rework of the font color system

1) The default font color is now B_DOCUMENT_TEXT_COLOR
2) The font color menu now shows a palette
3) The font color menu now includes a "default" item, set
to B_DOCUMENT_TEXT_COLOR
4) Added a Todo mentionning it would be ideal to not save the default color
itself, but instead saving the fact the default color was used. Maybe allow the
StyleBuffer to use a Null color or something similar.

StyledEdit: add navigation menu to status bar.

* Fix #12099.

StyledEdit: ensure caret position gets set correctly

* When opening documents without be:caret_position,
StyledEdit would place the cursor at the end of
the file. _LoadAttrs() intended to set it to the
beginning; however, a check for an existing BRect
for positioning the window would return early,
preventing the caret position to be set.

Fixes #11463

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.

StyledEdit: Fix #10349.

Override QuitRequested in FindWindow to notify the parent edit window of the
find window's demise so it can reset its corresponding pointer. Otherwise the
latter will potentially access the invalid pointer in question on subsequent
find requests, leading to potential crashes.

StyleEdit: non-modal Find/Replace windows implementation

* Switch to non-modal floating windows for Find/Replace dialogs,
preserve parameters of the previous search in this editor session;
* Fixes #10053.

- GCI 2013

StyledEdit: Use RecentItems helper instead of private impl.

* Switch recent documents list to use RecentItems.h helper instead of
homebrewn implementation;
* Fixes #9999.

- GCI 2013

StyledEdit:update status view after document was saved

StyledEdit:supress unlock if the file is on RO volume

Show the "Read-only" status for documents that are living on read-only
volumes and do not show unlock menu for such files.

* The enhancement pointed out by Sergei Reznikov (Diver). Thanks!

StyledEdit: fixed statistics words count.

* Bug #9822 and actual fix suggested by DanielW.

Remove this bit of code from StyledEdit

....as we're gonna do the work in BFilePanel instead.

Remove the alert dialog adjustements, they are now done in BAlert directly

The save panel adjustment has been kept and modified a bit to position the
window nicely. It too uses the BWindow::CenterIn() method that adjusts based
on the screen edges.

Move the save panel to the middle of the window as well

Move the alert to the middle of the window

Fix GCC2 build. Thanks to John for the warning.

Improve File Encoding StatusView cell. (Fixes #9653)

* Encoding cell of the StyledEdit StatusView is visible now only in case
the currently opened file encoding is not equal to default UTF-8 one;
* The Encodings menu that was opened by click on this cell is removed;
* Cmd-Opt-PgDn/PgUp shortcuts are added for quick iteration through the
list of encodings.

Fix CID992335,CID992334: Check FindRef/String returns

Satisfy Coverity by checking return values of FindRef and FindString
calls for fSavedMessage.

Resolves CID992335 and CID992334.

Update StyledEdit to use document background color. Style fixes.

See ticket #5293 Colors_picture2.png

StyledEdit:EncodingMenu: autodetect on root menu entry

StyledEdit::StatusView Encoding context menu implemented

Implement "be:caret_position" document file attribute.

* Use "be:caret_position"document file attribute instead of
"be:line" and "be:selection_{length|offset}" file attributes;
* Fixed code style violations. Thanks to Axel for pointing it out!

Unifying the quit/save alerts.

Wherever I found an alert prompting to save changes, I used the
button labeling 'Cancel', 'Don't save', 'Save' with the first button
left aligned, 2nd and 3rd right aligned.

I added the shortcuts 'd' for 'Don't save, and 's' for 'Save' where
not already set.

The topic was discussed at
http://permalink.gmane.org/gmane.os.haiku.devel/23244
The discussion died down, I hope I made changes everyone can live with.

Use "Revert" instead of "OK" as button label.

Handle be:line and °K in RefsReceived, store it in file attributes

This work was done during GCI2012

Fixes #4794

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

StyledEdit:Implemented StatusLine and R5-like ReadOnly mode

This work was done during GCI2012.

Fixes #3655

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Node monitoring and on-the-fly textencoding change

This work is based on the draft node monitoring implementation
created by Vlad Slepukhin during GCI 2012 and includes following:

* Refactoring of the document "Reload" feature - it replaces
"Revert to saved" one because do the same things and a bit more.
Looks like we have to keep "Reload" menu entry alive until
StyledEdit will get more functional Undo/Redo features. Reload
functionality is also heavily used in node monitoring and
on-the-fly text encoding changing. Fixes #6887;

* Support for text encoding on-the-fly switching. This make
life easier for those who lives in countires with multiple
popular 8-bit encodings. Russia is the sample of such
de facto standards' clash (KOI-8R vs CP1251 etc.);

* Node Monitoring support with alerting user in case the file
size or modification time were changed. Another alert is shown
in case edited file was removed or moved outside of the current
volume. Moving file inside of current volume silently changes
references. Choosing "Ignore" will supress new change alerts
until next Reload or Save user request;

* Do not nag user on quiting window with zero-length untitled
document. Not a Big Deal but annoys in some cases using this
editor session as temporary storage.

Revert of hrev44979 and real fix for #6453

Thanks Stefano Ceccherini for opening my eyes. ;-)

Preserve font size on changing font family of selection.

This task was completed during GCI 2012
Fixes #6453

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

64-bit fixes for StyledEdit.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Pulling declarations back into loop, plus small style change.

Pointed out by Jérô and John. Thanks,

Stylefixes, no functional change.

Patch by x-ist, thanks! Fixes non-terminating ReplaceAll, #8141.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Follow up commit on r41184, which removed the Edit->Clear menu item.
I suppose it was discussed on the i18n list as mentioned in that
commit. However two things, Humdinger: 1) You did not test your commit,
and 2) You did incomplete cleanup. If you had removed the member variable
from the StyledEditWindow header, you would have gotten at least a
compile error. Those things being said, I did not test my changes
either... :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41187 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed a few strings as discussed on the i18n mailing list. Added localization of license descriptions in AboutSystem.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41184 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bunch of localization fixes pointed out by Diver. Thanks!

Notes:
- FileTypes: The "Same as" button label separated to two entities in dependency of
context: "Same Type as ..." and "Same Application as ...";
- Tracker: The sentences like "If you do %action [...]. To do %action [...]"
now use separately translated verbs for so called
"ifYouDoAction" and "toDoAction";
- NetworkStatus: NetworkStatusView _ShowConfiguration is fixed back after previous
attempt to localize it in r37337: useless code bloating purged out,
broken quasi-header "ifaceName information:" pulled back from Hell;
- StyledEdit: Menu item "Can't undo" had different casing in some situation. Looks
like HTA cannot detect such situation, so right lines "Can't undo"
were masked by wrong one "Can't Undo" and this line stay untranslated
for most time.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40688 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use strlcpy not strncopy.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40036 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 5899: Move a variable so it does not go out of scope when a pointer to it
is used. In my testing this did not seem to be a problem but it doesn't hurt to
fix it.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40012 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 6931 and 8076: use strncpy for the extremely unlikely case that
B_TRANSLATE("???") returns something larger than the size of name.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40011 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 10412: remove assignments for unused variables.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40010 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by negusnyul that closes ticket #4689 by adding bold/italic
shortcuts to StyledEdit - thanks a lot!
* Minor style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39680 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by negusnyul that adds a few more keyboard shortcuts as part
of ticket #4689.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39583 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed incorrect indentation (spaces vs. tabs), thanks korli!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39550 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed private methhods to have an underscore prefix.
* Ordered methods as they are declared in the header.
* Style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39549 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Tamás Krutki that adds some statistic info to StyledEdit.
Thanks for the patch!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39546 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed CID 461 as well - same thing, only for adding a menu to the save panel.
* The menus are now only created when the menu bar is found.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38466 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed potential NULL menuBar. This fixes CID 462.
* Got rid of the global styled_edit_app variable.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38463 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed ReplaceAll behavior with mixed styles. Also suppress undo for replacements as it doesn't seem supported by BTextView.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37008 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Adapted to Ingo's suggestions: used a more descriptive attribute name,
got rid of the superfluous fSaveMessage check in LoadAttrs().
* Also made the attribute name a proper const variable, and renamed it to
kInfoAttributeName.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36705 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36679 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the se-info attribute endian-aware.
* Check in LoadAttrs() if the new frame looks valid, and fits on screen, and
ignore it if not.
* Moved static helper function out of the class definition.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36659 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by x-ist that adds StyledEdit storing its window position and
size per document in a se-info attribute.
* Minor style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36656 a95241bf-73f2-0310-859d-f6bbb57e9c96

* StyledEdit now checks the file permissions before writing it (bug #5521). An alert asks the user in case if not writable.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36114 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by mt : localize stylededit. Thanks !


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35656 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

Make StyledEdit check its open windows before launching a new one for an entry_ref. Simplify the application class somewhat by removing DispatchMessage() and replacing the custom made ArgvReceivedEx() with a standard ArgvReceived(). Rely on BPath to take care of paths relative to the current working directory - don't do it manually.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30701 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit didn't clear the marks on the Font Styles in the font menu.
It resulted in several bogus checkmarks. (ticket #2984)

Also, The last font was always checked by default. The error was that
instead than Marking the "left align" item, it was checking that font because
of the wrong variable used.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30590 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the line view again. Sorry, but this is pretty useless, had a small
fixed size, didn't follow our coding style, etc.
* I did not remove the back-end code in the StyledEditView, though (nor did I
had a look at it for coding style violations :-)).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30006 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Bryce Groff: add line number display to StyledEdit. Fixes ticket #2623. It does however expose an interesting curiosity in BTextView - CurrentLine() does not count a line until it's actually had some text put into it (i.e. simply hitting enter at the last line of the doc does not increment the number that CurrentLine() returns. Is this an oversight or does R5 behave this way also?



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29782 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Actually show the error that happened - are we Windows or what?
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28880 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit now alerts with "unsupported format" instead of "Bad argument type passed to function" (bug #3071)
OpenFile() now returns early when the format is unsupported (don't add the document to recent documents, don't allow to save the document) (bug #3072)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28565 a95241bf-73f2-0310-859d-f6bbb57e9c96

BFilePanel doesn't take ownership of the passed entry_ref. That code wouldn't have worked anyway, since FindRef() returns B_OK on success. CID 933

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27730 a95241bf-73f2-0310-859d-f6bbb57e9c96

* remove messenger leak in save panel
* tell something if saving a file fails before it gets to TranslationUtils, fixes #2612



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27225 a95241bf-73f2-0310-859d-f6bbb57e9c96

* show the config job panel, even if no page setup was already performed
this avoids to multiple window popup for page settings and job settings

* Note: this shows the painting regression introduced with r26665, see task #2534



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27211 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix of by one error, makes printing of ranges work properly



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26824 a95241bf-73f2-0310-859d-f6bbb57e9c96

* whitespace cleanup



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26823 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit didn't print anything if there's only one line (bug #1288).
Note, though, that printing in StyledEdit is still very much broken.
Often it prints only the current page, for example.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22511 a95241bf-73f2-0310-859d-f6bbb57e9c96

Additional style fixes from Julun: adding back the virtual keyword, moving the
commas on class member initializers, fixing a typo. Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22174 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch from "HOST", with a few small style fixes myself.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22163 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Jonas Sundstrom: fixed the usage of B_UTF8_ELLIPSIS hopefully
everywhere in the tree.
* Added the ellipsis to "About Haiku" in Deskbar as well.
* Minor cleanup of Deskbar's StatusView.cpp


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21156 a95241bf-73f2-0310-859d-f6bbb57e9c96

* StyledEditWindow::_LoadFile() now traverses symlinks when opening a file.
This fixes bug #593.
* No longer opens an empty document for every non existing path - it now only
opens a new document if there is none yet.
* No longer open an empty document for non existing files - instead, it just
passes the ref to StyledEditApp::OpenDocument(). StyledEditWindow::_LoadFile()
now treats those files gently as well, so that you can create new documents
via StyledEdit as on BeOS without getting annoyed too much.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17699 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed some minor bugs and oddities, improved error messages.
* Big-time cleanup, added license.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16696 a95241bf-73f2-0310-859d-f6bbb57e9c96

use BFilePanel::SetSaveText which selects the filename


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7140 a95241bf-73f2-0310-859d-f6bbb57e9c96

DarkWyrm feature request: keyboard short for Save As... command-shift-s


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6309 a95241bf-73f2-0310-859d-f6bbb57e9c96

With shatty's permission, added a patch to allow for opening a file by dropping it on the main window


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5488 a95241bf-73f2-0310-859d-f6bbb57e9c96

remove unused variables


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4447 a95241bf-73f2-0310-859d-f6bbb57e9c96

null settings reveal improper ownership bugs which are now fixed, no more luck needed, fixed a missing delete in destructor


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4267 a95241bf-73f2-0310-859d-f6bbb57e9c96

SetSettings turns over ownership to the BMessage so we null out our field to ensure we do not accidently use it later


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4265 a95241bf-73f2-0310-859d-f6bbb57e9c96

strange sanity check required


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4248 a95241bf-73f2-0310-859d-f6bbb57e9c96

disabled find next and replace same when no text has been found or replaced yet, enabled them when that occurs. also fixed replace all so it does not dirty the window if it fails to replace anything.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4247 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed the save as case as well


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4242 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed close click save does not save bug


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4241 a95241bf-73f2-0310-859d-f6bbb57e9c96

improve feedback and add shortcuts for alerts


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4177 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix typo in checkin


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4169 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed the "find does not work" bug on newly opened files by setting the cursor to the start of the file on opening


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4168 a95241bf-73f2-0310-859d-f6bbb57e9c96

at least tell the user that saving failed, if writing the file did, all the other returns should notify as well but I am tired and it is time to sleep :-P


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4167 a95241bf-73f2-0310-859d-f6bbb57e9c96

more and more error checks and helpful dialogs explaining what is happening when things go bad


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4166 a95241bf-73f2-0310-859d-f6bbb57e9c96

added 11 font size at Konrads request


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4113 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed annoying print before page setup aborts print bug


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4105 a95241bf-73f2-0310-859d-f6bbb57e9c96

print selected pages working better now


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4104 a95241bf-73f2-0310-859d-f6bbb57e9c96

pixel perfect printing?


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4103 a95241bf-73f2-0310-859d-f6bbb57e9c96

perfect print #1


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4100 a95241bf-73f2-0310-859d-f6bbb57e9c96

changed to use new BCharacterSet and BCharacterSetRoster from support kit. because libtextencoding.so is not finished yet it uses those sources directly instead of the library.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4092 a95241bf-73f2-0310-859d-f6bbb57e9c96

set changes monitoring on return by error


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3984 a95241bf-73f2-0310-859d-f6bbb57e9c96

moved encoding handling into StyledEditView and began reading the be:encoding attribute


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3866 a95241bf-73f2-0310-859d-f6bbb57e9c96

working save as encoding


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3863 a95241bf-73f2-0310-859d-f6bbb57e9c96

second encodings menu up for save as with field


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3853 a95241bf-73f2-0310-859d-f6bbb57e9c96

first start encodings menu up for save as


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3852 a95241bf-73f2-0310-859d-f6bbb57e9c96

update the alignment menu based on the current alignment of the text view


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2175 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed erroneous deleting of print settings BMessage and changed fMenuBar to fFontMenu to fix crashing in font settings


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2172 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed changing color reset font bug and made the menus update for font and family and font size


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2064 a95241bf-73f2-0310-859d-f6bbb57e9c96

update font menu for color based on selection or cursor location


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2063 a95241bf-73f2-0310-859d-f6bbb57e9c96

lots of font related changes to reduce memory consumption and speed up initialization. also fixes for word wrapping screen width.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2062 a95241bf-73f2-0310-859d-f6bbb57e9c96

improved soft wrapping, now saves alignment and wrapping states


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2061 a95241bf-73f2-0310-859d-f6bbb57e9c96

set the default save as directory appropriately


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2044 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix command line execution - thanks BGA


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2043 a95241bf-73f2-0310-859d-f6bbb57e9c96

disable undo after font actions


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1869 a95241bf-73f2-0310-859d-f6bbb57e9c96

I think replace all is fixed now?


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1868 a95241bf-73f2-0310-859d-f6bbb57e9c96

replace all still has problems but I am sleepy...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1867 a95241bf-73f2-0310-859d-f6bbb57e9c96

font operations now make the document unclean. they can't be undone, but R5 doesn't let you undo them either.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1865 a95241bf-73f2-0310-859d-f6bbb57e9c96

added encodings menu for save and open file panel (not functional yet)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1864 a95241bf-73f2-0310-859d-f6bbb57e9c96

recent menu works. save as puts current name into text field. revert bug fixed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1860 a95241bf-73f2-0310-859d-f6bbb57e9c96

revert to saved confirmation dialog added


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1859 a95241bf-73f2-0310-859d-f6bbb57e9c96

pixel tweaks


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1857 a95241bf-73f2-0310-859d-f6bbb57e9c96

style cleanup ; undo, revert, redo, save, quit functions fixed up ; no more extra windows ; quit when all windows are closed ; fix grey lines when scrolling


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1848 a95241bf-73f2-0310-859d-f6bbb57e9c96

made open into a submenu, changed case of Save As


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1837 a95241bf-73f2-0310-859d-f6bbb57e9c96

patches from Mattias Sundblad


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1836 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed newline at end of files.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1204 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initial Check in. Coded by Mattias Sundblad.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1135 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit: Rework of the font color system

1) The default font color is now B_DOCUMENT_TEXT_COLOR
2) The font color menu now shows a palette
3) The font color menu now includes a "default" item, set
to B_DOCUMENT_TEXT_COLOR
4) Added a Todo mentionning it would be ideal to not save the default color
itself, but instead saving the fact the default color was used. Maybe allow the
StyleBuffer to use a Null color or something similar.

StyledEdit: add navigation menu to status bar.

* Fix #12099.

StyledEdit: ensure caret position gets set correctly

* When opening documents without be:caret_position,
StyledEdit would place the cursor at the end of
the file. _LoadAttrs() intended to set it to the
beginning; however, a check for an existing BRect
for positioning the window would return early,
preventing the caret position to be set.

Fixes #11463

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.

StyledEdit: Fix #10349.

Override QuitRequested in FindWindow to notify the parent edit window of the
find window's demise so it can reset its corresponding pointer. Otherwise the
latter will potentially access the invalid pointer in question on subsequent
find requests, leading to potential crashes.

StyleEdit: non-modal Find/Replace windows implementation

* Switch to non-modal floating windows for Find/Replace dialogs,
preserve parameters of the previous search in this editor session;
* Fixes #10053.

- GCI 2013

StyledEdit: Use RecentItems helper instead of private impl.

* Switch recent documents list to use RecentItems.h helper instead of
homebrewn implementation;
* Fixes #9999.

- GCI 2013

StyledEdit:update status view after document was saved

StyledEdit:supress unlock if the file is on RO volume

Show the "Read-only" status for documents that are living on read-only
volumes and do not show unlock menu for such files.

* The enhancement pointed out by Sergei Reznikov (Diver). Thanks!

StyledEdit: fixed statistics words count.

* Bug #9822 and actual fix suggested by DanielW.

Remove this bit of code from StyledEdit

....as we're gonna do the work in BFilePanel instead.

Remove the alert dialog adjustements, they are now done in BAlert directly

The save panel adjustment has been kept and modified a bit to position the
window nicely. It too uses the BWindow::CenterIn() method that adjusts based
on the screen edges.

Move the save panel to the middle of the window as well

Move the alert to the middle of the window

Fix GCC2 build. Thanks to John for the warning.

Improve File Encoding StatusView cell. (Fixes #9653)

* Encoding cell of the StyledEdit StatusView is visible now only in case
the currently opened file encoding is not equal to default UTF-8 one;
* The Encodings menu that was opened by click on this cell is removed;
* Cmd-Opt-PgDn/PgUp shortcuts are added for quick iteration through the
list of encodings.

Fix CID992335,CID992334: Check FindRef/String returns

Satisfy Coverity by checking return values of FindRef and FindString
calls for fSavedMessage.

Resolves CID992335 and CID992334.

Update StyledEdit to use document background color. Style fixes.

See ticket #5293 Colors_picture2.png

StyledEdit:EncodingMenu: autodetect on root menu entry

StyledEdit::StatusView Encoding context menu implemented

Implement "be:caret_position" document file attribute.

* Use "be:caret_position"document file attribute instead of
"be:line" and "be:selection_{length|offset}" file attributes;
* Fixed code style violations. Thanks to Axel for pointing it out!

Unifying the quit/save alerts.

Wherever I found an alert prompting to save changes, I used the
button labeling 'Cancel', 'Don't save', 'Save' with the first button
left aligned, 2nd and 3rd right aligned.

I added the shortcuts 'd' for 'Don't save, and 's' for 'Save' where
not already set.

The topic was discussed at
http://permalink.gmane.org/gmane.os.haiku.devel/23244
The discussion died down, I hope I made changes everyone can live with.

Use "Revert" instead of "OK" as button label.

Handle be:line and °K in RefsReceived, store it in file attributes

This work was done during GCI2012

Fixes #4794

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

StyledEdit:Implemented StatusLine and R5-like ReadOnly mode

This work was done during GCI2012.

Fixes #3655

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Node monitoring and on-the-fly textencoding change

This work is based on the draft node monitoring implementation
created by Vlad Slepukhin during GCI 2012 and includes following:

* Refactoring of the document "Reload" feature - it replaces
"Revert to saved" one because do the same things and a bit more.
Looks like we have to keep "Reload" menu entry alive until
StyledEdit will get more functional Undo/Redo features. Reload
functionality is also heavily used in node monitoring and
on-the-fly text encoding changing. Fixes #6887;

* Support for text encoding on-the-fly switching. This make
life easier for those who lives in countires with multiple
popular 8-bit encodings. Russia is the sample of such
de facto standards' clash (KOI-8R vs CP1251 etc.);

* Node Monitoring support with alerting user in case the file
size or modification time were changed. Another alert is shown
in case edited file was removed or moved outside of the current
volume. Moving file inside of current volume silently changes
references. Choosing "Ignore" will supress new change alerts
until next Reload or Save user request;

* Do not nag user on quiting window with zero-length untitled
document. Not a Big Deal but annoys in some cases using this
editor session as temporary storage.

Revert of hrev44979 and real fix for #6453

Thanks Stefano Ceccherini for opening my eyes. ;-)

Preserve font size on changing font family of selection.

This task was completed during GCI 2012
Fixes #6453

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

64-bit fixes for StyledEdit.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Pulling declarations back into loop, plus small style change.

Pointed out by Jérô and John. Thanks,

Stylefixes, no functional change.

Patch by x-ist, thanks! Fixes non-terminating ReplaceAll, #8141.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Follow up commit on r41184, which removed the Edit->Clear menu item.
I suppose it was discussed on the i18n list as mentioned in that
commit. However two things, Humdinger: 1) You did not test your commit,
and 2) You did incomplete cleanup. If you had removed the member variable
from the StyledEditWindow header, you would have gotten at least a
compile error. Those things being said, I did not test my changes
either... :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41187 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed a few strings as discussed on the i18n mailing list. Added localization of license descriptions in AboutSystem.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41184 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bunch of localization fixes pointed out by Diver. Thanks!

Notes:
- FileTypes: The "Same as" button label separated to two entities in dependency of
context: "Same Type as ..." and "Same Application as ...";
- Tracker: The sentences like "If you do %action [...]. To do %action [...]"
now use separately translated verbs for so called
"ifYouDoAction" and "toDoAction";
- NetworkStatus: NetworkStatusView _ShowConfiguration is fixed back after previous
attempt to localize it in r37337: useless code bloating purged out,
broken quasi-header "ifaceName information:" pulled back from Hell;
- StyledEdit: Menu item "Can't undo" had different casing in some situation. Looks
like HTA cannot detect such situation, so right lines "Can't undo"
were masked by wrong one "Can't Undo" and this line stay untranslated
for most time.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40688 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use strlcpy not strncopy.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40036 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 5899: Move a variable so it does not go out of scope when a pointer to it
is used. In my testing this did not seem to be a problem but it doesn't hurt to
fix it.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40012 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 6931 and 8076: use strncpy for the extremely unlikely case that
B_TRANSLATE("???") returns something larger than the size of name.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40011 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 10412: remove assignments for unused variables.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40010 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by negusnyul that closes ticket #4689 by adding bold/italic
shortcuts to StyledEdit - thanks a lot!
* Minor style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39680 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by negusnyul that adds a few more keyboard shortcuts as part
of ticket #4689.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39583 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed incorrect indentation (spaces vs. tabs), thanks korli!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39550 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed private methhods to have an underscore prefix.
* Ordered methods as they are declared in the header.
* Style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39549 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Tamás Krutki that adds some statistic info to StyledEdit.
Thanks for the patch!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39546 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed CID 461 as well - same thing, only for adding a menu to the save panel.
* The menus are now only created when the menu bar is found.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38466 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed potential NULL menuBar. This fixes CID 462.
* Got rid of the global styled_edit_app variable.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38463 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed ReplaceAll behavior with mixed styles. Also suppress undo for replacements as it doesn't seem supported by BTextView.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37008 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Adapted to Ingo's suggestions: used a more descriptive attribute name,
got rid of the superfluous fSaveMessage check in LoadAttrs().
* Also made the attribute name a proper const variable, and renamed it to
kInfoAttributeName.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36705 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36679 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the se-info attribute endian-aware.
* Check in LoadAttrs() if the new frame looks valid, and fits on screen, and
ignore it if not.
* Moved static helper function out of the class definition.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36659 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by x-ist that adds StyledEdit storing its window position and
size per document in a se-info attribute.
* Minor style changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36656 a95241bf-73f2-0310-859d-f6bbb57e9c96

* StyledEdit now checks the file permissions before writing it (bug #5521). An alert asks the user in case if not writable.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36114 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by mt : localize stylededit. Thanks !


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35656 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

Make StyledEdit check its open windows before launching a new one for an entry_ref. Simplify the application class somewhat by removing DispatchMessage() and replacing the custom made ArgvReceivedEx() with a standard ArgvReceived(). Rely on BPath to take care of paths relative to the current working directory - don't do it manually.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30701 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit didn't clear the marks on the Font Styles in the font menu.
It resulted in several bogus checkmarks. (ticket #2984)

Also, The last font was always checked by default. The error was that
instead than Marking the "left align" item, it was checking that font because
of the wrong variable used.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30590 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the line view again. Sorry, but this is pretty useless, had a small
fixed size, didn't follow our coding style, etc.
* I did not remove the back-end code in the StyledEditView, though (nor did I
had a look at it for coding style violations :-)).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30006 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Bryce Groff: add line number display to StyledEdit. Fixes ticket #2623. It does however expose an interesting curiosity in BTextView - CurrentLine() does not count a line until it's actually had some text put into it (i.e. simply hitting enter at the last line of the doc does not increment the number that CurrentLine() returns. Is this an oversight or does R5 behave this way also?



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29782 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Actually show the error that happened - are we Windows or what?
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28880 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit now alerts with "unsupported format" instead of "Bad argument type passed to function" (bug #3071)
OpenFile() now returns early when the format is unsupported (don't add the document to recent documents, don't allow to save the document) (bug #3072)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28565 a95241bf-73f2-0310-859d-f6bbb57e9c96

BFilePanel doesn't take ownership of the passed entry_ref. That code wouldn't have worked anyway, since FindRef() returns B_OK on success. CID 933

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27730 a95241bf-73f2-0310-859d-f6bbb57e9c96

* remove messenger leak in save panel
* tell something if saving a file fails before it gets to TranslationUtils, fixes #2612



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27225 a95241bf-73f2-0310-859d-f6bbb57e9c96

* show the config job panel, even if no page setup was already performed
this avoids to multiple window popup for page settings and job settings

* Note: this shows the painting regression introduced with r26665, see task #2534



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27211 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix of by one error, makes printing of ranges work properly



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26824 a95241bf-73f2-0310-859d-f6bbb57e9c96

* whitespace cleanup



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26823 a95241bf-73f2-0310-859d-f6bbb57e9c96

StyledEdit didn't print anything if there's only one line (bug #1288).
Note, though, that printing in StyledEdit is still very much broken.
Often it prints only the current page, for example.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22511 a95241bf-73f2-0310-859d-f6bbb57e9c96

Additional style fixes from Julun: adding back the virtual keyword, moving the
commas on class member initializers, fixing a typo. Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22174 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch from "HOST", with a few small style fixes myself.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22163 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Jonas Sundstrom: fixed the usage of B_UTF8_ELLIPSIS hopefully
everywhere in the tree.
* Added the ellipsis to "About Haiku" in Deskbar as well.
* Minor cleanup of Deskbar's StatusView.cpp


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21156 a95241bf-73f2-0310-859d-f6bbb57e9c96

* StyledEditWindow::_LoadFile() now traverses symlinks when opening a file.
This fixes bug #593.
* No longer opens an empty document for every non existing path - it now only
opens a new document if there is none yet.
* No longer open an empty document for non existing files - instead, it just
passes the ref to StyledEditApp::OpenDocument(). StyledEditWindow::_LoadFile()
now treats those files gently as well, so that you can create new documents
via StyledEdit as on BeOS without getting annoyed too much.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17699 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed some minor bugs and oddities, improved error messages.
* Big-time cleanup, added license.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16696 a95241bf-73f2-0310-859d-f6bbb57e9c96

use BFilePanel::SetSaveText which selects the filename


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7140 a95241bf-73f2-0310-859d-f6bbb57e9c96

DarkWyrm feature request: keyboard short for Save As... command-shift-s


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6309 a95241bf-73f2-0310-859d-f6bbb57e9c96

With shatty's permission, added a patch to allow for opening a file by dropping it on the main window


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5488 a95241bf-73f2-0310-859d-f6bbb57e9c96

remove unused variables


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4447 a95241bf-73f2-0310-859d-f6bbb57e9c96

null settings reveal improper ownership bugs which are now fixed, no more luck needed, fixed a missing delete in destructor


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4267 a95241bf-73f2-0310-859d-f6bbb57e9c96

SetSettings turns over ownership to the BMessage so we null out our field to ensure we do not accidently use it later


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4265 a95241bf-73f2-0310-859d-f6bbb57e9c96

strange sanity check required


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4248 a95241bf-73f2-0310-859d-f6bbb57e9c96

disabled find next and replace same when no text has been found or replaced yet, enabled them when that occurs. also fixed replace all so it does not dirty the window if it fails to replace anything.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4247 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed the save as case as well


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4242 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed close click save does not save bug


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4241 a95241bf-73f2-0310-859d-f6bbb57e9c96

improve feedback and add shortcuts for alerts


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4177 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix typo in checkin


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4169 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed the "find does not work" bug on newly opened files by setting the cursor to the start of the file on opening


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4168 a95241bf-73f2-0310-859d-f6bbb57e9c96

at least tell the user that saving failed, if writing the file did, all the other returns should notify as well but I am tired and it is time to sleep :-P


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4167 a95241bf-73f2-0310-859d-f6bbb57e9c96

more and more error checks and helpful dialogs explaining what is happening when things go bad


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4166 a95241bf-73f2-0310-859d-f6bbb57e9c96

added 11 font size at Konrads request


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4113 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed annoying print before page setup aborts print bug


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4105 a95241bf-73f2-0310-859d-f6bbb57e9c96

print selected pages working better now


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4104 a95241bf-73f2-0310-859d-f6bbb57e9c96

pixel perfect printing?


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4103 a95241bf-73f2-0310-859d-f6bbb57e9c96

perfect print #1


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4100 a95241bf-73f2-0310-859d-f6bbb57e9c96

changed to use new BCharacterSet and BCharacterSetRoster from support kit. because libtextencoding.so is not finished yet it uses those sources directly instead of the library.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4092 a95241bf-73f2-0310-859d-f6bbb57e9c96

set changes monitoring on return by error


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3984 a95241bf-73f2-0310-859d-f6bbb57e9c96

moved encoding handling into StyledEditView and began reading the be:encoding attribute


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3866 a95241bf-73f2-0310-859d-f6bbb57e9c96

working save as encoding


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3863 a95241bf-73f2-0310-859d-f6bbb57e9c96

second encodings menu up for save as with field


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3853 a95241bf-73f2-0310-859d-f6bbb57e9c96

first start encodings menu up for save as


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3852 a95241bf-73f2-0310-859d-f6bbb57e9c96

update the alignment menu based on the current alignment of the text view


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2175 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed erroneous deleting of print settings BMessage and changed fMenuBar to fFontMenu to fix crashing in font settings


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2172 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed changing color reset font bug and made the menus update for font and family and font size


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2064 a95241bf-73f2-0310-859d-f6bbb57e9c96

update font menu for color based on selection or cursor location


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2063 a95241bf-73f2-0310-859d-f6bbb57e9c96

lots of font related changes to reduce memory consumption and speed up initialization. also fixes for word wrapping screen width.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2062 a95241bf-73f2-0310-859d-f6bbb57e9c96

improved soft wrapping, now saves alignment and wrapping states


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2061 a95241bf-73f2-0310-859d-f6bbb57e9c96

set the default save as directory appropriately


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2044 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix command line execution - thanks BGA


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2043 a95241bf-73f2-0310-859d-f6bbb57e9c96

disable undo after font actions


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1869 a95241bf-73f2-0310-859d-f6bbb57e9c96

I think replace all is fixed now?


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1868 a95241bf-73f2-0310-859d-f6bbb57e9c96

replace all still has problems but I am sleepy...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1867 a95241bf-73f2-0310-859d-f6bbb57e9c96

font operations now make the document unclean. they can't be undone, but R5 doesn't let you undo them either.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1865 a95241bf-73f2-0310-859d-f6bbb57e9c96

added encodings menu for save and open file panel (not functional yet)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1864 a95241bf-73f2-0310-859d-f6bbb57e9c96

recent menu works. save as puts current name into text field. revert bug fixed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1860 a95241bf-73f2-0310-859d-f6bbb57e9c96

revert to saved confirmation dialog added


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1859 a95241bf-73f2-0310-859d-f6bbb57e9c96

pixel tweaks


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1857 a95241bf-73f2-0310-859d-f6bbb57e9c96

style cleanup ; undo, revert, redo, save, quit functions fixed up ; no more extra windows ; quit when all windows are closed ; fix grey lines when scrolling


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1848 a95241bf-73f2-0310-859d-f6bbb57e9c96

made open into a submenu, changed case of Save As


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1837 a95241bf-73f2-0310-859d-f6bbb57e9c96

patches from Mattias Sundblad


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1836 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed newline at end of files.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1204 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initial Check in. Coded by Mattias Sundblad.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1135 a95241bf-73f2-0310-859d-f6bbb57e9c96