History log of /haiku/src/apps/haikudepot/ui/RatePackageWindow.cpp
Revision Date Author Comments
# bf866d5e 17-Feb-2024 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot : Improve Language Code Handling

HDS is soon going to be enhanced to deal with more than
just the two-character ISO language codes that it
currently supports. The logic in HD is currently expecting
that HDS will only supply these two character codes. This
change is about making adjustments to be able to cater to
any ICU language IDs from HDS.

The naming in HDS is still going to continue to use the
terminology that it currently does; it will call the
identifier for a language a "natural language code". The
HD source will instead reflect the nomenclature of ICU
and call the same thing a language ID.

Change-Id: Ib138c2e3b7b667edf15cd497c2f710f80b3c29f8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7424
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>


# 4b347fcc 23-Sep-2023 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Token Based Authentication

This switches the application over from using basic
authentication to using token-based authentication in
preparation for later using Open-ID based
authentication flows. The application version is also
bumped in order that the server can detect this version
at some later date in the future when it no longer
supports basic authentication itself.

Change-Id: I7addde1d57503c58d6bcd54908f22f66830c0c59
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6944
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>


# f6e22563 21-Mar-2022 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Send Repository Code on API

Some APIs will require the repository source
code to be sent in the future instead of the
repository code. This change prepares for
this.

Change-Id: Iccf0baca077ab81356ed81c18d14122a5b0dacec
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5137
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 7f86c219 29-Sep-2021 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Fix language selection

Fixes a problem that can arise with the
selection of language when adding or
editing user ratings.

Fixes #11316

Change-Id: I85625cdc156458d88f4d1ca01ae889d954364ffd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4511
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# 779ab335 09-Dec-2020 X512 <danger_mail@list.ru>

use .IsSet() instead if .Get() != NULL

Change-Id: Ia2b7a719fd398e78cc3b11d4f7b02cb81179f65f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3488
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>


# a5e4976d 22-Sep-2020 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Lists; Categories + Stabilities

Remove use of custom list class where it is not
really required in the area of Categories. Also
introduces stabilities relayed over from the
Server and used in the HD user interface instead
of being hard-coded.

Relates To #15534

Change-Id: Ib71141e71cd4a0b4882827e2e59b62072de01b4b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3331
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>


# f0e491d3 28-Jul-2020 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Icon / Tarball Handling

Instead of exploding the tar-ball of icons from
HDS, keep it as a tar-ball, index it and read
data directly out from specific indicies on demand.

This will speed up the process of downloading
the icons by removing the unpack. Also updates
will be faster by avoiding the need to delete the
old icon files.

Because icons are loaded on-demand, the start
time is faster by avoiding all the icon loads.
There are also savings on memory consumption.

Indexing on each load is surprisingly fast so
no external index is maintained. Likewise for
the tar-balls's meta-data.

This commit does not cover the implementation
of an LRU cache of the icons in memory.

Relates to #15370

Change-Id: Ia1647d8c805be89618f493d2592bf7877fca3f14
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3205
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# fa5c8097 25-Jul-2020 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Languages List

Abstacts the list of supported languages into
the LanguageModel class preventing use of
List. Also; fix a few cases where newer
logging techniques may have caused incorrect
logic flow.

Relates To #15534

Change-Id: I144fe4788abdaf0d93e53eeabc97b3f7aa2ec710
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3085
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# f96d1f4d 10-Jul-2020 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Better Logging

Changes the logging in HD to use a macro for the
various log levels to declutter the code and to
make it easier to more systematically log.

Change-Id: I025970707a0a11e7e3aaa4b52fc91288af0183f5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3018
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 1f3909ad 02-May-2020 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Referencable Fixes

Some misuse of BReferencable / BReference are causing the
debugger to fire while debugging another issue. This
should fix some of it.

Change-Id: I895e209afe9e350e35b111739140c85133107227
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2556
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# eaf026de 19-Apr-2020 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Fix Label on User Rating

Resolves #11639

Change-Id: I45d3952d1dd0fc998cf589b5180c0a81ab1f63b6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2501
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# d2d4866d 19-Sep-2019 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Display User's Usage Conditions

A HaikuDepotServer may have previously agreed to
user usage conditions. If this is the case then
they are now able to view those conditions. There
were some problems with date formatting in this
change and so the date formatting logic has moved
into the HaikuDepot source code temporarily until
issues with the BDateTime class can be resolved;
most likely as a separate piece of work.

Relates to 15209

Change-Id: Ic3e5413d9139f410d7f7e8b566d4c56352dd2778
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1870
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>


# 051ee9d8 01-Sep-2019 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Improvements to User Ratings

Change to match the web user interface behaviour;
the user ratings for all architectures are shown
and the list of user ratings is restricted to the
actual repository in use. This is important
where two repositories have the same package with
different versions. Also the architecture
is displayed with the version in the package info
page.

Change-Id: I8c024d9ddec6b97f52233b7462c47d2a1c83af09
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1817
Reviewed-by: Andrew Lindesay <apl@lindesay.co.nz>


# 01339a54 08-Jul-2019 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Display User Usage Conditions

This change will allow the user to view the user
usage conditions from the HDS system in a
HaikuDepot window. The display of the text is not
currently well formatted in that the Markdown is
not yet properly parsed, but the display of the
data is working.

Relates to 15209

Change-Id: Ia6ad4ef995f5fe3c29c40221964e44d4554a033d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1750
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# 4f8d9e12 21-May-2019 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Load Languages from HDS - Fixes

Follow-on changes from recent commit of the same title
with some improvements and fixes.

Change-Id: Ic4439966340578b920345332669591f6cdfcc203
Reviewed-on: https://review.haiku-os.org/c/1471
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# f85e0300 28-Apr-2019 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Load Languages from HDS

The HaikuDepot application has, thus far had its
own hard-coded list of languages that the user is
able to choose when (a) creating a new account or
(b) creating a user-rating. This change will mean
that those languages are loaded from the HDS
server dynamically and in this way the user can
choose from the full list. There have also been
improvements to the way in which the languages are
displayed in the menu as well.

Change-Id: If7cb7b87f348ca59d503d276a22444e72d0e6168
Reviewed-on: https://review.haiku-os.org/c/1425
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 018d5927 27-Sep-2018 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot : User-Rating / Star Selection Fix

This commit resolves a problem where the user-rating
is able to specify a rating (how many stars) or not.
The behaviour was not properly honouring the checkbox
to specify if the rating was to be used or not.

Change-Id: I01067bf899e1d5beab1474a197c5698166b9f582
Reviewed-on: https://review.haiku-os.org/600
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# cbadcae1 24-Jun-2018 Humdinger <humdingerb@gmail.com>

Small string changes in HaikuDepot GUI

* Don't translate internally used names in BMenuBars.
* Use presentable strings for the title of BAlerts.
* Make the wording a bit less technical.
Should the HaikuServer URL be part of the update/remove rating alert?

Change-Id: I0a984082eadbc5834ac6b8b2b1955e66098d1c8a


# a9edb9bf 05-Jun-2018 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Multiple improvements for user-ratings

* Display of the user-ratings listing improved
* When a user-rating is created / edited, the pkg is updated
* Creation date of the user-rating is unpacked shown
* Ability to create a user-rating with a comment, but no numerical rating
* Stars display show grey if no numerical rating present
* Improvements to error reporting when problem arise
* Parsing of the 'revision' field of the version working
* Removed debug logging for the text engine
* Other minor tweaks

Change-Id: I99f881ab1426641ef4177eec2d3bcacc7cb74e95


# 28966a14 18-Jan-2017 Humdinger <humdingerb@gmail.com>

HaikuDepot: Change text view colour in rating window

Sets B_DOCUMENT_BACKGROUND_COLOR for the comment text view.
The former B_PANEL_BACKGROUND_COLOR made it look un-editable.
Unfortunately, I'm unable to set the text colour to
B_DOCUMENT_TEXT_COLOR; it still uses B_PANEL_TEXT_COLOR.
Currently those are both black by default.

There are still a few instances left before closing #11689.


# ebb1a01c 20-Oct-2016 Andrew Lindesay <apl@lindesay.co.nz>

HaikuDepot: Handling for communications with application server over multiple repositories

This change allows for the HaikuDepot desktop application to query the server application
over HTTP for data regarding packages across the various repositories that the have been
configured on the desktop environment. Previously it was 'hard-coded' to only
communicate about the HaikuPorts repository.


# 87084745 07-Apr-2015 Michael Lotz <mmlr@mlotz.ch>

HaikuDepot: Clean up trailing whitespace.


# 72992391 04-Apr-2015 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Title versus Name distinction

* The name is the static package name. The title is either that name,
or a translated pretty version of the name.
* Adjust package info retrieval to server API changes. Unbreaks package
translations.


# 89e4ba17 28-Dec-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Update package info after rating package

Let Model::PopulatePackage() have a mode where it forces the update on a
package that has already been populated. Trigger populating from success
code path in RatePackageWindow. Fixes #11638.


# fa09af9a 03-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot/RatePackageWindow: Output in error code paths


# 602db4af 02-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Removed misleading default comment text


# 5ba7054c 02-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Don't try to send "unspecified" stability

Set to empty string and cause the JSON to have null. Fixes sending/editing
comments without specifying a stability rating.


# b5b71778 02-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Specific error for untracked packages

The web service currently only synchronizes with HaikuPorts. Packages
from 3rd party repositories which were added by the user cannot be rated.

Also, use a warning alert for errors in the UserLoginWindow and
RatePackageWindow.


# fb303f19 30-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Be more verbose about how to update ratings


# bf62b1f8 30-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Changed alert message for updating a rating


# 6e80c1ca 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Implemented creating/updating ratings...

... from the RatePackageWindow. It does not work yet, the errors
are reported. To be investigated...


# 965707a9 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Rating and login window have no system names.


# 8ecb43af 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Display check box to deactivate rating

... if a rating already exists for the given package and version.


# cec1192e 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Use getUserRatingByUserAndPkgVersion...

... instead of searching for a rating from the given user. This API will
also return deactivated ratings, so the user could re-activate it.


# 9ddea57b 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Better order of stability ratings


# 9586185a 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Aligned stability rating names with web app.


# 046dc04e 28-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Now retrives existing rating for a package...

... if there is one and fills the RatePackageWindow UI accordingly.
This will allow a user to edit her earlier rating for a given package.
The button labels will need to be adjusted. Uploading a rating still not
implemented.


# 83f46c71 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Handle BMessage for rating comment language


# da504dbc 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Allow to set the rating comment's language.


# c28b8304 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Add actual rating to RatePackageWindow.

Implemented SetRatingView based on RatingView. It previews the rating
when hovering and makes it permanent when clicked.


# 04c9d578 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Organized source into sub-folders


# 8708474567be756984f35cd6c5bfcc2c9546dc1e 07-Apr-2015 Michael Lotz <mmlr@mlotz.ch>

HaikuDepot: Clean up trailing whitespace.


# 72992391bb6f9351f80367604d64c5da21a9f4a9 04-Apr-2015 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Title versus Name distinction

* The name is the static package name. The title is either that name,
or a translated pretty version of the name.
* Adjust package info retrieval to server API changes. Unbreaks package
translations.


# 89e4ba17d0ae033b2a4896bfabfbde9cd4da5ed7 28-Dec-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Update package info after rating package

Let Model::PopulatePackage() have a mode where it forces the update on a
package that has already been populated. Trigger populating from success
code path in RatePackageWindow. Fixes #11638.


# fa09af9a8f2426e03e944d2a91078536a89f97db 03-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot/RatePackageWindow: Output in error code paths


# 602db4afd3308eedc07bccce5d68a933469f815b 02-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Removed misleading default comment text


# 5ba7054c6b912fc8981192e2337f14fcd6fe1a57 02-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Don't try to send "unspecified" stability

Set to empty string and cause the JSON to have null. Fixes sending/editing
comments without specifying a stability rating.


# b5b717785e8d8d696455844d561f3b47f36a2f9c 02-Oct-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Specific error for untracked packages

The web service currently only synchronizes with HaikuPorts. Packages
from 3rd party repositories which were added by the user cannot be rated.

Also, use a warning alert for errors in the UserLoginWindow and
RatePackageWindow.


# fb303f198746f0b662ed19648698ade34c6e9cea 30-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Be more verbose about how to update ratings


# bf62b1f845d2808baa285887555e96f7a1379dea 30-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Changed alert message for updating a rating


# 6e80c1ca11a81c8187f4f3edb4adbb62d570fc9d 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Implemented creating/updating ratings...

... from the RatePackageWindow. It does not work yet, the errors
are reported. To be investigated...


# 965707a9bbfd077a9bc885c83ddd4bdff50fcd23 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Rating and login window have no system names.


# 8ecb43af281b87c23f3c6418cc065e6ecdc9e696 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Display check box to deactivate rating

... if a rating already exists for the given package and version.


# cec1192ea0f9a4d5be486921e506fadcb9310fb2 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Use getUserRatingByUserAndPkgVersion...

... instead of searching for a rating from the given user. This API will
also return deactivated ratings, so the user could re-activate it.


# 9ddea57b38f3cd93dfcacb023403651b45e52eb0 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Better order of stability ratings


# 9586185a7c66799e08ac84b0f95822193fdd93fe 29-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Aligned stability rating names with web app.


# 046dc04e836e635c249a83dbfce8c4bf84d8560a 28-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Now retrives existing rating for a package...

... if there is one and fills the RatePackageWindow UI accordingly.
This will allow a user to edit her earlier rating for a given package.
The button labels will need to be adjusted. Uploading a rating still not
implemented.


# 83f46c7198f03c981cb985f8901744ef53b8ab6d 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Handle BMessage for rating comment language


# da504dbccebd2f1d71cbef2b934e4ba52ef86317 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Allow to set the rating comment's language.


# c28b83041e3919f35727918d0f81238ad9745f53 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Add actual rating to RatePackageWindow.

Implemented SetRatingView based on RatingView. It previews the rating
when hovering and makes it permanent when clicked.


# 04c9d578d85baa79584c1c40c61cc73ca58d527b 27-Sep-2014 Stephan Aßmus <superstippi@gmx.de>

HaikuDepot: Organized source into sub-folders