#
12e4ac5d |
|
10-May-2020 |
Adrien Destugues <pulkomandy@pulkomandy.tk> |
DiskUsage: fix infinite loop when computing tab width Stop when we have a solution that is within 1px of accurate. Since tab width are rounded to the nearest pixel anyway, there is no need to compute further, and this could otherwise never converge due to rounding errors. Fixes #15944.
|
#
93e5d9fa |
|
13-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Fix CID 1288122 In hrev48870 I made some updates to DiskUsage which accidentally caused this CID. Both the volume and item pointers were going out of scope without being deleted in the error case leading to a resource leak. This commit seeks to fix the problem by creating these objects as late as possible after the error checking. tempVolume, which, as it's name implies, is created temporarily on the stack is used instead of volume up until the point that AddTab() requires a more permanent heap-stored volume pointer. Same goes for the VolumeView and VolumeTab. name is created temporarily on the stack as well which works because it is copied when passed into VolumeView constructor by the grandparent BHandler before going out of scope.
|
#
fa05f35a |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Skip virtual volumes so we don't see the 4.00Kib system and config tab.
|
#
57ee63a5 |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: TabView flush to window border http://postimg.org/image/izae7h1qd/
|
#
1b53ff07 |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Use an int32 instead of an int for CountTabs() which returns an int32
|
#
58f4a50b |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Style fixes
|
#
5da82e3a |
|
03-Dec-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
DiskUsage: align tab focus mark with label. Fixes #6905.
|
#
da1f251a |
|
13-Jul-2013 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: drawing artefact in TabView
|
#
46db18d1 |
|
17-Nov-2012 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: Truncating of tabs could lead to deadlock (#9170)
|
#
3e52a3d5 |
|
14-Nov-2012 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: added ability to cancel an ongoing scan. fixes #6801. Also, progress now goes from 0.0 to 1.0 rather than from 0.00 to 100.00 (to avoid a * 100, followed by a / 100)
|
#
a9e957e2 |
|
13-Nov-2011 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: Implement truncation in tabs labels * To allow more devices to be shown and accessible within DiskUsage, truncate the columns names if necessary. Might help but not quite fix #6800.
|
#
973f8e21 |
|
14-Feb-2011 |
Siarzhuk Zharski <zharik@gmx.li> |
Applied yet another localization patch from Jorma Karvonen. Fixes #7169. Beside of localization task some refactoring was performed: - strings, stored previously in resources were moved from resource definition file to cpp files at the place of using; - cleanup of resource definitions and Common.cpp/Common.h. Additionall tasks, made by S.Zharski: - the rests of resource handling tasks were purged out from Common.cpp/Common.h; - Common.h renamed to DiskUsage.h; - the rests of code from Common.cpp merged into DiskUsage.cpp; - the preprocessor tricks and magics targeted mainly for resources support were removed; - some code style fixes and "internationalization style" fixes were made. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40493 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
dde4ac43 |
|
12-Oct-2010 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage enhancement (ticket #3520) * the volume are now displayed in tabs, mounting and unmounting volume adds and remove tabs accordingly * the infos (file size, etc..) are now displayed below the graph * node monitoring tells you when your current view is outdated. (the ticket suggested to adjust the view automatically, but I'll wait for comments on this first). * Drag&Dropping a file on the graph changes the tabview to the tab representing the volume owning that file. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38958 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
6020035b |
|
01-Jul-2010 |
Wim van der Meer <wpjvandermeer@gmail.com> |
Fixes a ''virtual status_t BMenuItem::Invoke(BMessage*)' was hidden' warning. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37332 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
15676f3a |
|
01-Jul-2010 |
Wim van der Meer <wpjvandermeer@gmail.com> |
Code style cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37331 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
fc60ab16 |
|
08-Sep-2008 |
Rene Gollent <anevilyak@gmail.com> |
gcc4 build fixes. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27381 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
032d13f4 |
|
08-Sep-2008 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
(gcc4) local variable shadows a parameter git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27379 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
f75a7bf5 |
|
07-Sep-2008 |
Stephan Aßmus <superstippi@gmx.de> |
Imported the nice disk usage tool "Guido" into the repo as "DiskUsage". Guido was originally written by Mike Steed. The code was freely available from his website at one point, which I am no longer able to find. I believe the license was a kind of public domain, at least compatible with our MIT/X11 license. The original code was well written with it's own coding style which was not very far from the Haiku coding style. I have hopefully adopted it completely to our coding style. While I did this, I came across several places with comments for a minor bug which I was able to resolve all. I also found ways to simplify certain places and I elliminated all non-necessary "inter-class knowledge" which was used to directly access members of other classes which should have been private. All in all, this should be a nice little addition, a useful tool which I found handy a lot of times. If I should not have added this without first consulting everyone, please voice your disagreement, and it can be removed it again. It is not part of the image yet. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27357 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
93e5d9fa15488a96d30252b17d279c286b915209 |
|
13-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Fix CID 1288122 In hrev48870 I made some updates to DiskUsage which accidentally caused this CID. Both the volume and item pointers were going out of scope without being deleted in the error case leading to a resource leak. This commit seeks to fix the problem by creating these objects as late as possible after the error checking. tempVolume, which, as it's name implies, is created temporarily on the stack is used instead of volume up until the point that AddTab() requires a more permanent heap-stored volume pointer. Same goes for the VolumeView and VolumeTab. name is created temporarily on the stack as well which works because it is copied when passed into VolumeView constructor by the grandparent BHandler before going out of scope.
|
#
fa05f35a2c184d96f3f11620835c2c699d1f1996 |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Skip virtual volumes so we don't see the 4.00Kib system and config tab.
|
#
57ee63a5e529b2fedf619c537a9f79e42a95a58b |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: TabView flush to window border http://postimg.org/image/izae7h1qd/
|
#
1b53ff078423242c6850035bfb7e867c0beaacbd |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Use an int32 instead of an int for CountTabs() which returns an int32
|
#
58f4a50b3330cb64eb0490a12edd9c4044ec272f |
|
06-Mar-2015 |
John Scipione <jscipione@gmail.com> |
DiskUsage: Style fixes
|
#
5da82e3a101ea3142f037c90967521639fddfafd |
|
03-Dec-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
DiskUsage: align tab focus mark with label. Fixes #6905.
|
#
da1f251a8f0772b0e5055cf8f64043a5fad15704 |
|
13-Jul-2013 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: drawing artefact in TabView
|
#
46db18d19961c418116e83cca2edc8c59ad40f3f |
|
17-Nov-2012 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: Truncating of tabs could lead to deadlock (#9170)
|
#
3e52a3d5e5479a4de086a481f3363765149fbd4e |
|
14-Nov-2012 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: added ability to cancel an ongoing scan. fixes #6801. Also, progress now goes from 0.0 to 1.0 rather than from 0.00 to 100.00 (to avoid a * 100, followed by a / 100)
|
#
a9e957e2def659b46fc26567b68a932cc2db5dcf |
|
13-Nov-2011 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage: Implement truncation in tabs labels * To allow more devices to be shown and accessible within DiskUsage, truncate the columns names if necessary. Might help but not quite fix #6800.
|
#
973f8e214d612688c4a30fd48572a7eb57c902be |
|
14-Feb-2011 |
Siarzhuk Zharski <zharik@gmx.li> |
Applied yet another localization patch from Jorma Karvonen. Fixes #7169. Beside of localization task some refactoring was performed: - strings, stored previously in resources were moved from resource definition file to cpp files at the place of using; - cleanup of resource definitions and Common.cpp/Common.h. Additionall tasks, made by S.Zharski: - the rests of resource handling tasks were purged out from Common.cpp/Common.h; - Common.h renamed to DiskUsage.h; - the rests of code from Common.cpp merged into DiskUsage.cpp; - the preprocessor tricks and magics targeted mainly for resources support were removed; - some code style fixes and "internationalization style" fixes were made. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40493 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
dde4ac438661765184581a6aeb2cd098d6b1a06f |
|
12-Oct-2010 |
Philippe Saint-Pierre <stpere@gmail.com> |
DiskUsage enhancement (ticket #3520) * the volume are now displayed in tabs, mounting and unmounting volume adds and remove tabs accordingly * the infos (file size, etc..) are now displayed below the graph * node monitoring tells you when your current view is outdated. (the ticket suggested to adjust the view automatically, but I'll wait for comments on this first). * Drag&Dropping a file on the graph changes the tabview to the tab representing the volume owning that file. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38958 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
6020035bb0dca3f355fe273e225d61c475c5446d |
|
01-Jul-2010 |
Wim van der Meer <wpjvandermeer@gmail.com> |
Fixes a ''virtual status_t BMenuItem::Invoke(BMessage*)' was hidden' warning. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37332 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
15676f3a876aa89db228c24032b7d6ee970253d6 |
|
01-Jul-2010 |
Wim van der Meer <wpjvandermeer@gmail.com> |
Code style cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37331 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
fc60ab16f5c51c3393ebb1d4095bac89931dbbe0 |
|
08-Sep-2008 |
Rene Gollent <anevilyak@gmail.com> |
gcc4 build fixes. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27381 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
032d13f49aad374db266392c9cdf7204be44621b |
|
08-Sep-2008 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
(gcc4) local variable shadows a parameter git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27379 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
f75a7bf508f3156d63a14f8fd77c5e0ca4d08c42 |
|
07-Sep-2008 |
Stephan Aßmus <superstippi@gmx.de> |
Imported the nice disk usage tool "Guido" into the repo as "DiskUsage". Guido was originally written by Mike Steed. The code was freely available from his website at one point, which I am no longer able to find. I believe the license was a kind of public domain, at least compatible with our MIT/X11 license. The original code was well written with it's own coding style which was not very far from the Haiku coding style. I have hopefully adopted it completely to our coding style. While I did this, I came across several places with comments for a minor bug which I was able to resolve all. I also found ways to simplify certain places and I elliminated all non-necessary "inter-class knowledge" which was used to directly access members of other classes which should have been private. All in all, this should be a nice little addition, a useful tool which I found handy a lot of times. If I should not have added this without first consulting everyone, please voice your disagreement, and it can be removed it again. It is not part of the image yet. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27357 a95241bf-73f2-0310-859d-f6bbb57e9c96
|