diskprobe: Add striped look and vertical line separators

* vertical lines per 4 bytes displayed
* striped line colors

Change-Id: I08508f15a60c5ceab8e3088faca9c03576c129e0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4563
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

DiskProbe: allow full and half fixed fonts.

DiskProbe DataView Color

Previously the DataView relied on the default colors, which layout now
overrides more uniformly. The document colors are more appropriate.

After the addition of the layout changes, the DataView would adopt
system panel colors.

Fixes #12572.

Signed-off-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>

DiskProbe: improved initial window size.

* Also some automatic whitespace cleanup.

DiskProbe: don't set a maximal size for the data view

We want the view to expand and fill the horizontal space as much as
possible.

DiskProbe: rewrite to use layout code.

The main goal is to use a layout aware tab view in the attribute editor
window, removing some hacks that caused #10480.

Diskprobe: some 64 bit fixes

* also warnings about comparisons between signed and non signed.

DiskProbe :
* Fix a gcc4 warning in the boolean operation



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34203 a95241bf-73f2-0310-859d-f6bbb57e9c96

DiskProbe :
In is_valid_utf8():
* Also accept CR and TAB as valid chars to be copied in clipboard.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34193 a95241bf-73f2-0310-859d-f6bbb57e9c96

Diskprobe :
in is_valid_utf8() :
* Accept EOL/LF as part of a valid UTF8 string.
* This allow a string containing it to be copied to the clipboard.
* Fixing ticket #1453.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34192 a95241bf-73f2-0310-859d-f6bbb57e9c96

DiskProbe:
* The is_valid_utf8(..) is supposed to accept a terminating null byte
but was instead looking for a null byte as the first byte.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34191 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed gcc 4 warnings.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31297 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed src/kits/tracker/OpenHashTable.h. The shared version in
headers/private/shared is newer, though with small interface changes.
* Removed the unnecessary Debug.h include in
headers/private/shared/ObjectList.h.
* Adjusted sources using these headers, mostly by adding missing includes.
* Lots of automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30123 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Resolved a TODO and implemented an is_valid_utf8() function that replaces the
former is_valid_ascii(). This function is now also exported in the header.
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28975 a95241bf-73f2-0310-859d-f6bbb57e9c96

* If only a part of the data could be read, the part that couldn't been read
is now cleared - this changes the behaviour of bug #603, but doesn't fix
it (as this is no DiskProbe bug).
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17621 a95241bf-73f2-0310-859d-f6bbb57e9c96

Build fixes for the R5/Dano target, no longer relies on the COMPILE_FOR_R5 macro.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16887 a95241bf-73f2-0310-859d-f6bbb57e9c96

Reverted last change, as BFont::IsFixed() does now work properly, thanks to Stefano.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13295 a95241bf-73f2-0310-859d-f6bbb57e9c96

BFont::IsFixed() doesn't seem to work correctly under the app_server yet
(though the implementation *looks* correct), so I've disabled this check
for now.
This let it draw the data correctly, although the line selection has
artifacts that are not present under R5.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13290 a95241bf-73f2-0310-859d-f6bbb57e9c96

The DataView can now also accept drop messages from others and itself; the
mouse is tracked when you're dragging over the view, and the affected area
is selected.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10470 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started implementing drag&drop - for now, you can drag contents out of the
DiskProbe window only. Only ASCII clippings will contain "text/plain" data,
so don't be surprised if Tracker sometimes doesn't create a clipping file
(if you drop on Tracker).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10465 a95241bf-73f2-0310-859d-f6bbb57e9c96

The block selection is now drawn incrementally if possible which removes flicker.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10380 a95241bf-73f2-0310-859d-f6bbb57e9c96

Selection changes via keyboard no longer copy DiskProbe's original behaviour,
but can be done like in BTextView.
Fixed a strange drawing bug that could happen on startup (R5): IsFocus()
could return false, even if the view had focus.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7646 a95241bf-73f2-0310-859d-f6bbb57e9c96

addr_t is now defined in public headers.
Fixed missing initialization from fBitPosition which could result in strange
input in the hex mode (only at first try).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7618 a95241bf-73f2-0310-859d-f6bbb57e9c96

Didn't send notices about a new preferred size when the block size was changed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6946 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now listens to file/attribute changes.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6825 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a message to change the selection.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6788 a95241bf-73f2-0310-859d-f6bbb57e9c96

No longer displays the selection when the file size is 0.
Also fixed a possibly wrong cursor position in that case.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6782 a95241bf-73f2-0310-859d-f6bbb57e9c96

ProbeView accidently didn't listen to kDataViewPreferredSize events.
Implemented the "Fit" font size setting.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6773 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented changing the block size - that caused several changes to
DataEditor::SetViewSize()/SetViewOffset() because they did not correctly
update some values under certain circumstances.
There is now a kMsgDataEditorParameterChange instead of just ...OffsetChange;
the message will contain information about what has changed exactly.
Added a new kDataViewPreferredSize notifier that indicates a change of
the preferred size of the DataView. The ProbeView now listens to that
instead of knowing when to update the window limits.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6772 a95241bf-73f2-0310-859d-f6bbb57e9c96

Connected the font size menu. "Fit" doesn't work yet, though.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now also send a selection update notice if the contents have changed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6745 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the B_COPY code into a separate function. Implemented B_PASTE.
Now also changes the selection to the cursor position in the hex editor when
you change the first part of the byte.
No need to hold the editor lock for Replace().


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6743 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a method to access DataView's internal buffer.
Implemented editing functionality for both focus types.
Optimized InvalidateRange() if the update spans over the whole view.
Now resets the cursor position/selection when the editor offset changed.
UpdateFromEditor() now takes the range of the size into account.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6739 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now has Undo/Redo support.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6734 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented R5 compatible settings.
The number base type (hex or decimal) and the window frame is already
correctly maintained (font size is only displayed, but not yet changed).
I don't know the meaning of the last 4 bytes in DiskProbe_data, but
it's probably not that bad.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6714 a95241bf-73f2-0310-859d-f6bbb57e9c96

Ignored the file size - it would have shown imaginary contents of a file
in its last block.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6710 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a selection observer notice (in addition to cursor position).
Now listens to B_SELECT_ALL, and B_COPY.
B_COPY copies the selection as "application/octect-stream" and, if
it's a valid ASCII string, also as "text/plain".


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6706 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now has one central DataBounds() method that's used by GetPreferredSize()
and others.
MouseMoved() no longer passes an invalid position to SetSelection() (avoiding
the selection to be changed unexpectedly). It will now also make sure that the
position hovered by the mouse is visible.
PositionAt() no longer skips points that are not inside the valid bounds (even
the wrong bounds), but clips the point to be inside of it.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6636 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented proper focus handling in DataView instead of forcing focus
whenever the window got activated.
New DataView::MakeVisible() makes sure the specified position is visible
in the view, and scrolls to it if not (both, horizontally and vertically).
Implemented cursor navigation and selection extension in the DataView class.
Fixed a bug in DataView::SetSelection() that could let slip through invalid
values.
Renamed DataEditor observer notices.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6634 a95241bf-73f2-0310-859d-f6bbb57e9c96

The cursor position is now correctly maintained in the HeaderView as well.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6631 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added support for different number bases in the offset column.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6622 a95241bf-73f2-0310-859d-f6bbb57e9c96

The scroll bars now work correctly.
Mouse wheel support added.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6572 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented the selection code.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6571 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the ConvertLine() method to produce almost exactly the same
output as the original DiskProbe.
fFontSize and fAscent are now automatically maintained when the font
size is changed. Rendering improved (spacing and location).
The maximum window size is now set to contain the whole data view.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6569 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started to implement the DataView class that will be the view to the editor.
For your entertaining it already shows the first block of the file/device.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6567 a95241bf-73f2-0310-859d-f6bbb57e9c96

DiskProbe: improved initial window size.

* Also some automatic whitespace cleanup.

DiskProbe: don't set a maximal size for the data view

We want the view to expand and fill the horizontal space as much as
possible.

DiskProbe: rewrite to use layout code.

The main goal is to use a layout aware tab view in the attribute editor
window, removing some hacks that caused #10480.

Diskprobe: some 64 bit fixes

* also warnings about comparisons between signed and non signed.

DiskProbe :
* Fix a gcc4 warning in the boolean operation



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34203 a95241bf-73f2-0310-859d-f6bbb57e9c96

DiskProbe :
In is_valid_utf8():
* Also accept CR and TAB as valid chars to be copied in clipboard.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34193 a95241bf-73f2-0310-859d-f6bbb57e9c96

Diskprobe :
in is_valid_utf8() :
* Accept EOL/LF as part of a valid UTF8 string.
* This allow a string containing it to be copied to the clipboard.
* Fixing ticket #1453.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34192 a95241bf-73f2-0310-859d-f6bbb57e9c96

DiskProbe:
* The is_valid_utf8(..) is supposed to accept a terminating null byte
but was instead looking for a null byte as the first byte.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34191 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed gcc 4 warnings.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31297 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed src/kits/tracker/OpenHashTable.h. The shared version in
headers/private/shared is newer, though with small interface changes.
* Removed the unnecessary Debug.h include in
headers/private/shared/ObjectList.h.
* Adjusted sources using these headers, mostly by adding missing includes.
* Lots of automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30123 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Resolved a TODO and implemented an is_valid_utf8() function that replaces the
former is_valid_ascii(). This function is now also exported in the header.
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28975 a95241bf-73f2-0310-859d-f6bbb57e9c96

* If only a part of the data could be read, the part that couldn't been read
is now cleared - this changes the behaviour of bug #603, but doesn't fix
it (as this is no DiskProbe bug).
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17621 a95241bf-73f2-0310-859d-f6bbb57e9c96

Build fixes for the R5/Dano target, no longer relies on the COMPILE_FOR_R5 macro.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16887 a95241bf-73f2-0310-859d-f6bbb57e9c96

Reverted last change, as BFont::IsFixed() does now work properly, thanks to Stefano.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13295 a95241bf-73f2-0310-859d-f6bbb57e9c96

BFont::IsFixed() doesn't seem to work correctly under the app_server yet
(though the implementation *looks* correct), so I've disabled this check
for now.
This let it draw the data correctly, although the line selection has
artifacts that are not present under R5.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13290 a95241bf-73f2-0310-859d-f6bbb57e9c96

The DataView can now also accept drop messages from others and itself; the
mouse is tracked when you're dragging over the view, and the affected area
is selected.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10470 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started implementing drag&drop - for now, you can drag contents out of the
DiskProbe window only. Only ASCII clippings will contain "text/plain" data,
so don't be surprised if Tracker sometimes doesn't create a clipping file
(if you drop on Tracker).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10465 a95241bf-73f2-0310-859d-f6bbb57e9c96

The block selection is now drawn incrementally if possible which removes flicker.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10380 a95241bf-73f2-0310-859d-f6bbb57e9c96

Selection changes via keyboard no longer copy DiskProbe's original behaviour,
but can be done like in BTextView.
Fixed a strange drawing bug that could happen on startup (R5): IsFocus()
could return false, even if the view had focus.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7646 a95241bf-73f2-0310-859d-f6bbb57e9c96

addr_t is now defined in public headers.
Fixed missing initialization from fBitPosition which could result in strange
input in the hex mode (only at first try).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7618 a95241bf-73f2-0310-859d-f6bbb57e9c96

Didn't send notices about a new preferred size when the block size was changed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6946 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now listens to file/attribute changes.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6825 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a message to change the selection.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6788 a95241bf-73f2-0310-859d-f6bbb57e9c96

No longer displays the selection when the file size is 0.
Also fixed a possibly wrong cursor position in that case.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6782 a95241bf-73f2-0310-859d-f6bbb57e9c96

ProbeView accidently didn't listen to kDataViewPreferredSize events.
Implemented the "Fit" font size setting.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6773 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented changing the block size - that caused several changes to
DataEditor::SetViewSize()/SetViewOffset() because they did not correctly
update some values under certain circumstances.
There is now a kMsgDataEditorParameterChange instead of just ...OffsetChange;
the message will contain information about what has changed exactly.
Added a new kDataViewPreferredSize notifier that indicates a change of
the preferred size of the DataView. The ProbeView now listens to that
instead of knowing when to update the window limits.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6772 a95241bf-73f2-0310-859d-f6bbb57e9c96

Connected the font size menu. "Fit" doesn't work yet, though.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now also send a selection update notice if the contents have changed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6745 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the B_COPY code into a separate function. Implemented B_PASTE.
Now also changes the selection to the cursor position in the hex editor when
you change the first part of the byte.
No need to hold the editor lock for Replace().


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6743 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a method to access DataView's internal buffer.
Implemented editing functionality for both focus types.
Optimized InvalidateRange() if the update spans over the whole view.
Now resets the cursor position/selection when the editor offset changed.
UpdateFromEditor() now takes the range of the size into account.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6739 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now has Undo/Redo support.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6734 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented R5 compatible settings.
The number base type (hex or decimal) and the window frame is already
correctly maintained (font size is only displayed, but not yet changed).
I don't know the meaning of the last 4 bytes in DiskProbe_data, but
it's probably not that bad.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6714 a95241bf-73f2-0310-859d-f6bbb57e9c96

Ignored the file size - it would have shown imaginary contents of a file
in its last block.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6710 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a selection observer notice (in addition to cursor position).
Now listens to B_SELECT_ALL, and B_COPY.
B_COPY copies the selection as "application/octect-stream" and, if
it's a valid ASCII string, also as "text/plain".


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6706 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now has one central DataBounds() method that's used by GetPreferredSize()
and others.
MouseMoved() no longer passes an invalid position to SetSelection() (avoiding
the selection to be changed unexpectedly). It will now also make sure that the
position hovered by the mouse is visible.
PositionAt() no longer skips points that are not inside the valid bounds (even
the wrong bounds), but clips the point to be inside of it.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6636 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented proper focus handling in DataView instead of forcing focus
whenever the window got activated.
New DataView::MakeVisible() makes sure the specified position is visible
in the view, and scrolls to it if not (both, horizontally and vertically).
Implemented cursor navigation and selection extension in the DataView class.
Fixed a bug in DataView::SetSelection() that could let slip through invalid
values.
Renamed DataEditor observer notices.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6634 a95241bf-73f2-0310-859d-f6bbb57e9c96

The cursor position is now correctly maintained in the HeaderView as well.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6631 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added support for different number bases in the offset column.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6622 a95241bf-73f2-0310-859d-f6bbb57e9c96

The scroll bars now work correctly.
Mouse wheel support added.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6572 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented the selection code.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6571 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the ConvertLine() method to produce almost exactly the same
output as the original DiskProbe.
fFontSize and fAscent are now automatically maintained when the font
size is changed. Rendering improved (spacing and location).
The maximum window size is now set to contain the whole data view.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6569 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started to implement the DataView class that will be the view to the editor.
For your entertaining it already shows the first block of the file/device.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6567 a95241bf-73f2-0310-859d-f6bbb57e9c96