#
7c095f47 |
|
01-Jun-2020 |
John Scipione <jscipione@gmail.com> |
BeControlLook: Fix app integration drawing issues Update BTab::DrawTab() to pass the current index, the index of the selected tab, and the index of the first and last tabs into BControlLook::DrawActiveTab() and BControlLook::DrawInactiveTab(). This allows you to draw tabs differently in your BTab or BControlLook subclass in many different circumstances. Modify BControlLook API to add indexes to DrawActiveTab() and DrawInactiveTab() like so: void DrawActiveTab(..., int32 index = 0, int32 selected = -1, int32 first = 0, int32 last = 0); void DrawInactiveTab(..., int32 index = 0, int32 selected = -1, int32 first = 0, int32 last = 0); These extra indexes are not used by HaikuControlLook which relies only on if the tab is active or inactive to draw. Add IndexOf(BTab* tab) method to BTabView and document it to get the index of the current tab in BTab::DrawTab(). Also add a warning in the BTabView::DrawTab() method not to use the position and full parameters anymore, use BTabView::IndexOf(), BTabView::Selection(), and BTabView::TabCount() to get the info you need. Using a dynamic_cast to a BTabView in BeControlLook to determine if the view is derived from a BTabView didn't work in the case of WebPositive. Furthermore, WebPositive does custom tab drawing which needed to be updated for alternative control look. These index parameters passed from BTab to BeControlLook allow us to draw the tab like BeOS without relying on a dynamic_cast to BTabView to get the info. Reproduce the functionality described above for BTab in WebPositive's custom tabs. Eliminate no longer needed code in favor of using indexes. Update WebPositive custom tabs to use BControlLook::DrawTabFrame() instead of BControlLook::DrawInactiveTab() matching the update made in BTabView. In BeControlLook::DrawTabFrame() fill rect with base color, WebPositive doesn't draw any tab background, so it expects this work to be done for it. Eliminate hasFrames variable from WebPositive. Rename TabSelected(index) to UpdateSelection(index) in WebPositive to better reflect its purpose. Adjusted HaikuControlLook::DrawInactiveTab() to draw the tab borders more selectively. Only draw border if left border is set for top and bottom tabs or top border is set for left and right tabs. Undo no longer needed frame manipulation border drawing workaround in HaikuControlLook::DrawTabFrame(). Draw scroll bar triangle without using DrawArrowShape(). Unlike in HaikuControlLook, DrawArrowShape() is used to draw arrows in BOutlineListView and menus distinctly from how it draws arrows in scroll bars. Draw our distinct arrows in DrawSrollBarButtons() instead. This fixes overflow of time edit up-down arrows in Clock prefs and the collapse-expand arrow in Deskbar not being vertically centered. In DrawBorders() only inset if we actually draw the border. Fix alignment issues with DrawSliderThumb dots for example in MediaPlayer volume knobs. Draw using line arrays calling AddLine instead of StrokeLine in several places. DrawMenuBar() extends to draw final pixel which eliminates an extra lines at the end of menu bars. Truncate button labels better fixing a few issues for example keymap keyboard layout button labels. Button insets has been updated a bit to fix drawing issues with buttons missing a border. Using a dynamic_cast to a BButton to determine if a view is a button in BeControlLook didn't work in the case of the keymap label. Look for B_FLAT, B_HOVER, or B_DEFAULT_BUTTON flag in BeControlLook::DrawLabel() to draw the label inverted on click. Pass the B_FLAT flag from Keymap keys when drawing using BControlLook so that the label is inverted. Change-Id: I07631f4b006bdb9aeca2adc9cbdf2da54dae8e92 Reviewed-on: https://review.haiku-os.org/c/haiku/+/2866 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
|
#
2502d45a |
|
22-Jan-2019 |
Augustin Cavalier <waddlesplash@gmail.com> |
BTabView: Change layout constructor to default to B_WIDTH_FROM_WIDEST. This seems to fit the "spirit of layout" better. Change-Id: I7a75b58de4c9f703d828cdd292b7b91ee720c135 Reviewed-on: https://review.haiku-os.org/c/891 Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
cb13fce8 |
|
19-Aug-2017 |
Kacper Kasper <kacperkasper@gmail.com> |
BTabView: implement drawing tabs on all sides. Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
|
#
3490eda8 |
|
29-Apr-2016 |
John Scipione <jscipione@gmail.com> |
ControlLook: Rename border param to borderStyle border vs. borders is confusing. BTabView: Rename border param to borderStyle BTabView docs: rename border param to borderStyle enumerate border styles in docs
|
#
6fd25536 |
|
14-Jul-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
TabView: Lots of style fixes.
|
#
c432a83b |
|
14-Jul-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
TabView: Add TabViewPrivate class, actually fix non-layout SetView. Thanks to Axel and Stephan for reviewing!
|
#
6031dea0 |
|
13-Jul-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
BTabView: Lots of fixes & cleanup. * Address TODO about setting fSelected when nothing is done. * Pass a pointer to the tab view to the BTab so that it can call Invalidate(). (Checked against BeOS). * Call Invalidate() from the BTab after SetView() & SetName(). Fixes #12108 & #12196.
|
#
b825666f |
|
19-Dec-2014 |
John Scipione <jscipione@gmail.com> |
Rename method parameter in header to match implementation
|
#
65dfd2c6 |
|
19-Dec-2014 |
John Scipione <jscipione@gmail.com> |
Documentation fixes for BTab and BTabView
|
#
5f844af7 |
|
28-Jul-2010 |
Alex Wilson <yourpalal2@gmail.com> |
Update BTabView for layout-friendly archiving. Added _InitContainerView() method that is called from _InitObject() but also called on its own during unarchival. Implemented BTabView::AllUnarchived() and implemented a case for this in BTabView::Perform(). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37796 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
b2e1893c |
|
21-Feb-2010 |
Stephan Aßmus <superstippi@gmx.de> |
Added SetBorder() virtual method and feature. Could also be used by the Terminal now to polish the tabbed look. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35569 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
89208c77 |
|
27-Aug-2009 |
Stephan Aßmus <superstippi@gmx.de> |
Finished unifying the Interface Kit headers: * Fixed copyrights (puncuation and capitalization, removed authors from headers) * Updated indentation style * Unified pointer/reference style * Re-ordered some methods for better grouping where it could be done (abd adopted source accordingly) * Small coding style fixes here and there No functional change intended. +alphabranch git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32745 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
b3601d82 |
|
21-Jun-2009 |
Stephan Aßmus <superstippi@gmx.de> |
* Update indentation style in TabView.h * Added _MinTabeSize() to BTabView. It makes sure that the BTabView displays at least two tabs. In the future it should also add the room to display some buttons for cycling the currently displayed tabs left/right if there is more than can fit. * In BTabView::Min/Max/PreferredSize(), use _MinTabSize() to compute the respective size. * Improve Tab rendering code so there are no ugly overlaps at the right edge if the tabs falls directly on the view edge. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31157 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
24a0a80b |
|
20-Nov-2008 |
Stephan Aßmus <superstippi@gmx.de> |
Properly integrate the BTabView into a layout tree. Ie, the content will now resize with the tab view. There is probably a more elegant way overriding DoLayout(), but this should do for the time being. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28706 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
e401039e |
|
20-Nov-2008 |
Stephan Aßmus <superstippi@gmx.de> |
Patch by Artur Wyszynski: * The BTabView can now be used with layout management. In this setup, children views are managed by a BCardLayout and are hidden/shown instead of removed/ added when (de)activated. Thanks a lot! git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28701 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
f6e4cbb9 |
|
15-Oct-2007 |
Axel Dörfler <axeld@pinc-software.de> |
* Rewrote BeBuild.h which had "a few" consequences (got rid of all those class definitions). * Minor cleanup here and there. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22577 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
e96b2023 |
|
27-Sep-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Patch from Ioan Molnar: If a Tab is partially out of the window, clicking on it to make it the active tab will scroll it to be completely visible. The best solution would probably be having a way to scroll through the whole list of tabs, or something like this. But for now, at least, makes the tabbed terminal a bit more useful. Thanks! git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22325 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
6d523548 |
|
27-Sep-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Fixed endlines git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22324 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
4eb5e0d5 |
|
26-Sep-2002 |
Marc Flerackers <mflerackers@nowhere.fake> |
Initial Checkin git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1195 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
6fd2553690c71824d7a6d80e2c6228c804eda3e8 |
|
14-Jul-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
TabView: Lots of style fixes.
|
#
c432a83bf3855f2a291d97b269bdcdee606149f5 |
|
14-Jul-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
TabView: Add TabViewPrivate class, actually fix non-layout SetView. Thanks to Axel and Stephan for reviewing!
|
#
6031dea0cb44f6a3e512f35ded22dfb02b0ae753 |
|
13-Jul-2015 |
Augustin Cavalier <waddlesplash@gmail.com> |
BTabView: Lots of fixes & cleanup. * Address TODO about setting fSelected when nothing is done. * Pass a pointer to the tab view to the BTab so that it can call Invalidate(). (Checked against BeOS). * Call Invalidate() from the BTab after SetView() & SetName(). Fixes #12108 & #12196.
|
#
b825666f3f37b12e687b05f3139f42ce5dcd9638 |
|
19-Dec-2014 |
John Scipione <jscipione@gmail.com> |
Rename method parameter in header to match implementation
|
#
65dfd2c67cbfcb15b18fa84c5bf1cd81247a27d7 |
|
19-Dec-2014 |
John Scipione <jscipione@gmail.com> |
Documentation fixes for BTab and BTabView
|
#
5f844af738dc96d1577e606e7936e5ea311b6978 |
|
28-Jul-2010 |
Alex Wilson <yourpalal2@gmail.com> |
Update BTabView for layout-friendly archiving. Added _InitContainerView() method that is called from _InitObject() but also called on its own during unarchival. Implemented BTabView::AllUnarchived() and implemented a case for this in BTabView::Perform(). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37796 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
b2e1893c6e497d765cb25c84b160a0fc561a7c68 |
|
21-Feb-2010 |
Stephan Aßmus <superstippi@gmx.de> |
Added SetBorder() virtual method and feature. Could also be used by the Terminal now to polish the tabbed look. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35569 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
89208c77f10235d43fda0c7b3fd6751db02cc12c |
|
27-Aug-2009 |
Stephan Aßmus <superstippi@gmx.de> |
Finished unifying the Interface Kit headers: * Fixed copyrights (puncuation and capitalization, removed authors from headers) * Updated indentation style * Unified pointer/reference style * Re-ordered some methods for better grouping where it could be done (abd adopted source accordingly) * Small coding style fixes here and there No functional change intended. +alphabranch git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32745 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
b3601d823ca218ee6b0fed890c66568a034cdd3a |
|
21-Jun-2009 |
Stephan Aßmus <superstippi@gmx.de> |
* Update indentation style in TabView.h * Added _MinTabeSize() to BTabView. It makes sure that the BTabView displays at least two tabs. In the future it should also add the room to display some buttons for cycling the currently displayed tabs left/right if there is more than can fit. * In BTabView::Min/Max/PreferredSize(), use _MinTabSize() to compute the respective size. * Improve Tab rendering code so there are no ugly overlaps at the right edge if the tabs falls directly on the view edge. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31157 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
24a0a80b056c98004faac3db38ab8e404d0da60c |
|
20-Nov-2008 |
Stephan Aßmus <superstippi@gmx.de> |
Properly integrate the BTabView into a layout tree. Ie, the content will now resize with the tab view. There is probably a more elegant way overriding DoLayout(), but this should do for the time being. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28706 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
e401039efad6e333f53abd1c523a384bdcd15ff9 |
|
20-Nov-2008 |
Stephan Aßmus <superstippi@gmx.de> |
Patch by Artur Wyszynski: * The BTabView can now be used with layout management. In this setup, children views are managed by a BCardLayout and are hidden/shown instead of removed/ added when (de)activated. Thanks a lot! git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28701 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
f6e4cbb95290a74b33d012600438b84742b0e572 |
|
15-Oct-2007 |
Axel Dörfler <axeld@pinc-software.de> |
* Rewrote BeBuild.h which had "a few" consequences (got rid of all those class definitions). * Minor cleanup here and there. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22577 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
e96b20231146d74d19186ae917c20a95277ec413 |
|
27-Sep-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Patch from Ioan Molnar: If a Tab is partially out of the window, clicking on it to make it the active tab will scroll it to be completely visible. The best solution would probably be having a way to scroll through the whole list of tabs, or something like this. But for now, at least, makes the tabbed terminal a bit more useful. Thanks! git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22325 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
6d523548f1ddd5c12462eeb482901e30cb374328 |
|
27-Sep-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Fixed endlines git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22324 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
4eb5e0d516d3902ab5eecdd4d05b143dcd38f735 |
|
26-Sep-2002 |
Marc Flerackers <mflerackers@nowhere.fake> |
Initial Checkin git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1195 a95241bf-73f2-0310-859d-f6bbb57e9c96
|