#
e10de1ec |
|
12-Jul-2018 |
Ryan Leavengood <leavengood@gmail.com> |
Visually align shortcuts in menus In a menu, we use the right side both for submenu arrows and shortcuts. As a result, when an entry has both a shortcut and a submenu, its shortcut is not aligned with others, and this does not look so nice. The spacing for the arrow appears only if there is a submenu in any of the items in the parent menu. Change-Id: If91fdcdad36abb0141fb05d1f59141f89540c1db Reviewed-on: https://review.haiku-os.org/c/haiku/+/355 Reviewed-by: Adrien Destugues <pulkomandy@gmail.com> Reviewed-by: Ryan Leavengood <leavengood@gmail.com>
|
#
5f603da0 |
|
17-Jul-2018 |
Adrien Destugues <pulkomandy@pulkomandy.tk> |
Better shape for submenu arrow Just use BControLook where appropriate. It already provides a nice arrow drawing function (also used in DeskBar expander and in scrollbar buttons). Fix second part of #8900 Changes by John Scipione: Update menu mark and submenu arrow color with menu text color Use text color for checkmark and submenu arrow colors, tint less black. This means that colored bg/white text menu item will also draw a white checkmark and submenu arrow. Break out BMenuItem::Draw functionality into private methods _IsActive, _LowColor() and _HighColor() methods and use them to set the mark colors. Scale submenu arrow and checkmark with item height (which scales with font size.) does not align shortcuts with submenu arrows... but if you were to do that you'd add item->Bounds().Height() / 2. Signed-off-by: John Scipione <jscipione@gmail.com> Change-Id: I8299094ef88bf227510b116eb1b84c261dc94723 Reviewed-on: https://review.haiku-os.org/c/341 Reviewed-by: Stefano Ceccherini <stefano.ceccherini@gmail.com> Reviewed-by: Axel Dörfler <axeld@pinc-software.de> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|
#
81364c9d |
|
18-Apr-2016 |
John Scipione <jscipione@gmail.com> |
BColorMenuItem: add custom color menufield http://insightfactory.tumblr.com/image/142366356207 * Make the color box a rectangle with proportions of golden ratio. * Override GetContentSize() to make menu item area larger. * Label should never truncate since I make sure there is enough room. * Draw the label using BMenuItem parent class * Carefully adjust the spacing so that there is an attractive amount of padding between the checkmark and color box and the color box and label. Add _AddMenu method to BMenuField that adds BColorMenuItem as its base menu item. This shows the BColorMenuItem in the closed state. Create BPrivate::MenuItemPrivate Add a SetSubmenu() method to MenuItemPrivate that gives you the ability to add a submenu after creating the object. This method should be public Skip disabled items Color gets updated even if you select an item in a submenu
|
#
61dfdec4 |
|
19-Apr-2016 |
John Scipione <jscipione@gmail.com> |
BMenu and friends: style fixes BMenuBar: style fix: msg => message MenuPrivate: style fixes MenuItem: 80 char limit style fix MenuBar: tiny style fix Menu: tiny style fix, indentation Menu: Small refactor Implement _SetIgnoreHidden() in header Change on to ignoreHidden Change on in _SetStickyMode to sticky _BMCItem_: tiny whitespace style fix Menu: style fixes, rename msgr => messenger BMenu: style fix, pointer != NULL BMenu::Archive rename ret to status Also check pointer against NULL explicitly BMenuItem style fixes: rename abbreviation, pointer style
|
#
fa412b5f |
|
28-Feb-2014 |
John Scipione <jscipione@gmail.com> |
BMenuItem: Style fixes related to documentation.
|
#
6a03786c |
|
28-Jul-2012 |
Ryan Leavengood <leavengood@gmail.com> |
Draw menus using the user chosen colors.
|
#
89208c77 |
|
27-Aug-2009 |
Stephan Aßmus <superstippi@gmx.de> |
Finished unifying the Interface Kit headers: * Fixed copyrights (puncuation and capitalization, removed authors from headers) * Updated indentation style * Unified pointer/reference style * Re-ordered some methods for better grouping where it could be done (abd adopted source accordingly) * Small coding style fixes here and there No functional change intended. +alphabranch git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32745 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
083de48a |
|
30-Sep-2007 |
Axel Dörfler <axeld@pinc-software.de> |
* Rewrote the trigger selection mechanism: it now searches for uppercase characters first, and then falls back to take everything. fTrigger is now uint32 and works with all unicode characters; unlike in BeOS, the MenuTriggerTest application now works correctly in Haiku. * fTriggerIndex is now a character position, not a byte position of the label; this allows BMenuItem::DrawContent() to draw the trigger at the correct position, even if there are multi-byte UTF-8 characters. * The above fixed bug #1506; triggers are still not working, though. * Rewrote Menu.h header. * Renamed all private methods (that are not called by BWindow) to have the underscore prefix. * Removed unused methods. * Some minor cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22384 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
0f11085c |
|
04-Apr-2006 |
Axel Dörfler <axeld@pinc-software.de> |
* Rewrote MenuItem.h (we're no longer using Be's header). * Renamed private SetSysTrigger() to SetAutomaticTrigger(). * Added the '_' prefix to private methods that aren't called by anything outside BMenuItem (ie. no friend classes either). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17005 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
bd780d99 |
|
04-Apr-2006 |
Axel Dörfler <axeld@pinc-software.de> |
Implemented _DrawControlChar() - for some reason, though, they get still not drawn (glyph cache returns character 0 for them), even though FontInspector under Dano shows those arrows in the fonts used... need to check under R5 as well. This fixes the BMenuItem part of bug #158. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17003 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
306e9208 |
|
27-Mar-2006 |
Stephan Aßmus <superstippi@gmx.de> |
* small cleanup of Draw (less usage of ui_color() which currently takes a trip to the server!) * changed look of mark and submenu symbol to better fit the rest of the already changed controls * the actual background color is passed to DrawMarkSymbol() and DrawSubmenuSymbol() git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16896 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
860ec9a8 |
|
30-Dec-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Moved BSeparatorItem's interface to its own file. Everything still builds, amazing :P git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10550 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
30fd5147 |
|
14-May-2003 |
haydentech <haydentech@nowhere.fake> |
Minor header-related changes git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3246 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
d734a8ce |
|
23-Oct-2002 |
beveloper <beveloper@nowhere.fake> |
some header files to be R5 compatible git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1617 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
fa412b5fd9117bd00abac82d663b13b1d1063148 |
|
28-Feb-2014 |
John Scipione <jscipione@gmail.com> |
BMenuItem: Style fixes related to documentation.
|
#
6a03786cc9918b43c7695cc2349e77eb3193e922 |
|
28-Jul-2012 |
Ryan Leavengood <leavengood@gmail.com> |
Draw menus using the user chosen colors.
|
#
89208c77f10235d43fda0c7b3fd6751db02cc12c |
|
27-Aug-2009 |
Stephan Aßmus <superstippi@gmx.de> |
Finished unifying the Interface Kit headers: * Fixed copyrights (puncuation and capitalization, removed authors from headers) * Updated indentation style * Unified pointer/reference style * Re-ordered some methods for better grouping where it could be done (abd adopted source accordingly) * Small coding style fixes here and there No functional change intended. +alphabranch git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32745 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
083de48a4bf9a88273bc1aae47da41a97fed22d2 |
|
30-Sep-2007 |
Axel Dörfler <axeld@pinc-software.de> |
* Rewrote the trigger selection mechanism: it now searches for uppercase characters first, and then falls back to take everything. fTrigger is now uint32 and works with all unicode characters; unlike in BeOS, the MenuTriggerTest application now works correctly in Haiku. * fTriggerIndex is now a character position, not a byte position of the label; this allows BMenuItem::DrawContent() to draw the trigger at the correct position, even if there are multi-byte UTF-8 characters. * The above fixed bug #1506; triggers are still not working, though. * Rewrote Menu.h header. * Renamed all private methods (that are not called by BWindow) to have the underscore prefix. * Removed unused methods. * Some minor cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22384 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
0f11085c6cb253405a96edd783bd77f668c05c8c |
|
04-Apr-2006 |
Axel Dörfler <axeld@pinc-software.de> |
* Rewrote MenuItem.h (we're no longer using Be's header). * Renamed private SetSysTrigger() to SetAutomaticTrigger(). * Added the '_' prefix to private methods that aren't called by anything outside BMenuItem (ie. no friend classes either). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17005 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
bd780d99357b568d6b1cf48db58508f3ee1b6450 |
|
04-Apr-2006 |
Axel Dörfler <axeld@pinc-software.de> |
Implemented _DrawControlChar() - for some reason, though, they get still not drawn (glyph cache returns character 0 for them), even though FontInspector under Dano shows those arrows in the fonts used... need to check under R5 as well. This fixes the BMenuItem part of bug #158. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17003 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
306e92084c48f5c5dd79a4d16735f07ca2f6276e |
|
27-Mar-2006 |
Stephan Aßmus <superstippi@gmx.de> |
* small cleanup of Draw (less usage of ui_color() which currently takes a trip to the server!) * changed look of mark and submenu symbol to better fit the rest of the already changed controls * the actual background color is passed to DrawMarkSymbol() and DrawSubmenuSymbol() git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16896 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
860ec9a8ac507646f2bf741277fea8eb4e614f25 |
|
30-Dec-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Moved BSeparatorItem's interface to its own file. Everything still builds, amazing :P git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10550 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
30fd51473f390b92d40b3a3c83b25e2d4a042f08 |
|
14-May-2003 |
haydentech <haydentech@nowhere.fake> |
Minor header-related changes git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3246 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
d734a8ce5a83e48e17a2d0d6635090d48c5ad161 |
|
23-Oct-2002 |
beveloper <beveloper@nowhere.fake> |
some header files to be R5 compatible git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1617 a95241bf-73f2-0310-859d-f6bbb57e9c96
|