Copy stable/9 to releng/9.3 as part of the 9.3-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

MFC r228559:

In contrib/telnet/libtelnet/sra.c, use the correct number of bytes to
zero the password buffer.

Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06]

Add an API for alerting internal libc routines to the presence of
"unsafe" paths post-chroot, and use it in ftpd. [11:07]

Fix a buffer overflow in telnetd. [11:08]

Make pam_ssh ignore unpassphrased keys unless the "nullok" option is
specified. [11:09]

Add sanity checking of service names in pam_start. [11:10]

Approved by: so (cperciva)
Approved by: re (bz)
Security: FreeBSD-SA-11:06.bind
Security: FreeBSD-SA-11:07.chroot
Security: FreeBSD-SA-11:08.telnetd
Security: FreeBSD-SA-11:09.pam_ssh
Security: FreeBSD-SA-11:10.pam

Copy head to stable/9 as part of 9.0-RELEASE release cycle.

Approved by: re (implicit)

Rename all symbols in libmp(3) to mp_*, just like Solaris.

The function pow() in libmp(3) clashes with pow(3) in libm. We could
rename this single function, but we can just take the same approach as
the Solaris folks did, which is to prefix all function names with mp_.

libmp(3) isn't really popular nowadays. I suspect not a single
application in ports depends on it. There's still a chance, so I've
increased the SHLIB_MAJOR and __FreeBSD_version.

Reviewed by: deischen, rdivacky

Use __FBSDID vs. rcsid[]. Also protect sccs[] and copyright[] from GCC 3.3.

Unbreak Kerberos 5 authentication in telnet.
(Credential forwarding is still broken.)

PR: bin/45397

Background:
When libdes was replaced with OpenSSL's libcrypto, there were a few
interfaces that the former implemented but the latter did not. Because
some software in the base system still depended upon these interfaces,
we simply included them in our libcrypto (rnd_keys.c).

Now, finally get around to removing the dependencies on these
interfaces. There were basically two cases:

des_new_random_key -- This is just a wrapper for des_random_key, and
these calls were replaced.

des_init_random_number_generator et. al. -- A few functions were used
by the application to seed libdes's PRNG. These are not necessary
when using libcrypto, as OpenSSL internally seeds the PRNG from
/dev/random. These calls were simply removed.

Again, some of the Kerberos 4 files have been taken off the vendor
branch. I do not expect there to be future imports of KTH Kerberos 4.

Encrypted strings (after hex decoding) aren't null terminated, because
0 might simply be part of the ciphertext.

PR: bin/40266
Submitted by: andr@dgap.mipt.ru
MFC after: 3 days

Warnings fixes. Sort out some variable types.

Help fix warnings by marking an argument as unused.

Fix an external declaration that was causing telnetd to core dump.

MFC after: 1 week
PR: 37766

Update build after import of Heimdal Kerberos 2002/02/17.

help the alphas out with the WARNS=2 stuff.

Damn. The previous mega-commit was incomplete WRT ANSIfication. This
fixes that.

Very large style makeover.

1) ANSIfy.
2) Clean up ifdefs so that
a) ones that never/always apply are appropriately either
fully removed, or just the #if junk is removed.
b) change #if defined(FOO) for appropiate values of FOO.
(currently AUTHENTICATION and ENCRYPTION)
3) WARNS=2 fixing
4) GC other unused stuff

This code can now be unifdef(1)ed to make non-crypto telnet.

Fix world by trimming an extra comment terminator.

Add Berkeley copyright to SRA.

This is by the kind permission of Dave Safford, formerly of TAMU who wrote the
original code. Here is an excerpt of the e-mail exchange concerning this
issue:

Dave Safford wrote:
>Nick Sayer wrote:
>> Some time ago we spoke about SRA and importing it into FreeBSD. I forgot to
>> ask if you had a prefered license boilerplate for the top of the files. It
>> has come up recently, and the SRA code in FreeBSD doesn't have one.

>I really have no preference - use whatever is most convenient in the
>FreeBSD environment.

>dave safford

This is the standard BSD license with clause 3 removed and clause 4
suitably renumbered.

MFC after: 1 day

Add __FBSDID() to diff-reduce with "base" telnet.

Code merge and diff reduce with "base" telnet. This is the "later"
telnet, so it was treated as the reference code, except where later
commits were made to "base" telnet.

Make the PAM user-override actually override the correect thing.

Fix the latest telnet breakage. Obviously this was never compiled.

Make sure the protocol actively rejects bad data rather than
(potentially) not responding to an invalid SRA 'auth is' message.

srandomdev() affords us the opportunity to radically improve, and at the
same time simplify, the random number selection code.

Catch any attempted buffer overflows. The magic numbers in this code
(512) are a little distressing, but the method really needs to be
extended to allow server-supplied DH parameters anyway.

Submitted by: kris

Catch malloc return failures. This should help avoid dereferencing NULL on
low-memory situations.

Submitted by: kris

If the uid of the attempted authentication is 0 and if the pty is
insecure, do not succeed. Copied from login.c. This functionality really
should be a PAM module.

Pointy hat fix -- reapply the SRA PAM patch. To -current this time.

Fix core noted in -stable with 'auth disable SRA'.

I just mistakenly commited this to RELENG_4. I have contacted Jordan to see
about how to fix this. Pass the pointy hat.

Add missing $FreeBSD$ to files that are NOT still on vendor a branch.

Fix 'telnet -X sra' coredump

PR# 19835

Don't call printf with no format string.

Get crypto from libcrypto, not libdes.

According to Mark Murray, Makefiles do not belong here. I guess we're
going to have to figure something else out.

Add SRA authentication to src/crypto/telnet.

SRA does a Diffie-Hellmen exchange and then DES-encrypts the
authentication data. If the authentication is successful, it also
sets up a session key for DES encryption.

SRA was originally developed at Texas A&M University.

This code is probably export restricted (despite the fact that I
originally found it at a University in Germany).

SRA is not perfect. It is vulnerable to monkey-in-the-middle attacks
and does not use tremendously large DH constants (and thus an individual
exchange probably could be factored in a few days on modern CPU
horsepower). It does not, however, require any changes in user or
administrative behavior and foils session hijacking and sniffing.
The goal of this commit is that telnet and telnetd end up in the DES
distribution and that therefore an encrypted session telnet becomes
standard issue for FreeBSD.

Old stuff laying around: Don't use getstr which can conflict with some
curses/termcap/terminfo implementations and causes recursion.

Bring the FreeBSD changes to the virgin sources.

This commit was generated by cvs2svn to compensate for changes in r29088,
which included commits to RCS files with non-trunk default branches.