MFC r354664-r354666

r354664:
sesutil: fix an out-of-bounds array access

sesutil would allow the user to toggle an LED that was one past the maximum
element. If he tried, ENCIOC_GETELMSTAT would return EINVAL.

Reported by: Coverity
Coverity CID: 1398940
Sponsored by: Axcient

r354665:
sesutil: fix some memory leaks

Reported by: Coverity
Coverity CID: 1331665
Sponsored by: Axcient

r354666:
sesutil: fix another memory leak

Instead of calloc()ing (and forgetting to free) in a tight loop, just put
this small array on the stack.

Reported by: Coverity
Coverity CID: 1331665
Sponsored by: Axcient

MFC r343728: Check element type before setting LEDs.

With r319610, sesutil started twiddling the bits of every SES device.
Not everything is a disk slot, there are also fan controllers, temperature
sensors, even power supplies, among other things controlled by SES.

Add a type check to make sure we are only operating on device slot and array
device slot elements. Other type elements will be skipped, but it would be
simple to add additional cases for controlling the ident LEDs of other
element types (which are not necessarily the same bits).

Rather than doing raw bit manipulation of an unstructured byte array using
unnamed numeric constants, leverage existing code abstractions.

Submitted by: Ryan Moeller <ryan@freqlabs.com>
Sponsored by: iXsystems, Inc.

MFC r320267, r320270-r320271, r320478

r320267:
Do not use sprintf(3) when not needed, while here,
prefer snprintf(3) over sprintf(3)

r320270:
Directly print the extra status instead of filling a buffer
then printing it.

This prepares the code to make it libxo friendly

Reviewed by: manu, Nikita Kozlov (nikita elyzion.net)
Sponsored by: Gandi.net

r320271:
sesutil no longer depends on libsbuf

Sponsored by: Gandi.net

r320478:
Add libxo(3) support to sesutil(8)

This is useful to simplify parsing "sesutil map"

Submitted by: nikita.kozlov@blade-group.com
Relnotes: yes
Reviewed by: Allanjude, bapt
Differential revision: https://reviews.freebsd.org/D11372
Sponsored by: blade

MFC r319610:
usr.sbin/sesutil: correct 'locate all off' to deactivate empty slot LEDs

PR: 217409
Approved by: re (marius)

MFC r306528: Fix `sesutil fault` operation.

Fault and ident bits are located in different control bytes, so previous
code was just doing nothing, writing into reserved bit.

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Plug memory leak

Reported by: coverity
CID: 1331664, 1331665

Cleanup headers

Found by: include-what-you-use

DIRDEPS_BUILD: Update dependencies.

Sponsored by: EMC / Isilon Storage Division

Show the enclosure name and id in sesutil map

Sponsored by: Gandi.net

Fix sesutil locate when a sesid is passed to locate command

sesutil: Add extra information specific to some SES devices to sesutil map

Rework stat2ascii preparing a buffer of what could be printed. This prevent the
risk of overflowing a static buffer.

Do not print those informations anymore in the "status" but into a new
"extra status" only printed if there are actually extra things to print.

Now add those extra informations:

* Thermal sensor temperature
* Cooling devices speed
* Voltage sensors, current consumption

Tested by: AllanJude
Sponsored by: Gandi.net
Differential Revision: https://reviews.freebsd.org/D4520

sesutils, pass the correct element type when printing the status of a given
element of the ses.

Sponsored by: Gandi.net

sesutil: fix map not printing the status of the LED device in an array

Sponsored by: Gandi.net

Rename some functions and variables inside sesutil(8) to make gcc happy

Reported by: bz
Approved by: bapt (implicit)
Sponsored by: ScaleEngine Inc.

Connect sesutil(1) and numactl(1) for META_MODE.

Sponsored by: EMC / Isilon Storage Division

Improve and expand sesutil(8)

- Return an error if no matching device is found when the locate command is run
- Enhance the locate command to be able to address drive bays with no disk, or where the SES controller has not made the mapping to the device name
- Added the fault command, similar to locate, but a different SES property. On some of my controllers locate blinks the activity light, others the fault light. The fault command keeps the fault light on constant.
- Improve the usage() output and use it everywhere
- Added the map command, displays all elements connected to each (or the specified) ses(4) controller
- Added the status command, returns the overall status of the ses(4) controller

Reviewed by: wblock (man page, earlier version)
Approved by: bapt (mentor)
MFC after: 3 weeks
Relnotes: yes
Sponsored by: ScaleEngine Inc.
Differential Revision: https://reviews.freebsd.org/D3580

Yet another fix for gcc 4.2

Remove extra i++

Reported by: allanjude@

Fix build with gcc 4.2

Reported by: kib

Add a new sesutil(8) utility

This is an utility for managing SCSI Enclosure Services (SES) device.

For now only one command is supported "locate" which will change the test of the
external LED associated to a given disk.

Usage if the following:
sesutil locate disk [on|off]

Disk can be a device name: "da12" or a special keyword: "all".

Reviewed by: mav
MFC after: 1 month
Relnotes: yes
Sponsored by: gandi.net
Differential Revision: https://reviews.freebsd.org/D3544