MFC 363241:

efibootmgr: typo in long option name

del-timout should be del-timeout

Reported by: mjg

MFC efibootmgr: r326725-r326728, r326771, r326800-r326804, r326806, r327163
r327572-r327573, r327610-r327611, r327877, r331069

r326725:
Import Netflix's efibootmgr to help manage UEFI boot variables

efibootmgr manages the UEFI BootXXXX variables that implement the UEFI
Boot Manager protocol defined in the UEFI standards. It is modeled
after the Linux program of the same name with a mostly compatible set
of command line options. Since there's a fair amount of OS specifioc
code due to differeing names and methods of doing things, the
compatibility isn't 100%.

Basic functionality is implemented, though the more advanced next boot
functionality that's been defined elsewhere is unimplemented.

Submitted by: Matt Williams (with unix / efi path xlate by me)
Sponsored by: Netflix

r326726:
Forgotten in 326725

Release Notes: Yes

r326727:
Remove vestiges of -d and -p commands.
Fix two core dumps when optional data isn't specified.

Sponsored by: Netflix

r326728:
Indent multiple device path entries correctly.

Sponsored by: Netflix

r326771:
Unbreak gcc build by using (void) for functions that take no args.

Sponsored by: Netflix

r326800:
Check return value for set_bootvar and give a good error message.

CID: 1383601
Sponsored by: Netflix

r326801:
Don't leak new_data.

CID: 1383605
Sponsored by: Netflix

r326802:
Fix resource leak. Free converted description after printing it.
Also minor style sort of local vars.

CID: 1383606
Sponsored by: Netflix

r326803:
Free load_opt_buf after we're done with it.

CID: 1383607
Sponsored by: Netflix

r326804:
Add sanity testing against maximum sane lengths for device paths for
loader and kernel.

CID: 1383608
Sponsored by: Netflix

r326806:
Actually insert the free(d) call missed in r326802.

Noticed by: rpokala@

r327163:
Remove write-only opt and useless optlen variables.

This squashes the warning gebnerated by GCC 6.x. Since
variables that are now removed had come documentation
value, put relevant bits in comment, so they can be
resurrected from there when actually needed.

r327572:
Ensure that we have a description string. When unspecified, default to "".

Sponsored by: Netflix

r327573:
Free options before setting them. This will prevent us from leaking
memory when we have multiple copies of the same option from being
specified.

Sponsored by: Netflix

r327610:
Fix usage strings. -d and -p were removed before this was committed to
FreeBSD, but the strings weren't updated.

Sponsored by: Netflix

r327611:
There's no need / benefit from deleting the variable before we set it.

Sponsored by: Netflix

r327877:
Fix error in determining the next available boot slot.

Sponsored by: Netflix

r331069:
Make not getting BootOrder a warning, not a fatal error when printing.

Sponsored by: Netflix

Relnotes: yes

Indent multiple device path entries correctly.

Sponsored by: Netflix

Remove vestiges of -d and -p commands.
Fix two core dumps when optional data isn't specified.

Sponsored by: Netflix

Forgotten in 326725

Release Notes: Yes

Import Netflix's efibootmgr to help manage UEFI boot variables

efibootmgr manages the UEFI BootXXXX variables that implement the UEFI
Boot Manager protocol defined in the UEFI standards. It is modeled
after the Linux program of the same name with a mostly compatible set
of command line options. Since there's a fair amount of OS specifioc
code due to differeing names and methods of doing things, the
compatibility isn't 100%.

Basic functionality is implemented, though the more advanced next boot
functionality that's been defined elsewhere is unimplemented.

Submitted by: Matt Williams (with unix / efi path xlate by me)
Sponsored by: Netflix