Copy stable/10@r272459 to releng/10.1 as part of
the 10.1-RELEASE process.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Close fd in initattr() and showattr().

Reviewed by: rwatson

The last big commit: let usr.sbin/ use WARNS=6 by default.

ANSIfy some more tools in usr.sbin/.

Most of these tools build with WARNS=6, except for their use of K&R
function declarations.

Fixed the misplaced $FreeBSD$.

When giving examples of how to use extattrctl(8) to configure UFS1
attributes, use the current convention for attribute directory names
so that UFS_EXTATTR_AUTOSTART will work with them.

Approved by: re (scottl)

style.Makefile(5)

The .Nm utility

Cross-reference with ffs(7).

Sponsored by: DARPA, NAI Labs

Make it clear that this applies only to UFS1 file systems, as UFS2 will
have native extended attributes rather than stacked extended attributes.
While I'm at it, make sure UFS_EXTATTR is not spelt FFS_EXTATTR.

Sponsored by: DARPA, NAI Labs
Obtained from: TrustedBSD Project

Clean up usage message: don't put optional parameter's in brackets.
Update copyright date.

Obtained from: TrustedBSD Project
Sponsored by: DARPA, NAI Labs
Extracted from: green

Simplify and optimize. This speeds up 'initattr' enormously for small
attribute sizes (up to two orders of magnitude!)

o Add a 'showattr' function the extattrctl, allowing a backing file to
be inspected to show the maximum attribute size and file.

Make extattrctl WARNS?=2-safe:
o remove extraneous extern's
o prototype functions
o combine multiple return (0)'s into a single return (0) at the
end of main()

Approved by: rwatson
Obtained from: TrustedBSD Project

o Reflect moving of extattr_namespace calls to libc from libutil; no
longer need to link libutil into command-line extended attribute
utilities.

Obtained from: TrustedBSD Project

o Update copyright dates, comments...

Obtained from: TrustedBSD Project

o extattrctl initattr, when pre-allocating store for extended attributes,
computed a a chunksize that didn't include the extended attribute
header. This was a non-fatal error, in that it was just writing out
zeros anyway, but did have the effect of not pre-allocating the
right amount of disk space. This fix calculates chunksize to include
the attribute header.

Submitted by: Dale Rahn
Sponsored by: DARPA, UPenn POSSE Project
Obtained from: OpenBSD

Perform a major cleanup of the usr.sbin Makefiles.
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.

Remove GCC'isms in CFLAGS.

mdoc(7) police: remove extraneous .Pp before and/or after .Sh.

Fix LDADD and add missing DPADD.

- Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.

Set the default manual section for usr.sbin/ to 8.

o Rename "namespace" argument to "attrnamespace" as namespace is a C++
reserved word.

Submitted by: jkh
Obtained from: TrustedBSD Project

Correct the arguments to the extattrct()l call so that the enable and
disable commands work as documented.

Approved by: rwatson

mdoc(7) police: -mdoc still has a nine-arguments limitation.

o Update extattrctl to take into account the updated EA interface with
explicit namespaces. Modify it to use libutil for string/constant
namespace conversions. Update the documentation to take into account
the new interface.

Obtained from: TrustedBSD Project

mdoc(7) police: split punctuation characters + misc fixes.

Prepare for mdoc(7)NG.

o Check return of strdup() for NULL, abort if so.

Submitted by: jedgar

mdoc(7) police: use the new features of the Nm macro.

o What a good idea, ``-o'' should be a ``-f'' like in every other
utility that is cautious but sometimes you want to be less
cautious. Go figure.

Submitted by: sheldonh

o Add a ``-o'' argument to initattr, which causes extattrctl to overwrite
the existing attribute file rather than aborting with an error.
o Useful if you want to reset the state of attributes on the system without
allocating different disk blocks through deletion and recreation,
for example, if you're doing benchmarks of extended attribute code. :-)

Obtained from: TrustedBSD Project

o When pre-allocating attribute storage space, also allocate space for
attribute instance headers, or higher inode numbers will require
additional disk blocks to be allocated later.

Obtained from: TrustedBSD Project

Whitespace-only: remove the only hard sentence break in the file.

Modify extended attribute protection model to authorize based on
attribute namespace and DAC protection on file:
- Attribute names beginning with '$' are in the system namespace
- The attribute name "$" is reserved
- System namespace attributes may only be read/set by suser()
or by kernel (cred == NULL)
- Other attribute names are in the application namespace
- The attribute name "" is reserved
- Application namespace attributes are protected in the manner
of the target file permission

o Kernel changes
- Add ufs_extattr_valid_attrname() to check whether the requested
attribute "set" or "enable" is appropriate (i.e., non-reserved)
- Modify ufs_extattr_credcheck() to accept target file vnode, not
to take inode uid
- Modify ufs_extattr_credcheck() to check namespace, then enforce
either kernel/suser for system namespace, or vaccess() for
application namespace
o EA backing file format changes
- Remove permission fields from extended attribute backing file
header
- Bump extended attribute backing file header version to 3
o Update extattrctl.c and extattrctl.8
- Remove now deprecated -r and -w arguments to initattr, as
permissions are now implicit
- (unrelated) fix error reporting and unlinking during failed
initattr to remove duplicate/inaccurate error messages, and to
only unlink if the failure wasn't in the backing file open()

Obtained from: TrustedBSD Project

o Other half of Sheldon's patch to fix initattr arguments, mistakenly
forgotten due to minimal sleep. Thanks!

Submitted by: sheldonh

o update extattrctl man page to reflect obligatory arguments to initattr
-r and -w arguments

Submitted by: sheldonh

o Correct getopt() argument so that initattr -r and -w take an additional
argument via optarg. This corrects a segfault when initattr is invoked
with either of these two arguments. Not sure how this got broken given
that in the original patches it was fine -- presumably a merging
mistake.

Obtained from: TrustedBSD Project

Minor mdoc markup fixes.

Reviewed by: maintainer

o Update extattrctl.8 to reflect new initattr -p, -r, and -w options.
o Update extattrctl.c to default new attributes to readable and writable
only by the kernel and root user. Previously the default was to allow
the file owner to directory view and manipulate the attributes, which
is probably an inappropriate default.

o Allow the ``-p'' argument to be specified to initattr, which indicates
that space for extended attributes should be preallocated, instead of
using a sparse attribute file. NOTE: This can result in a really
large file full of zeros. However, it can prevent a low disk condition
from causing an attribute write to fail, which is good for security and
consistency attributes.

o Unlink the attribute file during initattr if an error occurs -- this is
alright, as we specify O_CREAT when opening the file.

o Update initattr to add magic numbers and version number

Change "FreeBSD 5.0" to ".Fx 5.0"

Introduced /usr/sbin/extattrctl, a utility for managing UFS/FFS extended
attributes (recently committed). Using extattrctl, the extended attribute
service may be started and stopped for specific file systems; specific
attributes may be enabled or disabled, and the backing file for each
attribute configured. Also, backing files may be initialized.

Reviewed by: adrian, bp, freebsd-fs, the unthanked masses
Obtained from: TrustedBSD