Copy stable/10@r272459 to releng/10.1 as part of
the 10.1-RELEASE process.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

MFC r271797: Make kernel to update LUN size from the backing storage
on configuration reload also if that size was not specified in the new
configuration.

Previously it happened only if size was explicitly changed in config.

Approved by: re (delphij)

MFC r271571:

Fix two small nits in ctl.conf(5).

Approved by: re (glebius)
Sponsored by: The FreeBSD Foundation

MFC r271445,r271446,r271560:
Improve markup and language throughout the ctl.conf man page

MFC r271543:
Add the new iscsi(4) man page
Cross reference it from iscsid(8) and iscsictl(8)

Approved by: re (gjb), bcr (mentor)

MFC r271319:

Fix ctld(8) to not forget to send TargetPortalGroupTag and TargetAlias
when the initiator skips security negotiation. This fixes interoperability
with Xtend SAN initiator.

PR: 193021
Approved by: re (marius)
Sponsored by: The FreeBSD Foundation

MFC r271187:

Avoid ctld(8) crash on getaddrinfo(3) failure.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation

MFC r271169:

Turn two errors, which are possible to trigger only by bugs,
into assertions.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation

MFC r271157:

Fix typo.

Approved by: re (marius)
Sponsored by: The FreeBSD Foundation

MFC r270179:

Add missing libraries to DPADD; sort DPADD so DPADD and LDADD match up

This fixes "make checkdpadd"

Approved by: jmmv (mentor)
Phabric: D630
PR: 192765

MFC r270279:

Make the iSCSI stack use __FBSDID() properly.

Sponsored by: The FreeBSD Foundation

MFC r269183, r269191:
Add netmasks support to initiator-portal option.

MFC 268931:

Correct spelling errors in ctld.8. While here, correct similar errors
in ctl.conf.5 and fix a couple of contractions.

MFC r268795:
Fix ctld crash on startup if target alias is not set.

MFC r268328:
Close race in r268291 between port destruction, delayed by sessions
teardown, and new port creation during `service ctld restart`.

Close it by returning iSCSI port internal state, that allows to identify
dying ports, which should not be counted as existing, from really alive.

MFC r268302:
Pass through iSCSI session ISID from LOGIN request to the CTL frontend.

ISID is an important part of initiator transport ID for iSCSI. It is not
used now, but should be to properly implement persistent reservation.

MFC r268293:
Burry devid port method, which was a gross hack.

Instead make ports provide wanted port and target IDs, and LUNs provide
wanted LUN IDs. After that core Device ID VPD code only had to link all
of them together and add relative port and port group numbers.

LUN ID for iSCSI LUNs no longer created by CTL, but by ctld, and passed
to CTL as "scsiname" LUN option. This makes LUNs to report the same set
of IDs, independently from the port through which it is accessed, as
required by SCSI specifications.

MFC r268291:
Create separate CTL port for every iSCSI target (and maybe portal group).

Having single port for all iSCSI connections makes problematic implementing
some more advanced SCSI functionality in CTL, that require proper ports
enumeration and identification.

This change extends CTL iSCSI API, making ctld daemon to control list of
iSCSI ports in CTL. When new target is defined in config fine, ctld will
create respective port in CTL. When target is removed -- port will be
also removed after all active commands through that port properly aborted.
This change require ctld to be rebuilt to match the kernel.

As a minor side effect, this allows to have iSCSI targets without LUNs.
While that may look odd and not very useful, that is not incorrect.

MFC r267648:
serial_num and device_id fields are not necessarily null-terminated.

Before this it was impossible to use all 16 bytes of serial number, and
client always got serial number NULL-terminated, that is not required.

MFC r267606:
On discovery stage add set of TargetAddress keys to reply, reporting to
the client all the portal groups addresses and ports.

MFC: 267833

Fix issues in config parser relating to lun serial numbers.

Without this fix some serial numbers needed to be quoted
to avoid the config parser bailing out.

Submitted by: delphij
Sponsored by: iXsystems

MFC r264877:

Style fixes.

Sponsored by: The FreeBSD Foundation

MFC r264535:

English.

Sponsored by: The FreeBSD Foundation

MFC r264534:

If we fail to create LUN, try again on next configuration reload.

Sponsored by: The FreeBSD Foundation

MFC r264533:

Use consistent punctuation.

Sponsored by: The FreeBSD Foundation

MFC r264532:

Use proper terminology in debug messages.

Sponsored by: The FreeBSD Foundation

MFC r264531:

Constify.

Sponsored by: The FreeBSD Foundation

MFC r264530:

Properly pass the initiator address when running in proxy mode.

Sponsored by: The FreeBSD Foundation

MFC r264529:

Use socket address from accept(2) instead of retrieving it via
getpeername(2).

Sponsored by: The FreeBSD Foundation

MFC r264528:

Rework the way we enable CTL iSCSI port. Previously conf_apply()
needed it to be already enabled, because listening in proxy mode
requires it; however, it's conf_apply() that opens pidfiles,
so it resulted in port being enabled before pidfile was opened.
This was not so bad, but it was also disabled when pidfile couldn't
be opened due to ctld already running; this means that starting
second ctld instance screwed up the first.

Sponsored by: The FreeBSD Foundation

MFC r264526:

Properly identify target portal when running in proxy mode. While here,
remove CTL_ISCSI_CLOSE, it wasn't used or implemented anyway.

Sponsored by: The FreeBSD Foundation

MFC r264524:

Make it possible for the iSCSI target side to operate in both normal
and ICL_KERNEL_PROXY mode, and fix some bit rot so the latter actually
works again.

Sponsored by: The FreeBSD Foundation

MFC r264500:

Stop treating LUN 0 as mandatory. There is no reason to do that.

Sponsored by: The FreeBSD Foundation

MFC r263356:

Make the error message more clear.

Sponsored by: The FreeBSD Foundation

MFC r261752:

Empty data segment during Login Phase is rather unlikely, but it's
not, by itself, a protocol error. This fixes interoperability with
OpenBSD initiator.

Sponsored by: The FreeBSD Foundation

MFC r261751:

The log_whatever() routines don't accept NULL for format strings,
so mark them as __printflike instead of__printf0like.

Sponsored by: The FreeBSD Foundation

MFC r261764:

So, it turns out SIGCHLD is discarded by default, so we have to set up
a dummy handler to make it interrupt an ioctl(2) or select(2).

This makes those short-lived ctld(8) zombies disappear.

Sponsored by: The FreeBSD Foundation

MFC r261763:

Use new auth-type "deny" instead of using "chap" with no chap entries;
it's cleaner this way, and gives better feedback to the user.

Sponsored by: The FreeBSD Foundation

MFC r261762:

Use "default" as default discovery-auth-group, instead of "no-access".
It doesn't change visible behaviour, as previously auth-group "default"
wasn't redefinable, so by default access was always denied.

Sponsored by: The FreeBSD Foundation

MFC r261761:

Update manual page to match recent auth-group "default" changes.

Sponsored by: The FreeBSD Foundation

MFC r261760:

Add a new auth-group "default", defaulting to deny, and make it possible
to redefine it. From now on, assigning auth-group to a target is no longer
mandatory.

Sponsored by: The FreeBSD Foundation

MFC r261759:

Make it possible to redefine portal-group "default".

Sponsored by: The FreeBSD Foundation

MFC r261758:

Add auth-type.

Sponsored by: The FreeBSD Foundation

MFC r261757:

Rename a variable, no functional changes.

Sponsored by: The FreeBSD Foundation

MFC r261756:

Yacc cleanup; no functional changes.

Sponsored by: The FreeBSD Foundation

MFC r261755:

Make function ordering slightly more logical; no functional changes.

Sponsored by: The FreeBSD Foundation

MFC r261754:

Implement initiator-name and initiator-portal restrictions.

Sponsored by: The FreeBSD Foundation

MFC r261753:

Daemonize after applying configuration, not before, so that
any problems - including "daemon already running" - are visible
on the terminal and not just in logs.

Sponsored by: The FreeBSD Foundation

MFC r261750:

Improve check for duplicated paths. It shows the warning twice for every
path (once for each duplicate found), but it should do for now.

Sponsored by: The FreeBSD Foundation

MFC r261749:

Refactor.

Sponsored by: The FreeBSD Foundation

MFC r261768:

Make the debug messages during ctld(8) shutdown less confusing.

Sponsored by: The FreeBSD Foundation

MFC r261767:

Show proper configuration file line numbers in error messages.

Sponsored by: The FreeBSD Foundation

MFC r261766:

Make ctld error out on invalid characters in ctl.conf.

Sponsored by: The FreeBSD Foundation

MFC r261765:

Improve error reporting.

Sponsored by: The FreeBSD Foundation

MFC r259182:

Fix handling for empty auth-groups. Without it, ctld child process
would either exit on assertion, or, if assertions are not enabled,
fail to authenticate the target.

Sponsored by: The FreeBSD Foundation

Hoist all the mergeinfo up to the root in preparation for enforcing merges
to the root only. All MFC's were rerecorded to the root.

Going forward, if an MFC includes mergeinfo, it will need to be made to
the root and committed from the root. Merges with --ignore-ancestry
or diff | patch can go anywhere.

The mergeinfo in HEAD is in a bad state from years of neglect and manual
tampering and this was branched into 10.x. This confuses the coalescing
code and prevents it from doing its job.

Approved by: re (gjb, implicit)

MFC r258842:

Grammar fix.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation

MFC r258841:

Fix typos.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation

Fix typo.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Plug memory leaks.

Coverity CID: 1087993, 1087992
Approved by: re (marius)
Sponsored by: FreeBSD Foundation

Fix off-by-one.

Coverity CID: 1011375
Approved by: re (glebius)
Sponsored by: FreeBSD Foundation

Fix several problems in the new iSCSI stack; this includes interoperability
fix for LIO (Linux target), removing possibility for the target to avoid mutual
CHAP by choosing to skip authentication altogether, and fixing truncated error
messages in iscsictl(8) output. This also fixes several of the problems found
with Coverity.

Note that this change requires world rebuild.

Coverity CID: 1088038, 1087998, 1087990, 1088004, 1088044, 1088041, 1088040
Approved by: re (blanket)
Sponsored by: FreeBSD Foundation

Make iscsictl(8) automatically try to load the iscsi module. While here,
improve module loading in iscsid(8) and ctld(8).

Approved by: re (delphij)

Minor mdoc fixes.

Approved by: re (blanket)

Bring in the new iSCSI target and initiator.

Reviewed by: ken (parts)
Approved by: re (delphij)
Sponsored by: FreeBSD Foundation