Copy stable/10@r272459 to releng/10.1 as part of
the 10.1-RELEASE process.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

MFC r270027:

tmconfig compilation when MK_ATM == yes and MK_BSNMP == no

Makefile.inc1:
Always compile gensnmptree with bootstrap-tools when MK_BSNMP != no
instead of depending on a potentially stale tool installed on the build host

sbin/atm/atmconfig/Makefile:
- Always remove oid.h to avoid cluttering up the build/src tree.
- Consolidate all of the RESCUE/MK_BSNMP != no logic under one
conditional to improve readability
- Remove unnecessary ${.OBJDIR} prefixing for oid.h and use ${.TARGET} instead
of spelling out oid.h
- Add a missing DPADD for ${LIBCRYPTO} when compiled MK_BSNMP == yes and
MK_OPENSSL == yes and not compiling for /rescue/rescue

sbin/atm/atmconfig/main.c:
Change #ifndef RESCUE to #ifdef WITH_BSNMP in main.c to make it
clear that we're compiling bsnmp support into atmconfig

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

In sbin/atm/atmconfig/diag.c, fix a few warnings about format strings
not being literals.

MFC after: 1 week

Add missing static keywords for global variables to tools in sbin/.

These tools declare global variables without using the static keyword,
even though their use is limited to a single C-file, or without placing
an extern declaration of them in the proper header file.

Unbreak NO_DYNAMICROOT by explicitely linking to libcrypto if MK_OPENSSL isn't
set to no, as libbsnmp needs it.

MFtbemd:

Prefer MACHNE_CPUARCH to MACHINE_ARCH in most contexts where you want
to test of all the CPUs of a given family conform.

Switch the default WARNS level for sbin/ to 6.

Submitted by: Ulrich Spörlein

Remove netatm from HEAD as it is not MPSAFE and relies on the now removed
NET_NEEDS_GIANT. netatm has been disconnected from the build for ten
months in HEAD/RELENG_7. Specifics:

- netatm include files
- netatm command line management tools
- libatm
- ATM parts in rescue and sysinstall
- sample configuration files and documents
- kernel support as a module or in NOTES
- netgraph wrapper nodes for netatm
- ctags data for netatm.
- netatm-specific device drivers.

MFC after: 3 weeks
Reviewed by: bz
Discussed with: bms, bz, harti

Disconnect netatm from the build as it is not MPSAFE and relies on
NET_NEEDS_GIANT, which will shortly be removed. This is done in a
away that it may be easily reattached to the build before 7.1 if
appropriate locking is added. Specifics:

- Don't install netatm include files
- Disconnect netatm command line management tools
- Don't build libatm
- Don't include ATM parts in rescue or sysinstall
- Don't install sample configuration files and documents
- Don't build kernel support as a module or in NOTES
- Don't build netgraph wrapper nodes for netatm

This removes the last remaining consumer of NET_NEEDS_GIANT.

Reviewed by: harti
Discussed with: bz, bms
Approved by: re (kensmith)

o IFNAMSIZ includes a terminating null byte.

Submitted by: rdivacky
MFC after: 1 week

fix typo: "adaptor" -> "adapter"

Use the C99 syntax for designated initialisers.

Cleanups for gcc4:

- Use socklen_t for socket functions
- Remove an unnecessary extern
- Signed/unsigned cleanups

Reviewed by: harti

Forgot to change the pointer to the snmp_atm sources after repo-copy.
Correct this by pointing to the new location.

Pointy hat to: harti

Submitted by: keramida

Expand contractions.

Fixed the misplaced $FreeBSD$.

Sort sections.

Back the warnings down from 9 to 6, since that is the highest we have. If
we added a WARNS 7 level, it shouldn't be assumed this code will pass it.

Add support for the examination and modification of the devices.
This is implemented through SNMP and requires the ilmi daemon to
run on the system. To prevent bloat in rescue the atmconfig for
rescue is compiled without this stuff.

No need to include if_var.h.

Get rid of several unneeded includes (if.h, if_var.h, if_mib.h).

The media info is printed with the -hardware option so there is no
point to write 'Media' in the table header for the -atm option.

'atmconfig natm show' shows all currently configured PVCs for IP over ATM,
not 'atmconfig natm list'.

Add special lines for 'help commands'.

Allow more than one help file. There is a restriction that
each help file must start with a level 0 topic.

Allow the help file path and name to be overwritten by cc -D...
Also remove the current directory from the default help file path
and add an appropriate directory in /usr/local instead.

The natm sub-command was missing in the TOC of the helpfile.

Mechanically kill hard sentence breaks.

Markup overhaul.

Use WARNS?=3 for these in the arm case for now, due to toolchain issues.

Make NULL a (void*)0 whereever possible, and fix the warnings(-Werror)
that this provokes. "Wherever possible" means "In the kernel OR NOT
C++" (implying C).

There are places where (void *) pointers are not valid, such as for
function pointers, but in the special case of (void *)0, agreement
settles on it being OK.

Most of the fixes were NULL where an integer zero was needed; many
of the fixes were NULL where ascii <nul> ('\0') was needed, and a
few were just "other".

Tested on: i386 sparc64

style.Makefile(5):
Use WARNS?= instead of WARNS=.

style cleanup: Remove duplicate $FreeBSD$ tags.

These files had tags after the copyright notice,
inside the comment block (incorrect, removed),
and outside the comment block (correct).

Approved by: rwatson (mentor)

Add support for virtual interfaces. These have no phy chip and, hence, we
need to handle interfaces without phy specially.

Userland signed char fixes for PPC build. Problems were using a char
return for getopt() and comparing to -1, ditto with fgetc() and EOF,
and using the kg_nice value from <sys/user.h>

Submitted by: Stefan Farfeleder <stefan@fafoe.narf.at>
Reviewed by: obrien, bde (a while back)
Tested lightly on: ppc, i386, make universe

Update to reflect eni removal

Defer allocation of the actual receive mbuf until the external buffer
is returned from the card to the driver. Add a counter that shows
how many times this allocation has failed. Note, that we could even
further delay the allocation of the mbuf until we know, that we need it
(there are no receive errors and the connection is open). This will be done
in a later commit.

Print the new statistics field in atmconfig.

Get rid of a __DECONST by strdup'ing the string in question. When
called this way the program just prints its help intro, so the
memory leak is not a problem.

Pointed out by: bde

style.Makefile(5)

Restore vendor ID's.

Requested by: bde

Add a program for configuration of the ATM drivers and the IP over ATM
stuff. This utility allows inspection of the ATM characteristics,
the PHY layer, including statistics of both, the retrival of the
list of currently open channels and also allows access to utopia(4).

Add the new arguments for the add pvc command to the help information.
Correct a comment.

Submitted by: Vincent Jardin <vjardin@wanadoo.fr>
MFC after: 3 days

style.Makefile(5)'ize

Make firmware version 4.1.12 the default for download to PCA-200E adapters.
The old firmware (3.0.1) can still be used by specifying the '-3' option
to fore_dnld.

Document the -r option that resets the adapter prior to the download.

Ther newer firmware version allows traffic shaping.

Fix the code with respect to the assumption that sizeof(long) == 4.

Fix what was a common idiom in PDP-11 days: declare a local int and
use the address of that int for read(2). While this happens to work on
LE, it surely is wrong on BE.

Make this compile with WARNS=6.

Fix warnings: a variable that was unused, a variable that
was unused unless sun was defined and printing of u_longs
with %x.

PR: bin/39818
Submitted by: dan@obluda.cz
MFC after: 1 week

Use size_t for buffer sizes. Improve error handling in some places.
Remove a __DECONST() that was needed before this interface cleanup.

Add support for CBR and VBR PVCs. Enhance the error handling for
the 'add pvc' command.

Submitted by: Vincent Jardin <vjardin@wanadoo.fr>
MFC after: 2 weeks

Make atm WARNS=6 clean. The changes are mostly:

- remove some instances of __P()
- use real prototypes and un-K&R function headers
- constify where necessary (mostly strings and structures containing
strings)
- make functions and variables static that need not to be global
- tag unused function parameters as __unused

Testing: a fresh universe

When deciding whether to download the microcode or not look at the API rather
than at the vendor. We have three different Fore cards and only the PCA200
need the microcode. Look also at the RAM address and load the code only if
it is not zero. A zero RAM address means either a bug in the driver or
this is a interface created by harp(4) in which case fatm(4) handles the
microcode issue.

Due to a gcc bug, it doesn't like local variables with names like 'sin'.
Rename this for the moment. Also fix a sparc64 alignment warning.

Make ilmid WARNS=6 clean. The problem were a couple of unused function
arguments and missing consts.

Don't call print_pdu() when we are not debugging. This would result
in calling fprintf() with a NULL fp. Strange enough this didn't result
in cores in stable, but results in cores now.

MFC after: 2 weeks

Use size_t type vars in sizeof contexts.

- Fix function declarations.
- Provide function prototypes.

Submitted by: trhodes

Get rid of a few caddr_t's.

Submitted by: trhodes

asn_get_encoded() takes 2 arguments.

Retire set_reqid(), unused since 1.2.

- Add const qualifier to char * arrays.
- Retire Traps array; this was obsoleted in 1.2

Don't roll a private copy of basename().

- Replace hexdump() with a prettier version.
- Reformat log output.
- Consolidate PDU printing code into print_pdu().

Set pdu->pdulen in build_pdu().

Don't compile in lmi_object_instance().

- Handle the 'GET PREFIX' request.
- Deal with MADGE_OBJECT1 requests.
- Move code inside of switch cases to separate functions.

Submitted by: Richard Hodges <rh@matriplex.com>

Correct a comment.

Submitted by: Richard Hodges <rh@matriplex.com>

- Add a comment regarding SETPFX_OBJID
- Add an Objid definition for MADGE_OBJECT1
- Add an array to map ilmi_states to ASCII descriptions.

Submitted by: Richard Hodges <rh@matriplex.com>

Clean up formatting.

Submitted by: Richard Hodges <rh@matriplex.com>

Correct typos, mostly s/ a / an / where appropriate. Some whitespace cleanup,
especially in troff files.

english(4) police.

de-__P()

Cast malloc() assignments.

- bzero() allocations.
- check for malloc() failures.

Turn warnings back on.

The .Nm utility

Use a larger data type to prevent counters wrapping so quickly.
Silence a warning.

Sync this up with changes made in v1.8 of sys/netatm/atm_if.h

- Further replacing of UM_* macros with the appropriate function call. I
am fairly certain that this should do it and that I may now remove the
UM_ macros from port.h. I will, however, wait a few days to ensure
that these can be safely removed.

- Replace UM_* macros by replacing them with the appropriate function
call. These changes are similar to the ones made to atmarpd and scsp.

Default to WARNS=2.
Binary builds that cannot handle this must explicitly set WARNS=0.

Reviewed by: mike

The directory of the makefile that's including the file is tried first.
See section 3.2 of "PMake - A Tutorial" in /usr/share/doc/psd/12.make.

Remove whitespace at EOL.

- Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.

Set the default manual section for sbin/ to 8.

Correct grammar in comment.

Fix typo: seperate -> separate.

Seperate does not exist in the english language.

Submitted to look at by: kris

man(7) -> mdoc(7).

Add `_PATH_DEVZERO'.
Use _PATH_* where where possible.

Remove unused #include.

Remove unused #include.

1000000 usec -> 1 sec 0 usec; fix

Make the fore_dnld program more robust and reliable.

In particular HZ=1000 would seem to break it before.

Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.

With the kind permission of Marconi Communications (Formerly "Fore Communication"
include a copy of the 3.0.1 firmware for the PCA200E card in the fore_dnld
program.

There are various and subtle compatibility issues between the hfa driver and
the microcode, this version is belived to work best.

If a file is specified on the command line it will be used instead of the
embedded image.

Approved by: jkh

Handle GetResponse errors correctly.

$Id$ -> $FreeBSD$

Modify code to be -Wall'able.

PR: bin/11315

Getopt(3) returns -1 not EOF.

Clarify the number of network interfaces per physical interface available with
each type of signalling manager and bring the atm command into agreement with
the man page.

Re-write of ilmi daemon. Among the major changes, it does not use predefined
PDUs and should handle multi-request OIDs on GETs.

Rename a function name so that it doesn't conflict with a future system call.

Two patches from the HARP people:

Various Makefile related fixes.

-Wformat fixes.

Submitted by: Mike Spengler <mks@networkcs.com>

Remove blank after -I

Add new files for HARP3

Host ATM Research Platform (HARP), Network Computing Services, Inc.
This software was developed with the support of the Defense Advanced
Research Projects Agency (DARPA).