Deleted Added
sdiff udiff text old ( 126080 ) new ( 132199 )
full compact
1/*-
2 * Copyright (c) 1999 Kazutaka YOKOTA <yokota@zodiac.mech.utsunomiya-u.ac.jp>
3 * All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer as
10 * the first lines of this file unmodified.
11 * 2. Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution.
14 * 3. The name of the author may not be used to endorse or promote products
15 * derived from this software without specific prior written permission.
16 *
17 * THIS SOFTWARE IS PROVIDED BY THE AUTHORS ``AS IS'' AND ANY EXPRESS OR
18 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
19 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
20 * IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY DIRECT, INDIRECT,
21 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
22 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */
28
29#include <sys/cdefs.h>
30__FBSDID("$FreeBSD: head/sys/dev/fb/fb.c 126080 2004-02-21 21:10:55Z phk $");
31
32#include "opt_fb.h"
33
34#include <sys/param.h>
35#include <sys/systm.h>
36#include <sys/conf.h>
37#include <sys/bus.h>
38#include <sys/kernel.h>
39#include <sys/malloc.h>
40#include <sys/module.h>
41#include <sys/uio.h>
42#include <sys/fbio.h>
43#include <sys/linker_set.h>
44
45#include <vm/vm.h>
46#include <vm/pmap.h>
47
48#include <dev/fb/fbreg.h>
49
50SET_DECLARE(videodriver_set, const video_driver_t);
51
52/* local arrays */
53
54/*
55 * We need at least one entry each in order to initialize a video card
56 * for the kernel console. The arrays will be increased dynamically
57 * when necessary.
58 */
59
60static int vid_malloc;
61static int adapters = 1;
62static video_adapter_t *adp_ini;
63static video_adapter_t **adapter = &adp_ini;
64static video_switch_t *vidsw_ini;
65 video_switch_t **vidsw = &vidsw_ini;
66
67#ifdef FB_INSTALL_CDEV
68static struct cdevsw *vidcdevsw_ini;
69static struct cdevsw **vidcdevsw = &vidcdevsw_ini;
70#endif
71
72#define ARRAY_DELTA 4
73
74static int
75vid_realloc_array(void)
76{
77 video_adapter_t **new_adp;
78 video_switch_t **new_vidsw;
79#ifdef FB_INSTALL_CDEV
80 struct cdevsw **new_cdevsw;
81#endif
82 int newsize;
83 int s;
84
85 if (!vid_malloc)
86 return ENOMEM;
87
88 s = spltty();
89 newsize = ((adapters + ARRAY_DELTA)/ARRAY_DELTA)*ARRAY_DELTA;
90 new_adp = malloc(sizeof(*new_adp)*newsize, M_DEVBUF, M_WAITOK | M_ZERO);
91 new_vidsw = malloc(sizeof(*new_vidsw)*newsize, M_DEVBUF,
92 M_WAITOK | M_ZERO);
93#ifdef FB_INSTALL_CDEV
94 new_cdevsw = malloc(sizeof(*new_cdevsw)*newsize, M_DEVBUF,
95 M_WAITOK | M_ZERO);
96#endif
97 bcopy(adapter, new_adp, sizeof(*adapter)*adapters);
98 bcopy(vidsw, new_vidsw, sizeof(*vidsw)*adapters);
99#ifdef FB_INSTALL_CDEV
100 bcopy(vidcdevsw, new_cdevsw, sizeof(*vidcdevsw)*adapters);
101#endif
102 if (adapters > 1) {
103 free(adapter, M_DEVBUF);
104 free(vidsw, M_DEVBUF);
105#ifdef FB_INSTALL_CDEV
106 free(vidcdevsw, M_DEVBUF);
107#endif
108 }
109 adapter = new_adp;
110 vidsw = new_vidsw;
111#ifdef FB_INSTALL_CDEV
112 vidcdevsw = new_cdevsw;
113#endif
114 adapters = newsize;
115 splx(s);
116
117 if (bootverbose)
118 printf("fb: new array size %d\n", adapters);
119
120 return 0;
121}
122
123static void
124vid_malloc_init(void *arg)
125{
126 vid_malloc = TRUE;
127}
128
129SYSINIT(vid_mem, SI_SUB_KMEM, SI_ORDER_ANY, vid_malloc_init, NULL);
130
131/*
132 * Low-level frame buffer driver functions
133 * frame buffer subdrivers, such as the VGA driver, call these functions
134 * to initialize the video_adapter structure and register it to the virtual
135 * frame buffer driver `fb'.
136 */
137
138/* initialize the video_adapter_t structure */
139void
140vid_init_struct(video_adapter_t *adp, char *name, int type, int unit)
141{
142 adp->va_flags = 0;
143 adp->va_name = name;
144 adp->va_type = type;
145 adp->va_unit = unit;
146}
147
148/* Register a video adapter */
149int
150vid_register(video_adapter_t *adp)
151{
152 const video_driver_t **list;
153 const video_driver_t *p;
154 int index;
155
156 for (index = 0; index < adapters; ++index) {
157 if (adapter[index] == NULL)
158 break;
159 }
160 if (index >= adapters) {
161 if (vid_realloc_array())
162 return -1;
163 }
164
165 adp->va_index = index;
166 adp->va_token = NULL;
167 SET_FOREACH(list, videodriver_set) {
168 p = *list;
169 if (strcmp(p->name, adp->va_name) == 0) {
170 adapter[index] = adp;
171 vidsw[index] = p->vidsw;
172 return index;
173 }
174 }
175
176 return -1;
177}
178
179int
180vid_unregister(video_adapter_t *adp)
181{
182 if ((adp->va_index < 0) || (adp->va_index >= adapters))
183 return ENOENT;
184 if (adapter[adp->va_index] != adp)
185 return ENOENT;
186
187 adapter[adp->va_index] = NULL;
188 vidsw[adp->va_index] = NULL;
189 return 0;
190}
191
192/* Get video I/O function table */
193video_switch_t
194*vid_get_switch(char *name)
195{
196 const video_driver_t **list;
197 const video_driver_t *p;
198
199 SET_FOREACH(list, videodriver_set) {
200 p = *list;
201 if (strcmp(p->name, name) == 0)
202 return p->vidsw;
203 }
204
205 return NULL;
206}
207
208/*
209 * Video card client functions
210 * Video card clients, such as the console driver `syscons' and the frame
211 * buffer cdev driver, use these functions to claim and release a card for
212 * exclusive use.
213 */
214
215/* find the video card specified by a driver name and a unit number */
216int
217vid_find_adapter(char *driver, int unit)
218{
219 int i;
220
221 for (i = 0; i < adapters; ++i) {
222 if (adapter[i] == NULL)
223 continue;
224 if (strcmp("*", driver) && strcmp(adapter[i]->va_name, driver))
225 continue;
226 if ((unit != -1) && (adapter[i]->va_unit != unit))
227 continue;
228 return i;
229 }
230 return -1;
231}
232
233/* allocate a video card */
234int
235vid_allocate(char *driver, int unit, void *id)
236{
237 int index;
238 int s;
239
240 s = spltty();
241 index = vid_find_adapter(driver, unit);
242 if (index >= 0) {
243 if (adapter[index]->va_token) {
244 splx(s);
245 return -1;
246 }
247 adapter[index]->va_token = id;
248 }
249 splx(s);
250 return index;
251}
252
253int
254vid_release(video_adapter_t *adp, void *id)
255{
256 int error;
257 int s;
258
259 s = spltty();
260 if (adp->va_token == NULL) {
261 error = EINVAL;
262 } else if (adp->va_token != id) {
263 error = EPERM;
264 } else {
265 adp->va_token = NULL;
266 error = 0;
267 }
268 splx(s);
269 return error;
270}
271
272/* Get a video adapter structure */
273video_adapter_t
274*vid_get_adapter(int index)
275{
276 if ((index < 0) || (index >= adapters))
277 return NULL;
278 return adapter[index];
279}
280
281/* Configure drivers: this is a backdoor for the console driver XXX */
282int
283vid_configure(int flags)
284{
285 const video_driver_t **list;
286 const video_driver_t *p;
287
288 SET_FOREACH(list, videodriver_set) {
289 p = *list;
290 if (p->configure != NULL)
291 (*p->configure)(flags);
292 }
293
294 return 0;
295}
296
297/*
298 * Virtual frame buffer cdev driver functions
299 * The virtual frame buffer driver dispatches driver functions to
300 * appropriate subdrivers.
301 */
302
303#define FB_DRIVER_NAME "fb"
304
305#ifdef FB_INSTALL_CDEV
306
307#if experimental
308
309static devclass_t fb_devclass;
310
311static int fbprobe(device_t dev);
312static int fbattach(device_t dev);
313
314static device_method_t fb_methods[] = {
315 DEVMETHOD(device_probe, fbprobe),
316 DEVMETHOD(device_attach, fbattach),
317
318 DEVMETHOD(bus_print_child, bus_generic_print_child),
319 { 0, 0 }
320};
321
322static driver_t fb_driver = {
323 FB_DRIVER_NAME,
324 fb_methods,
325 0,
326};
327
328static int
329fbprobe(device_t dev)
330{
331 int unit;
332
333 unit = device_get_unit(dev);
334 if (unit >= adapters)
335 return ENXIO;
336 if (adapter[unit] == NULL)
337 return ENXIO;
338
339 device_set_desc(dev, "generic frame buffer");
340 return 0;
341}
342
343static int
344fbattach(device_t dev)
345{
346 printf("fbattach: about to attach children\n");
347 bus_generic_attach(dev);
348 return 0;
349}
350
351#endif /* experimental */
352
353#define FB_UNIT(dev) minor(dev)
354#define FB_MKMINOR(unit) (u)
355
356#if experimental
357static d_open_t fbopen;
358static d_close_t fbclose;
359static d_read_t fbread;
360static d_write_t fbwrite;
361static d_ioctl_t fbioctl;
362static d_mmap_t fbmmap;
363
364
365static struct cdevsw fb_cdevsw = {
366 .d_version = D_VERSION,
367 .d_flags = D_NEEDGIANT,
368 .d_open = fbopen,
369 .d_close = fbclose,
370 .d_read = fbread,
371 .d_write = fbwrite,
372 .d_ioctl = fbioctl,
373 .d_mmap = fbmmap,
374 .d_name = FB_DRIVER_NAME,
375};
376#endif
377
378
379static int
380fb_modevent(module_t mod, int type, void *data)
381{
382
383 switch (type) {
384 case MOD_LOAD:
385 break;
386 case MOD_UNLOAD:
387 printf("fb module unload - not possible for this module type\n");
388 return EINVAL;
389 }
390 return 0;
391}
392
393static moduledata_t fb_mod = {
394 "fb",
395 fb_modevent,
396 NULL
397};
398
399DECLARE_MODULE(fb, fb_mod, SI_SUB_PSEUDO, SI_ORDER_ANY);
400
401int
402fb_attach(int unit, video_adapter_t *adp, struct cdevsw *cdevsw)
403{
404 int s;
405
406 if (adp->va_index >= adapters)
407 return EINVAL;
408 if (adapter[adp->va_index] != adp)
409 return EINVAL;
410
411 s = spltty();
412 adp->va_minor = unit;
413 vidcdevsw[adp->va_index] = cdevsw;
414 splx(s);
415
416 printf("fb%d at %s%d\n", adp->va_index, adp->va_name, adp->va_unit);
417 return 0;
418}
419
420int
421fb_detach(int unit, video_adapter_t *adp, struct cdevsw *cdevsw)
422{
423 int s;
424
425 if (adp->va_index >= adapters)
426 return EINVAL;
427 if (adapter[adp->va_index] != adp)
428 return EINVAL;
429 if (vidcdevsw[adp->va_index] != cdevsw)
430 return EINVAL;
431
432 s = spltty();
433 vidcdevsw[adp->va_index] = NULL;
434 splx(s);
435 return 0;
436}
437
438/*
439 * Generic frame buffer cdev driver functions
440 * Frame buffer subdrivers may call these functions to implement common
441 * driver functions.
442 */
443
444int genfbopen(genfb_softc_t *sc, video_adapter_t *adp, int flag, int mode,
445 struct thread *td)
446{
447 int s;
448
449 s = spltty();
450 if (!(sc->gfb_flags & FB_OPEN))
451 sc->gfb_flags |= FB_OPEN;
452 splx(s);
453 return 0;
454}
455
456int genfbclose(genfb_softc_t *sc, video_adapter_t *adp, int flag, int mode,
457 struct thread *td)
458{
459 int s;
460
461 s = spltty();
462 sc->gfb_flags &= ~FB_OPEN;
463 splx(s);
464 return 0;
465}
466
467int genfbread(genfb_softc_t *sc, video_adapter_t *adp, struct uio *uio,
468 int flag)
469{
470 int size;
471 int offset;
472 int error;
473 int len;
474
475 error = 0;
476 size = adp->va_buffer_size/adp->va_info.vi_planes;
477 while (uio->uio_resid > 0) {
478 if (uio->uio_offset >= size)
479 break;
480 offset = uio->uio_offset%adp->va_window_size;
481 len = imin(uio->uio_resid, size - uio->uio_offset);
482 len = imin(len, adp->va_window_size - offset);
483 if (len <= 0)
484 break;
485 (*vidsw[adp->va_index]->set_win_org)(adp, uio->uio_offset);
486 error = uiomove((caddr_t)(adp->va_window + offset), len, uio);
487 if (error)
488 break;
489 }
490 return error;
491}
492
493int genfbwrite(genfb_softc_t *sc, video_adapter_t *adp, struct uio *uio,
494 int flag)
495{
496 return ENODEV;
497}
498
499int genfbioctl(genfb_softc_t *sc, video_adapter_t *adp, u_long cmd,
500 caddr_t arg, int flag, struct thread *td)
501{
502 int error;
503
504 if (adp == NULL) /* XXX */
505 return ENXIO;
506 error = (*vidsw[adp->va_index]->ioctl)(adp, cmd, arg);
507 if (error == ENOIOCTL)
508 error = ENODEV;
509 return error;
510}
511
512int genfbmmap(genfb_softc_t *sc, video_adapter_t *adp, vm_offset_t offset,
513 vm_offset_t *paddr, int prot)
514{
515 return (*vidsw[adp->va_index]->mmap)(adp, offset, paddr, prot);
516}
517
518#endif /* FB_INSTALL_CDEV */
519
520static char
521*adapter_name(int type)
522{
523 static struct {
524 int type;
525 char *name;
526 } names[] = {
527 { KD_MONO, "MDA" },
528 { KD_HERCULES, "Hercules" },
529 { KD_CGA, "CGA" },
530 { KD_EGA, "EGA" },
531 { KD_VGA, "VGA" },
532 { KD_PC98, "PC-98x1" },
533 { KD_TGA, "TGA" },
534 { -1, "Unknown" },
535 };
536 int i;
537
538 for (i = 0; names[i].type != -1; ++i)
539 if (names[i].type == type)
540 break;
541 return names[i].name;
542}
543
544/*
545 * Generic low-level frame buffer functions
546 * The low-level functions in the frame buffer subdriver may use these
547 * functions.
548 */
549
550void
551fb_dump_adp_info(char *driver, video_adapter_t *adp, int level)
552{
553 if (level <= 0)
554 return;
555
556 printf("%s%d: %s%d, %s, type:%s (%d), flags:0x%x\n",
557 FB_DRIVER_NAME, adp->va_index, driver, adp->va_unit, adp->va_name,
558 adapter_name(adp->va_type), adp->va_type, adp->va_flags);
559 printf("%s%d: port:0x%lx-0x%lx, crtc:0x%lx, mem:0x%lx 0x%x\n",
560 FB_DRIVER_NAME, adp->va_index, (u_long)adp->va_io_base,
561 (u_long)adp->va_io_base + adp->va_io_size - 1,
562 (u_long)adp->va_crtc_addr, (u_long)adp->va_mem_base,
563 adp->va_mem_size);
564 printf("%s%d: init mode:%d, bios mode:%d, current mode:%d\n",
565 FB_DRIVER_NAME, adp->va_index,
566 adp->va_initial_mode, adp->va_initial_bios_mode, adp->va_mode);
567 printf("%s%d: window:%p size:%dk gran:%dk, buf:%p size:%dk\n",
568 FB_DRIVER_NAME, adp->va_index,
569 (void *)adp->va_window, (int)adp->va_window_size/1024,
570 (int)adp->va_window_gran/1024, (void *)adp->va_buffer,
571 (int)adp->va_buffer_size/1024);
572}
573
574void
575fb_dump_mode_info(char *driver, video_adapter_t *adp, video_info_t *info,
576 int level)
577{
578 if (level <= 0)
579 return;
580
581 printf("%s%d: %s, mode:%d, flags:0x%x ",
582 driver, adp->va_unit, adp->va_name, info->vi_mode, info->vi_flags);
583 if (info->vi_flags & V_INFO_GRAPHICS)
584 printf("G %dx%dx%d, %d plane(s), font:%dx%d, ",
585 info->vi_width, info->vi_height,
586 info->vi_depth, info->vi_planes,
587 info->vi_cwidth, info->vi_cheight);
588 else
589 printf("T %dx%d, font:%dx%d, ",
590 info->vi_width, info->vi_height,
591 info->vi_cwidth, info->vi_cheight);
592 printf("win:0x%lx\n", (u_long)info->vi_window);
593}
594
595int
596fb_type(int adp_type)
597{
598 static struct {
599 int fb_type;
600 int va_type;
601 } types[] = {
602 { FBTYPE_MDA, KD_MONO },
603 { FBTYPE_HERCULES, KD_HERCULES },
604 { FBTYPE_CGA, KD_CGA },
605 { FBTYPE_EGA, KD_EGA },
606 { FBTYPE_VGA, KD_VGA },
607 { FBTYPE_PC98, KD_PC98 },
608 { FBTYPE_TGA, KD_TGA },
609 };
610 int i;
611
612 for (i = 0; i < sizeof(types)/sizeof(types[0]); ++i) {
613 if (types[i].va_type == adp_type)
614 return types[i].fb_type;
615 }
616 return -1;
617}
618
619int
620fb_commonioctl(video_adapter_t *adp, u_long cmd, caddr_t arg)
621{
622 int error;
623 int s;
624
625 /* assert(adp != NULL) */
626
627 error = 0;
628 s = spltty();
629
630 switch (cmd) {
631
632 case FBIO_ADAPTER: /* get video adapter index */
633 *(int *)arg = adp->va_index;
634 break;
635
636 case FBIO_ADPTYPE: /* get video adapter type */
637 *(int *)arg = adp->va_type;
638 break;
639
640 case FBIO_ADPINFO: /* get video adapter info */
641 ((video_adapter_info_t *)arg)->va_index = adp->va_index;
642 ((video_adapter_info_t *)arg)->va_type = adp->va_type;
643 bcopy(adp->va_name, ((video_adapter_info_t *)arg)->va_name,
644 imin(strlen(adp->va_name) + 1,
645 sizeof(((video_adapter_info_t *)arg)->va_name)));
646 ((video_adapter_info_t *)arg)->va_unit = adp->va_unit;
647 ((video_adapter_info_t *)arg)->va_flags = adp->va_flags;
648 ((video_adapter_info_t *)arg)->va_io_base = adp->va_io_base;
649 ((video_adapter_info_t *)arg)->va_io_size = adp->va_io_size;
650 ((video_adapter_info_t *)arg)->va_crtc_addr = adp->va_crtc_addr;
651 ((video_adapter_info_t *)arg)->va_mem_base = adp->va_mem_base;
652 ((video_adapter_info_t *)arg)->va_mem_size = adp->va_mem_size;
653 ((video_adapter_info_t *)arg)->va_window
654#ifdef __i386__
655 = vtophys(adp->va_window);
656#else
657 = adp->va_window;
658#endif
659 ((video_adapter_info_t *)arg)->va_window_size
660 = adp->va_window_size;
661 ((video_adapter_info_t *)arg)->va_window_gran
662 = adp->va_window_gran;
663 ((video_adapter_info_t *)arg)->va_window_orig
664 = adp->va_window_orig;
665 ((video_adapter_info_t *)arg)->va_unused0
666#ifdef __i386__
667 = (adp->va_buffer) ? vtophys(adp->va_buffer) : 0;
668#else
669 = adp->va_buffer;
670#endif
671 ((video_adapter_info_t *)arg)->va_buffer_size
672 = adp->va_buffer_size;
673 ((video_adapter_info_t *)arg)->va_mode = adp->va_mode;
674 ((video_adapter_info_t *)arg)->va_initial_mode
675 = adp->va_initial_mode;
676 ((video_adapter_info_t *)arg)->va_initial_bios_mode
677 = adp->va_initial_bios_mode;
678 ((video_adapter_info_t *)arg)->va_line_width
679 = adp->va_line_width;
680 ((video_adapter_info_t *)arg)->va_disp_start.x
681 = adp->va_disp_start.x;
682 ((video_adapter_info_t *)arg)->va_disp_start.y
683 = adp->va_disp_start.y;
684 break;
685
686 case FBIO_MODEINFO: /* get mode information */
687 error = (*vidsw[adp->va_index]->get_info)(adp,
688 ((video_info_t *)arg)->vi_mode,
689 (video_info_t *)arg);
690 if (error)
691 error = ENODEV;
692 break;
693
694 case FBIO_FINDMODE: /* find a matching video mode */
695 error = (*vidsw[adp->va_index]->query_mode)(adp,
696 (video_info_t *)arg);
697 break;
698
699 case FBIO_GETMODE: /* get video mode */
700 *(int *)arg = adp->va_mode;
701 break;
702
703 case FBIO_SETMODE: /* set video mode */
704 error = (*vidsw[adp->va_index]->set_mode)(adp, *(int *)arg);
705 if (error)
706 error = ENODEV; /* EINVAL? */
707 break;
708
709 case FBIO_GETWINORG: /* get frame buffer window origin */
710 *(u_int *)arg = adp->va_window_orig;
711 break;
712
713 case FBIO_GETDISPSTART: /* get display start address */
714 ((video_display_start_t *)arg)->x = adp->va_disp_start.x;
715 ((video_display_start_t *)arg)->y = adp->va_disp_start.y;
716 break;
717
718 case FBIO_GETLINEWIDTH: /* get scan line width in bytes */
719 *(u_int *)arg = adp->va_line_width;
720 break;
721
722 case FBIO_BLANK: /* blank display */
723 error = (*vidsw[adp->va_index]->blank_display)(adp, *(int *)arg);
724 break;
725
726 case FBIO_GETPALETTE: /* get color palette */
727 case FBIO_SETPALETTE: /* set color palette */
728 /* XXX */
729
730 case FBIOPUTCMAP:
731 case FBIOGETCMAP:
732 case FBIOPUTCMAPI:
733 case FBIOGETCMAPI:
734 /* XXX */
735
736 case FBIO_SETWINORG: /* set frame buffer window origin */
737 case FBIO_SETDISPSTART: /* set display start address */
738 case FBIO_SETLINEWIDTH: /* set scan line width in pixel */
739
740 case FBIOGTYPE:
741 case FBIOGATTR:
742 case FBIOSVIDEO:
743 case FBIOGVIDEO:
744 case FBIOVERTICAL:
745 case FBIOSCURSOR:
746 case FBIOGCURSOR:
747 case FBIOSCURPOS:
748 case FBIOGCURPOS:
749 case FBIOGCURMAX:
750 case FBIOMONINFO:
751 case FBIOGXINFO:
752
753 default:
754 error = ENODEV;
755 break;
756 }
757
758 splx(s);
759 return error;
760}